Pere Mato [Tue, 17 Sep 2013 15:40:30 +0000 (17:40 +0200)]
Second iteration of updating CMake build for ROOT6.
Pere Mato [Tue, 17 Sep 2013 14:49:58 +0000 (16:49 +0200)]
First iteration of updating CMake build for ROOT6. It builds on MacOSX but not yet run.
Fons Rademakers [Tue, 17 Sep 2013 14:34:33 +0000 (16:34 +0200)]
export MACOSXVERS which is needed in the Makefile.macosx* included in conftest.mk.
Dario Berzano [Thu, 29 Aug 2013 12:56:52 +0000 (14:56 +0200)]
TDirectoryFile::GetKey() hash list optimization
Danilo Piparo [Tue, 17 Sep 2013 09:26:10 +0000 (11:26 +0200)]
Fix for ROOT-5513
Item https://sft.its.cern.ch/jira/browse/ROOT-5513 was fixed.
It was blocking the compilation of CMSSW.
Now xml files of the form
<lcgdict>
<class name="edm::ErrorSummaryEntry" ClassVersion="10">
<version ClassVersion="10" checksum="
3974422774"/>
</class>
<class name="edm::ELseverityLevel" ClassVersion="10">
<version ClassVersion="10" checksum="
2388166397"/>
</class>
<class name="std::vector<edm::ErrorSummaryEntry>"/>
</lcgdict>
are properly digested by rootcling and the information passed
to TClass. Since TMapAttributeMap implements string and int
properties and they cover the 99% of the plausible usecases,
integer properties which cannot be stored in int variables
(like the checksums of CMS!) are stored as strings.
Andrei Gheata [Tue, 17 Sep 2013 08:04:08 +0000 (10:04 +0200)]
Fixed 2 important bugs in TGeoXtru affecting DistFromOutside and ComputeNormal. Added outside flag in TGeoBranchArray. Added SetLastSafety in TGeoNavigator.
(cherry picked from commit
88bce875172fa752c6e740ed26585360b84220a3)
Dario Berzano [Mon, 16 Sep 2013 14:57:53 +0000 (16:57 +0200)]
Optimized TStyle::AxisChoice()
CristinaCristescu [Mon, 16 Sep 2013 13:33:43 +0000 (15:33 +0200)]
Fix enums declared in redecls of namespaces.
Philippe Canal [Tue, 17 Sep 2013 00:06:52 +0000 (19:06 -0500)]
Fix fOffset calculation with rule applying to the whole object.
If a read rule does not a specific target, the corresponding StreamerElement
has a name that is not one of the data member (past or present) and thus
they need to be handled explicitly in TBranchElement::InitializeOffset.
A new 'bit' (kWholeObject) is introduced to explicitly distinguish those
type of StreamerElement.
(cherry picked from v5-34-00-patches commit
db8ea8103f1cbc6bc7d514f33a1c02261ec0512c)
Danilo Piparo [Mon, 16 Sep 2013 16:33:57 +0000 (18:33 +0200)]
Improved doc, fix class/ns encoding for rootmap files
Olivier Couet [Mon, 16 Sep 2013 14:14:11 +0000 (16:14 +0200)]
The TOC is now always visible.
Philippe Canal [Mon, 16 Sep 2013 11:50:55 +0000 (06:50 -0500)]
Assert only when in debug mode *and* llvmdev mode
Philippe Canal [Mon, 16 Sep 2013 01:17:51 +0000 (20:17 -0500)]
Support case in genreflex when the header are not all first on the command line
Philippe Canal [Mon, 16 Sep 2013 00:08:50 +0000 (19:08 -0500)]
Fix mismatched new/delete
David Abdurachmanov [Sat, 14 Sep 2013 08:43:51 +0000 (10:43 +0200)]
Fix RootCling arguments handling (reset once valid arg is found)
In the arguments check loop reset loop once a valid argument is
found, otherwise in case of an argument with value, the value will
be evaluated in the same iteration causing unexpected arguments
downstream.
E.g.,
rootcling v4 -f dict.cc -cap cap.cxx <..>
It finds -cap options, reads capaFileName (cap.cxx) and increments
ic (argument counter) by 1. Yet we continue checking arguments
and at the end it pass through undesirabe options filter. Thus it
is added to clingArgs, which is wrong.
Signed-off-by: David Abdurachmanov <davidlt@cern.ch>
Signed-off-by: Philippe Canal <pcanal@fnal.gov>
Philippe Canal [Sun, 15 Sep 2013 19:09:23 +0000 (14:09 -0500)]
Avoid creating an empty output file even in case of early failure
Philippe Canal [Sun, 15 Sep 2013 18:18:49 +0000 (13:18 -0500)]
Avoid assert in rootcling/genreflex just because there is a user error
Philippe Canal [Fri, 13 Sep 2013 13:26:47 +0000 (08:26 -0500)]
Fix race condition in Prefetching when using with a TChain.
Avoid race condition when moving from one TFile to another in a TChain by using a TSemaphore to mark the fact that there are still some prefetch requests in flight. By using this we ensure that the TTreeCache ( i.e. also the TFilePrefetch obj) is moved to the next file only when all in-flight requests are received. There are three things we need to take care of when moving the cache:
- make sure the async thread is not doing any work
- clear all blocks from prefetching and read list
- reset the file pointer in the prefetch obj
This was discovered when testing Prefeching on Alice jobs. While using it on TChains, we discovered a race condition which was quite hard to replicate on a simple test machine and required some traffic shaping to spot it.
[From Elvin]
David Abdurachmanov [Sat, 14 Sep 2013 08:34:42 +0000 (10:34 +0200)]
Drop grep and lipo -info from check_libcompat for Darwin
lipo supports -verify_arch option on Darwin target, which works
for fat and non-fat binaries. -verify_arch exists with status 0
if specified architecture is available in the binary.
Signed-off-by: David Abdurachmanov <davidlt@cern.ch>
Signed-off-by: Fons Rademakers <Fons.Rademakers@cern.ch>
David Abdurachmanov [Sat, 14 Sep 2013 09:01:51 +0000 (11:01 +0200)]
Add 3 new env variables for ./configure: LIBTIFF, LIBPNG, and LIBJPEG
Adds 3 new environments variables to ./configure script:
- LIBJPEG
- LIBPNG
- LIBTIFF
Similar to like we handle ZLIB.
Signed-off-by: David Abdurachmanov <davidlt@cern.ch>
Signed-off-by: Fons Rademakers <Fons.Rademakers@cern.ch>
Fons Rademakers [Fri, 13 Sep 2013 21:44:53 +0000 (23:44 +0200)]
don't use most recent OSX SDK but, of course, use the one the system is running.
Fons Rademakers [Fri, 13 Sep 2013 17:49:30 +0000 (19:49 +0200)]
in case there is more than one OSX SDK installed, take by default the latest.
Danilo Piparo [Fri, 13 Sep 2013 16:30:59 +0000 (18:30 +0200)]
Fix bug when no rootmapfilename is in input to genreflex
Lorenzo Moneta [Fri, 13 Sep 2013 16:44:43 +0000 (18:44 +0200)]
Try to fix a compilation error on some platform.
use ::abs for integer types instead of std::abs
Lorenzo Moneta [Fri, 13 Sep 2013 16:16:17 +0000 (18:16 +0200)]
Merge branch 'master' of https://root.cern.ch/git/root
Axel Naumann [Fri, 13 Sep 2013 15:59:45 +0000 (17:59 +0200)]
Only register temporaries for which lifetime extension is actually required.
Fons Rademakers [Fri, 13 Sep 2013 14:39:22 +0000 (16:39 +0200)]
set MACOSXVERSION also when cocoa is disabled.
Fons Rademakers [Fri, 13 Sep 2013 14:27:36 +0000 (16:27 +0200)]
simplify detection of OSXSDK and IOSSDK.
Fons Rademakers [Fri, 13 Sep 2013 14:27:15 +0000 (16:27 +0200)]
xlc compiler on OSX is not anymore supported.
Lorenzo Moneta [Fri, 13 Sep 2013 16:05:18 +0000 (18:05 +0200)]
Implement TMath::Abs in term of std::abs
See ROOT-5473
Lorenzo Moneta [Fri, 13 Sep 2013 16:05:18 +0000 (18:05 +0200)]
Implement TMath::Abs in term of std::abs
See ROOT-5473
Axel Naumann [Fri, 13 Sep 2013 15:59:45 +0000 (17:59 +0200)]
Only register temporaries for which lifetime extension is actually required.
Fons Rademakers [Fri, 13 Sep 2013 14:39:22 +0000 (16:39 +0200)]
set MACOSXVERSION also when cocoa is disabled.
Fons Rademakers [Fri, 13 Sep 2013 14:26:17 +0000 (16:26 +0200)]
fix warning coming from latest clang++ from Xcode 5.
Fons Rademakers [Fri, 13 Sep 2013 14:27:36 +0000 (16:27 +0200)]
simplify detection of OSXSDK and IOSSDK.
Fons Rademakers [Fri, 13 Sep 2013 14:27:15 +0000 (16:27 +0200)]
xlc compiler on OSX is not anymore supported.
Fons Rademakers [Fri, 13 Sep 2013 14:23:28 +0000 (16:23 +0200)]
fix warnings flagged by latest clang++ 3.4.
Fons Rademakers [Fri, 13 Sep 2013 14:22:56 +0000 (16:22 +0200)]
fix compile error flagged by latest clang++ 3.4.
Vassil Vassilev [Fri, 13 Sep 2013 13:21:13 +0000 (15:21 +0200)]
Disable tests on SLC6 32 bit.
Vassil Vassilev [Fri, 13 Sep 2013 13:13:21 +0000 (15:13 +0200)]
Add getter and silence a warning.
Vassil Vassilev [Fri, 13 Sep 2013 08:26:13 +0000 (10:26 +0200)]
80 Cols.
Danilo Piparo [Fri, 13 Sep 2013 10:39:36 +0000 (12:39 +0200)]
Fix bogus logic in capabilities file creation
rootcling was checking for the wrong string to be non empty.
Axel Naumann [Fri, 13 Sep 2013 08:37:54 +0000 (10:37 +0200)]
DGRs can have a decl to be emitted, another not to be emitted.
When this oce comes from a #include through ParseForModules():
class A{} g;
A should be emitted, but not g.
This is now tested in roottest/root/meta/templateAutoload.
Danilo Piparo [Fri, 13 Sep 2013 07:55:00 +0000 (09:55 +0200)]
Fix capabilities files generation
The generation of capabilities files was added.
CMS indeed uses those to feed the FW plugin manager, which is
very similar to the good Old SEAL plugin manager.
Axel Naumann [Thu, 12 Sep 2013 17:07:53 +0000 (19:07 +0200)]
Just reply on simplisticCast; register temporary. Fixes ROOT-5316.
CristinaCristescu [Thu, 12 Sep 2013 12:14:08 +0000 (14:14 +0200)]
Extract the enum decl without recursing, but iteration over decl context.
Olivier Couet [Thu, 12 Sep 2013 11:27:54 +0000 (13:27 +0200)]
fix a typo
Olivier Couet [Thu, 12 Sep 2013 09:38:30 +0000 (11:38 +0200)]
TPDF
Olivier Couet [Thu, 12 Sep 2013 09:27:58 +0000 (11:27 +0200)]
Fix JIRA-ROOT-5488. The matrices used by the Td and Tm PDF text operators (used to position and rotate text) cannot be concatenate with the current transformation matrix. This produced wrong slanted text for greek letters when the text angle was not zero. Now the operator "cm" is used instead of Td and Tm, allowing to concatenate the text transformation matrix with the matrix used slant the text.
Axel Naumann [Thu, 12 Sep 2013 07:14:43 +0000 (09:14 +0200)]
Compile RuntimeException with exceptions enabled.
Danilo Piparo [Thu, 12 Sep 2013 05:57:26 +0000 (07:57 +0200)]
Fix logic in prepending directory to rootmapfile
Before, we prepended blindly the directory of the dictionary.
This is bogus, indeed the rootmapfilename can be specified with a
full path. Now we check if this is the case. If yes, nothing is
prepended and we assume the user condifured her call to genreflex
properly and she does not need any meaningful defaults.
Fix typo in the rootmapfilename variable
Wim Lavrijsen [Wed, 11 Sep 2013 23:43:04 +0000 (16:43 -0700)]
workarounds for string <-> basic_string mismatches and kExactMatch lookup failures
Wim Lavrijsen [Wed, 11 Sep 2013 22:31:01 +0000 (15:31 -0700)]
Cling workaround for resolving ::_Self of iterators (used in operator== arguments)
Philippe Canal [Wed, 11 Sep 2013 21:13:47 +0000 (16:13 -0500)]
Add missing transaction before template instantiation
Vassil Vassilev [Wed, 11 Sep 2013 21:04:36 +0000 (23:04 +0200)]
Synthesizing if(DeclRefExpr) throw requires cling to be run with rtti.
Fix that problem by introducing an indirection - a compiled function that throws.
Vassil Vassilev [Wed, 11 Sep 2013 17:21:26 +0000 (19:21 +0200)]
Add trampoline that will help avoid running without -no-rtti.
Philippe Canal [Wed, 11 Sep 2013 19:10:51 +0000 (14:10 -0500)]
White space change (to force recompilation)
Philippe Canal [Wed, 11 Sep 2013 19:09:22 +0000 (14:09 -0500)]
Compile RuntimeException.o with -fexception
Philippe Canal [Tue, 31 Jul 2012 21:19:22 +0000 (21:19 +0000)]
From Brian:
For CMS backward compatibility, allow SetCacheRead to disconnect the cache from being the current cache, but keep the file attached to the cache.
git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@45322
27541ba8-7e3a-0410-8455-
c3a389f83636
(cherry picked from v5-34-00-patches commit
c35d989727faa88c2103533e3ed4007919fd0d10)
Conflicts:
tree/tree/inc/TTreeCache.h
Philippe Canal [Tue, 31 Jul 2012 21:19:14 +0000 (21:19 +0000)]
From Brian:
For CMS backward compatibility, allow SetCacheRead to disconnect the cache from being the current cache, but keep the file attached to the cache.
git-svn-id: http://root.cern.ch/svn/root/branches/v5-34-00-patches@45321
27541ba8-7e3a-0410-8455-
c3a389f83636
(cherry picked from v5-34-00-patches commit
eac731d2b12532ba0d2cd1986882bc0f82a1b8c4)
Axel Naumann [Wed, 11 Sep 2013 15:22:55 +0000 (17:22 +0200)]
Merge Cristina's HasDict improvements (GetUnderlyingType; set of names)
CristinaCristescu [Wed, 11 Sep 2013 12:45:21 +0000 (14:45 +0200)]
Change the set of Types that collects the classes without Dictionaries to a set of strings representing the names of teh classes.
CristinaCristescu [Tue, 10 Sep 2013 13:01:34 +0000 (15:01 +0200)]
Corection to the typedef and template check.
CristinaCristescu [Tue, 10 Sep 2013 10:08:21 +0000 (12:08 +0200)]
Check for data members of template type instead of the template parameters.
CristinaCristescu [Mon, 9 Sep 2013 11:30:02 +0000 (13:30 +0200)]
Using TMetaUtils::GetUnderlyingType for missing dicionaries.
CristinaCristescu [Mon, 9 Sep 2013 09:00:13 +0000 (11:00 +0200)]
Use TMetaUtile GetUnderlyingType.
Fons Rademakers [Wed, 11 Sep 2013 15:03:44 +0000 (17:03 +0200)]
fix for compiling ROOT with an alternative gcc (e.g. 4.8.1), ROOT-5496, ROOT-5493.
Vassil Vassilev [Wed, 11 Sep 2013 14:30:19 +0000 (16:30 +0200)]
Silence a warning.
Axel Naumann [Wed, 11 Sep 2013 13:14:14 +0000 (15:14 +0200)]
Check and register result of CompileMacro(). Fixes ROOT-4329.
Axel Naumann [Wed, 11 Sep 2013 13:13:37 +0000 (15:13 +0200)]
Register result of .L
Axel Naumann [Wed, 11 Sep 2013 12:30:37 +0000 (14:30 +0200)]
Remove terminating comma; silences GCC warning
Vassil Vassilev [Wed, 11 Sep 2013 11:31:14 +0000 (13:31 +0200)]
Use better name.
Vassil Vassilev [Wed, 11 Sep 2013 11:21:21 +0000 (13:21 +0200)]
Remove unused files.
Vassil Vassilev [Wed, 11 Sep 2013 11:18:06 +0000 (13:18 +0200)]
Extend the AST null deref checher and disable the IR checker.
This resulted in one change of warning kind, which is expected. I disabled the
test MetdhoCalls, Baozeng will look at it once he gets the code.
Vassil Vassilev [Wed, 11 Sep 2013 08:08:38 +0000 (10:08 +0200)]
Visit the possible dereferences in-depth.
Danilo Piparo [Wed, 11 Sep 2013 10:39:11 +0000 (12:39 +0200)]
Raised verbosity level
Axel Naumann [Wed, 11 Sep 2013 09:22:12 +0000 (11:22 +0200)]
Clarify what is thrown.
Danilo Piparo [Wed, 11 Sep 2013 08:09:20 +0000 (10:09 +0200)]
Refined error messages for the final commit
Danilo Piparo [Wed, 11 Sep 2013 07:55:54 +0000 (09:55 +0200)]
Cleanup
Move away from cout and use TMetaUtils::Error,Warning and Info.
Removed old commented lines.
Axel Naumann [Wed, 11 Sep 2013 08:04:08 +0000 (10:04 +0200)]
Handle llvm_unreachable (in NDEBUG) as runtime_exception. Implements ROOT-5456
Axel Naumann [Wed, 11 Sep 2013 08:03:27 +0000 (10:03 +0200)]
Typo
Axel Naumann [Wed, 11 Sep 2013 07:36:37 +0000 (09:36 +0200)]
Improve exception reporting.
Axel Naumann [Tue, 10 Sep 2013 15:04:23 +0000 (17:04 +0200)]
Add patch for not checking duplicate template default args from rootmap.
Axel Naumann [Tue, 10 Sep 2013 15:02:50 +0000 (17:02 +0200)]
Annotate template parameters with default arguments as coming from rootmap.
This prevents Sema from complaining about duplicate default argumant declarations.
Axel Naumann [Tue, 10 Sep 2013 15:01:46 +0000 (17:01 +0200)]
Duplicate declarations of template default argument from rootmap files are just fine.
Axel Naumann [Tue, 10 Sep 2013 14:58:04 +0000 (16:58 +0200)]
Remove PCM utility headers left for debugging.
Axel Naumann [Tue, 10 Sep 2013 09:56:27 +0000 (11:56 +0200)]
Callback to external storage now happens explicitly before Sema instantiates.
Axel Naumann [Tue, 10 Sep 2013 09:06:21 +0000 (11:06 +0200)]
Add more rationale as to how this exception is different from others.
Vassil Vassilev [Tue, 10 Sep 2013 17:34:09 +0000 (19:34 +0200)]
Use the correct routine.
Vassil Vassilev [Tue, 10 Sep 2013 16:56:32 +0000 (18:56 +0200)]
Don't confuse cling this is a wrapper function.
Vassil Vassilev [Tue, 10 Sep 2013 16:38:21 +0000 (18:38 +0200)]
Merge the two routines.
Vassil Vassilev [Tue, 10 Sep 2013 16:05:44 +0000 (18:05 +0200)]
Reuse code.
Danilo Piparo [Tue, 10 Sep 2013 15:25:48 +0000 (17:25 +0200)]
Fix for ROOT-5317 + Cleanup
This is the fix for
https://sft.its.cern.ch/jira/browse/ROOT-5317
Now dictionaries, their headers and rootmap files are initially
created as temp files (_tmp suffix) and only at the end of the
rootcling main "committed" (renamed).
This allows to have them on disk in case of crashes and to
avoid that a build continues with an incomplete or bogus
dictionary. This is very dangerous, since that the compilation
may in an unfortunate case progress untill success and strange
runtime behaviours may emerge.
The cleanup refers to some an unnecessary and previously not
always working function, CleanUpOnExit and some general code
cleanups.
Vassil Vassilev [Tue, 10 Sep 2013 15:01:25 +0000 (17:01 +0200)]
Silence warnings for unused fields.
Vassil Vassilev [Tue, 10 Sep 2013 13:44:27 +0000 (15:44 +0200)]
Comment out that unused variable until the new llvm import.
Fons Rademakers [Tue, 10 Sep 2013 14:59:30 +0000 (16:59 +0200)]
revert auto detection of gcc-toolchain as method is not consistent.
Vassil Vassilev [Tue, 10 Sep 2013 10:41:41 +0000 (12:41 +0200)]
Spell out that we want only one wrapper per transaction.
Vassil Vassilev [Tue, 10 Sep 2013 10:40:32 +0000 (12:40 +0200)]
Use interprter's unique prefix.
Vassil Vassilev [Tue, 10 Sep 2013 10:35:39 +0000 (12:35 +0200)]
Remove unused code.
Vassil Vassilev [Tue, 10 Sep 2013 10:33:33 +0000 (12:33 +0200)]
Spaces.