RootTalk


ROOT Discussion Forums

strage value with RooStats::AsymptoticCalculator

Discuss RooFit, TMVA and other statistical and mathematical tools here. Please post bug reports here.

Moderators: cranmer, rootdev

strage value with RooStats::AsymptoticCalculator

Unread postby wiso » Tue Dec 13, 2011 12:00

I'm trying the tutorial StandardHypoTestInvDemo using the profile likelihood and the three methods: the frequentist and the hybrid gives similar result, but the hybrid has some problems. I attach the screenshot.

Code: Select all
.x StandardHypoTestInvDemo.C(0, "combined", "ModelConfig", "", "obsData", 2, 3)
.x StandardHypoTestInvDemo.C(0, "combined", "ModelConfig", "", "obsData", 1, 3)
.x StandardHypoTestInvDemo.C(0, "combined", "ModelConfig", "", "obsData", 0, 3)


Schermata.png
wiso
 
Posts: 464
Joined: Sat Nov 26, 2005 14:16

Re: strage value with RooStats::AsymptoticCalculator

Unread postby moneta » Thu Dec 15, 2011 12:29

Hi,

Can you please attach the workspace so I can debug your problem ? It is probably due to some failures in fitting the model,

Lorenzo
moneta
 
Posts: 1416
Joined: Fri Jun 03, 2005 14:38
Location: CERN

Re: strage value with RooStats::AsymptoticCalculator

Unread postby wiso » Thu Dec 15, 2011 13:10

moneta wrote:Hi,

Can you please attach the workspace so I can debug your problem ? It is probably due to some failures in fitting the model,

Lorenzo


I'm using the one provided with the tutorial, it is automatically generated the first time you run the tutorial
wiso
 
Posts: 464
Joined: Sat Nov 26, 2005 14:16

Re: strage value with RooStats::AsymptoticCalculator

Unread postby moneta » Thu Dec 15, 2011 14:46

Hi,

By running on the tutorial workspace the asymptotic calculator :

Code: Select all
.x StandardHypoTestInvDemo.C(0, "combined", "ModelConfig", "", "obsData", 2, 3)


I get a reasanable result (see attached plot) with 5.32 patches or the trunk, but it is true I get a result like yours if I use just 5.32. It is probably due to a bug fix I have applied two days ago.

Best Regards

Lorenzo
Attachments
Asymptotic_Scan.png
moneta
 
Posts: 1416
Joined: Fri Jun 03, 2005 14:38
Location: CERN

Re: strage value with RooStats::AsymptoticCalculator

Unread postby wiso » Thu Dec 15, 2011 15:12

moneta wrote:Hi,

By running on the tutorial workspace the asymptotic calculator :

Code: Select all
.x StandardHypoTestInvDemo.C(0, "combined", "ModelConfig", "", "obsData", 2, 3)


I get a reasanable result (see attached plot) with 5.32 patches or the trunk, but it is true I get a result like yours if I use just 5.32. It is probably due to a bug fix I have applied two days ago.

Best Regards

Lorenzo


thank you. Do you plan a release before Christmas? can you link me the change in the code?
wiso
 
Posts: 464
Joined: Sat Nov 26, 2005 14:16

Re: strage value with RooStats::AsymptoticCalculator

Unread postby moneta » Thu Dec 15, 2011 15:25

Hi,
After checking in more detail, the problem is still there in the latest version. I was using a workspace done with the old HistFactory version. When using a new workspace done with the new HistFactory of 5.32 the Asymptotic calculator does not work anymore because the fits fail. The workspace are different and they contain in addition some extra nuisance parameters (a statistical error for each bin)
I will investigate this problem,

Best Regards

Lorenzo
moneta
 
Posts: 1416
Joined: Fri Jun 03, 2005 14:38
Location: CERN

Re: strage value with RooStats::AsymptoticCalculator

Unread postby wiso » Thu Dec 15, 2011 16:16

moneta wrote:Hi,
After checking in more detail, the problem is still there in the latest version. I was using a workspace done with the old HistFactory version. When using a new workspace done with the new HistFactory of 5.32 the Asymptotic calculator does not work anymore because the fits fail. The workspace are different and they contain in addition some extra nuisance parameters (a statistical error for each bin)
I will investigate this problem,

Best Regards

Lorenzo


thank you. About the fitting problem, can this problem be related with my other post? In that case it work with 5.28 and 5.33, but not with 5.32
wiso
 
Posts: 464
Joined: Sat Nov 26, 2005 14:16

Re: strage value with RooStats::AsymptoticCalculator

Unread postby moneta » Fri Jan 13, 2012 9:56

Hi,

This bug in the AsymptoticCalculator is now fixed in 5.32 patches and trunk. Thank you for reporting this

Best Regards

Lorenzo
moneta
 
Posts: 1416
Joined: Fri Jun 03, 2005 14:38
Location: CERN

Re: strage value with RooStats::AsymptoticCalculator

Unread postby wiso » Fri Jan 13, 2012 10:00

thank you very much, can you give me the link to the changeset?

moneta wrote:Hi,

This bug in the AsymptoticCalculator is now fixed in 5.32 patches and trunk. Thank you for reporting this

Best Regards

Lorenzo
wiso
 
Posts: 464
Joined: Sat Nov 26, 2005 14:16

Re: strage value with RooStats::AsymptoticCalculator

Unread postby moneta » Fri Jan 13, 2012 10:18

moneta
 
Posts: 1416
Joined: Fri Jun 03, 2005 14:38
Location: CERN


Return to Stat and Math Tool Support

Who is online

Users browsing this forum: No registered users and 2 guests