Rene Brun writes:
> Hi Brett,
>
> I have fixed a few problems connected with my mods to SetEditable.
> There were side-effects in the attribute panels.
> Let me know if you still have problems.
Well, test/guiviewer still doesn't work as is.
However, it can be fixed by bracketing the code which needs to modify
the locked canvas by doing the obvious:
mycanvas->SetEditable(kTRUE);
//... modify a locked TCanvas
mycanvas->SetEditable(kFALSE);
It will be a little tedious to add this fix to old code relying on the
previous behavior. However, I think this solution is probably better
than my previous sugestion of handling two types of Editablilty
(interactive vs. from code).
Below is the fixed test/guiviewer.cxx showing the needed changes.
Could you commit it?
Thanks,
-Brett.
-------------------------------------------------------------------
// @(#)root/test:$Name: $:$Id: guiviewer.cxx,v 1.3 2001/05/15 14:19:04 rdm Exp $
// Author: Brett Viren 04/15/2001
// guiviewer.cxx: GUI test program showing TGTableLayout widget manager,
// embedded ROOT canvases, axis and sliders.
// To run it do: make guiviewer; guiviewer
#include "guiviewer.h"
#include "TROOT.h"
#include "TApplication.h"
#include "TGTableLayout.h"
#include "TGFrame.h"
#include "TList.h"
#include "TGWindow.h"
#include "TRootEmbeddedCanvas.h"
#include "TEllipse.h"
#include "TBox.h"
#include "TArrow.h"
#include "TPolyLine.h"
#include "TGButton.h"
#include "TCanvas.h"
#include "TRandom.h"
#include "TGDoubleSlider.h"
#include "TGaxis.h"
#include <iostream.h>
Viewer::Viewer(const TGWindow *win) : TGMainFrame(win,500,500)
{
// Memory management isn't the best in this class, but make a half
// hearted attempts not to gush too much....
fCleanup = new TList;
TGCompositeFrame *table = new TGCompositeFrame(this,400,400,kSunkenFrame);
fCleanup->Add(table);
TGTableLayout* tlo = new TGTableLayout(table, 9, 6);
table->SetLayoutManager(tlo);
TGLayoutHints* loh = new TGLayoutHints(kLHintsTop|kLHintsLeft|
kLHintsExpandX|kLHintsExpandY);
AddFrame(table,loh);
TGTableLayoutHints* tloh;
// The Canvas
TRootEmbeddedCanvas* recanvas =
new TRootEmbeddedCanvas("Shapes",table,300,300);
tloh = new TGTableLayoutHints(2,5,2,6,
kLHintsExpandX|kLHintsExpandY |
kLHintsShrinkX|kLHintsShrinkY |
kLHintsFillX|kLHintsFillY);
table->AddFrame(recanvas,tloh);
fCanvas = recanvas->GetCanvas();
// The sliders
fHSlider = new TGDoubleHSlider(table,300,kDoubleScaleBoth,100);
tloh = new TGTableLayoutHints(2,5,0,1,
kLHintsExpandX|kLHintsShrinkX|kLHintsFillX);
table->AddFrame(fHSlider,tloh);
fHSlider->Connect("PositionChanged()","Viewer",this,"DoSlider()");
fVSlider = new TGDoubleVSlider(table,300,kDoubleScaleBoth,200);
tloh = new TGTableLayoutHints(0,1,2,6,
kLHintsExpandY|kLHintsShrinkY|kLHintsFillY);
table->AddFrame(fVSlider,tloh);
fVSlider->Connect("PositionChanged()","Viewer",this,"DoSlider()");
// The scales
fHScaleCanvas =
new TRootEmbeddedCanvas("H Scale",table,300,50);
tloh = new TGTableLayoutHints(2,5,1,2,
kLHintsExpandX|kLHintsShrinkX|kLHintsFillX);
table->AddFrame(fHScaleCanvas,tloh);
fHScaleCanvas->GetCanvas()->cd();
fHScaleCanvas->GetCanvas()->Range(0,0,1,1);
fHScale = new TGaxis(0.0,0.5, 1.0,0.5, 0.0,100.0, 510, "-");
//fHScale->SetLabelOffset(0.4);
fHScale->SetLabelSize(0.4);
fHScale->SetName("X Scale");
fHScale->Draw();
fHScaleCanvas->GetCanvas()->SetEditable(kFALSE);
fVScaleCanvas =
new TRootEmbeddedCanvas("V Scale",table,50,300);
tloh = new TGTableLayoutHints(1,2,2,6,
kLHintsExpandY|kLHintsShrinkY|kLHintsFillY);
table->AddFrame(fVScaleCanvas,tloh);
fVScaleCanvas->GetCanvas()->cd();
fVScaleCanvas->GetCanvas()->Range(0,0,1,1);
fVScale = new TGaxis(0.5,0.0, 0.50001,1.0, 0.0,100.0, 510, "-");
//fVScale->SetLabelOffset(0.4);
fVScale->SetLabelSize(0.4);
fVScale->SetName("Y Scale");
fVScale->Draw();
fVScaleCanvas->GetCanvas()->SetEditable(kFALSE);
// Call this after scales/sliders are setup
SetRange(0,0,100,100);
// The shape buttons
const char* shape_button_name[] = {
"Ellipse", "Box", "Triangle", "Arrow", "Zoom Out", "Zoom In", "Close"
};
UInt_t ind;
for (ind = 0; ind < 7; ++ind) {
TGTextButton* button =
new TGTextButton(table,shape_button_name[ind],ind);
tloh = new TGTableLayoutHints(5,6,ind+2,ind+1+2,
kLHintsExpandX|kLHintsExpandY |
kLHintsShrinkX|kLHintsShrinkY |
kLHintsFillX|kLHintsFillY);
table->AddFrame(button,tloh);
button->Resize(100,button->GetDefaultHeight());
button->Connect("Clicked()","Viewer",this,"DoButton()");
}
const char* ctrl_button_name[3][3] = {
{ "NW", "N", "NE" },
{ "W" , "C", "E" },
{ "SW", "S", "SE" }
};
UInt_t indx, indy;
for (indx = 0; indx < 3; ++indx) for (indy = 0; indy < 3; ++indy) {
TGTextButton* button = new TGTextButton(table,
ctrl_button_name[indy][indx],
(indx+1)*10 + indy +1);
tloh = new TGTableLayoutHints(indx+2,indx+1+2, 6+indy,6+indy+1,
kLHintsExpandX|kLHintsExpandY |
kLHintsShrinkX|kLHintsShrinkY |
kLHintsFillX|kLHintsFillY);
table->AddFrame(button,tloh);
button->Resize(100,button->GetDefaultHeight());
button->Connect("Clicked()","Viewer",this,"DoButton()");
}
table->Layout();
MapSubwindows();
Layout();
MapWindow();
}
Viewer::~Viewer()
{
fCanvas->Clear();
delete fCanvas;
fCleanup->Delete();
delete fCleanup;
}
void Viewer::DoButton()
{
TGButton* button = (TGButton*)gTQSender;
UInt_t id = button->WidgetId();
double xmin, ymin, xmax, ymax;
double xdiff, ydiff;
fCanvas->GetRange(xmin,ymin,xmax,ymax);
xdiff = xmax - xmin; ydiff = ymax - ymin;
fCanvas->cd();
switch (id) {
case 0: { // Ellipse
TEllipse* ellipse = new TEllipse(gRandom->Uniform(.8*xdiff)+.1*xdiff,
gRandom->Uniform(.8*ydiff)+.1*ydiff,
gRandom->Uniform(.1*xdiff),
gRandom->Uniform(.1*ydiff));
ellipse->SetFillColor(gRandom->Uniform(10));
ellipse->Draw();
fCanvas->Modified();
fCanvas->Update();
break;
}
case 1: { // Box
TBox* box = new TBox(gRandom->Uniform(xdiff)+xmin,
gRandom->Uniform(ydiff)+ymin,
gRandom->Uniform(xdiff)+xmin,
gRandom->Uniform(ydiff)+ymin);
box->SetFillColor(gRandom->Uniform(10));
box->Draw();
fCanvas->Modified();
fCanvas->Update();
break;
}
case 2: { // Triangle
double x[4], y[4];
x[0] = x[3] = gRandom->Uniform(xdiff)+xmin;
y[0] = y[3] = gRandom->Uniform(ydiff)+ymin;
x[1] = gRandom->Uniform(xdiff)+xmin;
y[1] = gRandom->Uniform(ydiff)+ymin;
x[2] = gRandom->Uniform(xdiff)+xmin;
y[2] = gRandom->Uniform(ydiff)+ymin;
TPolyLine* pl = new TPolyLine(4, x, y);
pl->SetLineColor(gRandom->Uniform(10));
pl->Draw();
fCanvas->Modified();
fCanvas->Update();
break;
}
case 3: { // Arrow
TArrow* arrow = new TArrow(gRandom->Uniform(xdiff)+xmin,
gRandom->Uniform(ydiff)+ymin,
gRandom->Uniform(xdiff)+xmin,
gRandom->Uniform(ydiff)+ymin);
arrow->SetLineColor(gRandom->Uniform(10));
arrow->Draw();
fCanvas->Modified();
fCanvas->Update();
break;
}
case 4: // Zoom out
SetRange(xmin-xdiff*.1, ymin-ydiff*.1, xmax+xdiff*.1, ymax+ydiff*.1);
break;
case 5: // Zoom in
SetRange(xmin+xdiff*.1, ymin+ydiff*.1, xmax-xdiff*.1, ymax-ydiff*.1);
break;
case 6:
gApplication->Terminate(0);
break;
case 11: // nw
SetRange(xmin-xdiff*.1, ymin+ydiff*.1, xmax-xdiff*.1, ymax+ydiff*.1);
break;
case 12: // w
SetRange(xmin-xdiff*.1, ymin, xmax-xdiff*.1, ymax);
break;
case 13: // sw
SetRange(xmin-xdiff*.1, ymin-ydiff*.1, xmax-xdiff*.1, ymax-ydiff*.1);
break;
case 23: // s
SetRange(xmin, ymin-ydiff*.1, xmax, ymax-ydiff*.1);
break;
case 33: // se
SetRange(xmin+xdiff*.1, ymin-ydiff*.1, xmax+xdiff*.1, ymax-ydiff*.1);
break;
case 32: // e
SetRange(xmin+xdiff*.1, ymin, xmax+xdiff*.1, ymax);
break;
case 31: // ne
SetRange(xmin+xdiff*.1, ymin+ydiff*.1, xmax+xdiff*.1, ymax+ydiff*.1);
break;
case 21: // n
SetRange(xmin, ymin+ydiff*.1, xmax, ymax+ydiff*.1);
break;
case 22: // c
SetRange(50.0-xdiff/2,50-ydiff/2,50+xdiff/2,50+ydiff/2);
break;
} // end switch(id)
}
void Viewer::DoSlider()
{
float xmin, ymin, xmax, ymax;
fHSlider->GetPosition(xmin,xmax);
fVSlider->GetPosition(ymin,ymax);
SetRange(xmin,ymin,xmax,ymax, kFALSE);
}
void Viewer::SetRange(Float_t xmin, Float_t ymin, Float_t xmax, Float_t ymax,
Bool_t move_slider)
{
fCanvas->Range(xmin,ymin,xmax,ymax);
//cerr << "x=[" << xmin << " - " << xmax << "], "
// << "y=[" << ymin << " - " << ymax << "]\n";
fHScaleCanvas->GetCanvas()->SetEditable(kTRUE);
fVScaleCanvas->GetCanvas()->SetEditable(kTRUE);
fHScale->SetWmin(xmin);
fHScale->SetWmax(xmax);
fVScale->SetWmin(ymin);
fVScale->SetWmax(ymax);
// Set position of slider - don't if DoSlider called SetRange
if (move_slider) {
fHSlider->SetPosition(xmin,xmax);
fVSlider->SetPosition(ymin,ymax);
}
fCanvas->Modified();
fHScaleCanvas->GetCanvas()->Modified();
fVScaleCanvas->GetCanvas()->Modified();
fCanvas->Update();
fHScaleCanvas->GetCanvas()->Update();
fVScaleCanvas->GetCanvas()->Update();
gClient->ForceRedraw(); //prevent GUI from being starved of redraws
fHScaleCanvas->GetCanvas()->SetEditable(kFALSE);
fVScaleCanvas->GetCanvas()->SetEditable(kFALSE);
}
//---- Main program ------------------------------------------------------------
int main(int argc, char **argv)
{
TApplication theApp("App", &argc, argv);
if (gROOT->IsBatch()) {
fprintf(stderr, "%s: cannot run in batch mode\n", argv[0]);
return 1;
}
Viewer viewer(gClient->GetRoot());
theApp.Run();
return 0;
}
This archive was generated by hypermail 2b29 : Tue Jan 01 2002 - 17:50:47 MET