Hi Salvatore,
Thanks for reporting this bug in TH3 when filling the histogram
with an intermediate buffer. Now fixed in CVS.
Rene Brun
On Fri, 13
Jun 2003, Salvatore Rappoccio wrote:
>
> Hi, All,
>
> I just noticed that TH3::BufferFill might have a bug:
>
>
> //______________________________________________________________________________
> Int_t TH3::BufferFill(Axis_t x, Axis_t y, Axis_t z, Stat_t w)
> {
> // accumulate arguments in buffer. When buffer is full, empty the buffer
> // fBuffer[0] = number of entries in buffer
> // fBuffer[1] = w of first entry
> // fBuffer[2] = x of first entry
> // fBuffer[3] = y of first entry
> // fBuffer[4] = z of first entry
>
> Int_t nbentries = (Int_t)fBuffer[0];
> if (4*nbentries+4 >= fBufferSize) {
> BufferEmpty(kTRUE);
> return Fill(x,y,z,w);
> }
> fBuffer[4*nbentries+1] = w;
> fBuffer[4*nbentries+2] = x;
> fBuffer[4*nbentries+3] = y;
>
> // Isn't this supposed to be = z????????????????????
> fBuffer[4*nbentries+4] = y;
> fBuffer[0] += 1;
> return -3;
> }
>
>
> This is version 3.05/00. Is this crazy?
>
>
> Sal Rappoccio
>
This archive was generated by hypermail 2b29 : Thu Jan 01 2004 - 17:50:12 MET