RE: [ROOT] TArrayI code change

From: Fons Rademakers (Fons.Rademakers@cern.ch)
Date: Fri Apr 23 2004 - 05:20:47 MEST


Hi Philippe,

 as promised I've made the branch "v3-10-02-patches" containing the
fixed TArrayI.h for the people that for some reason have to still stay
with the latest v3 and need this fix. Note, the binaries are not
updated.

Cheers, Fons.




On Thu, 2004-04-22 at 21:04, Philippe Canal wrote:
> Hi Rene,
> 
> However both Peter and Gero requested a __patched__ release of the __PRO__
> release 3.10/02
> (which is very wrong right now).  Fons agreed earlier to at least create a
> branch and
> put a tag on a patch release of 3.10/02.  I think this is the kind of
> problem that
> requires that the pro release be patch (it is silently doing the wrong
> thing!).
> 
> Cheers,
> Philippe.
> 
> -----Original Message-----
> From: owner-roottalk@pcroot.cern.ch
> [mailto:owner-roottalk@pcroot.cern.ch]On Behalf Of Rene Brun
> Sent: Thursday, April 22, 2004 2:53 PM
> To: Peter Elmer
> Cc: Gero Flucke; Rene Brun; Edward Chen; roottalk@pcroot.cern.ch
> Subject: Re: [ROOT] TArrayI code change
> 
> 
> Hi Pete,
> 
> This is correct.
> As I said in a previous mail, this problem had been fixed on April 5.
> 
> We are planning to come with 4.00/04 including this fix early next week.
> 
> Rene Brun
> 
> On
> Thu, 22 Apr 2004, Peter Elmer wrote:
> 
> >   Hi Rene,
> >
> >   Versions 3.10-02, 4.00-02, 4.00-03 all have the problem. 3.10-01 does
> not.
> >
> > 3.10-01
> > // @(#)root/cont:$Name:  $:$Id: TArrayI.h,v 1.14 2002/10/30 20:39:50 brun
> Exp $
> >    void         Reset()           {memset(fArray, 0, fN*sizeof(Int_t));}
> >    void         Reset(Int_t val)  {for (Int_t i=0;i<fN;i++) fArray[i] =
> val;}
> >
> > 3.10-02
> > // @(#)root/cont:$Name:  $:$Id: TArrayI.h,v 1.16 2003/11/14 11:17:13 brun
> Exp $
> >    void         Reset(Int_t val=0)  {memset(fArray,val,
> fN*sizeof(Int_t));}
> >
> > 4.00-02
> > // @(#)root/cont:$Name:  $:$Id: TArrayI.h,v 1.16 2003/11/14 11:17:13 brun
> Exp $
> >    void         Reset(Int_t val=0)  {memset(fArray,val,
> fN*sizeof(Int_t));}
> >
> > 4.00-03
> > // @(#)root/cont:$Name:  $:$Id: TArrayI.h,v 1.16 2003/11/14 11:17:13 brun
> Exp $
> >    void         Reset(Int_t val=0)  {memset(fArray,val,
> fN*sizeof(Int_t));}
> >
> >                                    Pete
> >
> > On Wed, Apr 21, 2004 at 10:42:56AM +0200, Gero Flucke wrote:
> > > On Wed, 21 Apr 2004, Rene Brun wrote:
> > >
> > > > Hi Ed,
> > > >
> > > > Sorry for the wrong information. The CVS log for revision 1.17 is not
> > > > correct. The problem in TArrayI was introduced in revision 1.11 (10
> June 2002)
> > > > corresponding to ROOT version 3.02/06 and fixed only on 5 April 2004.
> > > > The 3.10 binaries on the web do not contain this fix.
> > > >
> > > Hi Rene,
> > > now I am confused: The HTML-docu of releases 3.02, 3.04 and 3.05
> > > represent correct code, only 3.10 is wrong. If I remember right, the
> > > complain about the bug was reported for 3.10_2, claiming 3.10_1 was
> still
> > > correct:
> > > http://root.cern.ch/root/roottalk/roottalk04/1101.html
> > >
> > > Cheers
> > > 	Gero
> > >
> > > > Rene Brun
> > > >
> > > > Edward Chen wrote:
> > > > >
> > > > > Hi - according to CVS:
> > > > >
> > > > > http://root.cern.ch/viewcvs/cont/inc/TArrayI.h
> > > > >
> > > > > fixed problem with Reset() introduced in version v3-10-01a and
> higher,
> > > > > don't use memset to set array to non 0 values (memset sets bytes,
> not
> > > > > integers).
> > > > >
> > > > > The problem appears to have been introduced earlier than that.
> > > > >
> > > > > -Ed
> > > > >
> > > > > On Tue, 20 Apr 2004, Rene Brun wrote:
> > > > >
> > > > > > Ed,
> > > > > >
> > > > > > Version 3.10/02 of TArrayI::Reset was OK. The problem was
> introduced in
> > > > > > 4.00/00 and fixed in 4.00/03
> > > > > >
> > > > > > Rene Brun
> > > > > >
> > > > > > On Tue, 20 Apr 2004, Edward Chen wrote:
> > > > > >
> > > > > > > Hi - I was wondering if the builds of 3.10/02 available on the
> ROOT
> > > > > > > website include the fix to TArrayI::Reset() for non-zero values?
> Thanks.
> > > > > > >
> > > > > > > -Ed
> > > > > > >
> > > > > >
> > > > > >
> > > >
> >
> >
> >
> > -------------------------------------------------------------------------
> > Peter Elmer     E-mail: Peter.Elmer@cern.ch      Phone: +41 (22) 767-4644
> > Address: CERN Division PPE, Bat. 32 2C-14, CH-1211 Geneva 23, Switzerland
> > -------------------------------------------------------------------------
> >
-- 
Org:    CERN, European Laboratory for Particle Physics.
Mail:   1211 Geneve 23, Switzerland
E-Mail: Fons.Rademakers@cern.ch              Phone: +41 22 7679248
WWW:    http://www.rademakers.org/fons/      Fax:   +41 22 7679480



This archive was generated by hypermail 2b29 : Sun Jan 02 2005 - 05:50:07 MET