Re: make debian in 4.04/02

Hi Stanislav,
your patch is not against the current CVS and important note - at the moment ROOT's version (located at asimage./src/) of libAfterImage is significantely different from "official" libAfterImage shipped with debian. I'm going to send a patch with our modifications to Sasha Vasko ASAP. So, use ROOT built-in version of libAfterImage.

Regards. Valeriy

Stanislav Nesterov wrote:

> Hi Cris,
>
> I've made short patch for TASImage.cxx and libAfterImage for
> Debian-testing to compile. You can try to change temporary the sources
> until Christian changes building scripts.
>
> And I would like to ask Christian somehow modify `changelog' file to
> reflect current ROOT version correctly.
>
> Fons Rademakers wrote:
>
> > Hi Chris,
> >
> > we cannot use anymore the system provided libAfterImage due to the
> > many mods we had to make in it (we hope in a later stage to go back
> > into sync).
> > Can you try building the built-in libAfterImage?
> >
> > Christian (Holm), can you fix the debian package files such that we
> > always use the ROOT provided libAfterImage (I've already disabled
> > this option in ./configure in the head).
> >
> > Cheers, Fons.
> >
> >
> >
> > Chris Roat wrote:
> >
> >> Hi,
> >>
> >> I'm having difficulty compiling the afterimage part of ROOT using
> >> "make debian". The build proceeds through libRGL.so, and then gives
> >> the warnings below. I'm using sarge(testing). Any idea what has
> >> gone wrong? My afterimage library is up-to-date:
> >>
> >> [beta] ~/MultiFit > dpkg --list libafterimage-dev
> >> Desired=Unknown/Install/Remove/Purge/Hold
> >> |
> >> Status=Not/Installed/Config-files/Unpacked/Failed-config/Half-installed
> >> |/ Err?=(none)/Hold/Reinst-required/X=both-problems (Status,Err:
> >> uppercase=bad)
> >> ||/ Name Version Description
> >> +++-==================-==================-====================================================
> >>
> >> ii libafterimage-dev 2.00.04-3 imaging library designed
> >> for AfterStep - development
> >>
> >>
> >> Chris
> >>
> >>
> >>
> >> ==> lib/libRGL.so done
> >> g++ -O -I/usr/include/freetype2 -pipe -Wall -W -Woverloaded-virtual
> >> -fPIC -Iinclude -DHAVE_CONFIG/include/libAfterBase
> >> -I/usr/include/libAfterImage -o asimage/src/TASImage.o -c
> >> asimage/src/TASIma
> >> asimage/src/TASImage.cxx: In function `void
> >> fill_hline_notile_argb32(ASDrawContext*, int, int, int, long
> >> unsigned int)':
> >> asimage/src/TASImage.cxx:4499: error: cannot convert `CARD8*' to
> >> `CARD32*' in
> >> initialization
> >> asimage/src/TASImage.cxx: In function `void
> >> apply_tool_2D_argb32(ASDrawContext*, int, int, long unsigned int)':
> >> asimage/src/TASImage.cxx:4521: error: cannot convert `CARD8*' to
> >> `CARD32*' in
> >> initialization
> >> asimage/src/TASImage.cxx:4530: error: cannot convert `CARD8*' to
> >> `CARD32*' in
> >> initialization
> >> asimage/src/TASImage.cxx: In function `ASDrawContext*
> >> create_draw_context_argb32(ASImage*, ASDrawTool*)':
> >> asimage/src/TASImage.cxx:4577: error: cannot convert `ARGB32*' to
> >> `CARD8*' in
> >> assignment
> >> asimage/src/TASImage.cxx:4581: error: invalid conversion from `void
> >> (*)(ASDrawContext*, int, int, int, long unsigned int)' to `void
> >> (*)(ASDrawContext*, int, int, int, unsigned char)'
> >> asimage/src/TASImage.cxx:4582: error: invalid conversion from `void
> >> (*)(ASDrawContext*, int, int, long unsigned int)' to `void
> >> (*)(ASDrawContext*, int, int, unsigned char)'
> >> asimage/src/TASImage.cxx: In member function `void
> >> TASImage::DrawWideLine(unsigned int, unsigned int, unsigned int,
> >> unsigned
> >> int, unsigned int, unsigned int)':
> >> asimage/src/TASImage.cxx:4611: error: cannot convert `CARD32*' to
> >> `CARD8*' in
> >> assignment
> >> /usr/include/libAfterImage/asimage.h: At global scope:
> >> /usr/include/libAfterImage/asimage.h:767: warning: inline function `void
> >> init_image_layers(ASImageLayer*, int)' used but never defined
> >> make[2]: *** [asimage/src/TASImage.o] Error 1
> >> make[2]: Leaving directory `/sandbox/croat/Downloads/root-4.04.02'
> >> make[1]: *** [build-arch-stamp] Error 2
> >> make[1]: Leaving directory `/sandbox/croat/Downloads/root-4.04.02'
> >> make: *** [debian] Error 2
> >>
> >
>
> --
> Best regards,
> Stanislav.
>
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> Index: TASImage.cxx
> ===================================================================
> RCS file: /user/cvs/root/asimage/src/TASImage.cxx,v
> retrieving revision 1.22
> diff -u -r1.22 TASImage.cxx
> --- TASImage.cxx 3 May 2005 13:11:32 -0000 1.22
> +++ TASImage.cxx 20 May 2005 12:39:43 -0000
> @@ -4488,7 +4488,8 @@
>
> //_____________________________________________________________________________
> static void fill_hline_notile_argb32(ASDrawContext *ctx, int x_from, int y,
> - int x_to, CARD32 ratio)
> +// int x_to, CARD32 ratio)
> + int x_to, CARD8 ratio)
> {
> //
>
> @@ -4496,7 +4497,7 @@
>
> if (ratio != 0 && x_to >= 0 && x_from < cw && y >= 0 && y < ctx->canvas_height) {
> CARD32 value = ratio;
> - CARD32 *dst = ctx->canvas + y*cw;
> + CARD32 *dst = (CARD32*) (ctx->canvas + y*cw);
> int x1 = x_from;
> int x2 = x_to;
>
> @@ -4514,11 +4515,11 @@
> }
>
> //_____________________________________________________________________________
> -static void apply_tool_2D_argb32(ASDrawContext *ctx, int curr_x, int curr_y, CARD32)
> +static void apply_tool_2D_argb32(ASDrawContext *ctx, int curr_x, int curr_y, CARD8)
> {
> //
>
> - CARD32 *src = ctx->tool->matrix;
> + CARD32 *src = (CARD32*)ctx->tool->matrix;
> int corner_x = curr_x - ctx->tool->center_x;
> int corner_y = curr_y - ctx->tool->center_y;
> int tw = ctx->tool->width;
> @@ -4527,7 +4528,7 @@
> int ch = ctx->canvas_height;
> int aw = tw;
> int ah = th;
> - CARD32 *dst = ctx->canvas;
> + CARD32 *dst = (CARD32*)ctx->canvas;
> int x, y;
>
> if (corner_x+tw <= 0 || corner_x >= cw || corner_y+th <= 0 || corner_y >= ch) {
> @@ -4574,7 +4575,7 @@
>
> ctx->canvas_width = im->width;
> ctx->canvas_height = im->height;
> - ctx->canvas = im->alt.argb32;
> + ctx->canvas = (CARD8*)im->alt.argb32;
> ctx->scratch_canvas = 0;
>
> ctx->tool = brush;
> @@ -4608,7 +4609,7 @@
> };
>
> static ASDrawTool *brush = new ASDrawTool;
> - brush->matrix = matrix;
> + brush->matrix = (CARD8*)matrix;
> brush->width = thick;
> brush->height = thick;
> brush->center_y = brush->center_x = thick/2;
Received on Fri May 20 2005 - 16:10:27 MEST