Log of /trunk/geom/gdml/src/TGDMLParse.cxx
Parent Directory
Revision
48992 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Mar 28 15:26:26 2013 UTC (21 months, 3 weeks ago) by
rdm
File length: 121745 byte(s)
Diff to
previous 44557
From Lifeng Sun:
The attached patchset fixes a bunch of typo in the source:
0001-succes-success.patch
0002-preceed-preced.patch
0003-informations-information.patch
0004-childs-children.patch
0005-avaliable-available.patch
0006-writeable-writable.patch
0007-comand-command.patch
0008-unkown-unknown.patch
0009-wierd-weird.patch
0010-wheter-whether.patch
0011-unecessary-unnecessary.patch
0012-splitted-split.patch
0013-registerd-registered.patch
0014-recieve-receive.patch
0015-processsing-processing.patch
0016-ouput-output.patch
0017-mutiple-multiple.patch
0018-lenght-length.patch
0019-interupted-interrupted.patch
0020-independant-independent.patch
0021-inconsistant-inconsistent.patch
0022-expresion-expression.patch
0023-explicitely-explicitly.patch
0024-enviroment-environment.patch
0025-deafult-default.patch
0026-continous-continuous.patch
0027-completly-completely.patch
0028-commited-committed.patch
0029-choosen-chosen.patch
0030-backgroud-background.patch
0031-auxilliary-auxiliary.patch
0032-authentification-authentication.patch
0033-appropiate-appropriate.patch
0034-an-other-another.patch
0035-environement-environment.patch
0036-targetting-targeting.patch
0037-suppported-supported.patch
0038-paramater-parameter.patch
Revision
41578 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Oct 25 16:36:15 2011 UTC (3 years, 2 months ago) by
agheata
File length: 119968 byte(s)
Diff to
previous 39336
Change return type of GetScale method to TString. Change of attributes and tags according to gdml schema (e.g. twistTrap -> twistedtrap, twist->Phitwis, ...). Change order of formula and name in creating TGeoElement.
Revision
33670 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon May 31 14:45:23 2010 UTC (4 years, 7 months ago) by
agheata
File length: 118700 byte(s)
Diff to
previous 33480
Fixed support for divisions in the GDML parser. Basically everything was wrong, including the number of divisions parameter.
Revision
32733 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Mar 24 16:19:00 2010 UTC (4 years, 10 months ago) by
brun
File length: 117571 byte(s)
Diff to
previous 32677
From Andrei:
a new development along the line of having G4-TGeo material compatibility:
So far TGeoMaterial was computing only the radiation length. The patch adds computation of interaction length for materials and mixtures, using the G4 simplified formula. The radlen and intlen can be always set from outside as before.
Revision
30749 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Oct 15 16:33:04 2009 UTC (5 years, 3 months ago) by
brun
File length: 113162 byte(s)
Diff to
previous 30745
From Matthew Strait:
This patch fixes the spelling of "function" in the root source code
and documentation, which is misspelled (sometimes as part of larger
"function"-based words) at least 152 times:
* "funciton" 48 times
* "funcion" 36 times
* "funtion" 23 times
* "fucntion" 17 times
* "functionn" 6 times
* "fuction" 6 times
* "fuunction" 4 times
* "functioin" 3 times
* "fonction" 3 times
* "funstion" twice
* "fnuction" once
* "functiom" once
* "functio" once
* "funcition" once
Revision
30745 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Oct 15 12:23:45 2009 UTC (5 years, 3 months ago) by
brun
File length: 113161 byte(s)
Diff to
previous 23521
From daniele.francesco.kruse@cern.ch
"Added support for the 'ellipsoid' GDML tag.
In the solids section of the GDML file, an ellipsoid may be declared.
Unfortunately, the ellipsoid is not supported under ROOT so,
when the ellipsoid keyword is found, this function is called
to convert it to a simple box with corresponding dimensions."
Revision
22419 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Mar 3 00:25:01 2008 UTC (6 years, 10 months ago) by
rdm
Original Path:
trunk/gdml/src/TGDMLParse.cxx
File length: 110331 byte(s)
Diff to
previous 21200
From Andrew Savchenko:
ROOT can not be compiled with gcc-4.3.
Some ROOT source files doesn't contain required #include directives,
for example, they use strlen(), but #include <string.h> is missed or
malloc() is used and #include <stdlib.h> is missed.
Earlier versions of gcc allowed some headers to be included implicitly,
but issued a warning (-Wimplicit-function-declaration). Newer one,
gcc-4.3 denies such silly behaviour: all required headers must be explicitly
included.
Attached patch fixes this. Also it fixes another issue, which disallows
ROOT to compile under gcc-4.3: C functions don't belong to namespace std,
so expressions like std::memcpy() are no longer valid and plain memcpy()
should be used instead.
Revision
19680 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Aug 24 08:40:11 2007 UTC (7 years, 5 months ago) by
brun
Original Path:
trunk/gdml/src/TGDMLParse.cxx
File length: 109965 byte(s)
Diff to
previous 19562
From Zoltan Torzsok:
-Fix coding conventions
-TGDMLParse.cxx :: Extruded solid process:
- scalingFactor must be processed without length unit!
- zOrder need not to be processed with length unit!
-writer.py :: AddEltu
The parameter names are changed from (x,y,z) to (dx,dy,dz) according to the GDML schema.
Revision
19562 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Aug 7 07:53:05 2007 UTC (7 years, 5 months ago) by
brun
Original Path:
trunk/gdml/src/TGDMLParse.cxx
File length: 109831 byte(s)
Diff to
previous 17478
From Zoltan.Torzsok@cern.ch:
*** Using constants in GDML with ROOT ***
[ORIGINAL APPROACH]
Originally constants could not be used within mathematical expressions in ROOT.
The following example is to illustrate the problem:
<define>
<constant name="size" value="100.0"/>
</define>
<solids>
<box name="MyCube" x="size" y="size" z="size"/>
<box name="MyBox" x="1.0*size" y="2.0*size" z="3.0*size"/>
</solids>
The "MyCube" solid can be parsed since it contains a constant only.
The "MyBox" solid will indicate an error message like "size" is not
recognised as an expression. This happens because in the original method
the whole expression string is searched in the constant map.
If it can be found, it is replaced with its value.
In "MyBox" the expression string for the "x" attribute is "1.0*size"
and there isnt any constant defined with the name of "1.0*size".
We can trick the parser and eliminate the mentioned error message by
adding the following constants:
<constant name="1.0*size" value="100"/>
<constant name="2.0*size" value="200"/>
<constant name="3.0*size" value="300"/>
[MY APPROACH]
I am using a find-and-replace method on the expression string.
If the name of a constant is found within the expression string,
it is replaced with the value of the constant.
This approach fails in special cases, when a constants name contains
an other constants name, like in the following:
<constant name="wi" value="100"/>
<constant name="width" value="200"/>
In this case, every occurence of "width" will look like "100dth"
so that "width" will be no longer recognised. This must be fixed.
[TEST RESULTS]
Applying my method has not got any impact on speed, even with
highly sophisticated models like "cms.gdml".
[FEATURES]
- Works with multiple constants in a single expression (tested)
- Should work with multiple *.gdml files (not tested)
- Works with constants with expressions (tested)
Example:
<constant name="size" value="100.0"/>
<constant name="width" value="2.0*size"/>
<constant name="height" value="4.0*size"/>
<constant name="depth" value="8.0*size"/>
*** Problem with rotation in boolean solids is fixed now ***
Originally, in GDML/Geant4, in a boolean composition of two solids only the second solid could be rotated.
This rotation has opposite winding compared to the rotation of the volume, so that the inverse of the rotation matrix is used.
Later the boolean solid was extended, using the "firstrotation" token, so that the first solid can be rotated too.
But in the code the matrix inversion was omitted for this rotation. By adding matrix inversion to this rotation
the problem is solved.
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
enter a numeric revision.
