Log of /trunk/gui/sessionviewer/src/TProofProgressDialog.cxx
Parent Directory
Revision
36073 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Oct 5 08:14:21 2010 UTC (4 years, 3 months ago) by
ganis
File length: 48940 byte(s)
Diff to
previous 35650
In the PROOF progress dialog add a button to enable/disable the speedometer.
By default the speedometer is disable since it may impact performance.
Revision
34557 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Jul 22 15:12:01 2010 UTC (4 years, 6 months ago) by
rdm
File length: 46418 byte(s)
Diff to
previous 32590
fix cases in ROOT code where we would truncate the TTime (to avoid the
new error messages in TTime operator long on 32-bit platforms).
Revision
31250 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Nov 17 19:25:20 2009 UTC (5 years, 2 months ago) by
ganis
File length: 46702 byte(s)
Diff to
previous 30862
- Reset the speedo scale, average and peak value when resetting the dialog for a new query
- Do not show the total-sessions-in-the-cluster graph when no other session is active
Revision
30862 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sun Oct 25 08:26:46 2009 UTC (5 years, 3 months ago) by
ganis
File length: 46474 byte(s)
Diff to
previous 30860
- Further improvement in the estimation of the current rate
- Fix a problem preventing the chunck size to be displayed in some cases
- Adjust the scale for displaying the read bytes (use GB or TB when relevant)
Revision
30859 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Oct 24 14:53:07 2009 UTC (5 years, 3 months ago) by
ganis
File length: 45919 byte(s)
Diff to
previous 30853
Patch for improved performance monitoring. The 'Rate Plot' button in the progress
dialog is renamed 'Performance plot' and shows up to 4 plots with the event/sec,
the average read chunck size, the number of active workers and the number of active
PROOF sessions on the cluster, all as a function of processing time.
The read chunck size plot allows to monitor the usage of the cache.
The istantaneous processing rate (event/sec) is now better estimate: a few issues
with the normalizing times have ben solved, removing the artificial structures that
were observed.
The possibility to set a max packet time length is introduced (default 30 s); this
can be changes with the parameter PROOF_MaxPacketTime.
The size of the cache is also taken into account to optimize the use of the cache.
The parameter PROOF_UseParallelUnzip has been introduced to toggle the use of the
parallel unzip (default off for now).
A page describing the new performance plots is under preparation at
http://root.cern.ch/drupal/content/progress-dialog
Revision
29171 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 23 14:13:06 2009 UTC (5 years, 7 months ago) by
brun
File length: 36202 byte(s)
Diff to
previous 29059
From Gerri:
- Fix a few problems found running in valgrind:
- In XrdROOTMgr::Validate, add missing protection against inproper use of a
temporary file when in non debug mode
- Fix a problem with inproper deletion of XrdProofWorker objects when working
with a dynamically varying 'proof.conf'
- In TProof::HandleInputMessage, fix possible double delete after kPROOF_STOPPROCESS
- Fix a couple of issues on reconnection to a running session:
- make sure that the dialog buttons are in the correct state
- make sure that logs are redirected
- Fix an issue with the displaying speed of very large log files (bufferize instead of
doing line-by-line)
- In TProof::Draw, change the type of a notification message from 'error' to 'debug'
- Fix coding conventions in TDataSetManagerFile.cxx
Revision
29059 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Jun 17 15:43:11 2009 UTC (5 years, 7 months ago) by
ganis
File length: 35968 byte(s)
Diff to
previous 28370
Automatize running of PROOF sessions in valgrind.
The second argument of TProof::Open is used to trigger the relevant settings.
To valgrind the master session start PROOF with
TProof::Open("<master>","valgrind")
or
TProof::Open("<master>","valgrind=master")
To valgrind two workers sessions use
TProof::Open("<master>","valgrind=workers")
To valgrind <n> workers sessions use
TProof::Open("<master>","valgrind=workers#<n>")
To valgrind master and 2 workers (for <n> workers add '#<n>')
TProof::Open("<master>","valgrind=master+workers")
The valgrind logs are available with the tag '<ordinal>-valgrind' in the log dialog
or form TProofMgr::GetSessionLogs() .
To add options to valgrind execute
TProof::AddEnvVar("PROOF_WRAPPERCMD", "valgrind_opts:<options>")
before starting the session.
Revision
28370 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Apr 28 06:43:41 2009 UTC (5 years, 8 months ago) by
ganis
File length: 35920 byte(s)
Diff to
previous 27478
Add the possibility to switch to asynchronous mode while running synchronously.
A new button "Run in background" has been added to the dialog box. The behaviour
of Ctrl-C has also been modified: the user is prompted for a choice among continuing
asynchronously, stopping (terminating) or aborting the query.
Revision
25092 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Aug 8 10:26:13 2008 UTC (6 years, 5 months ago) by
ganis
File length: 33785 byte(s)
Diff to
previous 25074
From Anna:
- Complete patch for memory monitoring
- Fine-tune the tip for the memory plot button
- Fix some typos in comments
Revision
25072 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Aug 6 09:26:41 2008 UTC (6 years, 5 months ago) by
ganis
File length: 33810 byte(s)
Diff to
previous 24762
From Anna Kreshuk:
New functionality to display the memory footprint on workers and master as a function
of the entry processed (workers) or of the merging step (master).
Revision
24548 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Jun 25 15:03:28 2008 UTC (6 years, 7 months ago) by
ganis
File length: 31876 byte(s)
Diff to
previous 23929
From Anna and me:
- fix a memory leak in log retrieval (the TProofLog object was never deleted)
- add protections for the cases the manager cannot be initialized
- set default number of displayed lines to 100 instead of 10
- cosmetic changes
Revision
23131 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Apr 11 07:09:54 2008 UTC (6 years, 9 months ago) by
rdm
File length: 30058 byte(s)
Diff to
previous 23115
From Anna:
Improved version of TProofProgressLog using TProofMgr::GetSessionLogs()
to retrieve the logs directly from the server. The graphics layout of
the logbox has been re-designed, with new buttons to grep the logs and
to save them to a file. It is also possible to choose the range of
lines to be displayed and the subset of nodes.
Revision
18353 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Mar 19 15:14:10 2007 UTC (7 years, 10 months ago) by
rdm
Original Path:
trunk/sessionviewer/src/TProofProgressDialog.cxx
File length: 29329 byte(s)
Diff to
previous 18319
From Gerri:
- Support for multiple ROOT versions on a PROOF cluster.
TProofMgr::ShowROOTVersions() giving the following output:
root [0] TProof::Mgr("")->ShowROOTVersions()
----------------------------------------------------------
Available versions (tag ROOT-vers remote-path PROOF-version):
* cvs 5.15/03 /home/ganis/local/root/head/head 12
dev 5.15/03 /home/ganis/local/root/head/root 12
----------------------------------------------------------
- TProofMgr::SetROOTVersion(const char *version_tag)
to change the default for the user, eg
root [1] TProof::Mgr("")->SetROOTVersion("dev")
root [2] TProof::Mgr("")->ShowROOTVersions()
----------------------------------------------------------
Available versions (tag ROOT-vers remote-path PROOF-version):
cvs 5.15/03 /home/ganis/local/root/head/head 12
* dev 5.15/03 /home/ganis/local/root/head/root 12
----------------------------------------------------------
Available version are defined by the administrator via the
"xpd.rootsys" directive:
xpd.rootsys /home/ganis/local/root/head/head cvs
xpd.rootsys /home/ganis/local/root/head/root dev
in the xrootd config file.
- Improve error reporting in TXSocket
- Fix a problem with resetting a label in TProofProgressDialog
Revision
16775 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Nov 15 17:45:55 2006 UTC (8 years, 2 months ago) by
rdm
Original Path:
trunk/sessionviewer/src/TProofProgressDialog.cxx
File length: 28431 byte(s)
Diff to
previous 15507
From Gerri and Bertrand:
Fixes and new features developed in preparation for the Intel quad-core
launch demo:
- Add instantaneous event and MB processing rates in the Progress signal
and make necessary modification to exploit it in the Progress Dialog.
- Add possibility to change the Progress and Feedback periods
- A number of small improvements and bug fixes
Revision
15507 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Jun 21 16:18:27 2006 UTC (8 years, 7 months ago) by
rdm
Original Path:
trunk/sessionviewer/src/TProofProgressDialog.cxx
File length: 20026 byte(s)
Diff to
previous 15338
From Gerri:
The patch implements the following new functionality:
- Shutdown of idle sessions when quitting ROOT; if not idle the session
is shutdown as soon as processing terminates; it is possible to delay
the automatic shutdown by a tunable amount of time via a new directive
in the xrootd config file 'xpd.shutdown' (see xpd.cf.example).
- New static method TProof::Reset(const char *url) to hard-cleanup an
user area (implemented for Xproofd only); this implied quite some
additions in XrdProofdProtocol.
- Possibility to temporary remove / re-insert a worker from the active list
TProof::DeactivateWorker(const char *ord)
TProof::ActivateWorker(const char *ord)
with 'ord' the ordinal numer, e.g. "0.3" .
- A default url for the disk pool
const char *TVirtualProof::GetDataPoolUrl()
It is set by default to a string send back by the master, but it can
be changed via
void TVirtualProof::SetDataPoolUrl(const char *url)
Jan should then adapt his code to use this as default.
- Posibility to timeout Collect; for now this is only used at forced
termination.
The patch includes many small changes and bug fixes. One of the most important
is in TXNetSystem (a bug preventing correct treatment of multiple request
to the same redirector).
Revision
15338 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Jun 5 22:51:14 2006 UTC (8 years, 7 months ago) by
rdm
Original Path:
trunk/sessionviewer/src/TProofProgressDialog.cxx
File length: 19834 byte(s)
Diff to
previous 15312
From Gerri:
base/inc/TVirtualProof.h, proof/inc/TProof.h, proof/src/TProof.cxx
proof/src/TProofProgressDialog.cxx:
- fix a problem with the progress dialog when detaching a session:
a new signal CloseProgressDialog() is introduced, as well as the
possibility to empty the list of submitted queries at once via
TProof::Remove().
proofx/inc/TXHandler.h, .cxx:
- add generic argument to HandleInput() and HandleError().
proofx/inc/TXProofMgr.h, .cxx:
- move to new signature for HandleInput(), HandleError().
proof/inc/TSlave.h:
- add method to flush underlying socket.
proofx/inc/TXSlave.h, .cxx:
- move to new signature for HandleInput(), HandleError().
- implement new method to flush underlying socket.
proofx/inc/TXSocket.h, .cxx:
- Add method to flush socket.
- Handle interrupt messages in the reader thread.
- Remove interrupt semaphore (not needed any more).
- Remove timeout argument from GetInterrupt (not needed any more).
proofx/inc/TXProofServ.h, .cxx:
- move to new signature for HandleInput(), HandleError().
- implement interrupt handling in HandleInput().
- implement dedicated version of LockSession to deal with new format
of session tag (this is a bug fix).
proofd/inc/XrdProofConn.h, .cxx:
- Add mutex protection in the SendRecv method (it can be called from both
the reader and main threads).
proofd/src/XrdProofdProtocol.cxx:
- use an asynchronous message (instead of a signal) for interrupts.
proofx/inc/LinkDef.h, TXSocketHandler.h, .cxx, TXUnixSocket.cxx:
- add TXSocketHandler in the dictionary.
- cosmetics.
Revision
15312 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Jun 2 15:14:35 2006 UTC (8 years, 7 months ago) by
rdm
Original Path:
trunk/sessionviewer/src/TProofProgressDialog.cxx
File length: 19534 byte(s)
Diff to
previous 14752
From Gerri:
large PROOF patch. Main issues addressed:
- Output redirection to log file at 'proofserv' startup (instead of
after Setup())
- Log messages activated at session creation
- Session sandbox restructuring in such a way that the unique session
tag, created by the top master, uniquely identifies the session on
all nodes, for example on top master:
<User_Sandbox>/session-<top_master_session_tag>/
master-0-<top_master_session_tag>/master-0-<top_master_session_tag>.log
On worker 0.0
<User_Sandbox>/session-<top_master_session_tag>/
worker-0.0-<worker_0.0_session_tag>/worker-0.0-<worker_0.0_session_tag>.log
- Automatic creation of the dataset dir
- Improved handling of error conditions
- Reorganization of TProofServ and XrdProofdProtocol
- Several bug fixes, in particular in XrdProofdProtocol
Revision
12822 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Sep 22 23:29:30 2005 UTC (9 years, 4 months ago) by
rdm
Original Path:
trunk/sessionviewer/src/TProofProgressDialog.cxx
File length: 18129 byte(s)
Diff to
previous 12810
from Gerri:
- fix several issues with Begin() not being called when finalizing a query
done via TChain::Draw(), call setup code now also in Terminate().
- fix error with query progress dialog not finishing when analysing
subset of data set.
- add master and slave startup feedback code.
- fixes also a few additional problems with enabling/disabling of
Stop/Abort buttons and cleans up the treament of fOutputList in TQueryResult.
It is also make sure that there are no multiple copies of a TDSet in the
output list.
Revision
12722 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Sep 16 08:48:39 2005 UTC (9 years, 4 months ago) by
rdm
Original Path:
trunk/sessionviewer/src/TProofProgressDialog.cxx
File length: 17738 byte(s)
Diff to
previous 12561
From Gerri:
Big patch supporting query queueing on the PROOF master, interogation and
interaction with the queue. Retrieval, finalization and archival of query
results and multiple PROOF sessions. Some other fixes:
- TMacro.h, .cxx
add method Checksum to get the MD5 of the current context
(needed for optimized selector reinitialization)
- Changes needed to create and fill the list of data sets (TROOT,
TDSet, TChain, TChainProof)
- A new method TSelector::IsStandardDraw() to check if a selector
is for standard draw actions
- TEventIter: fix for the missing last update (see above)
- Few protections in TPacketizers destructors
- Fix for code conventions in TPerfStats (the other will follow)
- Occasional missing last update of the progress bar (systematically
reproduced with SetParallel(1)): all this part is quite involved
and I have found a solution which does not harm but perhaps is not
the most elegant.
- SetParallel(0): the progress bar was not working at all in such a
case, since no packetizer is involved. Still it is useful to see
that things are not stuck, so I have added some progress messages
there too. The problem is that I have not found a way to get the total
number of entries from a data set without doing all the machinery
done in the packetizer.
Revision
12561 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Aug 30 10:25:29 2005 UTC (9 years, 4 months ago) by
rdm
Original Path:
trunk/sessionviewer/src/TProofProgressDialog.cxx
File length: 17682 byte(s)
Diff to
previous 11730
From Gerri:
This is the patch to add support for asynchronous queries.
The principal modifications are in TProof and TProofPlayer.
In TProof, I have separated the parsing of the received messages
from the selection of the socket (new method CollectInputFrom()):
the new method is called directly by TProofInputHandler::Notify()
in the case of asynchronous mode.
Also in TProof I have added a method to redirect the logs to a
temporary file, to avoid having them on the main window while doing
something else. The method is TProof::RedirectLog(), it uses freopen,
fdopen and dup2, and works well back and forth.
The content of the temp file can be displayed into a log window
(new GUI class TProofProgressLog), via a new button in the
progress dialog ("Show Logs").
In TProofPlayer I have created a new method Finalize() with the
final part of Process(): this is necessary to be able to finalize
the queries processed asychronously.
There are several many other small changes and fixes: a couple
of non-backward comaptibilities introduced with the previous
patch, many small issues in the GUI (the stop and abort buttons
were never disabled ...).
Also, in view of multi-sessions, it does not make much sense to
have one progress dialog per query: one per session is enough;
I have added a method ResetProgressDialog() to reset it when a
new query is started.
Finally, as anticipation of the next patch, this patch includes
support for a list of queries created by the master and described
by the new class TProofQuery.
The list is displayed by TProof::ShowQueries().
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
enter a numeric revision.
