[root] / trunk / proof / proofplayer / src / TEventIter.cxx Repository:
ViewVC logotype

Log of /trunk/proof/proofplayer/src/TEventIter.cxx

Parent Directory Parent Directory


Links to HEAD: (view) (download) (as text) (annotate)
Sticky Revision:

Revision 45632 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Aug 16 12:42:02 2012 UTC (2 years, 5 months ago) by ganis
File length: 38639 byte(s)
Diff to previous 45348

   Patch extending the output-handling new functionality to Proof-Lite.
   It also fixes a recent issue with stressProof.

Revision 45348 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Aug 2 12:23:54 2012 UTC (2 years, 5 months ago) by ganis
File length: 38454 byte(s)
Diff to previous 45283

     Consolidation of the automatic output saving functionality
     - Fix an issue with saving output from memory on the master
     - Remove some duplications and fix several small bugs

Revision 45283 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Jul 30 10:42:38 2012 UTC (2 years, 5 months ago) by ganis
File length: 38461 byte(s)
Diff to previous 44652

   Patch automatizing the usage of the file-based technology to handle outputs.
   After this patch PROOF users can define as an option to Process an output file for their results
   and choose if the merging goes via file or in memory. User can also decide to save theit results
   in a set of files identified by a name (dataset).
   Administrators can force merging-via-file or can make it conditional to the resident memory exceeding
   a given threshold.

   The new options are documented at
                                         http://root.cern.ch/drupal/content/handling-outputs

   Since TProofOutputFile is now used by TProof, the class has been moved from proof/proofplayer
   (libProofPlayer) to proof/proof (libProof).
   The selector tutorials/proof/ProofSimple.h,.C has been modified to allo testing the new options,
   and a new test has been added to stressProof.

Revision 44652 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Jun 11 16:16:14 2012 UTC (2 years, 7 months ago) by ganis
File length: 36240 byte(s)
Diff to previous 44010
    - In TEventInterTree::Load, make sure that the name of the tree to load is taken
      from the TDSet object name, unless specified explicitely. Allows to handle
      correctly multiple tree in the same dataset in all cases.
    - In stressProof, add a test to process different trees in the same files using 
      three different descriptions of the dataset: by-name, TDSet, TChain .
      For this test, tutorials/proof/ProofNtuple.h,.C has been modified to create a
      second ntuple in the same file .

Revision 44010 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sun Apr 29 23:07:48 2012 UTC (2 years, 8 months ago) by ganis
File length: 35966 byte(s)
Diff to previous 42856
  Several optimizations in the low level PROOF event loop (TProofPlayer::Process):
  - Per-event calls to TEventIter::GetNextEvent are replaced by per-packet calls
    to a new function TEventIter::GetNextPacket and a for loop over the returned
    range;
  - Progress information is filled in on per-packet pace just before asking for
    a new packet, instead of being filled for each event;
  - In TProofProgressStatus, the relevant setters in were inlined, and the (expensive)
    calls to SetLastUpdate() reduced to the minimum required;
  - Status of objects is checked using bits instead of functions calls;
  - Check whether to dump memory info is done before calling CheckMemUsage.
  These optimizations allow to reduce dramatically the overhead introduced by the
  operations PROOF needs to perform during the event loop. A measurement of the
  overhead can be obtained from a very light computational task, for example,
  generating one random number and filling one histogram; executing this task
  within a PROOF-Lite session with 1 worker now takes only 1.8 times the time
  required by a straight loop in the parent ROOT session; the same number before
  was about 13. 

  The patch also introduces a couple of small changes enabling the use of
  TProofPlayerLocal to process selectors in the local session using the PROOF
  iteration mechanism; this is very useful for optimizations studies.

  Finally, a couple of missing protections were added in TProofPlayer.

Revision 42856 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Feb 2 21:09:30 2012 UTC (2 years, 11 months ago) by pcanal
File length: 26052 byte(s)
Diff to previous 42754
In TTreeCache remove the (mostly unused) location notion of owner (fOwner) as the ownership is now shared explicitly between a TTree and its TFile. In TTreeCache::UpdateBranches, also migrate the ownership from one file to the other

Revision 42754 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Jan 20 20:13:07 2012 UTC (3 years ago) by pcanal
File length: 26059 byte(s)
Diff to previous 41740
From Peter van Gemmeren:

Allow multiple read caches per file by adding a fCacheReadMap member and owner arguments to GetCacheRead() and SetCacheRead()
to TFile.

Index: io/io/inc/TFileCacheRead.h
Index: io/io/src/TFileCacheRead.cxx
* Adding new argument for constructor to specify TTree owner
* whitespace indents

Index: tree/tree/inc/TBasket.h
Index: tree/tree/src/TBasket.cxx
* Add optional tree owner argument to LoadBasketBuffers() to retrieve cache.
* In LoadBasketBuffers() and ReadBuffers() check the cache first than call TFile::ReadBuffer only if needed.

Index: tree/tree/inc/TChain.h
Index: tree/tree/src/TChain.cxx
* Override SetCacheSize() function to update TTree owner on the current cache.
* whitespace indents

Index: tree/tree/src/TTree.cxx
* Get TTreeCache for current TTree, by specifying owner in GetCacheRead() calls
* Always delete owned cache

Index: tree/tree/src/TTreeCache.cxx
* Adding new argument for constructor for TFileCacheRead to specify TTree owner

Index: tree/treeplayer/src/TTreePlayer.cxx
* Get TTreeCache for current TTree, by specifying owner in GetCacheRead() calls

Index: tree/tree/src/TTreeCloner.cxx
* Call TBasket::LoadBasketBuffers() with current TTree as owner of cache

Index: proof/proofplayer/src/TEventIter.cxx
* Get TTreeCache for current TTree, by specifying owner in GetCacheRead() and SetCacheRead() calls

Revision 41740 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Nov 2 21:44:12 2011 UTC (3 years, 2 months ago) by ganis
File length: 25931 byte(s)
Diff to previous 41635
Improve the 'friends' tutorial in PROOF

Revision 41635 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Oct 28 15:02:31 2011 UTC (3 years, 2 months ago) by ganis
File length: 25755 byte(s)
Diff to previous 41623
Another bunch of Coverity-related fixes

Revision 41623 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Oct 28 10:42:40 2011 UTC (3 years, 2 months ago) by ganis
File length: 25736 byte(s)
Diff to previous 39576
Fix another bunch of Coverity issues

Revision 39576 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Jun 7 17:12:37 2011 UTC (3 years, 7 months ago) by pcanal
File length: 25514 byte(s)
Diff to previous 39106
Support the case where the default size for the Cache is 0 and hence no cache is created. This can happen whenever the AutoFlush mechanism is explicitly disabled when create the TTree

Revision 39106 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu May 5 09:34:12 2011 UTC (3 years, 8 months ago) by ganis
File length: 25467 byte(s)
Diff to previous 38810
Add missing initialization (Coverity)

Revision 38810 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Apr 12 16:22:59 2011 UTC (3 years, 9 months ago) by ganis
File length: 25438 byte(s)
Diff to previous 37987
  Patch to correctly honour selector abort status settings in PROOF. Currently only
  the TSelector::kAbortProcess was handled by stopping processing. In particular
  TSelector::kAbortFile was ignored; this recently created some problems in ALICE
  with corrupted files, with repeated attempts to read events eventually leading to
  bad_alloc exceptions.

  This patch also fixes other related issues, in particular with the reporting of the
  non-processed {files, events} in the final 'MissingFiles' list. This list should
  now account much more precisely of the number of events which could not be processed.

  It also fixes a problem with the final update of the progress information affecting
  occasionally cases with skipped events.

Revision 37987 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Feb 7 07:10:15 2011 UTC (3 years, 11 months ago) by ganis
File length: 24401 byte(s)
Diff to previous 37396
   Add switch to control caching of the files read on MacOsX.
   A call to fcntl(fd, F_NOCACHE, 1) is done after opening the file.
   To disable OS file caching the parameter PROOF_DontCacheFiles - or the ROOT-rc
   variable ProofPlayer.DontCacheFiles - must be set to 1.
   By default caching is enabled.

Revision 37396 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Dec 8 13:12:00 2010 UTC (4 years, 1 month ago) by rdm
File length: 24115 byte(s)
Diff to previous 36015
From Gerri:
- Fix a problem with the registration of missing files in the 'MissingFiles'
  list. The files that could not be open during processing were not properly
  registered in the list (only those found missing during validation or
  giving problmes durign reading were correctly added).
- Add method TProof::ShowMissingFiles() to facilitate the display of the
  list of missing files.
- Add method TProof::GetMissingFiles() to get a TFileCollection (dataset)
  with the missing files for further processing.

Revision 36015 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Oct 1 13:54:46 2010 UTC (4 years, 3 months ago) by ganis
File length: 24114 byte(s)
Diff to previous 35259
fix a bunch of Coverity FORWARD_NULL issues

Revision 35259 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Sep 14 09:13:05 2010 UTC (4 years, 4 months ago) by ganis
File length: 24106 byte(s)
Diff to previous 35115
   In TEventIterUnit, fill the number of bytes written in TPefStats for the cases when this
   iterator is used for generating files.

Revision 35115 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Sep 2 10:24:11 2010 UTC (4 years, 4 months ago) by ganis
File length: 23664 byte(s)
Diff to previous 34254
Fix issue found by coverity

Revision 34254 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Jun 30 16:29:36 2010 UTC (4 years, 6 months ago) by ganis
File length: 23605 byte(s)
Diff to previous 33640
Fix warnings in notification statements

Revision 33640 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri May 28 13:55:26 2010 UTC (4 years, 7 months ago) by ganis
File length: 23546 byte(s)
Diff to previous 32204
   Fix a few issues affecting the usage of tree friends in PROOF (see reports on the forum)
   - In TDSet:
      - Add friend alias as an option to the URL ("friend_alias=<alias>|") instead of an
        object string in a TPair (non streamable!)
   - In TVirtualPacketizer::CreateNewPacket
      - Adapt to the change in TDSet
   - In TEventIter:
      - Adapt to the change in TDSet
      - Make sure that the file with the friend is closed only when is not used anymore.

   The patch also fixes an issue with the locality check for files in TDSet.

Revision 32204 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Feb 3 19:17:40 2010 UTC (4 years, 11 months ago) by ganis
File length: 22254 byte(s)
Diff to previous 32003
   Add support for processing many datasets in one go in TProof::Process(const char *dataset, ...).
   Two options are provided:
   - 'grand dataset':  the datasets are added up and considered as a single dataset;
                       syntax: "dataset1|dataset2|..."
   - 'keep separated': the datasets are processed one after the other; the user is
                       notified in the selector of the change of dataset so she/he
                       has the opportunity to separate the results. A new packetizer,
                       TPacketizerMulti, has been developed for this case: it basically
                       contains a list of standard packetizers (one for each dataset) and
                       loops over them.
                       Syntax: "dataset1,dataset2,..." or dataset1 dataset2 ..."
   In both cases, entry-list can be applied using the syntax "dataset<<entrylist", e.g.
   "dataset1<<el1|dataset2<<el2|".
   See http://root.cern.ch/drupal/content/working-data-sets#currentelem for more details.

   A test for the new functionality has been added to test/stressProof.cxx .

Revision 32003 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Jan 13 18:00:12 2010 UTC (5 years ago) by ganis
File length: 21936 byte(s)
Diff to previous 31946
   - Avoid a possible double deletion in TProofServ::HandleSubMerger
   - Fix a small memory leak in TEventIterUnit and TEventIterObj (the
     processed 'packet' was not deleted before asking the next one)
   - Improve comments in the TProofPlayer

Revision 31946 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Dec 22 08:26:59 2009 UTC (5 years, 1 month ago) by ganis
File length: 21886 byte(s)
Diff to previous 31723
   Fixes for two memory leaks appearing when running several queries in the same PROOF session:
    - in TProofServ::HandleProcess, delete the TProofPlayer instance at the end of the query
    - in the TEventIterTree destructor, make sure that the tree cache is also deleted

Revision 31723 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Dec 9 10:59:43 2009 UTC (5 years, 1 month ago) by ganis
File length: 21823 byte(s)
Diff to previous 31598
   Fix issues found by Coverity:
     - #8563, #8365, #8382  : unitialized member in constructor: TEventIter, TEventIterTree
     - #6231, #435: possible use of undefined pointer
     - #140: unreachable code

Revision 31598 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Dec 7 15:21:47 2009 UTC (5 years, 1 month ago) by rdm
File length: 21634 byte(s)
Diff to previous 31475
From Gerri:
Fix a few pending issues in PROOF-Lite:
  - Source the env file before running 'proofserv'; this allows to run valgrind
    or other wrapper scripts (e.g. experiment-specific environment initializers)
    before proofserv, as in normal PROOF
  - Fix a problem with Load()
  - Add the possibility for the administrator to control the number of workers
    for PROOF-Lite or eventually to forbid the use of it (request on the forum).
    The rootrc variable ProofLite.MaxWorkers is read out of /etc/system.rootrc
    and cannot be overwritten by users.

Improve handling of Ctrl-C:
  - Fix a problem in TMonitor affecting the effectiveness of interrupts.
  - Do not send the results from workers to masters if the query has been
    aborted.

Miscellanea:
  - Make sure that the size of the cache sent back to the packetizer by the
    workers is meaningful in case the defaults are used (i.e. not -1).
  - Make the current processed element available to selectors via the
    input list; this allows to write a more simple and effective packetizers
    for tasks where the entry is a file (e.g., dataset generation in the
    benchmark suite).

Revision 31475 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Nov 30 19:14:45 2009 UTC (5 years, 1 month ago) by ganis
File length: 21567 byte(s)
Diff to previous 31438
Do not delete the tree cache at the end of the query (not owner)

Revision 31438 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Nov 26 16:23:19 2009 UTC (5 years, 1 month ago) by ganis
File length: 21594 byte(s)
Diff to previous 31437
  Make sure that the entry number passed to TSelector::Process is unique and in
  increasing order for non-data driven processing (packetizer TPacketizerUnit).
  This allows to give a meaning to this variable, for example to related it to
  one dimension of an integration.

Revision 31437 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Nov 26 11:42:25 2009 UTC (5 years, 1 month ago) by ganis
File length: 21516 byte(s)
Diff to previous 31296
  - Re-enable the use of the tree cache also for local files
  - Adapt the default settings for the cache to the recent changes

Revision 31296 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Nov 18 20:35:00 2009 UTC (5 years, 2 months ago) by rdm
File length: 21780 byte(s)
Diff to previous 30965
small code cosmetics.

Revision 30965 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Nov 4 11:15:25 2009 UTC (5 years, 2 months ago) by ganis
File length: 21810 byte(s)
Diff to previous 30859
Adapt to the new convention for FileOpenEvent and FileReadEvent (see #30963)

Revision 30859 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Oct 24 14:53:07 2009 UTC (5 years, 3 months ago) by ganis
File length: 21831 byte(s)
Diff to previous 30577
  Patch for improved performance monitoring. The 'Rate Plot' button in the progress
  dialog is renamed 'Performance plot' and shows up to 4 plots with the event/sec,
  the average read chunck size, the number of active workers and the number of active
  PROOF sessions on the cluster, all as a function of processing time.

  The read chunck size plot allows to monitor the usage of the cache.

  The istantaneous processing rate (event/sec) is now better estimate: a few issues
  with the normalizing times have ben solved, removing the artificial structures that
  were observed.

  The possibility to set a max packet time length is introduced (default 30 s); this
  can be changes with the parameter PROOF_MaxPacketTime.
  The size of the cache is also taken into account to optimize the use of the cache.

  The parameter PROOF_UseParallelUnzip has been introduced to toggle the use of the 
  parallel unzip (default off for now).

  A page describing the new performance plots is under preparation at 
           http://root.cern.ch/drupal/content/progress-dialog

Revision 30577 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Oct 6 13:36:41 2009 UTC (5 years, 3 months ago) by ganis
File length: 20597 byte(s)
Diff to previous 30562
Follow-up of the previous patch: point to the correct tree cache instance after setting the new size

Revision 30562 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Oct 5 15:02:21 2009 UTC (5 years, 3 months ago) by ganis
File length: 20507 byte(s)
Diff to previous 29126
   - Add the possibility to enable/disable the tree cache and to change its size on per-query base;
     two new parameters are available:

        PROOF_UseTreeCache    Int_t        Enable (0) or Disable (1) the tree cache (default 1)
        PROOF_CacheSize       Long64_t     Cache size in bytes (default 10000000)

     Examples:

        a) to disable the cache for the next run enter:

                                 proof->SetParameter("PROOF_UseTreeCache", 0)

        b) to set the cache size to 20M

                                 proof->SetParameter("PROOF_CacheSize", 20000000)

   - Fix a problem with changing the tree cache size: the latter was reset to the default value
     after the first file.

Revision 29126 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Jun 22 09:05:46 2009 UTC (5 years, 7 months ago) by brun
File length: 20325 byte(s)
Diff to previous 25965
From Gerri:
Initialize the tree cache only for remote files; solves a long standing crash experienced by ALICE
                         when mixtures of local and remote files were assigned to workers

Revision 25965 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Oct 27 07:06:58 2008 UTC (6 years, 2 months ago) by ganis
File length: 19985 byte(s)
Diff to previous 25733
   Use the packet information to limit the entry range of interest in TTreeCache.
   This increases the efficiency of prefetching, avoiding multiple reads of parts
   of files, especially in cases when the packet size is smaller that the cache
   size.

Revision 25733 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Oct 7 22:37:15 2008 UTC (6 years, 3 months ago) by ganis
File length: 19774 byte(s)
Diff to previous 23750
Add the possibility to control the cache size via the env ProofPlayer.CacheSize

Revision 23750 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu May 8 09:32:50 2008 UTC (6 years, 8 months ago) by ganis
File length: 19697 byte(s)
Diff to previous 23435
Add missing protection

Revision 23435 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Apr 23 10:30:50 2008 UTC (6 years, 9 months ago) by ganis
File length: 19668 byte(s)
Diff to previous 23070
Fix gcc-4.3 warnings

Revision 23070 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Apr 9 07:17:22 2008 UTC (6 years, 9 months ago) by ganis
File length: 19665 byte(s)
Diff to previous 22635
Ask for next packet on TFile::Open failures (instead of exiting the loop)

Revision 22635 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Mar 13 10:50:20 2008 UTC (6 years, 10 months ago) by rdm
File length: 19416 byte(s)
Diff to previous 22546
move all PROOF related libraries under the new proof directory.

Revision 22546 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Mar 8 19:21:05 2008 UTC (6 years, 10 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 19416 byte(s)
Diff to previous 21467
other bunch of gcc 4.3 warnings removed:
-  warning: suggest a space before ; or explicit braces around empty body
   in for statement

Revision 21467 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Dec 18 17:44:44 2007 UTC (7 years, 1 month ago) by ganis
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 19413 byte(s)
Diff to previous 20882
Add/correct doc statements where needed

Revision 20882 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Nov 19 11:31:26 2007 UTC (7 years, 2 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 19188 byte(s)
Diff to previous 20862
Set property svn:eol-style LF on all source and Makefiles. This should avoid
problems with Win32 line endings ending up in the repository. All MS tools
support LF eols fine.

Revision 20862 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sun Nov 18 14:51:42 2007 UTC (7 years, 2 months ago) by ganis
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 19188 byte(s)
Diff to previous 20682
   Synchronize with braches/dev/proof r20835

   Summary:

   TProofServ:
     - read session.rootrc with level kEnvChange to be able to change existing
       settings
     - Avoid deleting a query result twice in some special cases
     - Fix a problem with the initialization of fKeptQueries
   rootrc.in:
     - restore default settings the asynchronous reading
   TFileCacheRead:
     - add missing protection in ReadBuffer
   TEventIter:
     - Enable the usage of TTreeCache
   XrdProofdProtocol:
     - Additional check on the ownership of the unix socket
     - Improve notification during Reset
     - Reduce default timeout on admin requests and make it configurable
   XrdProofConn:
     - Use the configurable maxtry everywhere where relevant
   TPacketizerAdaptive:
     - Store info on all the processed packets in per-worker lists

   TProofMgr, TXProofMgr, TXSocket, XProofProtocol, XrdProofdProtocol:
     - Add possibility for the admin to broadcast a message to the connected users

   getProof:
     - Add missing protection

Revision 20682 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Nov 6 15:51:59 2007 UTC (7 years, 2 months ago) by ganis
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 16497 byte(s)
Diff to previous 20098
  Import branches/dev/proof r20654

  Summary:

  + Improvements
    - Add support for SSH SOCKS4 tunnelling; the local port for the tunnel can be specified
      in the master URL, e.g. TProof::Open("master/?tunnel:8000")
    - Add the possibility to plot the estimated instantaneous rate
    - Add "PROOF_ForceLocal" parameter to the !TPacketizerAdaptive; if set to 1, all the data
      are processed locally.
    - Add support for remote grep functionality while retrieving logs (needed by the forthcoming
      memory monitor)
  + Bug fixes
    - Several small fixes to revive the multi-master mode.
    - XrdProofdProtocol:
      - add missing lock to the client instance in SendMsg to avoid screwing up requests from
        workers on the same machine
         - lock the mutex of the requester when setting prorities
         - add notification during Reset
         - fix problem with the detection of the 'allow' directive
         - fix problem with the parsing of the return value from XrdProofServProxy::TerminateProofServ()
         - always use the effective user to retrieve info fom another server
           (XrdProofdManager::GetProofConn is now used)
         - fix possible dead-locks from debug notifications done after hard-killing a session
         - re-enable the garbage collector thread of the connection manager in XrdProofConn to
           fix a problem with closing physical connections;
         - fix a problem with !CleanupProofServ in the case of a non-privileged daemon running
           in multi-user mode
         - introduce a timeout when waiting for the startup of a 'proofserv'.
    - XrdProofConn: init mutex in the ctor; lock in SendRecv
    - XrdProofSched: add support for using the priorities defined in the group manager to define
      the number of workers for sessions
      - TProof:
         - Broadcast priorities to unique nodes only
         - timeout after 5 mins the initial Collect to avoid clients getting stuck at this stage
         - add support for generic timeout in Collect (disabled by default)
         - fix a problem with SendFile.
      - TXProofServ: add a call to !TProof::InterruptCurrentMonitor() in Terminate() to stop 
        infinite loops in Collect
      - TXSocket:
         - Implement a flag to interrupt a TXSocket while waiting for messages
         - Split the session creation timeout in 4 attempts: the total timeout is the same but
           it may circumvent occasional forking problems.
      - XROOTD: 
         - fix a potential (possibly accademic) memory leak in the client
         - fix a access permission problem with Kerberos ticket forwarding
         - fix bug preventing 'locate' to work properly
         - re-enable optimized 'locate'

Revision 20098 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Sep 25 15:58:39 2007 UTC (7 years, 4 months ago) by ganis
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 16507 byte(s)
Diff to previous 19826
  TEventIter.cxx, TDSet.cxx
   - Take into account a possible hidden prefix when testing file locality
  TEventIter.cxx
   - Fix a problem affecting loading a tree from file subdirectories

Revision 19826 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Sep 19 19:56:11 2007 UTC (7 years, 4 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 15971 byte(s)
Diff to previous 19825
imported svn:keywords Id property

Revision 19825 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Sep 19 19:49:10 2007 UTC (7 years, 4 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 16025 byte(s)
Diff to previous 19770
remove :$ from tag line

Revision 19770 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sun Sep 9 10:48:50 2007 UTC (7 years, 4 months ago) by ganis
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 16035 byte(s)
Diff to previous 19335
 From Long Tran-Thanh:
 - New special iterator class, TEventIterUnit, to iterate over packets of generic units
 - Use bit 17 of TDSet and TDSetElement to flag empty data sets

Revision 19335 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Jul 13 13:22:57 2007 UTC (7 years, 6 months ago) by ganis
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 14688 byte(s)
Diff to previous 19311
From Anna:
- Add support for entry-lists to PROOF.
From me:
- Cleanup usage of TEntryList/TEventList arguments in the TProof/TProofPlayer API.

Revision 19311 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Jul 11 14:23:10 2007 UTC (7 years, 6 months ago) by ganis
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 13773 byte(s)
Diff to previous 19225
Remove TEventIterTree::fAcquiredTrees and related methods: it is unused and not
properly cleaned, causing (rare) segmentation violations.

Revision 19225 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Jul 2 16:22:08 2007 UTC (7 years, 6 months ago) by ganis
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 14193 byte(s)
Diff to previous 19213
Delete current tree before loading the new one.

Revision 19213 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Jul 2 07:52:40 2007 UTC (7 years, 6 months ago) by ganis
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 14171 byte(s)
Diff to previous 18697
Delete current element before asking for a new one.

Revision 18697 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue May 8 14:56:19 2007 UTC (7 years, 8 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 14146 byte(s)
Diff to previous 18527
From Gerri:
- Remove any reference to TObjectCache (following a problem observed
  by Anna).
- Remove any reference to TPacketizerDev (it is not used and for testing
  one can upload a new packetizer as a PAR package)

Revision 18527 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Apr 19 09:33:40 2007 UTC (7 years, 9 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 12733 byte(s)
Diff to previous 18336
From Gerri:
get rid of not really needed usage of queue, map, pair and list.
- TDSet.h, .cxx
  Use TList, TPair instead of std::list<std::pair<... >>

- TPacketizer.cxx, TAdaptivePacketizer.cxx, TEventIter.cxx,
  TPacketizerDev.cxx, TPacketizerProgressive.cxx
  Adapt to the previous change in TDSet

Revision 18336 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Mar 19 10:46:10 2007 UTC (7 years, 10 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 12591 byte(s)
Diff to previous 17888
reflect move from proof to proofplayer directory in the cvs tag line.

Revision 17888 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Feb 12 13:05:32 2007 UTC (7 years, 11 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 12585 byte(s)
Diff to previous 16870
From Gerri:
replace a large amount of includes from .h files and replace them
with forward declarations.

Revision 16870 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Nov 22 14:16:55 2006 UTC (8 years, 2 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 12489 byte(s)
Diff to previous 16775
remove a bunch of warnings about Long64_t being truncated to Int_t.

Revision 16775 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Nov 15 17:45:55 2006 UTC (8 years, 2 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 12484 byte(s)
Diff to previous 15690
From Gerri and Bertrand:
Fixes and new features developed in preparation for the Intel quad-core
launch demo:
- Add instantaneous event and MB processing rates in the Progress signal
  and make necessary modification to exploit it in the Progress Dialog.
- Add possibility to change the Progress and Feedback periods
- A number of small improvements and bug fixes

Revision 15690 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Jul 4 23:35:37 2006 UTC (8 years, 6 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 12306 byte(s)
Diff to previous 15648
Some new features in TSelector and derivatives:
- new method Abort() which allows Process() to be aborted by the user
  from within the selector. After Abort(), either the Process() is aborted
  or the current file is aborted and the next file in a chain will be
  processed. Abort() can also be called from Begin(), SlaveBegin(),
  Init() and Notify() to interrupt processing. In all cases SlaveTerminate()
  and Terminate() are still called.
- new method GetEntry() which is a wrapper around:
    fChain->GetTree()->GetEntry()
- GetStatus() now also implemented in TSelectorCint so the selector
  fStatus is correctly reported back by TTree::Process() also for
  interpreted selectors (also documented in the generated selector).
- documented in the generated selector code that the boolean return
  values of Notify() and Process() are not used.
- fixed a bug in TProofPlayer() that caused Init() and Notify() to be
  called for every packet and not once per file.

Revision 15648 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Jul 1 11:39:37 2006 UTC (8 years, 6 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 12179 byte(s)
Diff to previous 15415
Rename TTreeCache to TTreeFileCache, to avoid clash due to the renaming of
TTreeFilePrefetch -> TTreeCache.

Revision 15415 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Jun 13 21:12:20 2006 UTC (8 years, 7 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 12136 byte(s)
Diff to previous 15046
cosmetics, small corrections in comments.

Revision 15046 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon May 15 09:45:03 2006 UTC (8 years, 8 months ago) by brun
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 12134 byte(s)
Diff to previous 14648
From Gerri:
Fix coding convention violations in krb5auth, rpdutils and
   proof

Revision 14648 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Apr 11 17:51:08 2006 UTC (8 years, 9 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 11840 byte(s)
Diff to previous 14528
From Gerri:
- the buggy SafeDelete(fTreeCache) is removed
- fTreeCache is promoted to static (fgTreeCache)
this should finally fix the large tree object cache related memory leak.

Revision 14528 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Apr 3 14:19:09 2006 UTC (8 years, 9 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 11854 byte(s)
Diff to previous 13841
From Gerri:
fix memory leak due to non-shared cache structures.

Revision 13841 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Jan 17 14:23:40 2006 UTC (9 years ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 16935 byte(s)
Diff to previous 12899
From Gerri:
work around a current reflex/shadow class limitation: pure virtual classes
cannot have data members.

Revision 12899 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Oct 4 16:13:22 2005 UTC (9 years, 3 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 16769 byte(s)
Diff to previous 12733
By Sergei Linev:
fixes so PROOF can be compiled with old 2.95 compiler.

Revision 12733 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sun Sep 18 01:06:02 2005 UTC (9 years, 4 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 17536 byte(s)
Diff to previous 12729
From Zev Benjamin:
new PROOF packetizer, TPacketizerProgressive, that loops over all files
in the TDSet and processes the files as they progressively become available.

Revision 12729 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Sep 17 13:54:47 2005 UTC (9 years, 4 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 17424 byte(s)
Diff to previous 12722
From Gerri:
Reverse patch in TEventIter...::GetNextEvent() (Maarten's comment).

Revision 12722 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Sep 16 08:48:39 2005 UTC (9 years, 4 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 18023 byte(s)
Diff to previous 12284
From Gerri:
Big patch supporting query queueing on the PROOF master, interogation and
interaction with the queue. Retrieval, finalization and archival of query
results and multiple PROOF sessions. Some other fixes:
- TMacro.h, .cxx
  add method Checksum to get the MD5 of the current context
  (needed for optimized selector reinitialization)

- Changes needed to create and fill the list of data sets (TROOT,
  TDSet, TChain, TChainProof)

- A new method TSelector::IsStandardDraw() to check if a selector
  is for standard draw actions

- TEventIter: fix for the missing last update (see above)

- Few protections in TPacketizers destructors

- Fix for code conventions in TPerfStats (the other will follow)

- Occasional missing last update of the progress bar (systematically
  reproduced with SetParallel(1)): all this part is quite involved
  and I have found a solution which does not harm but perhaps is not
  the most elegant.

- SetParallel(0): the progress bar was not working at all in such a
  case, since no packetizer is involved. Still it is useful to see
  that things are not stuck, so I have added some progress messages
  there too. The problem is that I have not found a way to get the total
  number of entries from a data set without doing all the machinery
  done in the packetizer.

Revision 12284 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Jul 9 04:03:23 2005 UTC (9 years, 6 months ago) by brun
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 17598 byte(s)
Diff to previous 12013
From Marek:
 Add friend trees to PROOF.

Revision 12013 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Jun 10 18:01:36 2005 UTC (9 years, 7 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 10979 byte(s)
Diff to previous 11281
change fBytesRead, fBytesWrite, fgBytesRead and fgBytesWrite from Double_t
to Long64_t. In other files remove casts to Long64_t because these classes
already used Long64_t for byte counters.

Revision 11281 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Mar 10 17:57:05 2005 UTC (9 years, 10 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 11001 byte(s)
Diff to previous 9182
From Marek Biskup:
major new PROOF developments:
 - access to PROOF directly via the TChain interface (creating a TDSet
   in the background).
 - access to PROOF based trees via the TTreeViewer
 - fully implemented the TChain/TDSet::Draw() interface.
 - PROOF sessions can now be browsed via the TBrowser

Revision 9182 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sun Jun 13 16:26:36 2004 UTC (10 years, 7 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 10275 byte(s)
Diff to previous 8239
From Maarten and Kristjan Gulbrandsen:
PROOF and file I/O performance monitoring framework. The TVirtualPerfStats
abstract class allows adding monitoring events in base classes (TFile and
TNetfile). The performance monitoring info allows detailed study of PROOF
performance (which files accessed by which slaves, latency, read/write times,
packet size, etc.). The result is send back to the client in the form of a
memory based TTree.

Remove TProofStats.h and TProofStats.cxx, .d, .o from proof/inc and src.

Revision 8239 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Feb 19 00:11:19 2004 UTC (10 years, 11 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 9566 byte(s)
Diff to previous 6552
Big authentication patch by Gerri:
General purpose:
Add support for 'authenticated' sockets on client side
and prepare for support of server authenticated sockets.

Main changes:

o TSocket, TPsocket:
  Added support of 'authenticated' sockets: authentication
  is delegated to TSocket by calling a static method
  CreateAuthSocket() returning a TSocket*.
  TSocket is now the only class calling TAuthenticate.

o TFTP, TNetFile, TSlave:
  modified to cope with new socket authentication scheme.

o TAuthDetails replaced by TSecContext containing:
  - local authentication info
  - expiration time
  - pointer to a security context for the method (if any)
  - information for cleanup (via TSecContextCleanup)

o A list of valid TSecContext has been added to TROOT,
  accessible via gROOT->GetListOfSecContexts().

o THostAuth rewritten using arrays to avoid multiple use
  of 'new'; functionality extended by the addition of
  several new methods.

o TAuthenticate:
  - Loading of information from .rootauthrc has been optimized;
    this allowed to simplify method signatures and drop several
    methods. Also collection and transmission of authentication
    information from TSlave to TProofServ gets simplified by the
    new scheme.
  - Added support for server dependent directives in .rootauthrc
  - Added check for changes in .rootauthrc each time a new
    TAuthenticate is instantiated, so that changes in the file
    are picked-up interactively.
  - Checking for an existing TSecContext (previously TAuthDetails)
    has been improved
  - Improved diagnostics for SshAuth
  - Enlarged support for authentication method indication in protocol:
       UsrPwd: rootup/proofup
          SRP: roots/proofs           (already supported)
         Krb5: rootk/proofk           (already supported)
       Globus: rootg/proofg
          SSH: rootsh/proofsh
       UigGid: rootug/proofug

o GlobusAuth.cxx, Krb5Auth.cxx, SRPAuth.cxx
  - Adapted to new class TSecContext
  - Added support for improved search for reusable TSecContext
  - Drop globals used to store established security contexts
    (saved in TSecContext) and related methods

o Automatic creation of <RootDir>/etc/system.rootauthrc from
  compilation flags; this has priority on old envs
  'Rootd.Authentication' and 'Proofd.Authentication' and is
  superseded by $HOME/.rootauthrc

o Automatic creation of <RootDir>/etc/system.authdaemonrc from
  compilation flags; this is superseded by $HOME/.rootauthrc

o rpdutils:
  - several almost identical methods moved in from rootd/proofd
  - several new methods to simplify manipulation of the
    authentication tab file
  - moved (and improved) check for running of sshd in RpdSshAuth,
    performed only in case of failure (to avoid spurious messages
    printed by sshd in /var/log/messages)

o proofd.cxx, rootd.cxx
  - increased protocol version
  - all initialization stuff (included authentication and
    login) done via RpdInitSession
  - postpone opening of parallels sockets after authentication
    (to solve problem of Kerberos/Globus authentication with
    parallel sockets)(rootd)
  - Fixed problem with kerberos and globus authentication in rootd
    with parallel sockets.

Revision 6552 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue May 6 08:23:43 2003 UTC (11 years, 8 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 9411 byte(s)
Diff to previous 6519
remove warning on MacOS X (unused arguments and variables).

Revision 6519 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu May 1 17:51:42 2003 UTC (11 years, 8 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 9406 byte(s)
Diff to previous 6384
implementation of TProof::StopProcess() and propagation infrastructure.
By Maarten.

Revision 6384 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Apr 4 10:21:16 2003 UTC (11 years, 9 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 9200 byte(s)
Diff to previous 6321
patch by Maarten. Remove several memory leaks.

Revision 6321 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Mar 18 14:29:59 2003 UTC (11 years, 10 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 9195 byte(s)
Diff to previous 5321
PROOF patch from Maarten. Introduction of Draw() skeleton.

Revision 5321 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Sep 17 10:14:25 2002 UTC (12 years, 4 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 8923 byte(s)
Diff to previous 5010
call TSelector::Notify() when switching to a new file in the TEventIter.
By Maarten.

Revision 5010 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Jul 26 15:33:15 2002 UTC (12 years, 6 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 8901 byte(s)
Diff to previous 4955
attach was not reset to false. By Maarten.

Revision 4955 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Jul 17 12:29:38 2002 UTC (12 years, 6 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 8878 byte(s)
Diff to previous 4385
PROOF mods from Maarten. New TVirtualPacketizer that is the base class for
different packetizers. You want different packetizers for different
processing strategies (depending on files being available on disk or if
they need to be sequentially retrieved from mass storage, etc.).
Added global PROOF debug facility.

Revision 4385 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Apr 19 18:24:02 2002 UTC (12 years, 9 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 8742 byte(s)
Diff to previous 4167
Major PROOF updates from both Maarten and me. Coming close to a working
system.

Revision 4167 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Mar 13 01:52:21 2002 UTC (12 years, 10 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 5741 byte(s)
Diff to previous 3962
PROOF synchronization with Maarten. Addition in TProof using std::map.
Might not yet compile on all platforms. Need quick feedback to fix.

Revision 3962 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Feb 12 17:53:18 2002 UTC (12 years, 11 months ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 6789 byte(s)
Diff to previous 3699
PROOF merge with Maarten.

Revision 3699 - (view) (download) (as text) (annotate) - [select for diffs]
Added Fri Jan 18 14:24:10 2002 UTC (13 years ago) by rdm
Original Path: trunk/proofplayer/src/TEventIter.cxx
File length: 2126 byte(s)
relocate some proof file to remove circular dependencies between the
treeplayer and proof shared libraries. Also rename TPlayer to TProofPlayer
et al. Also remove Begin() from TSelector, use Begin(0) instead. This to
be backward compatible with existing TSelector scripts that don't have
Begin() and therefor give warnings about Begin() being hidden in the base
class.

This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.

  Diffs between and
  Type of Diff should be a

Sort log by:

Subversion Admin
ViewVC Help
Powered by ViewVC 1.0.9