[root] / trunk / roofit / roofitcore / inc / RooLinkedListElem.h Repository:
ViewVC logotype

Log of /trunk/roofit/roofitcore/inc/RooLinkedListElem.h

Parent Directory Parent Directory


Links to HEAD: (view) (download) (as text) (annotate)
Sticky Revision:

Revision 42984 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Feb 13 15:30:31 2012 UTC (2 years, 11 months ago) by wouter
File length: 3207 byte(s)
Diff to previous 42233
  Assorted bug fixes
 
  o Roo1DMomentMorphFunction, RooFunctorBinding, RooFunctor1DBinding, RooProdPdf, RooAbsRealLValue,
    RooSimSplitGenContext, RooBinIntegrator, RooVectorDataStore, RooSegmentedIntegrator, RooChangeTracker,
    RooAbsReal,RooFactoryWSTool, RooRealIntegral, RooTreeDataStore, RooUnitTest, RooAbsPdf
 
    - Coverity fixes (mostly missing initialization)


  o RooDataHist

    - Fix in bin volume correction for partial integrals


  o RooAbsData

    - Remove stray debug comment


  o RooObjCacheManager

    - Follow change in RooCacheManager


  o RooCacheManager

    - Back out LHCb version - new version that does same thing but works correctly

Revision 42233 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Nov 24 23:35:45 2011 UTC (3 years, 2 months ago) by wouter
File length: 3180 byte(s)
Diff to previous 42171
  o PiecewiseInterpolation, RooProdPdf, RooRealSumPdf, RooProduct, RooAddPdf, 
    RooAddition, RooHistPdf, RooHistFunc
 
    -  Implement isBinnedDistribution


  o RooSimSplitGenContext

    - New implementation of RooAbsGenContext for simultaneous pdf.
      The difference with the existing RooSimGenContext is that
      the logic is implemented at the generate() level rather than
      the generateEvent() level, which allows to perform mixed
      binned/unnbinned generation


  o RooBinnedGenContext

    - New implementation of RooAbsGenContext that performs binned
      generation, with an unbinned weighted dataset as output.
      This new context implements the algorithm of 
      the now deprecated method RooAbsPdf::generatedWeightedUnbinned()


  o RooSimultaneous

    - Implement method autoGenContext() that selects a split context
      can case (partially) binned generation is requested

    - Deprecate generateMixed() - now absorbed in generate() 
  

  o RooAbsGenContext

    - Make generate() virtual

    - Implement processing of extend mode here too


  o RooCompositeDataStore

    - Fix compiler shadowing warnings


  o RooAbsPdf

    - Add method binnedGenContext() to return a generator context
      for binned generation

    - Add method autoGenContex() that can return either a binned
      or unbinned context depending on the input and circumstances

    - Add support for ExpectedData(),GenBinned(),AllBinned() and AutoBinned()
      in generate()

    - Deprecate generateWeightedUnbinned() - now absorbed in generate()


  o RooLinkedList, RooLinkedListElem

    - Adjust memory management of chain elements to avoid slow heap growth 

   
  o RooGlobalFunc

    - Add GenBinned(),AllBinned() and AutoBinned()


  o Module.mk

    - Add RooSimSplitGenContext, RooBinnedGenContext

Revision 42171 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Nov 22 16:38:52 2011 UTC (3 years, 2 months ago) by moneta
File length: 3079 byte(s)
Diff to previous 41676
import from the 5.32 patches changes from revision 42089 until 42170

See 

  http://root.cern.ch/viewvc?view=rev&revision=42089

  http://root.cern.ch/viewvc?view=rev&revision=42128

  http://root.cern.ch/viewvc?view=rev&revision=42153

Revision 41676 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Nov 1 15:44:30 2011 UTC (3 years, 2 months ago) by wouter
File length: 2618 byte(s)
Diff to previous 41536
   *** Miscellaneous speed improvements ***
  
    o PiecewiseInterpolation

      - Import changes from Max baak (new interpolation options)

      - Deploy fast iterators


    o RooGaussian

      - Bug fix in analytical integral over 'mean' parameter (Lorenzo Moneta)


    o RooBernstein

      - Deploy fast iterators


    o RooProdPdf

      - Reorganize code for improved speed


    o RooDataHist

      - Add support for vector-based data storage


    o RooGenContext

      - Improve generation speed by putting internal pdf clone to ADirty mode


    o RooRealBinding

      - Minimize number of calls to min() and max() for efficiency reasons


    o RooAbsRealLValue

      - In randomize() Minimize number of calls to min() and max() for efficiency reasons


    o RooDataSet

      - Make addFast() even faster by disable state propagation


    o RooAbsGenContext

      - Disable state propagation in output dataset for efficiency reasons
      - Call initGenerator() only on the first generation sequence

 
    o RooVectorDataStore

      - Add support for native vs current buffers, to support the functioning
        of addColumn(s)() and cacheArgs() when the datastore is attached
        to a pdf in RooAbsOptTestStatistics

   
    o RooAbsCategoryLValue

      - Support change in RooAbsCategory to operate nominally by index rather than by label


    o RooXYChi2Var

      - Change code to support new pdf/data attachment scheme in RooAbsOptTestStatistics
        where only the store buffers are reattached and the variable objects themselves


    o RooFFTConvPdf

      - Bug fix in getActualObservables() - functionality of setCacheObs() is now restored


    o RooAbsReal

      - Small adjustments in getVal() to make it faster in most cases


    o RooAbsCollection

      - Add datamember to keep track contents is exclusively RooRealVars. For those that
        do implement a faster version of assignFast()


    o RooAbsData

      - Add methods attachBuffers() and resetBuffers() - forwarded to datastore - that
        facilite new 'fast-attach' methods used in RooAbsOptTestStatistic


    o RooCompositeDataStore

      - Fix copy constructors so that they clone and own the subsidiary datasets

      - Operate index by value rather than by string label for efficiency reasons


    o RooRealVar

      - Bug fix in attachToVStore() to properly handle RRVs with StoreError tags


    o RooAbsPdf

      - Adjustments in getVal() to make it faster for most cases
      - Modify generate(GenSpec*) to initialize specInit flag that
        triggers one-time call of initGenerator()
      - Modify generate() to not repeatedly call initGenerator() for the same gencontext

 
    o RooAbsArg

      - Deploy fast iterators in more places
      - Add various new inline methods performing multiple ops (e.g retrieving and
        clearing one or more dirty flags) for improbed RooAbsReal/RooAbsPdf::getVal()
        operations
   

    o RooBanner

      - Increment version tag to 3.48


    o RooRealIntegral

      - Add overloaded getVal() method that also checks for shapeDirty flag,
        which was removed from RooAbsReal::getVal() as it is not needed for
        any class other than RooRealIntegral


    o RooAddGenContext

      - Disable state propagation in output dataset for efficiency reasons
      - Replace ROOT container classes with STL versions for efficiency reasons


    o RooMultiCatIter

      - Adjust code to new RooCatType behaviour that by default only tracks the
        integer representation of type


    o RooProdGenContext

      - Replace ROOT container classes with STL versions for efficiency reasons


    o RooTreeDataStore

      - Adjust code so that it works with the new fast-attach mechanism used
        in RooAbsOptTestStatistic


    o RooRealProxy

      - In lvptr() remove explicit check for lvalue


    o RooSimGenContext

      - Disable state propagation in output dataset for efficiency reasons
      - Replace ROOT container classes with STL versions for efficiency reasons
      - In createDataSet() create a prototype dataset in the first call, and
        clone that for subsequent calls rather than calling the expensive named
        argument constructor each time


    o RooTrace

      - Add (dummy) method callgrind_zero() and callgrind_dump() as hook functions
        to facilitate improved callgrind profiling


    o RooAbsCategory

      - Adjust class so that it works with the integer representation of types only
        and lookup associated string label on the fly, whenever it is requested


    o RooFormular

      - Eliminate overloaded getVal() as its functionality is now provided in 
        RooAbsReal::getVal()


    o RooAbsOptTestStatistic

      - Implement new fast-attach mechanisms for pdf and datasets: only readjust the
        buffer pointers of the dataset to the pdf observables, rather than reattaching
        the pdf to the dataset observables. This results in a _much_ faster 
        operation of setData() and no longer entangles the test statistics with observables
        of datasets that may be deleted during the lifetime of the test statistic

 
    o RooSimultaneous
 
       - Overload fillDataHist() with new version with correct normalization (from Scott Snyder)


    o RooCategory

       - Adjust getLabel() so that it retries labels associated with the current index on the fly


    o RooCatType

       - Make label contents 'transient', i.e. it is not copied on assignment for faster 
         category operations. RooAbsCategory will load the associated labels on demand from now on.

Revision 41536 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Oct 21 20:30:29 2011 UTC (3 years, 3 months ago) by wouter
File length: 2634 byte(s)
Diff to previous 36230
   *** Deployment of vector datastore & miscellaneous speed improvements ***  

   o RooProduct,RooProdPdf,RooRealSumPdf,RooConstraintSum,RooAddition

     - Deploy minimal iterator


   o RooDataHist

     - Add sumEntries() 
     

   o RooDataSet

     - In ctor, allow choice of vector and tree data store.
     - Change calls to attachToTree() to attachToStore()     
     - Add sumEntries() forwarding call to stre


   o RooVectorDataStore

     - New RooAbsDataStore implementation, based on STL vectors
       rather than TTrees


   o RooAbsReal

     - Adjust getVal() so that clean-cache elements are processed more efficiently
     - Add attachToVStore() 
    

   o RooAbsCollection,RooLinkedList

     - Add minimalIterator() returning by valye a minimistic iterator (forward step only)
       with a non-virtual step function


   o RooAddPdf

     - Deploy minimal iterator
     - Skip evaluation of supplemental normalization factors if the're all one


   o RooAbsData

     - Add static member encoding default storage type (vector vs tree)
     - Add method convertToVectorStore() to convert datasets with a tree-based store
       to a vector-based store


   o RooCompositeDataStore

     - Implement dummy loadValues() method


   o RooRealVar

     - Implement attachToVStore()


   o RooAbsPdf

     - Deploy minimal iterators
     - In getVal() also check for negative integrals as problematic value


   o RooAbsArg
 
     - Implement default version of isDerived() that always returns kTRUE
     - Add pure virtual method attachToVStore()
     - Deploy minimal iterators
     - Implement attachToStore() which forwards to attachToTree() or attachToVStore()
       depending on the storage type


   o RooTreeDataStore

     - Use setOperMode() with recursion where needed instead of looping manually
       over branches
     - Implement sumEntries()


   o RooNameReg

     - Add special fast handling of null pointers for conversions both ways


   o RooAbsCategory

     - Implement attachToVstore()


   o RooRealVar

     - Implement isDerived() method that was orignally in RooAbsArg
     - Implement attachToVStore() that optionally attaches error buffers too


   o LinkDef3, Module.mk

     - Add class RooVectorDataStore


   o RooAbsString

     - Implement dummy attachToStore()


   o RooConstVar, RooCategory

     - Implement isDerived() that always returns kFALSE 


   o RooAbsDataStore

     - Add pure virtual method sumEntries()
     - Add pure virtual method loadValues() 


   o RooLinkedListIter

     - Add class RooMinimalLinkedListIterator for forward-only 
       iteration without virtual function calls 
     - Add typedef to RMLLI
     - Add non-virtual NextNV() to RooLinkedListIter

Revision 36230 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Oct 9 20:21:02 2010 UTC (4 years, 3 months ago) by wouter
File length: 2592 byte(s)
Diff to previous 24278
  And yet more Coverity fixes

Revision 24278 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sun Jun 15 15:21:16 2008 UTC (6 years, 7 months ago) by wouter
File length: 2623 byte(s)
Diff to previous 23134
   o RooMPSentinel WHERE RooGenContext RooLinearMorph RooHistFunc RooInvTransform RooFracRemainder 
     RooIntegrator2D RooGaussKronrodIntegrator1D RooFitResult RooFFTConvPdf RooHist RooFormula RooIntegrator1D 
     RooMCStudy RooGenericPdf RooIntegratorBinding RooMPSentinel RooImproperIntegrator1D RooExtendPdf RooInt 
     RooLinTransBinning RooLinkedList RooLinkedListElem RooGenCategory RooList RooGrid RooLinkedListIter 
     RooMCIntegrator RooHistPdf RooListProxy RooFormulaVar RooHistError RooLinearVar RooGenProdProj RooHashTable

     - Upgrade inline documention: make sure that (almost) every member function has some descriptive comments, every
       data member has a descriptive comment, make sure that each class has a description.

     - Fix class description header so that it is correctly identified by THtml

Revision 23134 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Apr 11 07:53:39 2008 UTC (6 years, 9 months ago) by rdm
File length: 2559 byte(s)
Diff to previous 20879
move the following directories to "roofit":

roofitcore, roofit

Revision 20879 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Nov 19 11:22:56 2007 UTC (7 years, 2 months ago) by rdm
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 2559 byte(s)
Diff to previous 20161
Set property svn:eol-style LF on all source and Makefiles. This should avoid
problems with Win32 line endings ending up in the repository. All MS tools
support LF eols fine.

Revision 20161 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Oct 1 16:28:25 2007 UTC (7 years, 3 months ago) by wouter
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 2559 byte(s)
Diff to previous 18735
   o RooAbsCache

    - New abstract base class for cache objects associated with RooAbsArgs.
      Caches register themselves with the owning RooAbsArg and propagate
      all necessary state changes and meta information to objects in the cache


   o RooCacheManager

    - Concrete template implementation of RooAbsCache with an interface
      and functionality styled after RooNormListManager. The template class
      provide no special handling for cache contents that includes RooAbsArg
      objects and does not forward hook calls. It is thus mostly intended
      to cache basic types indexed on a normalization/integration configuration


   o RooObjCacheManager

    - Class derived from RooCacheManager<RooAbsCacheElement> that implements
      all proper call forwarding and handling of state and other meta information
      to RooAbsArg objects embedded in the cache elements. To facilitate this
      functionality the RooAbsCacheElement defines a pure virtual method
      containedArgs() that must be implemented to expose its contents to
      the cache manager. The default behavior on a serverRedirect hook is
      to sterilize the cache. OperMode changes are not forwarded by default
      to the cache contents as cached objects do not necessarily have the
      same operation mode (e.g. if the cache contains an integral of its owner).
      Any calls to optimizeCacheMode(), printCompactTreeHook(), and findConstantNodes()
      are forwarded. Moreover, optimizeCacheMode() calls are remembered and
      any objects inserted in the cache after such a call was received will be
      optimized upon insertion in the cache

   o RooAbsCacheElement

    - Abstract base class for objects to be managed by RooObjCacheManager. Each
      object must in addition to its payload implement the containedArgs()
      member function that exposes the RooAbsArg object content to the manager
      for processing. The argument passed to containedArgs() indicates the use
      case for the returned list of objects, allowing the cache payload to
      return different lists depending upon use. This is for most applications
      not required.


   o RooAbsCachedPdf

    - Abstract base class derived from RooAbsPdf for p.d.f.s that implement 
      value caching in a grid over the entire domain of the observables. 
      The base class implements the overall caching logistics and manages
      the RooDataHists and RooHistPdfs that respresent the cached contents.
      Derived classes must inputBaseName() defined a unique name prefix for
      all cache objects, actualObservales() and actualParameters() to
      determined the actual observables and parameters given a set of 
      available observables and fillCacheObject() which should fill the
      RooDataHist cache for a given obs/params configuration with the
      p.d.fs values.


   o RooAbsSelfCachedPdf

    - Abstract base class derived from RooAbsCachedPdf that implements
      all of the required logistics in RooCachedPdf and only require
      derived classes from RooAbsSelfCachedPdf to implement evaluate().
      Any class derived from RooAbsPdf can thus be trivially switched
      to derived from RooAbsSelfCachedPdf and gain the caching functionality.
      

   o RooCachedPdf

    - Concrete class derived from RooAbsCachedPdf that implements
      the caching of an externally provided p.d.f in the constructor.


   o RooFFTConvPdf

    - Concrete class derived from RooAbsCachedPdf that implement generic
      numeric convolution of two input p.d.f.s using FFT technique
      and convolution theorem. Actual FFTs are calculated by FFTW
      through TVirtualFFT interface in ROOT. Present implementation only supports 
      convolution in one dimension, but this will be extended later
      as there are no fundamental limitations in RooAbsCachedPdf nor FFTW.
 

   o RooHistPdf

    - Moved from RooFit to RooFitCore because it is used by caching classes


   o RooProdPdf

     - Use new RooObjCacheManager to store partial objects

     - Fix memory leak (already patched in 15.0.14h)


   o RooDataHist

     - Use new RooCacheManager template to cache partial bin volumes

     - Add new set(),setAllWeights() method to update current weight and all weights
       respectively, for use in cached p.d.f.s

     - Add sliceIterator() that iterates over all bins in a lower dimensional 
       slice of the dataset


   o RooDataHistSliceIter

    - Class derived from TIterator that implements the iteration
      over a slice in a reduced number of dimensions in a RooDataHist


   o RooMsgService

     - Speed up processing of debug streams in cases where no debug streams are active

     - add macros series oocoutX and oocxcoutX that allow to associate message with
       a different object than *this

   o RooRealBinding

     - Interface new setValue method that allows value to be set outside default
       domain, but inside given alternate named range. For use in numeric integrator
       bindings


   o RooAbsRealLValue

     - Add new inRange() method with range name specifier to check against chosen
       range instead of default range


   o RooCmdConfig

     - Fix dangling return pointer problem in decodeStringOnTheFly() method


   o RooNameSet

     - Fix bug in refoll()


   o RooChi2Var, RooNLLVar

     - Add processing of AddCoefRange() named argument


   o RooConvCoefVar

     - Hold p.d.f in proxy without value/shape state propagation to obtain
       correct dependency of RooConvCoefVar through separate set proxy
       with parameters that do have state propagation

     - In getAnalyticalIntegral() ask for integration coefficient specific
       to coefficient (following interface change in RooAbsAnaConv)


   o RooEfficiency

     - Follow interface change in RooCategoryProxy


   o RooAbsAnaConvPdf

    - Use new RooObjCacheManager to hold normalization and coefficient representations

    - Extend getCoefAnalyticalIntegral() interface so that each coefficient
      can have a separate integration configuration

    - Modify makeCoefVars() such that it constructs the RooConvCoefVars with
      actual dependents for each coefficients, rather than inserting dependencies
      of any of the coefficients in each coefficient. This logic requires support
      from the implementation class that is interface through a new member function
      coefVars()


   o RooAbsReal 

    - Add Boolean data member treeVar that indicates is value buffer is also
      branch buffer of a tree. This information is already present in the RooAbsReal
      but is relatively expensive to retrieve and is always needed in the inner
      loop of data set operations. This extra member significantly speeds up operations

    - Remove superfluous _norm[] token in name returned by integralNameSuffix() if 
      no normalization set is supplied.

    - Add a fillDataHist() method that fills a given RooDataHist with a sampling
      of the given function. Added for support of caching p.d.f.s


    - Downgrading warning on non-dependent projection variables in plotOn() to
      a debug level message

    - Remove function optimizeDirty(),doConstOpt(),undoConstOpt(),findCacheableBranches()
      findUnusedDatasetVariables() and findRedundantCacheServers() as part of reorganization
      of optimization functionality.


   o RooAbsCollection

    - Use iterator semantics instead of vector semantics to process RooLinkedList
      contents in assignment operator

    - Add utility function contentsString() returning stl string with names
      of contents


   o RooAddPdf

    - Rewrite cache management using new RooObjCacheManager that holds projection
      integrals, range integrals and supplemental normalization lists


   o RooAbsOptGoodnessOfFit

    - Improve handling of normalization ranges and reference ranges for test statistics
      containing RooAddPdfs. New named argument in fitTo() and RooNllVar::ctor() pass
      reference range for fractions in RooAddPdf components that do not have an explicit
      fixed definition already. Name all normalization ranges explicitly after the
      subrange to which the're applied to avoid name clashes and conflicts if multiple
      normalization ranges are involved.

    - Rewrite informational messages through RooMsgService

    - Implement new constOptimizeTestStatistic() function that signals all test statistic
      components of a RooAbsArg expression tree to perform their constant term optimization

    - Implement new optimizeCaching() driver function that changes default lazy-evaluation-with-caching
      scheme to test statistic scheme where only parameters objects propagate state changes and
      where all components that depend directly or indirectly on observables have lazy evaluation
      disabled. Changes to p.d.f objects are delegated to RooAbsPdf::optimizeCacheMode(). Changes
      to dataset are delegated to RooAbsData::optimizeReadingWithCaching()

    - Implement new optimizeConstantTerms() function that is back end for constOptimizeTestStatistic
      implementation. 


  o RooAICRegistry, RooNormSetCache

    - Remove tracking of allocation cycles of RooArgSets as this scheme is superseded by
      memory pool mechanism for RooArgSet allocation


  o RooMappedCategory

    - Follow interface change in RooCategoryProxy.


  o RooRealMPFE

    - Follow reorganization of optimization functionality: implement new constOptimizeTestStatistic
      function for forwarding to slave processes.


  o RooRealVar

    - Add new setVal() function with range name to facilite setting of values that are outside
      default range, but inside specified alternate range. Needed for numeric integration and
      certain RooAddPdf coefficient projection.


  o RooAbsArg

    - Make state management functions public [is/set][Value/ShapeDirty](), setOperMode90
  
    - Add static _flipAClean boolean to support setACleanAdirty() static method.

    - Implement mechanism for registration of cache objects with base class RooAbsCache.
      Forward all calls to operModeHook(), redirectServersHook(), optimizeCacheMode()
      and printCompactTreeHook() to all caches for further processing
   
    - Define constOptimize() function and provide default implementation that forwards
      to all servers 

    - Implement optimizeCacheMode() function that puts expression tree in optimized
      caching for test-statistics operations (only cache/lazy evaluate nodes that
      do not (indirectly) depend on observables

    - Implement findConstantNodes() function that identifies all nodes that depend
      exclusively on constant observables and >0 observables that are eligible
      for precalculation and caching in test statistics operations by 
      RooAbsOptTestStatistic::optimizeConstantTerms()

    - Define constOptimizeTestStatistics that signal an expression tree that any
      embedded test statistic objects should perform their constant term optimization.
      Default implementation in RooAbsArg forwards call to all servers.


  o RooAbsPdf

    - Use new RooObjCacheManager to manage normalization integrals cache.

    - Process new SumCoefRange() option in fitTo() that sets the coeffient
      interpretation range for all embedded RooAddPdf objects of which
      the interpretation range was not explicitly set

    - Extend interface of fixAddCoefNormalizationSet(): add extra argument
      that controls if AddCoef normalization set are forcibly overruled
      for objects that already have an explicit range setting.

  
   o RooRealIntegral 

    - Add some informational messaging through RooMsgService, rewrite existing ones

    - Speed up numeric summations by precreating the involved RooSuperCategory
      in the ctor rather than in evaluate().

    - Fix bug in dependency insertion: explicitly require servers to be value
      server to avoid pulling in fake dependents.
    
    - Remove obsolete data members

    - Implement new setACleanADirty() function that atomically flips state of
      all AClean objects to ADirty for the duration of the integration step.
      Replaces the much more expensive prepareACleanFunc() that did this
      only for the objects involved.

    - Process factorizing terms in integral only if the list is not empty

    - Process Jacobian terms in integral only if the list is not empty


  o RooAddGenContext

   - Adapt to cache management chanches in RooAddPdf


  o RooNumIntFactory

   - Use STL classes for internal memory management


  o RooSetProxyy

   - Implement operator new() and operator() delete as required because
     RooArgSet implements them 


  o RooAbsGoodnessOfFit

   - Store and forward AddCoefRange information for embedded RooAddPdf objects

   - Implement constOptimizeTestStatistic() and forward to components


  o RooErrorVar

   - Follow inRange() interface change in RooAbsRealLValue


  o RooConvGenContext

    - Adapt code to make it work with both RooAbsAnaConv objects and
      the newly introduced RooFFTConvPdf


  o RooMinuit

    - Follow reorganization of optimization functionality


  o RooProjectedPdf

    - Store projection using new RooObjCacheManager


  o RooGlobalFunc

    - Add RooFit::SumCoefRange() named argument for RooAbsPdf::fitTo() 
      and RooNLLVar::ctor() and RooChi2Var::ctor()


  o RooClassFactory

    - Extend existing makePdf(),makeFunction and makeClass() functions
      to also accept RooAbsCategory arguments, to accept an optional string
      inserted as the return value expression inserted in the 
      evaluate() method of the class created, as well as as option string
      specifying one or more analytical integrations of the given function
      expression that will be advertised in the generated getAnalyticalIntegral()
      code and implemented in the generated analyticalIntegral() code

    - Add makeAndCompileFunction() and makeAndCompilePdf methods that
      generate the code and immediate compile it through ROOTs ACliC interface.
      These functions have a simpler interface because the list of arguments
      of the function to be created can be specified as a const RooArgSet&
      rather than a string with a list of names, thus making it easier
      for on-the-fly definition of compiled objects.

    - Add defineFunction() and definePdf() methods define and compile
      a function/pdf using the above functions and immediately instantiate
      an object of the given type passing the specified RooArgSet arguments
      to the constructor of the object. These functions make a compiled
      equivalent of RooFormulaVar based on the TFormula interpreter, i.e.

           RooAbsReal* f = new RooFormulaVar("f","D(1-2w)",RooArgSet(D,w)) ;

      becomes
       
           RooAbsReal* f = RooClassFactory::defineFunction("f","D(1-2w)",RooArgSet(D,w)) ;

   
  o RooAbsCategory

   - Add Boolean data member treeVar that indicates is value buffer is also
     branch buffer of a tree. This information is already present in the RooAbsReal
     but is relatively expensive to retrieve and is always needed in the inner
     loop of data set operations. This extra member significantly speeds up operations

   - Construct explit clean name for TBranch name if node is cached, equivalent
     to what is done in RooAbsReal. Needed because new constOptimizer can also
     cache RooAbsCategory objects


  o RooArgSet

   - Implement operator new() and operator delete() to implement memory pool scheme
     for RooArgSets. The goal of this implementation is to insure that two RooArgSet
     pointers are _never_ the same. This allows to RooNormSet cache manager to safely
     and quickly index integration and normalization configurations by evaluating
     the contents of a RooArgSet only the first time it sees it.


  o RooSimultaneous

   - Implement caching of partial integrals using new RooObjCacheManager

   - Following interface change in RooCategoryProxy ;


  o RooAbsData

   - Defined pure virtual methods optimizeReadingWithCache() and allClientsCached()


  o RooTreeData

   - Implement optimizeReadingWithCache() which determines given a p.d.f to be
     evaluated and a list of the nodes that are cached for it, which observables
     in the dataset are no longer required because they are either not an observable
     of the p.d.f, or they exclusively feed nodes that are cached. Reading of these
     observables is disabled through SetBranchStatus().
  
   - Move allClientsCached() utility function here from RooAbsReal.


  o RooCategoryProxy

   - Remove const char*() conversion operator in favor of a const char* label() method
     to remove possibly ambiguities in C++ math expressions involving category proxies.


  o LinkDef3.h

   - Add newly defined classes

Revision 18735 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri May 11 09:13:47 2007 UTC (7 years, 8 months ago) by verkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 2562 byte(s)
Diff to previous 11181
Change structure and names of files to that of ROOT CVS repository

Revision 11181 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Feb 25 14:23:04 2005 UTC (9 years, 10 months ago) by wverkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 2573 byte(s)
Diff to previous 9370
   o All files

     - Update copyright notice from 2004 to 2005

Revision 9370 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Jul 2 07:39:04 2004 UTC (10 years, 6 months ago) by wverkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 2573 byte(s)
Diff to previous 8538
  This round of updates achieves two major goals

    - Large (O(10-100)) speedup in handling of very
      complex PDFS (>10000 nodes) by pervasive use
      of self-expanding hash tables

    - Fix outstanding problems with RooProdPdf
      through new strategy to deal with cached
      objects in cloning/server redirect operations

  There is also a handful of minor fixes

  ------------------------------------------------

  o RooSetPair

    - New auxiliary class to store pair of RooArgSet pointers


  o Roo1DTable

    - Don't fill entries with zero weight


  o RooAbsArg

    - Add optional 2nd arg to printCompactTree() to store
      output to file


  o RooAbsCollection

    - Initialize RooLinkedLists with hashing size threshold of 43



  o RooAbsGoodnessOfFit, RooAbsOptGoodnessOfFit, RooProdPdf

    - Follow changes in printCompactTree() syntax



  o RooAbsOptGoodnessOfFit

    - Remove all methods that implement dirty state optimization
      and constant term caching (migration to RooAbsReal)


  o RooAbsReal

    - Various fixes in plotAsymOn fix plotting of asymmetries
      in conjunction with ProjWData() and Slice()

    - Add methods that implement dirty state optimization
      and constant term caching (migration from RooAbsOptGoodnessOfFit)


  o RooDataProjBinding

    - Remove some old debug code


  o RooHashTable

    - New constructor option allow to choose hashing by name,
      pointer or objects Hash() value

    - Switch to using TMath::Hash() fast hashing method
      using 'especially selected random numbers' (!)

    - Add kludgy support for storage of RooLinkedListElem
      and RooSetPair objects, which do not inherit from TObject.

      (A full redesign of RooLinkedList and RooHashTable is needed
       at some point)


  o RooHist

    - Fix print statement


  o RooHistError

    - Lower (n,m) threshold for calculation of approximate binomial
      error to avoid factorial overflow problems.


  o RooLinkedList

    - Introduce automatically activated hashing by name and pointer
      to speed up handling of long lists beyond size threshold
      given in ctor (zero threshold disables this features)

    - Automatically rehash tables when #entries becomes greater
      than hash table size


  o RooNameSet

    - Sort contents upon insertion. This fixes broken operator==
      for certain set comparisons


  o RooNormListManager

    - Add support for 'sterile' operation. If contents is sterilized
      via new sterilize() member function or use of sterile copy
      ctor RooNormSetCache information is retained (and thus
      ordering and slot indeces used by client classes) but
      stored contents associated with given iset/nset pairs
      is deleted. A 'setNormList()' call that maps to a
      sterilized slot will recycle that slot. Optional new argument
      in getNormList will tell client that requested information
      has been sterilized rather than not being there.


  o RooNormSetCache

    - Store set pair information in hash table of RooSetPair objects
      rather than two fixed size arrays of RooArgSet pointers.
      This greatly improves lookup speed (indexed by set pointers)
      and automatically expands the capacity of the set cache
      as is needed for very complex fits.


  o RooProdPdf

    - Abandon strategy to forward redirectServer requests to
      cached product configurations. This strategy has turned
      out to be flawed as insufficient information is available
      in the redirectServers context to do the right thing
      under all circumstances. Invocation of redirectServerHook()
      will now sterilize the cache, using new RooNormListManager
      feature

    - Modify getAnalyticalIntegralWN(), which looks up cached
      product configurations by index to recognize sterilized
      entries. If such an entry is encountered, it is reconstituted
      on the fly.


  o RooRealIntegral

    - Store owned clones of factorizing observables instead of linking
      to instances provided in ctor as ownership related of those
      turns out not to be well defined.


  o RooRefCountedList

    - Set hashing threshold of underlying RooLinkedList at 17


  o RooSimPdfBuilder

    - Increase buffer sizes of RooStringVars in set returned by
      createProtoBuildConfig() to accomodate requests for ever
      more complex pdf configurations.

Revision 8538 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Apr 5 22:44:13 2004 UTC (10 years, 9 months ago) by wverkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 2543 byte(s)
Diff to previous 6614
  o All files

    - Update (c) to 2004

Revision 6614 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed May 14 02:58:40 2003 UTC (11 years, 8 months ago) by wverkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 2542 byte(s)
Diff to previous 5317
  o RooRealIntegral

    - Interface segmented integrators (1D and 2D)

  o All others

    - Various fixes (mostly initialization orders in ctor,
      unused variables) to achive clean complication
      on Linux with '-Wall -Wno-parentheses'

  o LICENSE

    - Update copyright notice

Revision 5317 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Sep 17 06:39:35 2002 UTC (12 years, 4 months ago) by verkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 2542 byte(s)
Diff to previous 5212
  o RooAbsPdf, RooAbsReal, RooDataHist, RooTreeData

    - Changed protected plotOn() to accept RooLinkedList instead of TList

  o RooCmdConfig

    - Change process(),stripCmdList to use RooLinkedList instead of TList

  o RooFormula

    - Changes all internal lists to RooLinkedList (was TList, TObjArray)

  o RooHashTable, RooLinkedList, RooLinkedListElem, RooLinkedListIter

    - Change interface from RooAbsArg to TObject

  o RooHtml

    - Update copyright, web address etc


  o RooRefCountList

    - Inherit from RooLinkedList instead of THashList

  o RooSimultaneous

    - Fix handling of RooCmdArgLists & change protected plotOn() interface from
      TList to RooLinkedList

  o RooTrace

    - Fix include files

  o makedocs

    - Set default to production color scheme

Revision 5212 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Sep 5 04:34:04 2002 UTC (12 years, 4 months ago) by verkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 2281 byte(s)
Diff to previous 5209
  o All files

   - Fix aesthetic detail in new headers

Revision 5209 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Sep 4 21:07:02 2002 UTC (12 years, 4 months ago) by verkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 2343 byte(s)
Diff to previous 5174
  o All files

    - Replace file header with new 'legalized' version

  o LICENSE

    - New file with full text of license agreement

Revision 5174 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Aug 21 23:06:42 2002 UTC (12 years, 5 months ago) by verkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 1664 byte(s)
Diff to previous 3073
  Major new version (to become V00-01-00)

  o README

    - Update standalone compilation instructions
      Refer BaBar users to RooFitBabar/README

  o RooAICRegistry

    - Fix memory leak

  o RooAbsArg

    - Add default implementation of constOptimize() that
      forwards the call to all servers

    - Add RooAbsOptGoodnessOfFit, RooRealMPFE as friends

    - Add protected pure virtual method setTreeBranchStatus()
      that can be used by the optimizer to disable reading
      of the tree branch associated with the RooAbsArg

  o RooAbsBinning

    - Add description

  o RooAbsCategory

    - Add operator==()

    - Implement setTreeBranchStatus()

  o RooAbsCollection

    - Add addClone(RooAbsCollection&,...) to add a list of clones

  o RooAbsData

    - Add pure virtual methods for new caching mechanism:
       * cacheClone() returns a clone of the dataset with cache
       * resetCache() clears the existing cache
       * setArgStatus() disables reading of given args from tree

  o New class RooAbsGoodnessOfFit

    - Abstract base class for goodness-of-fit variables.
      A goodness-of-fit is any quantity calculated from a PDF
      and a dataset. This class orgamizes parallelization over multiple
      CPUs and calculation of GOFs from simulatenous PDFs.

  o New class RooAbsOptGoodnessOfFit

    - Abstract base class for goodness-of-fit variables
      that calculate the PDF value at each data point in the
      given dataset. It implements various optimizations:
      caching of constant terms, elimination of unused variables etc.

  o RooAbsPdf

    - Deploy new normalization integral manager RooNormManager
      to cache multiple normalization integrals for a PDF.
      This greatly increases the efficiency for certain situations
      where PDFs are alternatingly called with 2 or more different
      normalization choices

    - Reimplement fitTo() in terms of RooNLLVar and RooMinuit.

    - Reimplement plotNLLOn() in terms of RooNLLVar and plotOn()

    - Migrate plotNLLContours to RooMinuit

    - Remove obsolete method fitContext

  o RooAbsReal

    - Add operator==()

    - Implement setTreeBranchStatus()

    - Fix memory leak in createProjection()

  o RooAbsString

    - Implement setTreeBranchStatus()

  o RooAddModel

    - Eliminate getNormSpecial() construction that was originally
      introduced to efficiently handle calls with 2 alternating
      projection/normalization configurations originating from
      RooConvolutedPdf. This is now handled by RooNormManager.

  o RooAddPdf

    - Reimplement caching of coefficient projection list and
      supplemental normalization list using RooNormListManager.
      (Also supports caching of multiple configurations now)

  o RooArgSet

    - Implement addClone(RooAbsCollection&,...)

  o RooBanner

    - Add description

  o RooBinning

    - Add description

  o New class RooChi2Var

    - Implementation of simple Chi^2 of RooAbsOptGoodnessOfFit
      for a RooDataHist and a RooAbsPdf.

      Chi^2 is calculated from PDF value at the bin center.
      Poisson errors are used if no user defined errors are present

  o RooConvolutedPdf

    - Reimplement normalization integral management using
      RooNormListManager

    - Deprecate use of RooResolutionModel::getNormSpecial. No longer needed.

  o RooCustomizer

    - Fix memory leak

  o RooDataHist

    - Add lo/hi Error associated with each bin. Default implementation
      returns poisson errors. Error is return by weightError().

    - New set() function allows user to override poisson errors

  o RooDataSet

    - Fix copy ctor for weighted datasets

    - Implement cacheClone()

  o RooDirItem

    - Add description

  o RooDouble

    - Add description

  o RooExtendPdf

    - Follow changes in normalization management of RooAbsPdf

  o Removed class RooFitContext

    - Replaced by RooMinuit/RooNLLVar

  o RooFitResult

    - Change terminology NLL -> FCN (fits are no longer NLL necessarily)

    - Store and report accuracy code of minuit error matrix

    - Minor tweaking of parameter dumps with mixed symmetric/asymmetric
      errors

  o RooGenericPdf

    - Follow changes in RooAbsPdf normalization management

  o RooIntegratorConfig

    - Add description

  o RooLinTransBinning

    - Add description

  o RooLinkedListElem

    - Add description

  o RooLinkedListIter

    - Add description

  o New class RooMPSentinel

    - New class to keep track of server processes started for
      parallelized goodness-of-fit calculations. On linux
      hosts, these processes don't exit when the parent process
      exits. This class sends termination signals when this
      singleton class is deleted

  o RooMath

    - Activate CERF disk caching by default

  o New class RooMinuit

    - New seamless interface between RooFit objects and MINUIT
      Class propagates information forth and back between RooAbsArg
      objects and minuits internal memory buffer (e.g. parameter
      values, errors, step sizes, constant status)

    - This class minimizes any RooAbsReal function (doesn't need to
      be a NLL or Chi2)

  o Removed class RooNLLBinding

    - Obsolete after introduction of RooNLLVar

  o New class RooNLLVar

    - Implementation for NLL of RooAbsOptGoodnessOfFit

  o RooNameSet

    - Fix memory leak

  o New class RooNormManager

    - New manager class for normalization/projection integrals for PDFs
      This class matches RooArgSet pointer pairs to the integration
      and normalization sets to previously registered integrals.
      Multiple pointer pairs can point to the same integral (e.g.
      pointer to different RooArgSets with the same contents) and
      multiple integrals can be cached. This class doesn't create
      the normalization integrals. It merely indicates if it has
      one or not, and leaves it up to the owning class to create
      and register new normalizations


  o New class RooNormListManager

    - Similar to RooNormManager, except that RooArgLists of normalization
      integrals are caches instead of single integrals

  o RooNormSetCache

    - Rework functionality. This class, used by RooNorm(List)Manager
      manages multiple redundant RooArgSet pointer pairs that represent
      the same projection/normalization configuration

  o RooProdPdf

    - Almost complete rewrite in terms of RooNormListManager


  o RooRealConstant

    - Minor const changes

  o RooRealIntegral

    - Streamline iterator use: Create various interator in ctor
      and reuse them in evaluate() instead of creating and deleting
      them on the fly

  o New class RooRealMPFE

    - Front end for MultiProcessor calculations. Class RooRealMPFE
      takes a RooAbsReal as argument and calculates it in separate
      process. Calculations can be started asynchronously with
      the calculate() call. The rest of the interface (and behaviour)
      is identical to that of the original RooAbsReal.

  o RooResolutionModel

    - Deprecate getNormSpecial - superceded by RooNormManager

  o RooSetProxy

    - Implement addClone(const RooAbsCollection&,...)

  o Removed class RooSimFitContext

    - Obsolete - replaced by RooMinuit/RooNLLVar

  o RooSimGenContext

    - Fix memory leak

  o RooSimultaneous

    - remove obsolete fitContext() method

  o RooTreeData

    - Reimplement caching. Cached functions are now stored in
      a separate tree in the dataset. Main benefit of the new
      implementation is that caches can efficiently be reset
      and refilled on the fly

  o makedocs

    - Add stanzas for new tutorial macros

Revision 3073 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Oct 19 22:19:50 2001 UTC (13 years, 3 months ago) by verkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 1620 byte(s)
Diff to previous 3048
   Fix persistence of RooLinkedList, RooDataSet
   --------------------------------------------

   o RooAbsArg

     - Remove assert in default ctor(). Once put there
       to trap streamer based cloning

   o RooAbsCollection

     - Follow minor interface changes in RooLinkedList

   o RooAbsData

     - Make _cachedVars not persisted

   o RooLinkedList

     - Make custom streamer that sequentually
       read/writes contained elements to stream

     - Inherit from TObject to facilitate persistence

   o RooFitCore_LinkDef.hh

     - Added to declare that RooLinkedList has a custom streamer

   o RooLinkedListElem

     - Declare as transient class (not used in RooLinkedList persistence)

   o RooTreeData

     - Add transient flag that determines if object was constructed
       from default ctor (i.e. an object retrieved from persistence)
       If set get() will on first use reconnect all args in _vars
       as branches to the tree

Revision 3048 - (view) (download) (as text) (annotate) - [select for diffs]
Added Wed Oct 17 05:04:00 2001 UTC (13 years, 3 months ago) by verkerke
Original Path: trunk/roofitcore/inc/RooLinkedListElem.h
File length: 1485 byte(s)
  Efficient generation of convoluted variables
  --------------------------------------------

  o RooConvGenContext

    - New generator context that generates physics
      model and resolution model separately and returns
      the smeared result

  o RooConvolutedPdf

   - Overload genContext() to use the new efficient
     generator scheme if both resolution model and
     and physics model support direct generation
     of the convolution variable and the resolution
     model has no other dependents

   - Add protected changeModel() function to allow
     RooConvGenContext to change present model on the
     fly.

  o RooGenContext

   - Add option to force consideration for direct generation
     of a given set of dependents. Used by RooConvGenContext
     to force direct generation of convolution variable when
     convoluted with the truth model

  o RooTruthModel

   - Hand code the 6 basis functions used for B mixing
     and decay as special cases. (Significant speed gain)


  o RooResolutionModel

   - In convolution(), swicth from RooAbsArg::findServer(0) to
     RooFormulaVar::getParameter(0)


  Collection Storage / General stability improvement
  --------------------------------------------------

  o RooAbsCollection

    - Switch to use RooLinkedList instead of THashList as
      internal storage mechanism

  o RooLinkedList,RooLinkedListElem,RooLinkedListIter

    - New efficient implementation of a linked list
      that doesn't try to access it's members when
      removing them (nor does any other funny & illegal
      things that all TList subclasses can't seem to stop doing)



  Miscellaneous fixes
  -------------------

   o RooAICRegistry

     - Fix copy ctor (clone owned RooArgSets)

   o RooFormula

     - Introduced delayed compilation of TFormula:
       formula is compiled only when value is requested
       for the first time. (Efficiency gain for RooFormulaVars
       used as basis function, which are often not evaluated
       at all)

   o RooAbsReal

     - Fix erroneous warning message in makeProjectionSet()

   o RooAcceptReject

     - Delete cache in ctor!

   o RooListProxy

     - Bug fix: overload addOwned()

This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.

  Diffs between and
  Type of Diff should be a

Sort log by:

Subversion Admin
ViewVC Help
Powered by ViewVC 1.0.9