Log of /trunk/roofit/roofitcore/src/RooArgSet.cxx
Parent Directory
Revision
39817 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Jun 18 12:49:41 2011 UTC (3 years, 7 months ago) by
wouter
File length: 31527 byte(s)
Diff to
previous 38909
o RooDataSet
- Introduce pool-based memory allocation scheme
- In ctor for composite datasets with Link() ensure that
order of observables is preserved to allow use of assignFast()
o RooRealSumPdf
- Use getNorm() in expectedEvents() rather than createIntegral()
o RooAbsCollection
- Do no allocate hash tables by default
- Introduce contents claim counter to counter 'foreign' ownership
claims of contents (needed for RooAbsOptTestStatistic::setData()
support)
- If collection is owning, only delete contents if claim count is also zero
- In snapshot() raise hash table threshold from 100 to 1000
o RooRefCountedList
- Disable hash tables by default
o RooStudyPackage
- Make study package own clone of incoming workspace
- Implement copy ctor
o RooAbsTestStatistic
- Implement 'master' setData() method. Forward to setDataSlave()
of self for monolithic likelihoods or forward data components
to likelihood components in case node is SimMaster. If data
is not fast-splittable, execute slow split.
o RooAbsData
- Implement 'live check' to be able to conclude if a given dataset
pointer points to a live or dead object
- Claim contents of _vars through new claim mechanism. Release
in dtor, allow _vars to delete contents if claim count is zero
- Add concept of owned component datasets to support fast-splitting
of dataset
- Add method canSplitFast() that indicate if fast split is available
(only possible if dataset was created as composite)
- Add method getSimData() that retrieves pointer to component
RooDataSet representation for a given index state
o RooObjCacheManager
- Add static mechanism that allows to deleted cached observables lists used for
cache optimization triggers to be deleted on a sterilize() action. This
is useful on toy studies with setData() operation, that would otherwise
collect very large lists of observable clones during the toy cycle.
o RooAbsPdf
- Set contraint term to ADirty to avoid synchronization problems when using
setData() in the likelihood
o RooAbsArg
- In clone operations set hash table threshold at 1000 nodes
- In getObservables() use pass-by-value iterators rather than heap iterators
to making this faster. Also make getObservables() non-virtual, as it is in
fact not overloaded in any subclass (anymore). Also remove looping over
branch nodes to call getObservablesHook() as no class implements method
anymore.
o RooAddition
- Implement a setData() method that forwards to its components. Allows transparent
operation of setData() on likelihood objects with constraint terms
o RooLinkedList
- Add method that returns iterator by value (simply forwards to similar implementation
in RooLinkedList)
o RooSimGenContext
- Move calculation of fraction table from ctor to dedicated updateFraction() method
- Before each generation sequence call updateFractions() so that multi-generation
sequence are robust against parameter changes between calls
- In createDataSet() always make a composite dataset if the index is present, as this
allows faster use in toymc operations
o RooAbsOptTestStatistic
- Initialize all variables in default ctor
- In dtor and ctor handle ownership of dataset observables, on which we put a claim
(i.e. we need to delete contents if the test statistics survives the dataset)
- Reimplement existing setData() as setDataSlave(), and add claim management on
dataset observables. When attached new data to function, request that object caches
clear full content in sterilize() operation to avoid buildup of cache objects in
long toy runs.
- In setData() adjust event count of test statistics, for correct functioning of extended
terms after update
o RooArgSet
- In ctor for list and a single object, only add object if not already in list
(is already checked, but new procedure preserves order of list elements in case
object was already present)
o LinkDef
- Add list<RooAbsData*> and map<string,RooAbsData*> to support streaming of composite datasets
o RooAbsStudy
- Implement clone method to support polymorphic array cloning
o RooAbsReal
- Add interface method setData()
o RooProfileLL
- When storing coordinates of absolute minimum, store only those that are non-constant.
Otherwise option to restart each minimization from known absmin may alter constant
parameters
Revision
34064 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 22 15:05:19 2010 UTC (4 years, 7 months ago) by
wouter
File length: 31480 byte(s)
Diff to
previous 28259
Import roofit/roofit(core) changes from dev/roostats branch to trunk
=== r34062 ===
o RooProdPdf
- Fix compilation error on Windows
- Fix memory leak
- Fix some shadowing problems
o RooDataHist
- Fix memory leak
o RooFactoryWSTool
- Add syntax checker routine to factory front-end. At present
this counts only of all pairs of (),[],{} match.
- Add factory syntax 'set::name(a,b,c)' as factory syntax for
RooWorkspace::defineSet("name","a,b,c") ;
o RooAddPdf
- Fix memory leak
o RooAbsNumGenerator, RooAcceptReject, RooFoamGenerator
- Fix uninitialized pointer problem spotted by valgrind
o RooRealMPFE
- Fix gcc 4.4 warnings by checking return values of all read(),write()
and pipe() calls.
o RooAbsPdf
- Fix variable shadowing issue
o RooRealIntegral
- Fix memory leak
o RooTreeDataStore
- Fix memory leak
o RooSimultaneous
- Fix variable shadowing issue
o RooGlobalFunc, LinkDef2
- Include fix from Kyle/Axel to solve include guard issue in macros
for namespace RooFit
=== r34020 ===
Update to RooRealSumPdf where normalization had memory leak
=== r33961 ===
o RooAbsReal
- Add new method setEvalErrorLoggingMode() that takes three options
PrintErrors (default), CountErrors (new) and CollectErrors (supports
structured printing during minimization
o RooRealMPFE, RooMinimizerFCN, RooMinimizer, RooMinuit
- Follow changes in RooAbsReal
o RooAbsPdf
- Make getLogVal() return log(0) when probability is zero, rather than zero,
to support operation of (non-log) likelihood functions
=== r33945 ===
o RooNumRunningInt, RooCachedPdf, RooCachedReal
- Use aggregateCacheUniqueSuffix() advertised by content to
distinguish objects with identical structure that have
different non-parametric content (such as likelihood functions)
o RooAbsCachedPdf, RooAbsCachedReal
- Allow addition of additional suffix to name of object cached
in expensive object store
o RooAbsReal
- Introduce virtual function cacheUniqueSuffix() that allow function
objects that have non-parametric content that can cause two instance
of an object with the same parameter to behave differently (e.g. likelihoods that
have different datasets but the same pdf) to advertise a string suffix
that can be attached to the index name in the expensive object cache to
distinguish different instances
- Introduct method aggregateCacheUniqueSuffix() that concatenates all suffixes
produced by any branch node into a single string
o RooAbsOptTestStatistic
- Advertise dataset pointer as unique cache suffix
o RooProdPdf
- Large scale adjustment to code to be able to handle pdfs where
the normalization range of its observables is defined by
multiple ranges rather than a single range
o RooMsgService
- Add concept of debug workspace and debug code to facilitate
debugging of complex problems
o RooGenContext
- Force use of Accept/Reject sampler for problems with observables where
the range depends on other observables as Foam cannot handle these
o RooDataSet
- Bug fix in handling of weights in append() operation
o RooAbsGenContext
- Add support for handling of explicit normalization range(s)
o RooAbsReal
- Bug fix in createIntegral(), avoid use of strtok() due to possible recursive use
o RooAddPdf
- Large scale adjustment to code to be able to handle pdfs where
the normalization range of its observables is defined by
multiple ranges rather than a single range
o RooAbsPdf
- Add support for definition of multiple normalization ranges, with setNormRange()
as user front end
o RooAbsArg
- Fix bug in link state management: a state change to ADirty must be propagated to
all clients.
- Add maximum level argument to printComponentTree()
o RooRealIntegral
- Fine tuning of debug-level print messages
- Fix memory leak
o RooAddGenContext
- Add support for handling of multiple normalization ranges
o RooRangeBoolean
- New RooAbsReal implementation that returns 1 or 0, depending on another observable
having a value in a predefined range
o RooAbsIntegrator
- Fine tuning of debug-level printouts
o RooTreeDataStore
- Multiple bug fixes in handling of weighted data
o RooAbsOptTestStatistic
- Small changes to support operation with multiple normalization ranges
o RooArgSet
- Add utility method isInRange() that is forwarded to content
o RooGenProdProj
- Add new operation mode that does not factorize, which is needed for certain cases
with multiple n
=== r33943 ===
o RooProdPdf
- Large scale adjustment to code to be able to handle pdfs where
the normalization range of its observables is defined by
multiple ranges rather than a single range
o RooMsgService
- Add concept of debug workspace and debug code to facilitate
debugging of complex problems
o RooGenContext
- Force use of Accept/Reject sampler for problems with observables where
the range depends on other observables as Foam cannot handle these
o RooDataSet
- Bug fix in handling of weights in append() operation
o RooAbsGenContext
- Add support for handling of explicit normalization range(s)
o RooAbsReal
- Bug fix in createIntegral(), avoid use of strtok() due to possible recursive use
o RooAddPdf
- Large scale adjustment to code to be able to handle pdfs where
the normalization range of its observables is defined by
multiple ranges rather than a single range
o RooAbsPdf
- Add support for definition of multiple normalization ranges, with setNormRange()
as user front end
o RooAbsArg
- Fix bug in link state management: a state change to ADirty must be propagated to
all clients.
- Add maximum level argument to printComponentTree()
o RooRealIntegral
- Fine tuning of debug-level print messages
- Fix memory leak
o RooAddGenContext
- Add support for handling of multiple normalization ranges
o RooRangeBoolean
- New RooAbsReal implementation that returns 1 or 0, depending on another observable
having a value in a predefined range
o RooAbsIntegrator
- Fine tuning of debug-level printouts
o RooTreeDataStore
- Multiple bug fixes in handling of weighted data
o RooAbsOptTestStatistic
- Small changes to support operation with multiple normalization ranges
o RooArgSet
- Add utility method isInRange() that is forwarded to content
o RooGenProdProj
- Add new operation mode that does not factorize, which is needed for certain cases
with multiple normalization ranges
=== r33758, r33720 ===
o RooPoisson
- Fixes in internal generation code
o RooLogNormal, RooGamma, LinkDef1
- New classes contributed by Gregory Schott
Revision
26044 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Oct 31 16:45:22 2008 UTC (6 years, 2 months ago) by
wouter
File length: 30533 byte(s)
Diff to
previous 25829
(Fixes inferred from valgrinding of expanded stressRooFit test suite)
o RooParamBinning
- Fix initialization of _owner in default ctor
o RooAbsRealLValue
- Fix small memory leak in createHistogram()
o RooDataSet
- Fix small memory leak in constructor
o RooCurve
- Fix leaking of array of sampling hints in addPoints()
o RooAbsReal
- Fix small leak in plotAsymOn()
- Fix double ownership problem in createIntRI()
o RooProduct
- Fix two small memory leaks
o RooAbsTestStatistics
- Downgrade initSimMode message from ERROR to INFO
o RooAbsPdf
- Add Warning() modifier to plotOn() to set MINUIT SET NOWarn option
- Fix small memory leak in fitTo() when using constraints
- Fix glitch in generate() in extended mode when nPoisson=0
- Fix small memory leak in plotOn() when using ranges
o RooRealIntegral
- Fix small memory leak in constructor
o RooPolyVar
- Add destructor that deletes internal iterator
o RooMinuit
- Add interface to suppress MINUIT warnings
o RooGlobalFunc
- Define Warnings() named argument
o RooArgSet
- Add protection to pool allocation scheme in case pool size is not
exactly N times object size
o RooSimultaneous
- Fix small memory leak
Revision
25758 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Oct 9 16:10:42 2008 UTC (6 years, 3 months ago) by
wouter
File length: 30267 byte(s)
Diff to
previous 25184
o RooArgSet
- Fix slow memory growth reported in Savannah #41775
o RooAddPdf
- Fix crash observed by Chris West (BaBar) -- Only apply range ratio
correction if ranges are defined.
Revision
25184 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Aug 20 13:59:55 2008 UTC (6 years, 5 months ago) by
wouter
File length: 29138 byte(s)
Diff to
previous 24261
o RooAbsSelfCachedPdf
- Declare embedded RooHistPdf as self-normalized to prevent
superfluous calculation of unit normalization
o RooDataHist
- Add new named argument ctor that can collate multiple
TH[123] into a N+1 dimensional RooDataHist which has
an extra RooCategory to distinguish the source, as
well as import single a TH[123] objects
- Add ctor that can do the same, but specified from
a map<string,TH1> specification.
- Add new importTH1Set(),importTH1() utility methods to implement
common functionaly of both new ctors
- Add adjustBinning() method that encapsulates the functionality
to adjust the RooDataHist observable binning to match that
of a given (imported) TH1, which was formerly contained in the ctor
- Speed up code in interpolateDim() by reducing number of required
lookups of the observable binning definition.
o RooParamBinning
- Add tree printout of boundary functions, if defined in verbose
printing mode
o RooMsgService
- Add special handling of PROGRESS message level: automatically
insert newline when switching from a PROGESS to another message level.
o RooPlot
- In verbose printing, add index number to printout of each contained
plotable object
o RooGenContext
- Fix for handling of observables with parameterized ranges
- Eliminate forgotted debug print statement
o RooAbsRealLValue
- Implement new binning interface methods that take binning reference
rather than binning name, for faster use in internal operations
- Implement new RooAbsLValue methods with RooAbsBinning pointers
o RooDataSet
- Add new named argument constructor that can generically handle imports
of TTrees, RooDataSet and can collate multiple RooDataSets into
a N+1 dimensional RooDataSet with an extra RooCategory that labels
the source dataset
o RooDLLSignificanceModule
- Tune some of the names of the produced output observables
o RooChi2Var
- Set the default error type to RooAbsData::SumW2
o RooCustomizer
- Modify the sterile build() routine to make the returned
head node own all the created components rather than
the customizer itself.
o RooAbsCategoryLValue
- In copyCache(), check that the value copied is in fact
valid for the destination.
o RooFitResult
- Tune the line widths of the objects created in plotOn()
when creating the error ellipse.
- Add a method correlationHist() that returns a 2D histogram
with the correlation matrix element values, which is labeled
with the parameter names.
o RooCurve
- Add explicit handling for evaluation errors that can occur
when sampling the function being represented. New constructor
arguments control how evaluation errors are logged to
RooMsgService, in similar style to RooMinuit, and control
how the drawn output value is affected (as calculated, or
substituted with a user controlled value).
o RooFFTConvPdf
- Add automated handling of FFT sampling windows of the 'physics'
pdf and the 'resolution' pdf. In the new setup the second pdf
is always assumed to be a 'resolution' pdf and its sampling window
is chosen symmetrically around zero, regardless of the definition
of the range of the convolution observable. The width of the sampling
window, and the number of sampling bins is still tied to the "cache"
binning defined in the convolution observable. Added setShift()
modifiers allow the user to manually control the sampling window
shifts on both pdf. The shift introduced by sampling a shifted
window of the resolution effect is correct a posteriori by
performing a compensating rotation of the final FFT buffer.
- Modify FFTCacheElem to cache a functional clone of both pdf
with optional shift transformations applied through a RooLinearVar
substitution of the original convolution observable. Instruct
caching RooDataHist not to forward dirty state propagation calls
and set sampling pdf clones to AlwaysDirty to increased operational
efficiency.
o RooChangeTracker
- Add parameters() method returning the tracked parameters
o RooRealSumPdf
- Implement component selection functionality in plotting as
is available for RooAddPdf
o RooEfficiency
- Implement analytical integral over acceptance category
(it is always 1.0)
o RooHist
- Implement ability to handle RooAbsData::None error bars
(i.e no errors)
- Expand functionality of constructor taking two TH1s
to also represent the efficiency binomial in addition
to the assymmetry binomial
- Add addEfficiencyBin() method to handle calculation
of efficiency bins.
o RooAbsReal
- Make named argument version of fitTo() default method
when invoked with no arguments
- In fitTo(), if pdf is extendable and no explicit Extended() argument
is given, automatically included extended likelihood term
- In fitTo(), disable default running of MINOS when invoked without
arguments
- Move component selection functionality from RooAbsPdf
to here so that it also works for RooRealSumPdf, which
takes RooAbsReals as components rather than RooAbsPdf
- Add simplified createHistogram() method that takes
string with comma separated observable names and
three optional bin numbers.
- Add createHistogram() method that takes a list of
RooCmdArgs that can serve as backend for all user
interface methods.
- In plotOn() support the new Slice() argument for categories
that allow inline specification of of the slice position.
- Also add support for the PrintEvalErrors(Int_t numErr) and
EvalErrorValue(Double_t value) arguments to allow better control
of evaluation error handlign during plotting.
- Also add support for the MoveToBack() argument that immediately
inserts the curve at the bottom of a RooPlot stack.
o RooProduct
- Remove erroneous assert()
o RooAbsCollection
- In snapshot(), only add "Snaphot of" to name if original
has a non-null name.
- In verbose printing mode, remove printing of 'extras' and
only print '(owning contents)' of collection has a non-null name
o RooAddPdf
- Fix logic of recursive fractions constructor. Recursive additions
happen start on the rightmost pair of pdfs, recursively adding
one more pdf to the left at each iteration. Coefficients describe
the fractions of the leftmost pdf in each recursive addition,
starting with the outermost addition of the 1st pdf to the
som of all other pdfs, continuing with the fraction of the
2nd pdf being added to the sum of pdf 3-n etc...
o RooAbsCachedPdf
- Degrade 'parameters have changed' message from INFO to DEBUG
- Interface cache histogram objects to RooExpensiveObjectCache
with associated parameters given by RooChangeTracker
- Fix bug in printing: only print normalization object of
cache if it actually exists
o RooAbsTestStatistic
- Reimplement copy constructor to initialize from scratch from
original contents, to support sane implemlementation of
copying of optimized test statistics with multi-process
calculations.
- Fix redirectServers method for objects implementing multi-process
test statistics
o RooRecursiveFraction
- Invert incoming list of plain fractions when filling internal
list in ctor so that last fraction is 'special' instead of first
to support improved handling of recursive fractions in RooAddPdf
o RooAbsData
- Fix client-server reconnect handling for dataset observables
with parameterized ranges in terms of other dataset observables
- Add simplified createHistogram() method that takes
string with comma separated observable names and
three optional bin numbers. If bin counts are negative,
the ranges of output histogram are automatically calculated.
If the bin counts are positive, the ranges of the observables
are used for the histogram, unless the observable has an
open-ended ranges, in which case the automatic calculation
is used.
- Add createHistogram() method that takes a list of
RooCmdArgs that can serve as backend for all user
interface methods.
- Extend createHistogram() method with named arguments
to take AutoBinning and AutoSymBinning arguments to
automatically calculate the ranges of the output histogram
with the specified number of bins.
- Add a table() method that takes a set of RooCategories
and returns a table of the output states of a RooSuperCategory
of the given input categories.
o RooProfileLL
- Add option to start minimization always from parameters
of global minimum.
o RooRealMPFE
- Remove some forgotted debug printouts
- Pass IsConstant() state of RooRealVars being transferred in
addition to their value and error.
- Fix copy constructor
o RooRealVar
- In printing interface, maker error part of 'value' rather
than of 'extras'
- Fix bug in format() concerning constant parameters with
errors.
o RooAbsPdf
- Move component selection support for RooAddPdf to RooAbsReal
so that it also works with RooRealSumPdf.
- Remove some superfluous DEBUG level print messages
- Add support for EvalErrorWall() named argument in fitTo
to give user control of the 'NLL wall' feature used to
force MINUIT to retreat from regions with evaluation errors
- Enlarge default size of box created by paramOn()
o RooAbsArg
- Add pointer to expensive object cache to use for any expensive
objects to be cached in association with this object
- Add recurseNonDerived option to branchNodeServerList
- Overload printAddress() to so that RooAbsArg base address
is printed rather than RooPrintable base address, which
can be different due to multiple inheritance
- In constant term optimization, prevent addition of
observables with parameterized ranges to cache.
- Add interface methods to get and set the associated
expensive object cache
- Add flipAClean() accessor method for corresponding
static data member to solve windows linkage problems.
o RooRealIntegral
- Add support for cache values of >1D integrals in
expensive object cache
o RooExpensiveObjectCache
- New repository class that holds expensive components of RooAbsArg
function objects along with the parameters value for which the
stored expensive object is valid. All newly created objects
are associated with a default singleton instance in memory,
but objects in RooWorkspaces are associated with a cache in the
workspace.
o RooMCStudy
- Add Silence() named argument to ctor that will silence all
RooFit messages during running below the PROGRESS level
- Store generated number of events in fitParDataSet()
- Only store generated parameter values in fitParDataSet()
if constraints were used
- Give fitParDataSet() a unique named, named after the
fit and/or generator model used.
o RooNumRunningInt
- Fix bug in calculation of cdfs.
o RooMinuit
- Deprecate support for error handling mechanisms that are now
phase out.
- Implement option to ignore evaluation errors
- Improve the contour() method to return a RooPlot containing
contour TGraphs, rather than drawing them directory on a canvas
o RooDouble
- Set name to string representation of value
o RooGlobalFunc
- Add various named argument constructors needed by other code
o RooCintUtils
- New name space with CINT interaction utilities
- Add function to match a given functin pointer to a string with
a function argument list specification to facilitate manual overloading
of method on function pointer declarations, which is not supported
directly by CINT
o RooPrintable
- Introduce printAddress() method to print address
o RooRandomizeParamMCSModule
- Fix bug in init()
o RooAcceptReject
- Adjust code to make it work with observables with parameterized ranges
o RooWorkspace
- Add an embedded expensive object cache to each workspace. Connect each
inserted object to the internal expensive object cache and transfer
any cache contents upon insertion as necessary.
o RooNumIntConfig
- Tune non-verbose printing output
o RooAbsOptTestStatistic
- Implement correct handling of test statistics with observables
that have parameterized ranges in terms of other observables
- Implement sane copy constructor.
o RooHistError
- Add method to calculate confidence intervals for efficiency binomials.
o RooSentinel
- Add cleanup handler for expensive object cache global instance
o RooBinningCategory
- New real->cat function that represents binning associated with
any given RooAbsRealLValue as category functions. Category states
mapping to observable bins are automatically created and named
o RooSimultaneous
- Add support for new Slice() arguments that allow to specify the
slice position for category observables.
o RooTreeData
- More fixes for infernal warning messages from TTree concerning
improperly constructed memory resident trees
- Forward TTree::Draw() method with cut expression.
- Add Efficiency() named argument to plotOn() method to support
plotting of efficiencies represent by a category observable
that indicates which event do (not) pass a given cut
- Support FillColor() and FillStyle() named arguments in plotOn()
for the benefit of bar chart representations of histograms
- Add plotEffOn() method to implement internal handling specific
to efficiency plotting
- Extend functionality of getRange() method to automatically
include margins and optional interval symmetrization around
the mean if requested.
- Adjust observable pruning algorithm in data reading optimization
mode to take observables with parameterized ranges into account
o RooDirItem
- When creating a memory resident object, do not change directory if
already in memory directory.
Revision
24261 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Jun 13 10:18:57 2008 UTC (6 years, 7 months ago) by
wouter
File length: 28655 byte(s)
Diff to
previous 23134
o RooCachedPdf RooCachedReal RooChi2Var RooAddModelRooChangeTracker RooCategory RooAddPdf
RooAdaptiveGaussKronrodIntegrator1D RooCacheManager RooArgList RooCatType RooBanner RooBrentRootFinder
RooArgProxy RooCategorySharedProperties RooAddGenContext RooCategoryProxy RooBinning RooAddition RooAcceptReject RooArgSet
- Upgrade inline documention: make sure that every member function has some descriptive comments, every
data member has a descriptive comment, make sure that each class has a description.
- Fix class description header so that it is correctly identified by THtml
o RooAddPdf
- Add DIV0 protection in updateCoefficients() when running in extended ML mode
Revision
21379 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Dec 14 15:12:29 2007 UTC (7 years, 1 month ago) by
wouter
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 24011 byte(s)
Diff to
previous 21064
o (Large number of classes)
- Systematically use Riosfwd.h in header files instead
of <iostream> or Riostream.h
- Include "Riostream.h" in implementations where necessary
- Convert remaining <iostream> to "Riostream" in implementations
- Outline all inline functions using cout or endl to facilitate
use of fwd declaration of iostreams in all classes
- Elimination of some duplicate headers
- Match use of 'using namespace std' in implementation files
to classes that actually use STL classes
Revision
20988 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Nov 22 14:54:13 2007 UTC (7 years, 2 months ago) by
wouter
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 23392 byte(s)
Diff to
previous 20879
** Bringing trunk up-to-date w.r.t recent changes in branches/dev/roofit branch **
Aggregated messages from branch commits follow
--- Date: Fri Oct 19 20:35:30 2007 New Revision: 20422 ---
o RooAbsArg
- Add debug level print statement in findConstantNodes()
o RooAbsAnaConvPdf
- Do not expose cached RooCoefVars to constant term finding process.
--- Date: Fri Oct 19 21:03:40 2007 New Revision: 20423 ---
o RooPlot
- Add forwarding function for all revent Set*() methods of TH1
--- Date: Fri Oct 19 21:48:40 2007 New Revision: 20424 ---
o RooAbsAnaConvPdf
- Back out special handling of exposure of cached RooCoefVars
to constant term finding process.
o RooObjCacheManager
- Do not perform constant term finding on cache contents
if cache manager is configured to perform clearOnRedirect
for server redirects.
--- Date: Wed Oct 31 23:36:10 2007 New Revision: 20587 ---
o RooAbsRealLValue
- Remove stray debug print statements
o RooAddPdf
- Add new default ctor to fix persistence introduced by
new cache management scheme
- Add forgotten initializer to regular ctor
o RooAbsCachedPdf
- Add formal server-link dependency on cache parameters to
RooHistPdf cache representation so that the constant term
optimizer can make the correct decision
- Make RooObjCacheManager a persistent data member
o RooObjCacheManager
- Add debug message level information
- Make _optCacheObservables a transient data member and initialize
it in the default ctor.
o RooAbsPdf, RooProjectedPdf
- Add new default ctor to fix persistence introduced by
new cache management scheme
- Make RooObjCacheManager a persistent data member
o RooAbsArg
- Add methods graphVizTree() that produce input files
for AT&Ts graphViz to make graphical representation
of object tree. (To make actual graphics run 'dot -Tps -o graph.ps %s'
where %s is argument passed to graphVizTree().
o RooSetProxy
- Remove stray debug print statements
o RooSimultaneous
- Initialize forgotten data member in all ctors
o RooProdPdf, RooAbsAnaConvPdf
- Make RooObjCacheManager a persistent data member
o RooSuperCategory
- Make contained iterator a transient data member
and initialize it in the default ctor.
o RooCacheManager
- Add explicit separate default ctor.
o RooAddModel
- Completely new implementation, based on existing RooAddPdf.
RooResolutionModel functionality (convolution(),basisCode())
taken from original RooAddModel. Reimplement integration strategy
with caching of integral objects, rather than implementing
only common analytical component
o RooAbsAnaConvPdf,RooResolutionModel,RooAbsPdf
- Remove special hook function that were required for functioning
of original RooAddModel
o RooObjCacheManager
- Keep all _optCacheObservables versions created alive in separate owned list
and only delete at end in dtor to avoid dangling pointer in complex
optimizations
o RooAbsArg
- In optimizeCacheMode() ignore nodes that already have been const optimized.
Although const optimization normally happens first, late cache optimization
that happen upon late creation of objects can take place after const optimization.
--- Date: Tue Nov 13 12:04:55 2007 New Revision: 20774 ---
o RooAddModel
- Completely new implementation, based on existing RooAddPdf.
RooResolutionModel functionality (convolution(),basisCode())
taken from original RooAddModel. Reimplement integration strategy
with caching of integral objects, rather than implementing
only common analytical component
o RooAbsAnaConvPdf,RooResolutionModel,RooAbsPdf
- Remove special hook function that were required for functioning
of original RooAddModel
o RooObjCacheManager
- Keep all _optCacheObservables versions created alive in separate owned list
and only delete at end in dtor to avoid dangling pointer in complex
optimizations
o RooAbsArg
- In optimizeCacheMode() ignore nodes that already have been const optimized.
Although const optimization normally happens first, late cache optimization
that happen upon late creation of objects can take place after const optimization.
o RooMsgService
- Some restructuring to speed up code.
- Change topic naming from string to enum.
- Change debug-level print macros to take inline pre-decision
based on static RooMsgService boolean that indicates if any debug
stream is active. Also extend this speedup to doLogD() macro.
- Allow multiple Topic specifications in a single stream using bit-wise
or to reduce default number of streams from 6 to 2.
- Terminate matching logic to streams early for 'universal' streams
for which the logic does not depend on object properties.
o RooGlobalFunc
- Change Topic() argument from RooMsgService::MsgTopic to Int_t to allow specification
of multiple topics
o RooDataHist, RooMsgService, RooGenContext, RooAddModel, RooFFTConvPdf
RooAbsAnaConvPdf, RooAbsReal, RooAddPdf, RooAbsOptGoodnessOfFit, RooAbsCachedPdf
RooProfileLL, RooObjCacheManager, RooAbsArg, RooAbsPdf, RooRealIntegral
RooAddGenContext, RooProdGenContext, RooConvGenContext, RooProjectedPdf, RooClassFactory
RooWorkspace, RooTreeData
- Follow change in RooMsgService interface
--- Date: Tue Nov 13 13:13:05 2007 New Revision: 20776 ---
o RooMCStudy
- Initialize _genParams in 2nd ctor (fixes savannah #31139)
--- Date: Fri Nov 16 21:24:52 2007 New Revision: 20853 ---
o RooProdPdf, RooAddition
- Fix memory leaks found with valgrind
o RooMsgService, RooRealConstant, RooNumIntFactory, RooMinuit, RooNameReg, RooNumIntConfig, RooArgSet
- Add cleanup() function to delete singleton at exit
o RooMinuit
- Initialize _warnLevel data member (valgrind)
o RooAddModel
- Disable coefficient projections in convolution mode
(savannah #31302)
o RooTrace
- Remove messages about objects already deleted when not in verbose mode
o RooSentinel
- New class handling cleanup at exit
--- Date: Mon Nov 19 16:41:52 2007 New Revision: 20901 ---
o Makefile
- Makefile to build stressRooFit
o Makefile.arch
- Stolen from $ROOTSYS/test
o stressRooFit
- Driver framework, base class of unit tests and
automatic plot, curve, fit result comparison tools
that unit tests can request
o TestBasic1
- Basic test running fitting, generation and plotting on Gaussian p.d.f
--- Date: Wed Nov 21 17:58:28 2007 New Revision: 20965 ---
o stressRooFit
- Add regression test support for Double_t values
and RooTables
- In post-test analysis mode, analyze count of
(silent) ERROR messages and fail test if they
occcur
- Eliminate memory leaks in testing framework
- Add arguments '-n <N>' to run single test and
argument '-mc' to run suite in memory checking
mode in which case no references files are opened
to avoid ROOT I/O related noise in valgrind leak reports.
- Link in 21 new tests
o TestBasic2 ... TestBasic22
- New stress testing modules. Modules 4,6,7,11,21 and 22
are empty for now. All others are fully functional.
--- Date: Thu Nov 22 14:32:14 2007 New Revision: 20980 ---
o test/TestBasic15, test/TestBasic16, test/TestBasic20
- Fix memory leak in test code itself
o test/stressRooFit
- Activate RooFit internal memory tracing when run in memory check mode
o RooDataHist
- Fix memory leak
o RooMsgService
- Add Tracing subject
- Fix bug in printing of multi-subject streams
- Keep track of total number of (silent) ERROR messages
- Add method to access contents of stream configurations
o RooIntegrator1D, RooIntegrator2D, RooSegmentedIntegrator1D, RooSegmentedIntegrator2D,
RooGaussKronrodIntegrator1D, RooAdaptiveGaussKronronIntegrator1D, RooMCIntegrator, RooGrid
- Fix default ctor to initialize all values used in dtor
o RooAddModel
- Add optional boolean to ctor to take ownership of components. Used
in RooAddModel::convolution()
- Fix memory leak in convolution()
o RooFitResult
- Migrations to RooMsgService
- Add isIdentical() method for use in regression testing
o RooCurve, RooHist
- Add isIdentical() method for use in regression testing
o Roo1DTable
- Make persistable
- Add isIdentical() method for use in regression testing
o RooMath
- Migrations to RooMsgService
- Register static memory allocation of CERF lookup table in RooSentinel
for cleanup in atexit().
o RooAbsReal
- Migrations to RooMsgService
- Fix invalid read access due to wrong destructor order in plotAsymOn()
- Fix memory leak in plotOn()
o RooAbsCollection
- Restrict creation of hash tables to deep-copy operations
or shallow copy operations of lists with >30 elements
o RooAddPdf, RooRealVar, RooDataProjBinding, RooFormulaVar, RooTreeData
- Migrations to RooMsgService
o RooAbsOptGoodnessOfFit
- Fix memory leak
o RooAbsPdf
- Migrations to RooMsgService
- Fix memory leak in fitTo()
o RooNumIntFactory
- Delete all owned prototype integrators in dtor
o RooBinning
- Fix ctors to always initialize _xlo and _xhi
o RooResolutioModel
- Register static identity RooFormulaVar with RooSentinel
for cleanup in atexit()
o RooSimPdfBuilder
- Migrations to RooMsgService
- Delete all fitCats and RooSimultaneous instances created
by builder in dtor
- Return non-const top-level p.d.f. from buildPdf()
o RooLinkedList
- First delete hash tables, then clear list instead of
reverse order to avoid invalid read problems with TList
o RooMinuit
- Migrations to RooMsgService
- Initialize MINUIT print levels to -1 if RooMsgService
is operating in silent mode
- Trim initial error on parameters if param +/- 2*errors
is out of param range
o RooSentinel
- Add cleanup hooks from RooMath and RooResolutionModel
o RooSimultaneous
- Fix memory leak
- Migrations to RooMsgService
o RooProjectedPdf
- Implement RooProjectedPdf::CacheElem dtor
o RooTable
- Add pure virtual isIdentical() interface
Revision
20161 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Oct 1 16:28:25 2007 UTC (7 years, 3 months ago) by
wouter
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 23073 byte(s)
Diff to
previous 19826
o RooAbsCache
- New abstract base class for cache objects associated with RooAbsArgs.
Caches register themselves with the owning RooAbsArg and propagate
all necessary state changes and meta information to objects in the cache
o RooCacheManager
- Concrete template implementation of RooAbsCache with an interface
and functionality styled after RooNormListManager. The template class
provide no special handling for cache contents that includes RooAbsArg
objects and does not forward hook calls. It is thus mostly intended
to cache basic types indexed on a normalization/integration configuration
o RooObjCacheManager
- Class derived from RooCacheManager<RooAbsCacheElement> that implements
all proper call forwarding and handling of state and other meta information
to RooAbsArg objects embedded in the cache elements. To facilitate this
functionality the RooAbsCacheElement defines a pure virtual method
containedArgs() that must be implemented to expose its contents to
the cache manager. The default behavior on a serverRedirect hook is
to sterilize the cache. OperMode changes are not forwarded by default
to the cache contents as cached objects do not necessarily have the
same operation mode (e.g. if the cache contains an integral of its owner).
Any calls to optimizeCacheMode(), printCompactTreeHook(), and findConstantNodes()
are forwarded. Moreover, optimizeCacheMode() calls are remembered and
any objects inserted in the cache after such a call was received will be
optimized upon insertion in the cache
o RooAbsCacheElement
- Abstract base class for objects to be managed by RooObjCacheManager. Each
object must in addition to its payload implement the containedArgs()
member function that exposes the RooAbsArg object content to the manager
for processing. The argument passed to containedArgs() indicates the use
case for the returned list of objects, allowing the cache payload to
return different lists depending upon use. This is for most applications
not required.
o RooAbsCachedPdf
- Abstract base class derived from RooAbsPdf for p.d.f.s that implement
value caching in a grid over the entire domain of the observables.
The base class implements the overall caching logistics and manages
the RooDataHists and RooHistPdfs that respresent the cached contents.
Derived classes must inputBaseName() defined a unique name prefix for
all cache objects, actualObservales() and actualParameters() to
determined the actual observables and parameters given a set of
available observables and fillCacheObject() which should fill the
RooDataHist cache for a given obs/params configuration with the
p.d.fs values.
o RooAbsSelfCachedPdf
- Abstract base class derived from RooAbsCachedPdf that implements
all of the required logistics in RooCachedPdf and only require
derived classes from RooAbsSelfCachedPdf to implement evaluate().
Any class derived from RooAbsPdf can thus be trivially switched
to derived from RooAbsSelfCachedPdf and gain the caching functionality.
o RooCachedPdf
- Concrete class derived from RooAbsCachedPdf that implements
the caching of an externally provided p.d.f in the constructor.
o RooFFTConvPdf
- Concrete class derived from RooAbsCachedPdf that implement generic
numeric convolution of two input p.d.f.s using FFT technique
and convolution theorem. Actual FFTs are calculated by FFTW
through TVirtualFFT interface in ROOT. Present implementation only supports
convolution in one dimension, but this will be extended later
as there are no fundamental limitations in RooAbsCachedPdf nor FFTW.
o RooHistPdf
- Moved from RooFit to RooFitCore because it is used by caching classes
o RooProdPdf
- Use new RooObjCacheManager to store partial objects
- Fix memory leak (already patched in 15.0.14h)
o RooDataHist
- Use new RooCacheManager template to cache partial bin volumes
- Add new set(),setAllWeights() method to update current weight and all weights
respectively, for use in cached p.d.f.s
- Add sliceIterator() that iterates over all bins in a lower dimensional
slice of the dataset
o RooDataHistSliceIter
- Class derived from TIterator that implements the iteration
over a slice in a reduced number of dimensions in a RooDataHist
o RooMsgService
- Speed up processing of debug streams in cases where no debug streams are active
- add macros series oocoutX and oocxcoutX that allow to associate message with
a different object than *this
o RooRealBinding
- Interface new setValue method that allows value to be set outside default
domain, but inside given alternate named range. For use in numeric integrator
bindings
o RooAbsRealLValue
- Add new inRange() method with range name specifier to check against chosen
range instead of default range
o RooCmdConfig
- Fix dangling return pointer problem in decodeStringOnTheFly() method
o RooNameSet
- Fix bug in refoll()
o RooChi2Var, RooNLLVar
- Add processing of AddCoefRange() named argument
o RooConvCoefVar
- Hold p.d.f in proxy without value/shape state propagation to obtain
correct dependency of RooConvCoefVar through separate set proxy
with parameters that do have state propagation
- In getAnalyticalIntegral() ask for integration coefficient specific
to coefficient (following interface change in RooAbsAnaConv)
o RooEfficiency
- Follow interface change in RooCategoryProxy
o RooAbsAnaConvPdf
- Use new RooObjCacheManager to hold normalization and coefficient representations
- Extend getCoefAnalyticalIntegral() interface so that each coefficient
can have a separate integration configuration
- Modify makeCoefVars() such that it constructs the RooConvCoefVars with
actual dependents for each coefficients, rather than inserting dependencies
of any of the coefficients in each coefficient. This logic requires support
from the implementation class that is interface through a new member function
coefVars()
o RooAbsReal
- Add Boolean data member treeVar that indicates is value buffer is also
branch buffer of a tree. This information is already present in the RooAbsReal
but is relatively expensive to retrieve and is always needed in the inner
loop of data set operations. This extra member significantly speeds up operations
- Remove superfluous _norm[] token in name returned by integralNameSuffix() if
no normalization set is supplied.
- Add a fillDataHist() method that fills a given RooDataHist with a sampling
of the given function. Added for support of caching p.d.f.s
- Downgrading warning on non-dependent projection variables in plotOn() to
a debug level message
- Remove function optimizeDirty(),doConstOpt(),undoConstOpt(),findCacheableBranches()
findUnusedDatasetVariables() and findRedundantCacheServers() as part of reorganization
of optimization functionality.
o RooAbsCollection
- Use iterator semantics instead of vector semantics to process RooLinkedList
contents in assignment operator
- Add utility function contentsString() returning stl string with names
of contents
o RooAddPdf
- Rewrite cache management using new RooObjCacheManager that holds projection
integrals, range integrals and supplemental normalization lists
o RooAbsOptGoodnessOfFit
- Improve handling of normalization ranges and reference ranges for test statistics
containing RooAddPdfs. New named argument in fitTo() and RooNllVar::ctor() pass
reference range for fractions in RooAddPdf components that do not have an explicit
fixed definition already. Name all normalization ranges explicitly after the
subrange to which the're applied to avoid name clashes and conflicts if multiple
normalization ranges are involved.
- Rewrite informational messages through RooMsgService
- Implement new constOptimizeTestStatistic() function that signals all test statistic
components of a RooAbsArg expression tree to perform their constant term optimization
- Implement new optimizeCaching() driver function that changes default lazy-evaluation-with-caching
scheme to test statistic scheme where only parameters objects propagate state changes and
where all components that depend directly or indirectly on observables have lazy evaluation
disabled. Changes to p.d.f objects are delegated to RooAbsPdf::optimizeCacheMode(). Changes
to dataset are delegated to RooAbsData::optimizeReadingWithCaching()
- Implement new optimizeConstantTerms() function that is back end for constOptimizeTestStatistic
implementation.
o RooAICRegistry, RooNormSetCache
- Remove tracking of allocation cycles of RooArgSets as this scheme is superseded by
memory pool mechanism for RooArgSet allocation
o RooMappedCategory
- Follow interface change in RooCategoryProxy.
o RooRealMPFE
- Follow reorganization of optimization functionality: implement new constOptimizeTestStatistic
function for forwarding to slave processes.
o RooRealVar
- Add new setVal() function with range name to facilite setting of values that are outside
default range, but inside specified alternate range. Needed for numeric integration and
certain RooAddPdf coefficient projection.
o RooAbsArg
- Make state management functions public [is/set][Value/ShapeDirty](), setOperMode90
- Add static _flipAClean boolean to support setACleanAdirty() static method.
- Implement mechanism for registration of cache objects with base class RooAbsCache.
Forward all calls to operModeHook(), redirectServersHook(), optimizeCacheMode()
and printCompactTreeHook() to all caches for further processing
- Define constOptimize() function and provide default implementation that forwards
to all servers
- Implement optimizeCacheMode() function that puts expression tree in optimized
caching for test-statistics operations (only cache/lazy evaluate nodes that
do not (indirectly) depend on observables
- Implement findConstantNodes() function that identifies all nodes that depend
exclusively on constant observables and >0 observables that are eligible
for precalculation and caching in test statistics operations by
RooAbsOptTestStatistic::optimizeConstantTerms()
- Define constOptimizeTestStatistics that signal an expression tree that any
embedded test statistic objects should perform their constant term optimization.
Default implementation in RooAbsArg forwards call to all servers.
o RooAbsPdf
- Use new RooObjCacheManager to manage normalization integrals cache.
- Process new SumCoefRange() option in fitTo() that sets the coeffient
interpretation range for all embedded RooAddPdf objects of which
the interpretation range was not explicitly set
- Extend interface of fixAddCoefNormalizationSet(): add extra argument
that controls if AddCoef normalization set are forcibly overruled
for objects that already have an explicit range setting.
o RooRealIntegral
- Add some informational messaging through RooMsgService, rewrite existing ones
- Speed up numeric summations by precreating the involved RooSuperCategory
in the ctor rather than in evaluate().
- Fix bug in dependency insertion: explicitly require servers to be value
server to avoid pulling in fake dependents.
- Remove obsolete data members
- Implement new setACleanADirty() function that atomically flips state of
all AClean objects to ADirty for the duration of the integration step.
Replaces the much more expensive prepareACleanFunc() that did this
only for the objects involved.
- Process factorizing terms in integral only if the list is not empty
- Process Jacobian terms in integral only if the list is not empty
o RooAddGenContext
- Adapt to cache management chanches in RooAddPdf
o RooNumIntFactory
- Use STL classes for internal memory management
o RooSetProxyy
- Implement operator new() and operator() delete as required because
RooArgSet implements them
o RooAbsGoodnessOfFit
- Store and forward AddCoefRange information for embedded RooAddPdf objects
- Implement constOptimizeTestStatistic() and forward to components
o RooErrorVar
- Follow inRange() interface change in RooAbsRealLValue
o RooConvGenContext
- Adapt code to make it work with both RooAbsAnaConv objects and
the newly introduced RooFFTConvPdf
o RooMinuit
- Follow reorganization of optimization functionality
o RooProjectedPdf
- Store projection using new RooObjCacheManager
o RooGlobalFunc
- Add RooFit::SumCoefRange() named argument for RooAbsPdf::fitTo()
and RooNLLVar::ctor() and RooChi2Var::ctor()
o RooClassFactory
- Extend existing makePdf(),makeFunction and makeClass() functions
to also accept RooAbsCategory arguments, to accept an optional string
inserted as the return value expression inserted in the
evaluate() method of the class created, as well as as option string
specifying one or more analytical integrations of the given function
expression that will be advertised in the generated getAnalyticalIntegral()
code and implemented in the generated analyticalIntegral() code
- Add makeAndCompileFunction() and makeAndCompilePdf methods that
generate the code and immediate compile it through ROOTs ACliC interface.
These functions have a simpler interface because the list of arguments
of the function to be created can be specified as a const RooArgSet&
rather than a string with a list of names, thus making it easier
for on-the-fly definition of compiled objects.
- Add defineFunction() and definePdf() methods define and compile
a function/pdf using the above functions and immediately instantiate
an object of the given type passing the specified RooArgSet arguments
to the constructor of the object. These functions make a compiled
equivalent of RooFormulaVar based on the TFormula interpreter, i.e.
RooAbsReal* f = new RooFormulaVar("f","D(1-2w)",RooArgSet(D,w)) ;
becomes
RooAbsReal* f = RooClassFactory::defineFunction("f","D(1-2w)",RooArgSet(D,w)) ;
o RooAbsCategory
- Add Boolean data member treeVar that indicates is value buffer is also
branch buffer of a tree. This information is already present in the RooAbsReal
but is relatively expensive to retrieve and is always needed in the inner
loop of data set operations. This extra member significantly speeds up operations
- Construct explit clean name for TBranch name if node is cached, equivalent
to what is done in RooAbsReal. Needed because new constOptimizer can also
cache RooAbsCategory objects
o RooArgSet
- Implement operator new() and operator delete() to implement memory pool scheme
for RooArgSets. The goal of this implementation is to insure that two RooArgSet
pointers are _never_ the same. This allows to RooNormSet cache manager to safely
and quickly index integration and normalization configurations by evaluating
the contents of a RooArgSet only the first time it sees it.
o RooSimultaneous
- Implement caching of partial integrals using new RooObjCacheManager
- Following interface change in RooCategoryProxy ;
o RooAbsData
- Defined pure virtual methods optimizeReadingWithCache() and allClientsCached()
o RooTreeData
- Implement optimizeReadingWithCache() which determines given a p.d.f to be
evaluated and a list of the nodes that are cached for it, which observables
in the dataset are no longer required because they are either not an observable
of the p.d.f, or they exclusively feed nodes that are cached. Reading of these
observables is disabled through SetBranchStatus().
- Move allClientsCached() utility function here from RooAbsReal.
o RooCategoryProxy
- Remove const char*() conversion operator in favor of a const char* label() method
to remove possibly ambiguities in C++ math expressions involving category proxies.
o LinkDef3.h
- Add newly defined classes
Revision
19583 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Aug 9 19:55:47 2007 UTC (7 years, 5 months ago) by
wouter
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 23458 byte(s)
Diff to
previous 18781
o RooAbsCollection
- Add snapshot() function that fills output in existing collection to
aid copy ctors of classes that own deep-copies of trees such as RooWorkspace
o RooArgSet
- Add utilities that keep track of pointer recycling to aid proper functioning
of RooNormSetCache
o RooNormSetCache
- Explicitly handle cases in cache management where RooArgSet pointers are
reallocated on a previously used address.
o RooSetPair
- Add data members that store the allocation cycle
o RooMsgService
- Expand inline comments and documentation
o RooProfileLL
- Expland inline comments and documentation
o RooProjectedPdf
- Expland inline comments and documentation
- Adjust code so that normalization set of projection contains only
actual observables of integrand
o RooWorkspace
- Expland inline comments and documentation
- Implement copy ctor in terms of new snapshot function
- Fix dtor (forgot to delete owned datasets)
- When importing a dataset, also import its observables as variables
o RooFormulaVar
- Fix default ctor for persistence
- Fix passing of normalization set to RooFormula
o RooCategory
- Fix default ctor for persistence
o RooRealVar
- Fix default ctor for persistence
o RooBanner
- Increment version tag to v2.20
Revision
15668 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Jul 3 15:37:11 2006 UTC (8 years, 6 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 22632 byte(s)
Diff to
previous 12103
o RooAbsCollection
- Fix bug in printLatex() : mangle both upper and lowercase options for sibling lists instead
of just uppercase options
o RooAbsGoodnessOfFit
- Forgot to put certain print statements in if (_verbose) conditionals (C.Roat)
- Order of arguments in calls to create() sometimes wrong (verbose/ncpu swapped) (C.Roat)
o RooAbsOptGoodnessOfFit
- Fix more mistakes with if (_verbose) conditionals (C.Roat)
o RooAbsRealLValue
- Remove forgotten debug print statement
o RooAdaptiveGaussKronrodIntegrator1D,RooGaussKronrodIntegator1D,RooIntegrator1D,RooIntegrator2D,
RooSegmentedIntegrator1D,RooSegmentedIntegrator2D,RooImproperIntegrator1D,RooMCIntegator
- Change initialization process of RooNumIntFactory from dynamic process on loading to
static process in RooNumIntFactor ctor as current model has problems
o RooAddPdf
- Add forgotton initializer for _refCoefRangeName in one of the constructors
o RooArgSet
- Declare writToFile() and writeToStream() as 'const'
o RooBanner
- Increment version tag to v2.08
o RooChi2Var
- Fix copy/paste error in print statements in ctor
o RooFitResult
- Put ROOT version dependent #ifdef around TMatrix forward declaration
to make it work with both ROOT4 and ROOT5
o RooHist,RooPlot
- New implementation of pullHist/residualHist from G.Raven
o RooNumIntConfig
- Add forgotten initializers of RooCategory datamembers to ctor (fixes crashes
observed by J. Rademackers)
o RooNumIntFactory
- Perform static initialization of all numeric integrator engines in the factory constructor
(fixes oberved crashes of all numeric integration and configuration business)
o RooRealVar
- Back out change that setting asymmetric error clear symmetric error and vice versa.
It causes just too much confusion...
o RooSharedPropertiesList
- Explicitly check for and handle input null pointers
Revision
12103 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 21 19:59:52 2005 UTC (9 years, 7 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 22622 byte(s)
Diff to
previous 12098
o RooStreamParser
- Add boolean argument to zapToEnd() that controls if folded
line continuations are zapped as well
o RooArgSet
- Use new feature of zapToEnd() to selectively zap folded lines.
o RooTreeData
- Make all plotOn() methods public to avoid some obscure problems
with AIX C++ compiler
Revision
12098 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 21 16:42:31 2005 UTC (9 years, 7 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 22595 byte(s)
Diff to
previous 12082
o RooBanner, make_roofit_installkit
- Update version number to 2.00
o RooAbsRealLValue
- Fix bug in frame(): Name() and Title() were only processed if both were
specified. Now they can be specified individually
o RooArgSet
- Make printing of messages concerning processing of include files in readFromStream()
conditional to the verbose flag being true
o RooPlot
- Disable persisting of pointer to normalization object -- causes root crash on Write()
o RooStreamParser
- Fix processing of skipped lines to also skip the continuation lines if the skipped
line was folded over multiple file lines
Revision
12082 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Jun 20 15:45:21 2005 UTC (9 years, 7 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 22569 byte(s)
Diff to
previous 12063
o RooBanner
- Update version number and copyright
o Many files
- Change <iostream> to "Riostream" to support compilation on platforms
that do not have iostream classes in namespace std
o RooAbsAnaConvPdf
- Fix bug in range integration in getAnalyticalIntegralWN()
- Change getCoefAnalyticalIntegral() signature to include rangeName in argument list
o RooAbsArg
- Add methods getObservables()/getParameters with const RooAbsData& argument
o RooAbsPdf
- Add support for Range(Double_t, Double_t) to specify fit range in fitTo()
- Migrate getMaxVal()/maxVal() to RooAbsReal [Gerhard]
- Fix bug in normalization of PDF projections over limited range: account for both
fraction of data in range and fraction of projection in range (calculation of latter
deferred to RooAbsReal::plotOn)
o RooAbsReal
- Migrate getMaxVal()/maxVal() from RooAbsReal [Gerhard]
- Add code in plotOn() to support normalization of PDF projections plotted in limited range
o RooAbsRealLValue, RooRealVar, RooErrorVar, RooLinearVar
- Change getBinning() so that it only creates a new binning on the fly if a newly added boolean argument
is true. Otherwise, return default binning
o RooAdaptiveGaussKronrodIntegrator1D, RooGaussKronrodIntegrator1D
- Declare prototypes for glue functions
o RooArgSet
- Fix readFromStream() and writeToStream() so that they are consistent with each other again for
both regular and scientific notation mode.
- Fix processing of include directives inside files in readFromFile()
- Suppress warning messages about ignored lines in files unless verbose flag is set. Add verbosity control
flag to readFromFile().
o RooCategory
- Support concept of ranges for categories as well through new member functions setRange(),addToRange(),
clearRange(),hasRange(),isInRange() and isStateInRange(). Ranges are named TLists containing a non-owned
subset of the possible RooCatTypes.
o RooCategoryProxy
- Make lvptr() const since it is.
o RooConvCoefVar
- Pass rangeName in getAnalyticalIntegral() to getCoefAnalyticalIntegral()
o RooPlotable, RooCurve, RooHist, RooEllipse
- Implement getFitRangeNEvt(Double_t, Double_t) that returns the number of events in the given sub-range.
o RooDataHist
- Fix bug using RooAbsData::plotOn --> using RooTreeData::plotOn
o RooGlobalFunc
- Add adjustNorm boolean argument to named argumentss Range()
o RooMultiCatIter
- Require that input is RooAbsCategoryLValue rather than RooAbsCategory.
o RooPlot
- Keep track of object that generated normalization event count in addition to event count itself.
This allows to later on calculate an event count in a limited range through getFitRangeNEvt(Double_t, Double_t)
o RooRealIntegral
- Support ranges in category summation in integration code.
o RooSimPdfBuilder
- Fix bug in unitarity constraint split of parameter in partial build: adjust formula for remainder fraction
so that it only uses the states that are actually built.
- Improve error handling
o RooSuperCategory
- Implement hasRange() and isInRange() functionality inherited from RooAbsRealLValue
o RooClassFactory
- New class that automatically generates code for PDFs and functions given a name and a list of argument names
o RooEffProd
- New class that implement product of PDF and efficiency function. Main feature is efficient implementation
of event generator in case input PDF has 'smart' event generator
o RooEffGenContext
- Generator context associated with RooEffProd
o Module.mk
- ROOT make file module needed to compile RooFit as part of ROOT
o make_roofit_installkit
- Script to package RooFit source as ROOT module for compilation with ROOT system
Revision
12063 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Jun 16 09:31:32 2005 UTC (9 years, 7 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 22667 byte(s)
Diff to
previous 11619
o RooFit.hh
- New global header file for compiler patches. Currently contains
single patch for SunOS imported from BaBar.hh
o All .cc files
- Include RooFit.hh as first header file
o RooAbsData
- Make all plotOn() methods public
o RooAbsProxy
- Include pragma to switch of VC++ warning C4355
"'this' : used in base member initializer list'"
which would otherwise be triggered on each proxy initialization.
(each proxy constructor _expects_ a base class ptr so the warning
is misleading)
o RooAdaptiveGaussKronrodIntegrator1D, RooDataHist, RooGaussKronrodIntegrator1D,
RooGraphSpring, RooMCIntegrator, RooPolyVar, RooTreeData
- Change pow --> TMath::power() to eliminate windows compiler warnings
o RooEllipse
- Change constant M_PI to TMath::Pi()
o RooGlobalFunc
- Change RooConst --> RooFit::RooConst as functions has been moved into namespace
o RooMath
- Add erf() and erfc() forwarder functions to TMath::Erf() and TMath::Erfc()
o RooRealConstant
- Move RooConst() function into namespace RooFit
o RooSimultaneous
- Remove one default parameter from implementation version of plotOn() to resolve
overloading ambiguity reported by AIX compiler
o RooTreeData
- Make nested struct PlotOpt public to avoid CINT access problems
o RooTruthModel
- Add explicit cast to fabs() of proxy as it gives warning in Windows C++
Revision
11405 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Mar 22 13:05:26 2005 UTC (9 years, 10 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 22492 byte(s)
Diff to
previous 11181
o RooAbsPdf, RooGlobalFunc
- Add support for Minos(const RooArgSet& paramSet) named argument
in fitTo() that runs minos only on the selected subset of parameters
o RooStreamParser
- Eliminate putBackToken() as it is fundamentally flawed
o RooArgSet, RooRealVar
- Rework readFromStream so that it works without
RooStreamParser::putBackToken()
o RooRealVar
- Eliminate some unused data members that were accidentally
included during development
Revision
10648 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Nov 29 20:24:44 2004 UTC (10 years, 1 month ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 22396 byte(s)
Diff to
previous 10638
o All Classs
- Remove '#include BaBar/BaBar.hh' that was erroneously
introduced by the BaBar IOstream migration utilities
o Several class
- Initializion order changes, removal of unused variables,
addition of missing return statements to make all code
compile cleanly with '-Wall -Wno-parentheses'
o RooAbsFunc
- Make resetNumCall() const
o RooAbsIntegrator
- Add calculate() method that wrape integral() between
profiling code the track the number of integrand
function calls
o RooIntegrator1D,RooImproperIntegrator1D,RooSegmentedIntegrator1D,
RooSegmentedIntegrator2D,RooMCIntegrator
- Change interface to take RooNumIntConfig class instead
of now deprecated RooIntegratorConfig class
- Add member function that advertise capability of the integrator:
canIntegrate1D,2D,ND,OpenEnded()
o RooAbsReal
- Change normalization integral management classes
(createIntegral(), (set)defaultIntegratorConfig(),
(set)specialIntegratorConfig()) to work with new
RooNumIntConfig class.
o RooArgSet
- Add new convenience functions get/setRealValue(),
get/setCatLabel/Index(), get/setStringValue() to
manage common content of RooArgSet.
o RooConvCoefVar, RooConvGenContext
- Support class name change RooConvolutedPdf -> RooAbsAnaConfPdf
o RooCustomizer
- Add function setCloneBrancSet() that allows to specify
an external set that takes ownership of the cloned branch
nodes so that customized objects can live beyond the lifetime
of the RooCustomizer instance
o RooImproperIntegrator1D
- Add code to handle limit scenario changes (closed to open ended
and vice versa) on the fly
o RooIntegrator1D
- Add fixSteps option to terminate integral calculation after
fixed number of steps w/o extrapolation. This is more robust
for certain types of integrals
o RooRealIntegral
- Change interface to take RooNumIntConfig class instead of
RooIntegratorConfig class
- Delegate instantiation of numeric integration engines to
new class RooNumIntFactory
o RooNumIntConfig
- New class to store configuration of numeric integator engines.
This class has a brief common section with common properties
like absolute and relative precision convergence criteria,
and a section with implementation specific details for each
engine in the form of a RooArgSet. The default settings for
each existing engine are automatically added to the defaultConfig()
instance during run-time initialization
o RooNumIntFactory
- Factory class for numeric integration engines. Each existing
integrator engine automatically registers with the factory
stating its capabilities (1D,2D,ND / Open-ended). The
createIntegrator() function instantiates an integrator
appropriate for a given problem. In case more than one
integration engine can solve the given problem the (user
changable) information in the RooNumIntConfig passed along
with the call is used.
o RooGaussKronrodIntegrator1D
- New integrator engine based on Gaussian quadrature techniques.
This implementation, taken from GSL 1.5 implements the Gauss-Kronrod
techniques where the error on the integral is take from the difference
between the Gauss and Kronrod techniques. These techniques share common
sampling points allowing to calculate the error without additional cost.
This integrator applies the 10,21,43, and 87 point rules in succession
until the desired accuracy is reached. Open-ended integrals are
automatically handled through a x -> 1/x coordinate transformation
o RooAdaptiveGaussKronrodIntegrator1D
- New integrator engine based on Gaussian quadrature techniques.
This implementation, taken from GSL 1.5 implements the Gauss-Kronrod
techniques where the error on the integral is take from the difference
between the Gauss and Kronrod techniques. These techniques share common
sampling points allowing to calculate the error without additional cost.
This integrator applies the 10,21,31,41,51 or 61 point rule and
recursively subdivides the integration domain until the desired accuracy
is reached. For integrands with integrable singulaties the Wynn epsilon
rule can be selected to speed up the converges of these integrals. Open
ended integrals are automatically handles through a x -> 1/x
coordinate transformation
o RooNumConvPdf
- New operator PDF class that implements numeric convolution of
any two PDFs. The calculation of the convolution integrand
is implemented in the auxiliary class RooConvIntegrandBinding,
which in turn can be integrated with any 1-D numeric integration
engine. The default integration method for convolution integrals
is the adaptive Gauss-Kronrod method, which appears to give the
most stable results. By default the integration is performed
from -inf to +inf, but can optionally be restricted to a sliding
window using the setConvolutionWindow class, useful for relatively
narrow resolution PDFs.
o RooAbsAnaConvPdf
- New name of RooConvolutedPdf to clearly distinguish its functionality
from RooNumConvPdf
Revision
3150 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Nov 1 22:52:22 2001 UTC (13 years, 2 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 17042 byte(s)
Diff to
previous 3124
o RooAbsPdf
- In getVal() without normalization change to use
evalTracePdf instead of evalTrace (obsolete)
o RooAbsReal
- Change signature of static method createHistogram()
to take non-const RooArgList& as argument to avoid
overloading ambiguity with non-static createHistogram()
with RooAbsReal& in same slot.
- Fix asymmetry plotting. Relative normalization of positive
and negative component of functions asymmetry was not
properly accounted for
o RooAbsString
- Change internal storage mechanismg from char[1024]
to a heap based char array. Length can be specified in ctor
o RooArgSet
- Support input file sectioning in readFromFile()
o RooCustomizer
- Minor adjustment in verbose output
o RooDataSet
- In read(). wllow space in addition to ',' as separator between
file names
o RooFormula
- In DefinedVariable(), check that for objects of type 'cat::state'
the given state is actually defined in cat.
o RooSimPdfBuilder
- Use new custom string length of RooStringVar in various places
o RooStreamParser
- Change code to handle string tokens of more than 1024 chars
- Fixes in EOF detection logic
Revision
3124 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Oct 27 22:28:23 2001 UTC (13 years, 2 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 16265 byte(s)
Diff to
previous 3067
A large number of small fixes and improvements
o Roo1DTable
- Modify Print() behaviour. Standard print will
only show non-empty fields, verbose shows all fields
o RooAbsArg
- Change getParameters so that it can accept 0 as
dataset pointer (implies no dependents)
o RooAbsPdf
- Follow plotOn() changes in RooAbsReal
o RooAbsReal
- Add optional const RooArgSet* projData argument to
plotOn(). Projected dependents that appears in this
dataset, if specified, will be projection via summation
over data instead of integration.
- Add clipInvalid option to bindVars() and propagate to
RooRealBinding
- Modify cleanBranchName() to truncate 'clean names'
(which are used for the TTree branch) to 63 chars
as cannot handle such cases (SEGV). In case name
is longer than 63 chars, truncate name at 46 chars
and suffix with _crc followed by hex representation
of CRC32 checksum of the full name.
- Add crc32() method to calculate the checksum of a string
o RooAddModel,RooAddPdf
- Do not evaluate PDF components multiplied by a zero coefficient
o RooAddPdf
- Fix DIV0 in analyticalIntegral if number of expected events
for all PDFs combined totals zero
o RooArgSet
- Add ability to readFromStream and readFromFile to optionally
flag read arguments with a user specified attribute
(Mostly useful to determine which elements have _not_ been read)
o RooConvolutedPdf
- Change declareBasis() signature from a RooArgSet& to a RooArgList&
to correctly handle cases where the names of parameters are identical
(e.g. tau=zero and dm=zero for prompt background models)
- Expand logic in RooGenContext. Add additional requirement for
use of optimized generator context: both the physics pdf and
the resolution model must support direct generation of the
convolution variable.
(Still have to fix RooAddModel/Pdf for cases where all components
can do direct generation)
o RooCurve
- Deploy RooRealBinding::clipInvalid feature to zero plotted functions
outside the validity range of their dependents
- Add extra points at (xlo,0) and (xhi,0) to obtain correct filling
pattern when using the 'F' draw option.
o RooCustomizer
- Add warnings for multiple split or replace rules on the same leaf
o RooDataSet
- Make read() take a const RooArgList& instead of a RooArgList&
and immediately make temporary copy for internal use.
- All constructors with string based cut: add default empty cut.
o RooFitContext
- Ctor: Compare limits on dependents in PDF and dataset if limits
of PDF are smaller and fully contained in those of the dataset,
adjust the dataset ranges in the internal copy and reject events
outside the PDF limits. If PDF ranges are not identical or fully
contained in dataset limits, give error message and abort.
- In fit() fix handling of parameters handed to TMinuit: set pmin/pmax
to the parameter value for constant parameters. For floating parameters
with open limits and without error, use 1/10 of the plot range
instead of 1/10 of the fit range.
o RooFormula,RooFormulaVar
- Change RooArgSet to RooArgList to pass formula parameters.
This allows construction of formulas with ordinal references
for list of parameters with multiple occurrences of the same
variable.
o RooRealBinding
- Add clipInvalid option, specified in ctor. If set, loadValues()
will first check if the values to be loaded are in the limits
of the bound objects dependents. If not the values are not loaded
and an invalid flag is set. If the invalid flag is set operator()
will return 0.
o RooRealVar
- Add various 'named parameter' functions on a trial basis
o RooSimFitContext
- Gracefully handle RooSimultaneous PDFs with missing PDFs.
o RooSimGenContext
- Forgot to set index state in theEvent RooArgSet when generating
the index category
- Remove forced normalization of index state in evaluate()
- Remove dummy plotOn() method and specialized plotOn() with data
method as projection over the index state can now be handled
the regular plotOn method. Overload RooAbsPdf::plotOn to
force caller to specify projection dataset for the index category
if projection over the index category is requested
o RooTable
- Remove print(), add default Print(Option_t *), and reimplement
printing via inheritance from RooPrintable
o RooTreeData
- In loadValues(RooTreeData*) explicitly check isValid() of
each element of _vars after copying. If any is invalid,
reject the event.
- In table() change simple clone of tableVar to deep clone.
Implement use of optional cut string (accidentally omitted sofar)
o RooTruthModel
- Add highly trivial direct generator for the convolution variable
o RooDataProjBinding
- New lightweight binding between an RooAbsReal and a dataset
that returns the projection of the real over the dataset
via summation. If the dataset only contains category variables
an supercategory of all the datasets categories is created
and the data is summed (with appropriate weights) over the
supercategory states instead of over every event.
Revision
3067 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Oct 19 06:56:53 2001 UTC (13 years, 3 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 16109 byte(s)
Diff to
previous 3015
o RooAbsArg
- Introduce static variable and function nameFieldLength()
that controls size of the name field when printing
in standard print mode. Default(0) makes field fit
name of object
- Introduce universal value assignment via virtual
operator=() to Double_t, Int_t, const char*.
Default implementation in RooAbsArg results in user
error message.
- Extend createFundamental() to optionally take a new name
as argument
- Add new pure virtual fillTreeBranch() method in which
subclasses must implement a method to fill their branches
in the given tree with their current value
o RooAbsCategory,RooAbsReal,RooAbsString
- Implement fillTreeBranch()
- Adjust createFundamental()
o RooAbsCollection
- Fix replace() to find correct replacement candidate if >1
object exists in list with name of variable to be replaced
- In printToStream() adjust RooAbsArg::nameFieldLength()
to size of longest argName contained in list
o RooAbsData
- Fix default ctor to instantiate unpersisted data members
o RooArgList
- Add operator[] taking index as argument, returning a
RooAbsArg&. If index is out of range, a softAbort() is
generated
o RooArgSet
- Add operator[] taking arg name as argument, returning a
RooAbsArg&. If index is out of range, a softAbort() is
generated
o RooErrorHandler
- New lightweight class implementing softAssert()
and softAbort() that will terminate processing
but not kill the root session.
o RooCustomizer
- Make inherit from RooPrintable and implement Print() method
o RooDataSet
- Add self to gDirectory() in every ctor to facilitate persistence.
Remove internal ttree from gDirectory to avoid unnecessary entries.
o RooFormula
- Disable conditional compilation pending investigation of some
obscure problems
o RooRealVar
- Add static functions printScientific() and printSigDigits()
that control formatting in print() and writeToStream().
- Augment format() to be able to print both value and error
with specified precision (instead of always using the precision
from the error when its printed)
o RooStreamParser
- Process continuation line sequences '\\' in readLine()
o RooStringVar
- Implement operator=(const char*)
o RooTreeData
- Change cacheArg() and cacheArgs() to use new column adding
technique implemented via fillTreeBranch()
- Change addColumn() and to use new column adding
technique implemented via fillTreeBranch().
Add new addColumns() member to do multiple columns at once.
Revision
3015 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Oct 12 01:48:47 2001 UTC (13 years, 3 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 15581 byte(s)
Diff to
previous 2995
New optimized generator contexts for RooAdd/Prod/SimPdf
-------------------------------------------------------
o RooAbsPdf,RooProdPdf,RooAddPdf,RooSimultaneous
- Introduce protected virtual function genContext()
which returns the appropriate generator context
for that PDF:
RooAbsPdf --> RooGenContext
RooProdPdf --> RooProdGenContext
RooAddPdf --> RooAddGenContext
RooSimultaneous --> RooSimGenContext
o RooAbsGenContext
- New abstract generator context
o RooGenContext
- Make inherit from RooAbsContext
o RooAddGenContext
- New optimized generator context for RooAddPdf
that generates the components separately
o RooSimGenContext
- New optimized generator context for RooSimultaneous
that generates the components separately
o RooProdGenContext
- New optimized generator context for RooProdPdf
that generates the dependents of each components
separately and then merges them
Dataset enhancements
-------------------
o RooDataHist
- Add constructor from TH1,TH2,TH3
- Add interpolation order to weight(RooArgSet& coord,...)
function that optionally performs nth order
interpolation of the weight distribution in the
real dimensions of the dataset.
(Currently supports up to 2 real dimensions)
o RooHistPdf
- Add option to ctor to optionally interpolate
histogram contents in real dimensions
o RooDataSet
- Introduce merge() methods that adds the columns
of one or more datasets (of equal length)
Miscellaneous (fixes Remedy #5603)
-------------
o RooRealVar
- Fix output format in writeToStream(). One ')' too many
- Read '+/-' as 3 tokens due to change in parsing rules
o RooArgSet
- Change punctuation rules of parser in readFromStream
so that it doesn't break up variable names with
funny characters
Revision
2995 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Oct 8 05:20:24 2001 UTC (13 years, 3 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 15550 byte(s)
Diff to
previous 2967
Documentation update
--------------------
o Most classes
- Update inline documentation
o RooHtml
- Add MakeIndexNew() method that can create sub-index files
by topic. Similar to THtml::MakeIndex(), but topic is taken
from tag in file instead of subdirectory name
- Add MakeIndexOfTopics() method that creates master
index of index files by topic.
o All classes
- Provisionally assign one of the following topic tags to each class
PDF - Probability Density functions
REAL - Real valued functions
CAT - Discrete valued functions
PLOT - Plotting and tabulating
CONT - Container classes
MISC - Miscellaneous
USER - Other user classes
AUX - Auxiliary classes for internal use
o makedocs
- Modify to make new sub-index files and index of topics file.
(Description of topic tags is defined here)
Revision
2967 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Oct 3 21:54:00 2001 UTC (13 years, 3 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 15543 byte(s)
Diff to
previous 2927
Documentation update
--------------------
o RooAbsCollection, RooArgSet, RooArgList
- Update inline documentation
Misc small fixes
----------------
o RooAbsCollection
- Change name of _isCopy to _ownCont and change message
in printToStream accordingly
o RooArgSet
- Deprecate compact mode of readFromStream()/writeToStream()
as order of set can no longer be used to assign ascii fields
- Add readFromFile() and writeToFile() wrapper functions
around readFromStream()/writeToStream() for users convenience
o RooArgList
- Introduce readFromStream()/writeToStream(), compact mode only.
o RooDataSet
- Change read() method to take an ArgList instead of an ArgSet
as only the former can be used to match the fields of an ascii file.
Actual reading of file is now done by RooArgList::readFromStream()
in compact mode. Mapping to RooDataSets internal RooArgSet (which
potentially has a different order) is done by
RooAbsCollection::operator=()
Revision
2927 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Oct 1 22:04:21 2001 UTC (13 years, 3 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 11397 byte(s)
Diff to
previous 2838
o RooRealIntegral
- Introduce LValue detection in tree structure analysis.
An iterative algorithm determines if there is a non-empty
set of LValue branch nodes suitable for analytical integration
and a set of leaf nodes to be integrated, that exclusively
relate to each other (i.e. set of leafs serves only exactly one
element of the set of LV branches; LV branches only depend on
that set of leafs). If such sets can be found, the LV branches
are substituted for the leafs in the list of dependents to be
integrated.
Actual use of these LV branches in analytical integration
still depends on capability of integrated function. If not,
numerical integration will be performed on LValue.
Caveats: currently the algorithm does not optimize scenarios
like 'server a -> LVnodes (A,B), server b ->LVnodes(A,B), i.e.
multi-dimensional coordinate rotations. Although the
iterative algorithm could easily identify the potential replacement
(a,b) -> (A,B), such substitutions would have to be reviewed
after interaction with the integrated functions' getAnalyticalIntl().
If it turns out the function can only analytically integrate A or B
but not both, the entire substitution would have to be backed out
as an integral over (A,a,b) or (B,a,b) has a redundant dimension.
o RooArgSet,RooArgList
- Add ctor from TCollection. RooArgSet ctor will skips and warns about
eventual duplicate entries by name.
o RooAbsPdf
- Remove obsolete fitTo(TH1*,...) dummy entry point.
o RooLinearVar
- Remove debug print statement
Revision
2838 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Sep 24 23:06:01 2001 UTC (13 years, 4 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 10971 byte(s)
Diff to
previous 2798
Major cleanup in integration of normalization functions
Miscellaneous small improvements and fixes
o Roo1DTable
- Add get(),getFrac() methods to retrieve contents
o RooAbsCollection
- Add selectCommon() method to create new collection
containing args common to two sets
o RooAbsData
- Minor const-correctness changes
o RooAbsReal
- Rearrangement of getAnalyticalIntegral/analyticalIntegral entry points.
Both functions now exist with and without a 'const RooArgSet* normSet'
The functions with normSet are used by RooRealIntegral, and its default
implementation handle the pass-through scenario (code 0 = getVal(normSet))
and defers other codes to the non-normSet variant.
Simple PDFs should implement the non-normSet variants, as they used
to do sofar, except they no longer should (or are able to) process
the passthrough scenario.
Advanced PDFs such as RooAdd,ProdPdf, RooConvolutedPdf that implement
complex integration schemes that depend on the exact normSet configuration
reimplement the getAI,aI functions with normSet.
o RooResolutionModel, RooAddModel
- Implement (or forward in case of RooAddModel) new getNormSpecial method.
This function is identical in functionality to RooAbsPdf::getNorm()
except that it caches a separate copy of the normalization integral.
This member is introduced for the benefit of RooConvolutedPdf::analyticalIntegral
which, in case of a normalized integration, alternatingly calls two different
normalizations. In the original single cache code, this would lead to
100% caching failure and 300% slowdown of the code. getNormSpecial is
protected for access by RooConvolutedPdf only.
o RooAddPdf,RooProdPdf,RooSimultaneous,RooConvolutedPdf
- Re-implement distributed analytic integration bookkeeping using
the auxiliary RooAICRegistry class, which keeps track of multiple
analytical integration codes (hence AIC)
o RooAICRegistry
- New auxiliary class to faciliate the management of distributed analytic
integration.
o RooArgSet
- Minor printing fix
o RooConvolutedPdf
- Complete rewrite of handling of analytical integrations. For RCP objects
analytical integrations are not all necesarily analytic, but include
integrations deferred to convolution objcts. Analytical integrations
are split off for coefficient terms. Complete double bookkeeping introduced
for 'integration' part of analytic integration and 'normalization' part
of integration, each of which can have a different argSet to defer
to the convolution objects and a different coefficient analytical integration
code. Current implementation is believed to be complete.
o RooFormulaVar
- Follow signature change of getAnalyticalIntegral/analyticalIntegral
o RooMath
- Implement file cacheing scheme for complex error function lookup table.
To invoke persistent caching, call RooMath::cacheCERF(kTRUE) prior to
use
o RooRealAnalytic
- Store and forward normalization set to analyticalIntegral call of
bound RooAbsReal
o RooSimultanous
- Implement new plotOn() method, taking a dataSet which can correctly
project a RooSimultaneous. The code is mostly copied from RooAbsReal::
plotOn, except that the plotted pdf is constructed as a RooAddPdf
of the RooSimultaneous components, weighted by the fractions found
in the passed dataset
o RooTreeData
- Small const-correctness fixes
Revision
2798 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Sep 17 18:48:17 2001 UTC (13 years, 4 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 10968 byte(s)
Diff to
previous 2779
Generalize RooArgSet to RooAbsCollection and introduce RooArgList
and corresponding proxy. Introduce RooArgList where appropriate
as replacement of a TList of proxies, eliminate all use of TList
inherited functions in RooArgSet/List.
Some optimizations implemented following profiling studies
Various fixes for compilation with Solaris CC 5.0
o RooAbsArg
- Change signature of server management function to use RooAbsCollection
instead of RooArgSet
- Add proxy management support for new RooListProxy class
o RooAbsPdf
- Disable use of RooNameSets as optimization attempt. It appears
to cost more time than it saves
o RooAbsProxy, RooArgProxy, RooAbsReal, RooAcceptReject,
RooDataHist, RooFormula, RooFormulaVar, RooGenCategory,
RooGenContext, RooGenericPdf, RooPlot, RooRealIntegral,
RooResolutionModel, RooSetProxy, RooSuperCategory, RooTreeData
- Follow RooAbsArg member function signature changes
o RooAddPdf, RooConvolutedPdf, RooFitContext, RooSimFitContext,
RooFitResult, RooPdfCustomizer, RooProdPdf,
- Change implementation from using TList to using RooArgList
o RooAbsCollection
- New abstract base class for collections of RooAbsArgs. This
class contains mostly code from the former RooArgSet implementation
o RooArgSet
- Re-implement as derived class of RooAbsCollection. A RooArgSet
cannot contain duplicates (as before), but also doesn't give
random access (by index) to its member elements
o RooArgList
- New implementation of RooAbsCollection that allows duplicates
in the list, allows sorting and lookup by index.
o RooListProxy
- Proxy version of RooArgList, similar to RooSetProxy. To be used
as data member of RooAbsArg implementation to hold external
RooAbsArg references.
Revision
2779 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Sep 6 20:49:16 2001 UTC (13 years, 4 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 21271 byte(s)
Diff to
previous 2747
Fix (hopefully all) outstanding problems in HEAD induced RooArgSet
changes
o RooAbsArg
- Modify error logic in findNewServer() to not assert if name
changing server change finds no new servers
o RooAddModel
- Change debugging print statements in ::convolution to show
RooAddModel as class instead of RooResolutionModel.
(convolution originally copied from RooResolutionModel)
o RooArgSet
- In removeAll() change Clear() to _list.Clear(). The former
didn't clear the list but went unnoticed because TObject apparently
has a Clear() member as well. Confusing...
o RooConvolutedPdf
- Improve error messaging in case a convolution integral cannot be
constructed
o RooDataSet
- Change RooArgSet::add() to RooArgSet::addOwned() in addColumn()
o RooResolutionModel
- Expand error messaging in convolution()
Revision
2747 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Aug 24 23:55:15 2001 UTC (13 years, 5 months ago) by
david
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 21267 byte(s)
Diff to
previous 2745
RooRealIntegral:
- add logic to reuse an existing numerical integration engine when possible
RooArgSet:
- replace Delete() with _list.Delete()
- create addOwned() member fn that allows objects to be added to a list
with ownership transfered to the list (like addClone())
RooFitResult:
- change _globalCorr and the elements of _corrMatrix to use "copied"
ArgSet's and let the ArgSet dtor handle the cleanup (ie, remove Delete()'s
from RooFitResult)
Revision
2742 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Aug 24 17:28:40 2001 UTC (13 years, 5 months ago) by
david
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 20079 byte(s)
Diff to
previous 2735
RooArgSet:
- fix 2 stupid bugs that I introduced in the list->set migration
RooAbsData:
- initialize all data members in copy ctor (I had to guess the
right value for some of them)
- replace GetName() with other.GetName() in copy ctor (caused
occasional crash)
RooAbsData,RooDataSet:
- clean up memory management for AbsData::_vars by using addClone()
instead of add() and letting the _vars dtor handle the Delete().
Revision
2735 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Aug 23 23:43:43 2001 UTC (13 years, 5 months ago) by
david
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 19904 byte(s)
Diff to
previous 2716
The following changes enforce set semantics in the public use of
RooArgSet's by removing the public TList interface.
RooArgSet:
- change base class from TList to TObject
- add protected data member THashList _list
- add inline createIterator() to export _list.MakeIterator()
- add inline getSize() to export _list.GetSize()
RooAbsArg,RooAbsData,RooAbsPdf,RooAcceptReject,RooConvolutedPdf,
RooCurve,RooFitContext,RooFitResult,RooFormula,RooFormulaVar,
RooGenContext,RooGenericPdf,RooLinearVar,RooMultiCatIter,
RooNameSet,RooPdfCustomizer,RooRealBinding,RooRealIntegral,
RooSetProxy,RooSuperCategory,RooDataSet:
- replace RooArgSet::MakeIterator() with createIterator(), etc.
RooAbsArg,RooArgProxy,RooSetProxy:
- move a block of duplicated code in RooAbsArg::redirectServers()
RooSetProxy::changePointer() and RooArgProxy::changePointer() into
a new RooAbsArg::findNewServer() member fn.
*** Outstanding problems now resolved by temporary cheater member
*** functions added to RooArgSet:
- RooConvolutedPdf uses RooSetProxy::At() and ::IndexOf()
- RooFitContext uses RooArgSet::At() and ::Sort()
- RooFitResult uses RooArgSet::IndexOf() and ::At()
- RooMultiCatIter uses RooArgSet::getCollection()
- RooPdfCustomizer uses RooArgSet::Sort()
- RooRealBinding uses At()
- RooSimFitContext uses RooArgSet::At() and IndexOf()
Revision
2715 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Aug 22 00:50:26 2001 UTC (13 years, 5 months ago) by
david
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 19611 byte(s)
Diff to
previous 2714
RooGenContext:
- move static random number interface to dedicated RooRandom class
RooRandom:
- new static interface class
- add support for pseudo-random numbers (used for Monte Carlo integration)
RooQuasiRandomGenerator:
- implement quasi-random generator algorithm
RooAbsCategoryLValue,RooAbsRealLValue,RooAcceptReject,RooGrid,RooIntegratorTest,RooMCIntegrator:
- use RooRandom instead of RooGenContext for random numbers
RooMCIntegrator:
- add option to use either a standard or a quasi random number generator (quasi is default)
RooAbsPdf:
- remove obsolete generator interface member fns
Revision
2655 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Aug 9 01:02:15 2001 UTC (13 years, 5 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 19667 byte(s)
Diff to
previous 2641
o Many classes
- Simplify use of TString as this is suspected to cause spurious
TString memory errors
o Many classes
- Fix about a dozen of memory leaks reported by GC (mostly iterators)
o RooArgProxy,RooSetProxy
- Change order of multiple inheritance to put TObject (or derived)
first. This fixes vtable/vptr mishap on Solaris
o RooAbsArg
- Introduce dynamic_cast<> in changeNormSet() to cast the TObject
from the proxy list into a RooAbsProxy (needed in conjuction
with above change)
o Several classes
- Make destructor virtual, fix Clone() function signature to match
that of TObject
Revision
2626 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Aug 2 21:39:13 2001 UTC (13 years, 5 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 19314 byte(s)
Diff to
previous 2624
o RooTrace
- New memory tracing utility (singleton class)
o RooAbsArg,RooDataSet,RooArgSet
- Install hooks for RooTrace in ctors and dtors
o RooThreshEntry
- Fix bug in copy ctor
o RooAbsReal,RooAbsPdf
- Move analytical integration support
(getAnalyticalIntegral,analyticalIntegral,
forceAnalyticalInt,selfNormalized) from RooAbsPdf to RooAbsReal
so that every RooAbsReal can be integrated
o All RooAbsReal derived classes
- Change signature of evaluate(),getVal(),traceEval(),checkDependents()
from X(const RooDataSet* dset) X(const RooArgSet* nset)
o RooAbsPdf
- Manage normalization caching with a RooArgSet listing the dependents
instead of a RooDataSet containing this list
- Remove obsolete nLogLikelihood function (now in RooFitContext)
o RooAbsArg
- rename setProxyDataSet to setProxyNormSet
- add getParameters(),dependentOverlaps() that
take a 'const RooArgSet*'
o Roo*Proxy
- rename changeDataSet() to changeNormSet()
o RooConvolutedPdf
- Replace dummy data set for convolution normalization by an RooArgSet
o RooDataSet
- Remove inheritance from TTree, make it contain a TTree instead.
Forward all relevant TTree member functions. Add correct Clone()
function (now possible due to inheritance change)
o Various classes
- Fix const handling to eliminate Linux2 compiler warnings
Revision
2624 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Aug 1 21:30:16 2001 UTC (13 years, 5 months ago) by
david
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 18926 byte(s)
Diff to
previous 2612
- support generating vars that PDF does not depend on explicitly
(they will have uniform distributions)
- support plotting of an AbsReal wrt a variable that it does not
depend on explicitly (plot will be flat but normalization is still
not correct)
- new method RooArgSet::addClone() parallels add() but *only* works
on a copied list (used in RooAcceptReject.cc)
- RooArgSet::remove() can now remove elements from a copied set and
deletes them at the same time.
- change RooRealFunc1D binding object to project out extra variables
instead of calculating along a slice (but normalization wrt x is
not done correctly yet in this case).
Revision
2612 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jul 31 05:54:23 2001 UTC (13 years, 5 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 17741 byte(s)
Diff to
previous 2345
o All RooAbsArg derived classes
- Change clone() to clone(const char* newname=0) to facilitate cloning with alternate names.
o RooAbsArg
- Add another layer to link management: operMode. If operMode=auto, all behaves
as before. If operMode=AClean, the arg assumes the cache is always clean and
getValueDirty() will always return false. If operMode=ADirty, the arg assumes
the cache is always dirty and isValueDirty will always return true.
The ADirty and AClean modes are used by the optimizer in the fit context
to shut down link management (and save time) for cases where the arg is
always dirty after a dirty state propagation from one of the dependents.
The AClean mode is used similarly for args that are cached in the dataset
The setOperMode() member is protected as care should be taken in switching modes.
It is the callers responsability to ensure that the claimed state (especially
in case of AClean) is indeed correct.
- Split setValueDirty(Bool_t flag) in setValueDirty() and clearValueDirty().
The latter is trivial and can be inlined to save time.
- redirectServers() now has an optional nameChange flag that allows to reconnect
to servers with different names. If the option is enabled, a link will be reconnected
to the server with a 'ORIGNAME:<servername>' attribute instead of a server with <servername>
This feature is used by RooPdfCustomizer.
- Added recursive printDirty() member that listed dirty state of arg and all its servers.
- Add sorting capability by implementing IsSortable() and CompareTo() members.
Sorting will result in alphabetical ordering by object name.
o RooAbsCategory
- Change tree attachement: store both label and index fields in tree instead of
just the index field. Looking up the corresponding label turns out to be rather
expensive, especially if many state are defined.
- The postTreeLoadHook() mechanism that formerly implemented the index lookup
has been abandoned completely (save 1 virtual function call per data set load).
o RooAbsPdf
- Change function call structure of eval tracing a bit to reduce the number
of calls per trace from virtual calls to 1 concrete call.
- In syncNormalization, if the data sets are different, first check if they
also have a different contents before processing the change. (Save multiple
identical normalization calculations for cases were a resolution model is
shared by >1 RooConvolutedPdf. (WVE Caveat: this has some problems: code will
die if cached data set is deleted before pdf. Will fix this soon)
Install pre- and postSyncNormalizationHook functions that can be used to customize
the call. Used by RooConvolutedPdf to create/update dummy data sets used to
push down partial integrations to the convolution integrals.
- Move nLogLikelihood to RooFitContext
o RooAbsReal
- in attachToTree(), mangle name of object in tree to exclude math symbols that
are interpreted by root in certain circumstances
o RooAddModel
- Store coef and proxy iterators in class instead of creating them on the fly each
time in evaluate()
- Release ownership of proxied resolution models in the copy constructor. If the
AddModel is copied, the proxied components will be owned by the list created
by RooArgSet::snapshot().
- Include name of AddModel owner in component resolution model to avoid multiple
identically named object in certain PDF configurations
- Export 'master list' of combined normalization leaf node servers of all components.
The convolutedPdf needs this for it's own dependency calculation
o RooArgSet
- Add silent option to remove()
o RooCatType
- Store name in char[] instead of in TNamed::fName (a TString) so that
the name can be attached to a Tree. (A TString is not a TObject)
o RooConvolutedPdf
- Push integration of all dependents that do not overlap with the coefficients
to the convolution integrals, instead of just the convolution variable
o RooDataSet
- Add new constructor that allows to specify the cut as a RooFormulaVar object
instead of a string. This allows to cut on function arguments that are not
part of the data set
- Allow to switch off dirty state propagation after a row-load operation
(can be used in certain optimization scenarios)
o RooFitContext
- Add option to not clone either dataset or pdf on construction
- Remove non-RooRealVar parameters from master parameter list to prevent that
MINUIT chokes on them
- Sort minuit parameter list alphabetically
- Add cache optimization option, which shuts down all link management for the
all pdf value components (not normalization). This can save a significant amount
of time, especially for very complex PDFs as the number dirty propagations scales
with the square of the number of nodes. Use newly introduces AClean and ADirty
modes to ensure proper evaluation of PDF nodes
- Add option to execute migrad with 'strategy 0', which skips the evaluation of
the error matrix. (Saves time if you do that later with HESSE anyway)
- Move nLoglikelihood() function from RooAbsPdf to here.
- Improve readability of messages in fitting in log-mode: print on screen only value
and name of parameters that change instead of dumping all their values all the time.
The old format has been retained in the log file, to allow automated processing of such files.
o RooFormulaVar
- Also update _origList on a serverRedirect
- Export ok() function of RooFormula (indicates if expression compiled ok)
o RooMath
- Add fast, interpolated, complex error function. Upon first use separate lookup tables
are filled for the im and re part of the complex error function. New functions will
do a 2nd or 3rd order 2D interpolation (depending on z) of the lookup table for either
the re part, the im part or both. Precision is better that 1e-6 in ~99% of covered
phase space. Imprecise regions are in problematic part of cErf where giant fluctuations
occur. Typical likelihood calculated with interpolated cErf agrees in the first 10
significant digits. Interpolation function is ~3.5 times faster than original CWERF
implementation, when only 1 component (im/re) of cErf is needed (most cases).
Interpolation function taken from Numerical Recipes and further optimized for
fixed grid assumption
o RooMappedCategory
- Clone also MapCatEntries in RooMappedCategory copy ctor
o RooProdPdf
- Store coef and proxy iterators in class, instead of instantiating them on the fly
in evaluate()
- Add optional cutoff parameter. If running PDF product goes below cutoff, product
calculation is terminated (default value=0, very small values like 1e-15 can be
benificial in case of wide window calculations a Gaussian + something flattish)
o RooRealIntegral
- Allow and perform integration over variables that input function doesn't depend
on (multiply integral by product of ranges of such variables)
o RooResolutionModel
- In convolution(): append name of owner to convolution, to avoid non-identical
convolutions with the same name in certain PDF configurations
- Forward redirectServers to basis function
o RooSimultaneous
- Overload fitTo() to create a RooSimFitContext instead of a RooFitContext
which allows certain additional optimizations specific to RooSimultaneous
- Normalize by the number of registered PDFs instead of the number of types
defined by the index category (allows to to partial fits)
o RooStreamParser
- Take '}' and ';' out of the default punctuation list so that RooSuperCategory
state names do not get broken up into multiple tokens
o RooThresholdCategory
- New category class that applies a series of thresholds on a RooRealVar to
define its state.
o RooThreshEntry
- Support class for RooThresholdCategory
o RooPdfCustomizer
- Utility class that serves a factory to build multiple PDFs from a single prototype
that have slightly different leaf nodes.
The class takes a proto type and a master index category in the constructor.
A series of splitting rules determines how given leaf nodes are to be 'split'
over the master index category or a subset of the master index (in case the master
index is a RooSuperCategory)
The instiated 'split' leaf nodes are put in an argset referenced in the constructor.
and the owner of the argset is responsible for deleting them (or passing them on
to another RooPdfCustomizer). The instantiated branch nodes are owned by the customizer.
o RooSimFitContext
- Specialized fit context, derived from RooFitContext, that optimizes the likelihood
calculation in case the top level pdf is a RooSimultaneous. The original data
set is broken into pieces, corresponding to a single state of the RooSimultaneous
index category and those data subsets are combined with the corresponding PDF branches
of the RooSimultaneous to form an array of regular RooFitContexts. The total likelihood
is calculated as the sum of the likelihoods from the array of fit contexts.
The NLL output from each subcontext is cached and only recalculated if a parameter
that the PDF of that subcontexts depends on, is changed.
This form of calculation is very efficient for fits where the correlation matrix has
a block diagonal form. The CPU time in RooSimFitContext scales (approximately) with
the number of elements in the block diagonal elements instead of with the total number
of elements.
o Nearly all classes
- A large number of minor bugs has been fixed and many functions
that are called very frequently have been inlined, made non-virtual or
have been eliminated, following the result of repeated profiler studies.
Revision
2345 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu May 31 21:21:37 2001 UTC (13 years, 7 months ago) by
david
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 17301 byte(s)
Diff to
previous 2222
RooAbsPdf:
- add interface for querying built-in generator capabilities, similar
to the analytic integral interface: getGenerator() & generateEvent()
- rename tryIntegral() methods to matchArgs()/matchArgsByName() and fix
problem with >1 proxy name in TList version (now matchArgsByName())
- move attatchDataSet() method into RooAbsArg and change RooDataSet* arg to RooDataSet&
- make RooAcceptReject a friend so it can use recursiveRedirectServers()
RooArgSet:
- add a method remove(const RooArgSet&) that calls remove(const RooAbsArg&)
- add removeAll() method
- add replace(const RooArgSet&) method
RooAcceptReject:
- implementation of general-purpose accept-reject generator, used by RooGenContext
RooAbsRealLValue,RooAbsCategoryLValue:
- add non-virtual randomize() method for toy MC
RooAbsArg:
- add printout of our memory address in verbose printToStream() for x-referencing
with client/server addresses of other AbsArgs.
RooRealIntegral:
- augment verbose printToStream() output
RooAbsCategory:
- add protected getOrdinal() method
RooAbsCategoryLValue:
- add protected setOrdinal() method
Revision
2184 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri May 11 23:37:41 2001 UTC (13 years, 8 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 15260 byte(s)
Diff to
previous 2182
o RooAbsArg
- Extend xxxNodeServerList and getDependents with an option
to truncate tree searches at an LValue type object
o RooAbsPdf
- Add static flag to enable verbose evaluation (useful in optimization
checking). Switch using RooAbsPdf::verboseEval(1,0) ;
- Use new 'Lvalue' type dependents list for integration
o RooMultiCatIter
- Require RooAbsCategoryLValue as input type instead of RooCategory
o RooRealIntegral
- Fix an overlooked update to new list copy behaviour
(caused integration to change value of dependents)
o RooSuperCategory
- Also copy current value in copy ctor
o RooGenericPdf
- New, very similar too RooFormulaVar, except that it is normalized
o (Many classes)
- Disable low-level debug print statements
Revision
2167 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri May 11 06:30:01 2001 UTC (13 years, 8 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 15096 byte(s)
Diff to
previous 2165
o RooAbsArg
- In destructor, only print out warnings about live clients
that get cut off in verboseDirty() mode.
For automatically declared RooAbsArg this error condition
never occurs, but for client/server links in lists, the
order of deletion doesn't take these link directions into account.
o RooCategory
- Disallow defineType("") with a semicolon in the name.
This would confuse the reverse mapping of
RooSuperCategory::setIndex()/setLabel()
o RooArgSet
- Make default clone/copy ctor not copy the contents of the
list (Some core classes changed that used this feature)
- Extend snapshot function to ::snapshot(Bool_t deepCopy)
which allows to make both shallow (only list contents copied)
and deep snapshots (also all dependents of list contents
copied and added to list)
- Modify replace() to use AddBefore();Remove() instead
of Remove();Add() so that a replace call doesn't interfere
with an iterator over the RooArgSet
o RooRealIntegral
- Change dependent type checking from RooRealVar/RooCategory
to RooAbsRealLValue/RooAbsCategoryLValue
o RooSuperCategory
- Add MakeIterator() function which returns a RooMultiCatIter
on the super categories servers.
- Implement setIndex/setLabel(), which decodes the composite super
label into labels of the input categories
- Make use of new RooSetProxy which proxies the RooArgSet list
of input categories
- Enhance verbose printing
o RooGenCategory
- Port/rewrite from RooFitTools. User method scanned for all states
and translated into a
'SuperCategory type-index -> GenCategory type-index'
map (int-to-int via a simple array), making the class substantially
faster. The mapping is revised upon a shapeDirty() which is
propagated from all the input categories
o RooAbsCategory
- New abstract common base for RooArgProxy and RooSetProxy
o RooSetProxuy
- Proxies a RooArgSet. Essential service provided: upon a
redirectServers the list contents is replaced with the
new pointers from the redirection list.
Revision
2164 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu May 10 18:58:48 2001 UTC (13 years, 8 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 14846 byte(s)
Diff to
previous 2114
*** Changes to allow a dataset to cache of derived objects ***
o RooAbsReal, RooAbsCategory and RooAbsString
Now each implements a protected method attachToTree, which allows to
connect the cache of any RooAbsArg to a TTree column
All other implementations (RooRealVar etc) removed
o Most classes
Type-blind assignment RooAbsArg* <...>::operator(const RooAbsArg*)
has been replaced by RooAbsArg::copyCache(RooAbsArg *), which is
needed for data set copy operations.
A new method RooAbsArg::syncCache(RooDataSet *)
can be used force to update the cache before a copyCache call.
o RooDataSet
- Holds a list of _cacheVars in addition to _vars, which are not
owned by the data set, but are updated nevertheless.
The cache list is not copied in a Clone() or copy operation.
- New methods cacheArg(RooAbsArg&) and cacheArgs(RooArgSet&)
register derived objects for caching in the dataset.
The values for these derived objects for each row of the tree
will be calculated and stored as a new column in the tree.
The cache of the derived object is attached to that tree column.
On a RooDataSet:get() row-load call, a setDirty(kTRUE) is called
for each cached (and uncached) object to propagate a value change
to the cached objects clients. Then immediately a setDirty(kFALSE)
is performed on the cached objects, to impose that the tree-loaded
value of the cache is correct and doesn't need to be recalculated.
o RooFitContext
- Optimizer not uses cacheArgs instead of addColumn, which
is integration-safe and can now be used on any derived object
with constant parameters
o RooAbsPdf
- Another iteration in the structure of getVal.
To make data set attachement work, the normalized value is
now stored in the cache instead of the raw value.
*** Cleanup of assignment operator ***
o RooAbsRealLValue/RooAbsCategoryLValue
- Implements assignment to Double_t/(Int_t,const char*)
o RooRealVar/RooCategory
- Implemements assignment to RooRealVar/RooCategory
o All other assignment operators deprecated
- No more assignment of derived types to each other
(conceptually unclear)
Revision
2114 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu May 3 02:15:56 2001 UTC (13 years, 8 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 14842 byte(s)
Diff to
previous 2015
o (Most classes)
Merge X(const x&) and X(const char*, const X&) copy constructors
into a single X(const& X, const char*=0)
o RooAbsArg
- Add 'depth-aware' client-server management functions
recursiveRedirectServers(...)
treeNodeServerList(...)
leafNodeServerList(...)
branchNodeServerList(...)
overlaps(...)
dependsOn(...) (now recursive)
- Add/move parameter/dependent interpretation to RooAbsArg
getParameters(...)
getDependents(...)
dependentOverlaps(...)
checkDependents(...)
- Change Clone() to Clone(const char*) and make it call
a pure virtual clone().
o RooAbsPdf
- First implementation
- Actual fitting implemented in RooFitContext
- Incorporates normalization technology from
RooNormFunction (now retired)
- Separate getValNorm() dropped in favour of
getVal(const RooDataSet* =0)
- getVal(...) provides all owned proxies with
the correct data set (which they need for their
value cast operators that don't take an RDS)
o RooFitContext
- First implementation
- Owns a clone of a dataset and a PDF and ties them
together with a redirectServers
- Caches indexed parameter list for fast Minuit lookup
- global Optimizer function seeks out PDF components
that only have constant parameters and add these
as precalculated columns to the data set clone
(redirectServers edits PDF tree to point to cache)
o RooDataSet
- Implement addColumn(RooAbsReal) that adds a column
of precalculated values given function for each
row of the data set
o RooAbsReal
- Change getVal() to getVal(const RooDataSet* set=0)
to allow dynamic normalization for PDFs.
o RooArgProxy and dependents
- Cache last data set used, for use in getVal(...) call in
value cast operator.
o RooRealProxy
- add min()/max() functions that get out the integration limits
if the underlying real is a RooRealVar. (Needed by RooAbsPdf
analytical integration implementations)
o (Most classes)
- A large number of minor fixes have been applied to make
the Solaris 5.7 compiler happy
Revision
2015 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Apr 20 01:51:39 2001 UTC (13 years, 9 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 14508 byte(s)
Diff to
previous 1985
o Work out proxy concept
RooReal/CategoryProxy now inherit from common base RooArgProxy (->TNamed)
Proxy ctor takes pointer to RooAbsArg that owns the proxy
registers itself and declares proxied object as server.
Modified redirectServers in RooAbsArg will automatically updated
registered proxies in addition to client/server links
o Change RooUnblindCPAsym/DeltaTVar to use new proxy mechanism
o Extend functionality of RooArgSet
- add(RooArgSet) to add a list of arguments
- replace(a,b) to replace an arg in the list
- setAttribAll(attrib,value) to set/clear given attribute
in all list members
- selectByAttrib(attrib,value) to create a sublist containing only
args with given attrib set or cleared
Revision
1985 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Apr 14 00:43:20 2001 UTC (13 years, 9 months ago) by
davidk
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 12748 byte(s)
Diff to
previous 1969
RooCatType:
- multiply-inherit from RooPrintable and standardize printToStream()
- remove Int_t() and Int_t&() cast operators
- operator==(const RooCatType&) requires index and label to match (was just index before)
RooAbsCategory:
- add lookupType(const RooCatType&) which was being faked using RooCatType::Int_t() before
- delegate equality tests in lookupType() methods to RooCatType::operator==() methods
- delegate printing of RooCatType's to RooCatType::printToStream()
RooMappedCategory:
- standardize printToStream()
- change a!=b into !(a==b) for RooCatType a,b (op!= was being faked by RooCatType::Int_t())
- add setShapeDirty() in addMap()
RooAbsArg:
- use AbsArg::printToStream(OneLine) to print client,server info in printToStream(Verbose)
RooPlot:
- add getPlotVar() member fn
RooDataSet:
- add const plot(RooAbsReal&) and plot(RooPlot*) methods to eventually replace Plot()
- make Plot() const and remove the unused options argument
- const_cast our ArgSet in Plot() so we can call redirectServers()
RooFormula:
- make ctor ArgSet argument const to allow DataSet::plot() to be const
Revision
1952 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Apr 11 00:54:37 2001 UTC (13 years, 9 months ago) by
davidk
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 12383 byte(s)
Diff to
previous 1910
RooPrintable:
- new class that defines printToStream() virtual method and provides
helper functions for converting Option_t -> PrintOption and one-line
printing
- subclasses should always call oneLinePrint() in printToStream() to
generate a standard first line (and only line in case of
PrintOption=OneLine)
RooDataSet,RooPlot,RooArgSet:
- multiple-inherit from RooPrintable
- standardize implementations of printToStream() and Print()
RooPlot:
- change base class from TH1F to TH1
RooPlotWithErrors:
- rename to RooHist
RooDataSet:
- add default options for read()
Revision
1910 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sun Apr 8 00:06:49 2001 UTC (13 years, 9 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 12842 byte(s)
Diff to
previous 1900
o Another major round of const-correctness improvements
o Add RooDerivedReal as an intermediates class between
RooAbsReal and RooRealFormula,RooRealIntegral,RooUnblind*
the getVal() -> cache check -> traceEval() -> evaluate()
chain has been moved into this class.
Derived Classes of RooDerivedReal only need to implement
evaluate() for contents definition. The getVal() of RooAbsReal
return the straight contents of _value.
o Added RooRealIntegral class, which represents the integal and/or sum
over various RooRealVar/RooCategory dependents of a generic RooDerivedReal
Integral value is cached and updated when the value of one of the
non-integrated dependents of the integrated functions changes
(detected via valueDirty bit propagation), or if the integration ranges
of one of the integrated dependents change (detected via shapeDirty
bit propagation).
If the RooDerivedReal supports analytical integration (implemented
via the getAnalyticalIntegral/analyticalIntegral functions) it's
analytical integrator is used. Otherwise a numerical integration algorithm
is used (currently limited to 1-dimensional integrations)
Summation of an arbitrary number of category dependents is supported
but not implemented yet, pending the port of RooSuperCategory, which
will support a trivial implementation.
Analytical integation interface: Each RooDerivedReal has 2 functions
implemented
- getAnalyticalIntegral(RooArgSet& integrandList),
which determines if analytical integration is supported
for the given list of integrands. If not, it returns
code 0. If yes, it returns a positive code, which RooRealIntegral
will pass to analyticalIntegral().
- analyticalIntegral(Int_t code) Performs or dispatches the
analytical integral represented by the code assigned by
getAnalyticalIntegral()
In theory, the above scheme could be implemented with just one
function, returning a pointer to a member function, but
pointer-to-members are not supported by ROOT due to portability
problems. The current scheme is inspired on the TFormula implementation
of referencing external parameters.
A default implementation in RooDerivedReal handles the default
(no analytical integration available) case.
Revision
1900 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Apr 5 01:49:11 2001 UTC (13 years, 9 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 12834 byte(s)
Diff to
previous 1863
o Implement custom Clone() for all RooAbsArg derivatives
which uses the copy constructor. The TObject Clone()
uses the Streamer() functions that have unintended side
effects on the bidirectional link lists in RooAbsArg
o Fix RooFormula/RooRealFormula so that it is properly
clonable / copyable
o Add options RooAbsArg::addServer(), that allow to mask
value or shape dirty state information from the server
(This will allow RooPDF classes to distinguish between
parameters, which require value state propagation, and
dependents, which require shape state propagation)
Revision
1863 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Mar 29 01:06:45 2001 UTC (13 years, 9 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 12372 byte(s)
Diff to
previous 1852
o Add blinding support
- RooDataSet can now read mixed blind/unblind data, if the
blinding string (if present) is always the same.
The data set dynamically adds a 'blindState' category to
it's internal variable list which indicates if a given event
is blinded or not.
- Imported RooFitTools/RooBlind as RooBlindTools
- Created two unblinder engines RooUnblindCPDeltaTVar and
RooUnblindCPAsymVar. To perform blinding to do
RooRealVar deltat(...)
RooCategory tag(...)
RooCategory blindStat(...) // All these should come from a RooDataSet
RooUnblindCPDeltaTVar deltat_ub("deltat_ub","DeltaT unblind",
"Blinding String",deltat,tag,blindsStat)
OR
RooRealVar sin2b(...)
RooUnblindCPAsymVar sin2b_ub("sin2b_ub","Sin2Beta unblind",
"Blinding String",sin2b)
Then feed deltat_ub and sin2b_ub in the PDF.
the print() and read/write methods of the unblinders show some
configuration information, but don't reveal the unblinded value
The getVal() of the unblinders is 'protected' and can only be
accessed by RooDataSet
o Some cleanup in dirty flag propagation code
o Optional indexing category in RooDataSet::read that tells from which file
a given event is coming. A dummy category should be appended to the varlist
and it's name should be given as the last argyment in the RooDataSet ctor.
If the filespec is "fileA,fileB,fileC", for each file a new index type
is created with values 0,1,2 etc.. and labels ('file000','file001' etc).
One can also explicitly assign index labels to each file using the
following file spec string: "fileA:Dstar,fileB:Dstar,fileC:Jpsi".
In this example fileA and fileB will have index label Dstar (value 0)
and file C has label "Jpsi" (value 1)
Finally it is also possible to predefine label types in the index
category. RooDataSet::read will use the existing label/values defined
and assign new ones where undefined.
o Fix type in RooAbsArg::Print()
Revision
1852 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Mar 27 01:20:20 2001 UTC (13 years, 10 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 12271 byte(s)
Diff to
previous 1846
o Add RooProxy classes for use in PDFs
o Enhance RooStreamParser
- Configurable definition of punctuation
- new atEOL() member can tell if there is an EOL
between the last read token and the next token to be read
- Read quoted string always as a single token
- readString() will strip quotes if present (readToken() doesn't)
o Add RooAbsString, RooStringVar classes,
analogous too RooAbsReal/RooRealVar
Revision
1846 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Mar 22 15:31:25 2001 UTC (13 years, 10 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 12150 byte(s)
Diff to
previous 1842
o Extend RooFormula to understand RooCategory labels '<catName>:<catLabel>'
so you can e.g. do (tagCat==tagCat::Kaon)
o Transplant and rework most advanced reading options from RFT/RooVarList
to RFC/RooArgSet
- Nested if statements
if (conditional)
else if (conditional)
else
endif
Conditionals are evaluated by a RooFormula object that can use the
entire arglist as variables
- Recursive include statements
include <filepath>
- Some useful other commands for configuration file use
echo "message" -> Print message while processing
abort -> Force termination of read with error status
Handling of errors in the input file format is fairly exhaustive.
o Some reworking of the RooStreamParser in the way newlines are handled.
Some of the clients of RSP have been changed accordingly.
Main new feature is a RSP::atEOL() member that determines if there is
a newline between the last read token and the next token to be read.
o Temporarily made RooAbsArg::Print/printToStream non-const as the
implementation in some subclasses call a non-const getVal()
This problem must be fixed for good in all classes soon.
Revision
1842 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Mar 22 02:13:47 2001 UTC (13 years, 10 months ago) by
davidk
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 8270 byte(s)
Diff to
previous 1839
RooAbsArg:
- add comments for THtml docs
- add const in printing methods
- replace print() method with impl for TObject::Print()
- move printLinks() into printToStream()
- implement 2 levels of detail in printToStream()
RooArgSet:
- change use of print() to printToStream()
makedocs:
- configure to strip out class descriptions from .cc file
Revision
1839 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Mar 21 15:14:21 2001 UTC (13 years, 10 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 8259 byte(s)
Diff to
previous 1834
o Finish RooMappedCategory::writeToStream()
o Check and fix validity checking in *::readFromStream()
o RooDataSet::read now uses RooArgSet::readFromStream
o Change event selection in RooDataSet::Plot,RooDataSet::RooDataSet(tree)
to use RooFormula instead of TTreeFormula
o Add interface to RooAbsCategory in RooFormula
Revision
1827 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Mar 16 07:59:12 2001 UTC (13 years, 10 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooArgSet.cxx
File length: 6578 byte(s)
Diff to
previous 1806
o Make naming convention of member functions more uniform
o RooAbsArg: Add 'Shape' dirty state management
o Roo*Value: Distinguish between integration and plotting limits
o Roo*Value: Disentangle meaning of limits and constant-ness
o Add tracing to RooAbs{Value,Index} evaluation
o redirectServers & traceEval have global trace function and
hooks for additional subclass tracing
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
enter a numeric revision.
