Log of /trunk/roofit/roofitcore/src/RooFactoryWSTool.cxx
Parent Directory
Revision
43071 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Feb 21 17:01:01 2012 UTC (2 years, 11 months ago) by
axel
File length: 66317 byte(s)
Diff to
previous 42984
Fix clang warnings: strlcpy(A, B, len) with len == strlen(B) instead of sizeof(A). Was okay in all cases, but double call to strlen() for no good reason.
Revision
42984 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Feb 13 15:30:31 2012 UTC (2 years, 11 months ago) by
wouter
File length: 66183 byte(s)
Diff to
previous 42515
Assorted bug fixes
o Roo1DMomentMorphFunction, RooFunctorBinding, RooFunctor1DBinding, RooProdPdf, RooAbsRealLValue,
RooSimSplitGenContext, RooBinIntegrator, RooVectorDataStore, RooSegmentedIntegrator, RooChangeTracker,
RooAbsReal,RooFactoryWSTool, RooRealIntegral, RooTreeDataStore, RooUnitTest, RooAbsPdf
- Coverity fixes (mostly missing initialization)
o RooDataHist
- Fix in bin volume correction for partial integrals
o RooAbsData
- Remove stray debug comment
o RooObjCacheManager
- Follow change in RooCacheManager
o RooCacheManager
- Back out LHCb version - new version that does same thing but works correctly
Revision
42515 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Dec 16 12:23:16 2011 UTC (3 years, 1 month ago) by
wouter
File length: 65921 byte(s)
Diff to
previous 42443
o RooFactoryWSTool
- Extend buffer size in string parser from 1K to 10K per expression
o RooConstraintSum
- Some naming changes
o RooAbsPdf, RooGlobalFunc
- Introduce named argument GlobalObservables(const RooArgSet&) to define
normalization observables for constraint terms ('auxiliary measurements')
Can be used in fitTo() and createNLL()
o RooMultiVarGaussian
- Implement analytical integration over parameters as well
o RooMinuit
- Implement speedup for orginal parameter lookup which speeds up very fast likelihoods
with a large number of parameters
Revision
42443 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Dec 8 15:08:16 2011 UTC (3 years, 1 month ago) by
wouter
File length: 65882 byte(s)
Diff to
previous 39949
o RooAbsData
- In split() explicitly add weight variable to component datasets if
the dataset is weighted. This fixes a bug (reported by M Baak)
that weights are ignored when a weighted dataset generated
from RooSimulateous::generate() are ignored in the likelihood.
(this happens because the weights are only in the component datastores
in the form constructed by RooSimGenContext::generate() and not
in the top-level dataset). The 'fast-split' which is executed e.g.
by setData() is not affected by this because it directly recycles
the component datastores
o RooDataSet,RooDataHist,RooAbsData
- Add new optional argument to emptyClone() to introduce
weight variable on the fly if needed.
o RooDataHist
- Speed up getIndex() by allowing fast-assign methods
o RooFactoryWSTool
- Add inverse conditional symbol '|~' to PROD() notation
i.e. PROD(F|~x,G) interprets pdf F as conditional on all observables
_except_ x
o RooUnitTest, Module.mk
- Regression testing class. Moved from stressRooFit here so that
it can also be used by stressRooStats
Revision
39949 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Jun 24 15:13:35 2011 UTC (3 years, 7 months ago) by
wouter
File length: 65684 byte(s)
Diff to
previous 39377
o RooAbsReal, RooFactoryWSTool, RooRealIntegral
- Fix inline of statics for windows
o RooBanner
- Increment version tag to 3.16
o SimpleLikelihoodRatioTestStatistic
- Allow reuse of NLL optimization (OFF by default)
Revision
39377 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed May 25 16:56:49 2011 UTC (3 years, 8 months ago) by
wouter
File length: 65620 byte(s)
Diff to
previous 38906
o RooProdPdf
- Add redirectServersHook() that implements back-end of node removal
functionality (remove terms inserted by customizer labeled as REMOVAL_DUMMY)
o RooCustomizer
- Implement node removal functionality when a special REMOVAL_DUMMY target
is specified as subtitution target (high level interface provided through factory)
o RooFactoryWSTool
- Add support for "EDIT(model,node=$REMOVE)" and "EDIT(model,node=$REMOVE(nodelist)"
to remove "node" from either all occurring RooProdPdf terms in mode, or only the
ones listed in nodelist
o RooAbsArg
- Support node removal operation in redirectServers() method
o RooRealConstant
- Extend factory to also be able to create range removal dummy nodes
o RooAbsCollection
- Add 'claim counter' that can be incremented or decremented. If claim count is
non-zero, the destructor will not delete its contents, even if marked as
owning (used by new RooAbsOptTestStatistic::setData() functionality)
o RooAddPdf
- When inserting integral ratios to correct for range mismatches into coefficient projection factors
first check if ranges with different names actually represent the same range. In this case
omit the ratio factor (can result in a significant speedup)
o RooAbsData
- Add lightweight tracker of live instances to support more robust operation of RooAbsOptTestStatistic::setData()
o RooStudyManager
- Import fixes from Sven (do not automatically close PROOF session at end of runProof())
o RooWorkspace
- Add methods renameSet() and removeSet() to rename/remove named sets in the workspace
o RooAbsOptTestStatistic
- Make operation of setData() more robust: make method function properly even if currently attached
dataset is deleted _before_ new dataset is attached [ to support speedup of RooStats code ]
Revision
38906 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Apr 18 20:05:25 2011 UTC (3 years, 9 months ago) by
wouter
File length: 65303 byte(s)
Diff to
previous 37172
o RooSpHarmonic
- Fix bug in one of the constants
o RooProdPdf
- Fix memory leak
o RooFactoryWSTool
- Allow for custom postfix on automatically generated class names
o RooAbsPdf
- In getVal() clear _normSet explicitly to zero when called with nset=0
(Needed in conjuction with RooProdPdf fix)
o RooAddition
- In defaultErrorLevel() search for NLL and chi^2 like terms recursively
rather than only one level deep
o RooClassFactory
- Allow for custom postfix on automatically generated class names
o RooAbsOptTestStatistic
- Remove obsolete zero-propagation in combinedValue() that was causing
trouble in massive parallelization of simultaneously likelihoods
Revision
34064 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 22 15:05:19 2010 UTC (4 years, 7 months ago) by
wouter
File length: 64756 byte(s)
Diff to
previous 30403
Import roofit/roofit(core) changes from dev/roostats branch to trunk
=== r34062 ===
o RooProdPdf
- Fix compilation error on Windows
- Fix memory leak
- Fix some shadowing problems
o RooDataHist
- Fix memory leak
o RooFactoryWSTool
- Add syntax checker routine to factory front-end. At present
this counts only of all pairs of (),[],{} match.
- Add factory syntax 'set::name(a,b,c)' as factory syntax for
RooWorkspace::defineSet("name","a,b,c") ;
o RooAddPdf
- Fix memory leak
o RooAbsNumGenerator, RooAcceptReject, RooFoamGenerator
- Fix uninitialized pointer problem spotted by valgrind
o RooRealMPFE
- Fix gcc 4.4 warnings by checking return values of all read(),write()
and pipe() calls.
o RooAbsPdf
- Fix variable shadowing issue
o RooRealIntegral
- Fix memory leak
o RooTreeDataStore
- Fix memory leak
o RooSimultaneous
- Fix variable shadowing issue
o RooGlobalFunc, LinkDef2
- Include fix from Kyle/Axel to solve include guard issue in macros
for namespace RooFit
=== r34020 ===
Update to RooRealSumPdf where normalization had memory leak
=== r33961 ===
o RooAbsReal
- Add new method setEvalErrorLoggingMode() that takes three options
PrintErrors (default), CountErrors (new) and CollectErrors (supports
structured printing during minimization
o RooRealMPFE, RooMinimizerFCN, RooMinimizer, RooMinuit
- Follow changes in RooAbsReal
o RooAbsPdf
- Make getLogVal() return log(0) when probability is zero, rather than zero,
to support operation of (non-log) likelihood functions
=== r33945 ===
o RooNumRunningInt, RooCachedPdf, RooCachedReal
- Use aggregateCacheUniqueSuffix() advertised by content to
distinguish objects with identical structure that have
different non-parametric content (such as likelihood functions)
o RooAbsCachedPdf, RooAbsCachedReal
- Allow addition of additional suffix to name of object cached
in expensive object store
o RooAbsReal
- Introduce virtual function cacheUniqueSuffix() that allow function
objects that have non-parametric content that can cause two instance
of an object with the same parameter to behave differently (e.g. likelihoods that
have different datasets but the same pdf) to advertise a string suffix
that can be attached to the index name in the expensive object cache to
distinguish different instances
- Introduct method aggregateCacheUniqueSuffix() that concatenates all suffixes
produced by any branch node into a single string
o RooAbsOptTestStatistic
- Advertise dataset pointer as unique cache suffix
o RooProdPdf
- Large scale adjustment to code to be able to handle pdfs where
the normalization range of its observables is defined by
multiple ranges rather than a single range
o RooMsgService
- Add concept of debug workspace and debug code to facilitate
debugging of complex problems
o RooGenContext
- Force use of Accept/Reject sampler for problems with observables where
the range depends on other observables as Foam cannot handle these
o RooDataSet
- Bug fix in handling of weights in append() operation
o RooAbsGenContext
- Add support for handling of explicit normalization range(s)
o RooAbsReal
- Bug fix in createIntegral(), avoid use of strtok() due to possible recursive use
o RooAddPdf
- Large scale adjustment to code to be able to handle pdfs where
the normalization range of its observables is defined by
multiple ranges rather than a single range
o RooAbsPdf
- Add support for definition of multiple normalization ranges, with setNormRange()
as user front end
o RooAbsArg
- Fix bug in link state management: a state change to ADirty must be propagated to
all clients.
- Add maximum level argument to printComponentTree()
o RooRealIntegral
- Fine tuning of debug-level print messages
- Fix memory leak
o RooAddGenContext
- Add support for handling of multiple normalization ranges
o RooRangeBoolean
- New RooAbsReal implementation that returns 1 or 0, depending on another observable
having a value in a predefined range
o RooAbsIntegrator
- Fine tuning of debug-level printouts
o RooTreeDataStore
- Multiple bug fixes in handling of weighted data
o RooAbsOptTestStatistic
- Small changes to support operation with multiple normalization ranges
o RooArgSet
- Add utility method isInRange() that is forwarded to content
o RooGenProdProj
- Add new operation mode that does not factorize, which is needed for certain cases
with multiple n
=== r33943 ===
o RooProdPdf
- Large scale adjustment to code to be able to handle pdfs where
the normalization range of its observables is defined by
multiple ranges rather than a single range
o RooMsgService
- Add concept of debug workspace and debug code to facilitate
debugging of complex problems
o RooGenContext
- Force use of Accept/Reject sampler for problems with observables where
the range depends on other observables as Foam cannot handle these
o RooDataSet
- Bug fix in handling of weights in append() operation
o RooAbsGenContext
- Add support for handling of explicit normalization range(s)
o RooAbsReal
- Bug fix in createIntegral(), avoid use of strtok() due to possible recursive use
o RooAddPdf
- Large scale adjustment to code to be able to handle pdfs where
the normalization range of its observables is defined by
multiple ranges rather than a single range
o RooAbsPdf
- Add support for definition of multiple normalization ranges, with setNormRange()
as user front end
o RooAbsArg
- Fix bug in link state management: a state change to ADirty must be propagated to
all clients.
- Add maximum level argument to printComponentTree()
o RooRealIntegral
- Fine tuning of debug-level print messages
- Fix memory leak
o RooAddGenContext
- Add support for handling of multiple normalization ranges
o RooRangeBoolean
- New RooAbsReal implementation that returns 1 or 0, depending on another observable
having a value in a predefined range
o RooAbsIntegrator
- Fine tuning of debug-level printouts
o RooTreeDataStore
- Multiple bug fixes in handling of weighted data
o RooAbsOptTestStatistic
- Small changes to support operation with multiple normalization ranges
o RooArgSet
- Add utility method isInRange() that is forwarded to content
o RooGenProdProj
- Add new operation mode that does not factorize, which is needed for certain cases
with multiple normalization ranges
=== r33758, r33720 ===
o RooPoisson
- Fixes in internal generation code
o RooLogNormal, RooGamma, LinkDef1
- New classes contributed by Gregory Schott
Revision
29108 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Jun 19 14:44:57 2009 UTC (5 years, 7 months ago) by
wouter
File length: 60626 byte(s)
Diff to
previous 28963
o RooFFTConvPdf
- Minor adjustment to default caching policy for
convolution in non-observables
o RooAbsReal
- Fix bug in fillHistogram() in support for conditional observables
- Add support for conditional observables in createPlotProjection
(required for above bug fix)
- Add special method logEvalError() that processes messages received
from remote processes in a safe way (fixes SEGV in parallel fitting)
- Add recursion protected to logEvalError()
o RooFactoryWSTool
- Fix typo in printed message
o RooRealMPFE
- Fix bug in server-side code: remove spurious static declaration
of an iterator
- Use new specialized logEvalError() method to process error message
on client-side
o RooGlobalFunc
- Implement IntegratedObservables()
Revision
28963 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Jun 12 15:47:45 2009 UTC (5 years, 7 months ago) by
wouter
File length: 60627 byte(s)
Diff to
previous 28263
* roofit/roofit & roofit/roofitcore
- Update from dev/roostats branch
- Addition of RooMinimizer interface (from Alfio)
* roofit/roostats
- Minimal changes need to follow some code
changes in roofit/roofitcore
Revision
28263 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Apr 16 19:31:21 2009 UTC (5 years, 9 months ago) by
wouter
File length: 60602 byte(s)
Diff to
previous 28259
Fixes for MSVC7 compilation problems
o RooGlobalFunc
- Use specialized set containers in Conditional()
o RooProdPdf
- Adjust ctor to changes in Conditional
o RooCmdArg
- Fix bug in ctor
o RooFactoryWSTool
- Eliminate vector<RooArgSet> construction to save RooArgSets
in prod(). Rely on internal containers in RooCmdArg now.
Revision
28259 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Added
Thu Apr 16 16:21:16 2009 UTC (5 years, 9 months ago) by
wouter
File length: 60730 byte(s)
Update roofit/roofitcore and roofit/roofit with
RooFit v2.98 code from dev/roostats branch
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
enter a numeric revision.