Log of /trunk/roofit/roofitcore/src/RooFormula.cxx
Parent Directory
Revision
44507 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Jun 4 12:30:41 2012 UTC (2 years, 7 months ago) by
axel
File length: 12766 byte(s)
Diff to
previous 42171
Remove
using namespace std;
from Riostream.h, which has huge consequences for all of ROOT.
Riostream.h is now a simple wrapper for fstream, iostream, iomanip for backward compatibility; Riosfwd.h simply wraps iosfwd.
Because of templates and their inline functions, Riostream.h needed to be included in headers, too (e.g. TParameter.h), which violated the assumption that Riostream.h is not exposing its using namespace std to headers.
ROOT now requires R__ANSISTREAM, R__SSTREAM, which does not change the set of supported compilers.
Without "using namespace std", several identifiers are now prefixed by std::; e.g. roofit/* source files now have a using namespace std to keep their coding style.
TFile::MakeProject() now generates "using namespace std" to convert the CINT-style class names into C++ ones.
Revision
24278 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sun Jun 15 15:21:16 2008 UTC (6 years, 7 months ago) by
wouter
File length: 12648 byte(s)
Diff to
previous 23538
o RooMPSentinel WHERE RooGenContext RooLinearMorph RooHistFunc RooInvTransform RooFracRemainder
RooIntegrator2D RooGaussKronrodIntegrator1D RooFitResult RooFFTConvPdf RooHist RooFormula RooIntegrator1D
RooMCStudy RooGenericPdf RooIntegratorBinding RooMPSentinel RooImproperIntegrator1D RooExtendPdf RooInt
RooLinTransBinning RooLinkedList RooLinkedListElem RooGenCategory RooList RooGrid RooLinkedListIter
RooMCIntegrator RooHistPdf RooListProxy RooFormulaVar RooHistError RooLinearVar RooGenProdProj RooHashTable
- Upgrade inline documention: make sure that (almost) every member function has some descriptive comments, every
data member has a descriptive comment, make sure that each class has a description.
- Fix class description header so that it is correctly identified by THtml
Revision
23538 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Apr 24 21:02:00 2008 UTC (6 years, 9 months ago) by
wouter
File length: 10815 byte(s)
Diff to
previous 23134
Import changes from development branch
==== Date: Wed Feb 20 22:33:28 2008 =====
o RooRealSumPdf
- Do _not_ use normalization of RooAbsPdf input components
in numerator of RooRealSumPdf expression since it is
already explicitly occurring in denominator of RooRealSumPdf.
(Fixes wrong normalization reported by Tristan)
o RooObjCacheManager
- Register owner of cache with each cache elememt to
facilitate callbacks
o RooAbsCacheElement
- Add storage for pointer to owner of cache and
supply setOwner() function
o RooAbsPdf
- Use RooObjCacheManager callback mechanism to zero
'last used normalization' pointer in RooAbsPdf
when the cache-owned object pointed is about
to be deleted.
o RooAbsArg
- Make crc32 function static
o RooWorkspace
- Add CodeRepo nested class that allows to store C++ code
of RooAbsArg derived classes that are not in ROOT distribution
but are contained in workspace. When reading any missing
class, code is compiled on the fly allowing for transparent
reading of workspace object from file. Code is found in
location pointed to from TClass objects. Additional search
path for declaration and implementation files can be provided
to be able to handle non-trivial cases.
- Add WSDir nested class that represents information contained
in workspace as read-only TDirectory for easy interactive use.
Directory representation is created using makeDir() member function.
o LinkDef3
- Add nested classes in RooWorkspace
===== Date: Wed Mar 26 23:04:26 2008 =====
o RooProdPdf
- Fix typo in ctor documentaion
- Improve error message in expectedEvents() when no extendable p.d.f.s are found
- Implement getConstraints() function to retrieve constraint p.d.f terms from product
expression given set of observables and set of parameters to be constrained.
o RooMsgService
- Add PROGRESS message level between INFO and WARNING
- Add globalKill level for messages to be able to quickly eliminate all messages below
a given level without interfering with the stream structore of RooMsgService
o RooPrintable
- Implement new printing interface with more details control over items printed trhough contents enum
(multiple ORable options) and style of printing (inline, single line, (verbose) multiline) with style
enum (exclusive options).
- Introduce generic virtual functions for printing of name,title,value,arguments,
and extras of each object.
- Each class can overload the default contents used for all printing
uses (inline,verbose,standard) etc as well as the default printing style invoked by Print()
o RooPlot,RooGenContext, RooAbsRealLValue,RooDataSet,RooNameSet,RooCustomizer, RooAbsGenContext, RooAddModel,
RooFitResult,RooCurve,RooAbsAnaConv,RooHist,RooAbsReal,RooAbsCollection,RooAddPdf,RooTable,RooAbsData,
RooMappedCategory,RooFormula,RooFormulaVar,RooCatType,RooRealVar,RooAbsArg,RooAbsPdf,RooPlotable,RooRealIntegral,
RooAbsBinning,Roo1DTable,RooAddGenContext,RooGenericPdf,RooResolutionMode,RooAbsHiddenReal,RooMultiCategory,
RooAbsString,RooSetProxy,RooProdGenContext,RooConvGenContext,RooGenCategory,RooGrid,RooSimGenContext,
RooThresholdCategory,RooAcceptReject,RooSuperCategory,RooEllipse,RooNumIntConfig,RooAbsCategory,RooListProxy,
RooLinearVar,RooTreeData,RooTreeData
- Update to new RooPrintable interface
o RooGenContext,RooAbsGenContext,RooAddGenContext,RooProdGenContext,RooConvGenContext,RooSimGenContext
- Implement attach() function to simplify management of changing parameters during lifetime of context
o RooAbsRealLValue
- Eliminate inFitRange() warning message as it is gives too many false warnings when used with
parameterized ranges
o RooCustomizer
- Make owning of contents optional to simplify release of created components
o RooAbsReal
- Implement new evaluation error logging mechanism. Rather than passing zero p.d.f values, push error message with
details on a static stack (if logging is enabled by e.g. RooMinuit).
- Augment functionality of createIntegral: explicitly allow integration over ranges with bounds parameterized in
in terms of other integrated observables. Integrals of this type are automatically recognized and cast
as recursive integrals in case of >1-D integrals to integrate over requested phase space.
- Add createIntObj() helper function for above functionaliy.
- Eliminate a lot of commented out debug code from createPlotProjection()
- Modify fillHistogram(): when plot observables are cloned, explicitly interconnect clones again to facilitate
proper plotting of N-D integrals with entangled parameterized ranges
- Add ScaleFactor() argument to fillHistogram to control use of histogram density correction scale factor in Z-scale
of filled histogram
o RooProduction
- Fix bug for persistence
o RooRealMPFE
- Extend client/server protocol with message to retrieve RooAbsReal evaluation error log from server side and
merge with error log on client side
o RooRealVar
- Introduced concept of non-shared alternative binnings(ranges) required to accommodate RooParamBinning ranges
that cannot be shared across instances because of their client/server connection to other objects in p.d.f
expression trees. Modify setBinning to automatically recognize non-shareable binnings and divert those to
non-shared alternative binning container.
- Add setRange([const char*,] RooAbsReal&,RooAbsReal&) methods to simplify creation of parameterized ranges.
o RooAbsArg
- Introduce concept of owned components with addOwnedComponents() interface to be able to make any RooAbsArg
object own any number of others. This can be used to simplify the memory management of object trees
- Introduce prohibitServerRedirect mode that will trigger fatal assert if any server redirect is attempted
to thus configured object. Useful as debugging tool to track faulty copy constructors that leave clone
object tree unintentionally connected to the original object tree.
- Migrate fixed--name-field management tool from RooAbsReal to RooAbsArg. Used to accomplish regular
formatting in RooAbsCollection::printStream.
- Add concept of transient boolean attributes that are not tranferred on copy construction. Mostly useful
for debugging.
- Extend leafNodeServerList and treeNodeServerList to distinguish to types of leaf-nodes: strict leaf modes
in the sense of the client-server tree structure and 'physical' leaf nodes that do not recurse into
nodes that have isDerived()==kFalse. The latter corresponds to the original concept of leaf nodes / variables,
which the former mode, a new addition, explicitly exposes any shape servers contained in parameterized
ranges of variables.
- Fix logic error in recursiveServerRedirect: do not recurse into nodes that are in the replacement list themselves.
- Fix bug in printCompactTree(): value/shape clients were not always properly indicated.
- Add getAllConstraints() method that finds all RooProdPdfs in expression trees and harvest constraints from all
of these from the getConstraint() method
o RooAbsPdf
- Implement new evaluation error logging mechanism for negative p.d.f values and zero normalization integrals
- Add Constrain(const RooArgSet& pars) and ExternalConstraints(const RooArgSet& pdfs) arguments to fitTo() method.
The Constrain() method retrieves any constraints p.d.f. on parameters multiplied in any RooProdPdf in the normal
p.d.f expression and adds those to the likelihood that is minimized. Only constraints on the listed parameters
will be picked up. Multiple constraints per parameter may exist. The ExternalConstrains() argument implements
similar functionality except that provided external constraint p.d.f.s are added rather than internal constraints.
- Fix potentially fatal bug in print statement in getContext()
- Add new method createCdf() to create a cumulative distribution function from given p.d.f. Given a set of observables x,
the returned c.d.f is implemented in terms of a RooRealIntegral of p.d.f(x') over a parameterized range from [ 0 - x ].
o Roo1DIntegrator
- Improve error message
o RooRealIntegral
- Fix bug in calculation of shape dependencies on observables.
- Add handling of dependencies of integral value on values of objects representing parameterized ranges of
integrated observables.
o RooMCStudy
- Add Constrain(const RooArgSet& pars) and ExternalConstraints(const RooArgSet& pdfs) arguments to constructor.
In addition to passing these arguments to the fitTo() call of the fit stage, modify event generation as
follows: instead of sampling events from 'static' generator p.d.f, sample value of constrained parameters
from joint constraints p.d.f and sample observables at those parameter settings. Save the generator parameters
for each toy as these change per toy. Change the pull calculation such that it uses the per-event truth values
rather than the per-study truth value if constraints are used.
o RooAddition
- Fix bug in evaluate() related to persistence
o RooMinuit
- Enable/disable new evaluation error logging mechanism prior to and just after each MINUIT call.
- Print logged error messages, if any, in glue function
o RooProjectedPdf
- Fix important bug: normalization set should always include integration set for each configuration
o RooGlobalFunc
- Add definition of Scaling(),Constrain() and ExternalConstraints() helper functions
o RooUniformBinning
- Remove dedicated print function as it output is identical to that of the generic print function in RooAbsBinningx
o RooAbsBinning
- Add virtual methods isParameterized(),lowBound() and highBound() to be to detect and analyze parameterized binnings
through abstract interface
- Add isShareable() method to be able to separate shareable and non-shareable binnings in RooRealVar.
- Add insertHook() and removeHook() function to allow connection of possible proxies present in binning to
owning RooAbsArg.
o RooWorkspace
- Improve code import facility by introducing a class->file mapping step in the CodeStore to correctly handle cases where
multiple classes are defined in a single file.
- Add check that TClass interface actually yields file names.
- Only require default constructor to be present for non-abstract classes. It should be there for abstract classes as
well but current TClass::HasDefaultConstructor() method will not tell us.
o RooTreeData
- Improve renameVariable() method to not only rename the RooAbsArg branch buffer but also any TTree branches involved as well.
While the tree branch names are generally invisible to the user, having branch names that are different from branch buffer names
may cause branch naming conflicts in merge() that are not detectable as branch buffer naming conflicts.
o RooParamBinning
- New class implementing binning with low and high points defined by external RooAbsReal objects
o RooConstrainSum
- Helper class for RooAbsPdf to represent likelihood of collection of constraint p.d.f.s.
==== Date: Fri Mar 28 10:04:57 2008 =====
o RooRecursiveFraction
- Helper function for RooAddPdf that calculates recursive fraction
f1*(1-f2)*(1-f3) from a given set of plain fractions
o RooAddPdf
- Add flag to ctor to optionally interpret fractions as recursive fractions.
If activated it constructs the recursive fractions using RooRecursiveFraction
from the original fractions
o LinkDef3.h, Module.mk
- Add new class RooRecursiveFraction
==== Date: Tue Apr 1 22:42:19 2008 ====
o RooDataWeightedAverage
- New implementation of RooAbsOptTestStatistics that calculates data weighted
average of any RooAbsReal. This class serves as successor of RooDataProjBinding
that no longer complies with new optimization scheme.
o RooRealBinding
- Implement name() function for more useful error messaging in integration
o RooChi2Var,RooNLLVar
- Follow changes in base class
o RooAbsReal
- In plotOn() support binning flag in ProjWData(). Reimplement data-weighted projections
using new RooDataWeightedAverage class instead of RooDataProjBinding which does not
work with new generic function optimization scheme.
- Add support for NumCPU() argument
in plotOn() to facilitate multi-processor calculation of projections. Extend NumCPU()
argument to pass interleaving option in MP splitting mode of RooAbsTestStatistic
- Move fixAddCoefNormalization() and fixAddCoefRange() from RooAbsPdf to RooAbsReal
o RooAbsTestStatistic
- Generalize functionality: allow RooAbsReals as input arguments instead of RooAbsPdfs only.
Also add virtual globalNormalization() function that allows to apply a global normalization
term after combinedValue() operation to facilitate functionality of RooDataWeightedAverage.
- Add option to split data in multiprocessor mode in interleave mode instead of in bulk mode.
Interleave mode is useful for parallel processing of histogram data where bulk partitions
may not contain equal amount of non-zero data points leading to non-optimal load balancing
between processes.
o RooAbsPdf
- Move fixAddCoefRange() and fixAddCoefNormalization to RooAbsReal to support operation of
new generalized RooAbsTestStatistic
o RooIntegrator1D
- Use name() of RooAbsFunc() to clarify warning and error messages.
o RooRealIntegral
- Rename _operMode to _intOperMode to avoid shadowing of equally named data member in RooAbsArg
- Fix bug in recursive printing
o RooSetProxy
- Fix bug in print()
o RooGlobalFunc
- Modify ProjWData() and NumCPU() helper functions with extra optional argument
o RooAbsOptTestStatistic
- Follow changes in RooAbsTestStatistic
o RooAbsFunc
- Add virtual name() function to facilitate better error and warning messages from integrators
=== Date: Tue Apr 15 17:57:32 2008 ===
o RooMsgService
- Add option to prefix streamed messages with process ID to simplify
debugging of parallel fits
o RooAbsProxy
- Add optional addContents flag to print()
o RooArgProxy, RooSetProxy, RooListProxy
- Implement addContents flag in print()
o RooAbsReal
- Reimplement stack of logged error messages in terms of custom EvalError class.
A separate list<EvalError> is now kept for each object that reports an error.
In addition to the given error message a record is constructed of the proxy
values at the time of reporting.
- In printEvalErrors() add option to restrict number of reported items per node.
If number is zero, only number of errors per node is shown (without details)
o RooRealMPFE
- Adjust ReportErrors message to changes EvalError implementation in RooAbsReal.
- Make sure to synchronize remote error logging state with state of parent process
before each evaluate()
o RooRealVar
- Move printing of error from printValue() to printExtras()
o RooNLLVar
- Fix bug in setting of interleave parameter of base class in certain ctors
o RooAbsPdf
- Improve passing of eval error messsages by make separate messages for NaN
and negative values and including details in the error message
- Add PrintEvalError(Int_t nErr) option to fitTo() to control new eval error
message control system
- Int printValue show both value (raw from evaluate()) as well as most recently
used normalization value (if available)
o RooMinuit
- Interface new eval error logging control by adding setPrintEvalErrors(Int_t numEvalErrors)
=== Date: Thu Apr 24 15:11:59 2008 ===
o Various classes
- Fix all -Wshadow compiler warnings
=== Date: Thu Apr 24 16:32:21 2008 ===
o RooMsgService
- Use TSystem::GetPid() rather than getpid() for portability
o RooAbsReal
- Make nested class EvalError public
o RooWorkspace
- Fix windows compiler warning
========================================
o RooBanner
- Increment version tag to 2.40
Revision
20161 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Oct 1 16:28:25 2007 UTC (7 years, 3 months ago) by
wouter
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 10660 byte(s)
Diff to
previous 19826
o RooAbsCache
- New abstract base class for cache objects associated with RooAbsArgs.
Caches register themselves with the owning RooAbsArg and propagate
all necessary state changes and meta information to objects in the cache
o RooCacheManager
- Concrete template implementation of RooAbsCache with an interface
and functionality styled after RooNormListManager. The template class
provide no special handling for cache contents that includes RooAbsArg
objects and does not forward hook calls. It is thus mostly intended
to cache basic types indexed on a normalization/integration configuration
o RooObjCacheManager
- Class derived from RooCacheManager<RooAbsCacheElement> that implements
all proper call forwarding and handling of state and other meta information
to RooAbsArg objects embedded in the cache elements. To facilitate this
functionality the RooAbsCacheElement defines a pure virtual method
containedArgs() that must be implemented to expose its contents to
the cache manager. The default behavior on a serverRedirect hook is
to sterilize the cache. OperMode changes are not forwarded by default
to the cache contents as cached objects do not necessarily have the
same operation mode (e.g. if the cache contains an integral of its owner).
Any calls to optimizeCacheMode(), printCompactTreeHook(), and findConstantNodes()
are forwarded. Moreover, optimizeCacheMode() calls are remembered and
any objects inserted in the cache after such a call was received will be
optimized upon insertion in the cache
o RooAbsCacheElement
- Abstract base class for objects to be managed by RooObjCacheManager. Each
object must in addition to its payload implement the containedArgs()
member function that exposes the RooAbsArg object content to the manager
for processing. The argument passed to containedArgs() indicates the use
case for the returned list of objects, allowing the cache payload to
return different lists depending upon use. This is for most applications
not required.
o RooAbsCachedPdf
- Abstract base class derived from RooAbsPdf for p.d.f.s that implement
value caching in a grid over the entire domain of the observables.
The base class implements the overall caching logistics and manages
the RooDataHists and RooHistPdfs that respresent the cached contents.
Derived classes must inputBaseName() defined a unique name prefix for
all cache objects, actualObservales() and actualParameters() to
determined the actual observables and parameters given a set of
available observables and fillCacheObject() which should fill the
RooDataHist cache for a given obs/params configuration with the
p.d.fs values.
o RooAbsSelfCachedPdf
- Abstract base class derived from RooAbsCachedPdf that implements
all of the required logistics in RooCachedPdf and only require
derived classes from RooAbsSelfCachedPdf to implement evaluate().
Any class derived from RooAbsPdf can thus be trivially switched
to derived from RooAbsSelfCachedPdf and gain the caching functionality.
o RooCachedPdf
- Concrete class derived from RooAbsCachedPdf that implements
the caching of an externally provided p.d.f in the constructor.
o RooFFTConvPdf
- Concrete class derived from RooAbsCachedPdf that implement generic
numeric convolution of two input p.d.f.s using FFT technique
and convolution theorem. Actual FFTs are calculated by FFTW
through TVirtualFFT interface in ROOT. Present implementation only supports
convolution in one dimension, but this will be extended later
as there are no fundamental limitations in RooAbsCachedPdf nor FFTW.
o RooHistPdf
- Moved from RooFit to RooFitCore because it is used by caching classes
o RooProdPdf
- Use new RooObjCacheManager to store partial objects
- Fix memory leak (already patched in 15.0.14h)
o RooDataHist
- Use new RooCacheManager template to cache partial bin volumes
- Add new set(),setAllWeights() method to update current weight and all weights
respectively, for use in cached p.d.f.s
- Add sliceIterator() that iterates over all bins in a lower dimensional
slice of the dataset
o RooDataHistSliceIter
- Class derived from TIterator that implements the iteration
over a slice in a reduced number of dimensions in a RooDataHist
o RooMsgService
- Speed up processing of debug streams in cases where no debug streams are active
- add macros series oocoutX and oocxcoutX that allow to associate message with
a different object than *this
o RooRealBinding
- Interface new setValue method that allows value to be set outside default
domain, but inside given alternate named range. For use in numeric integrator
bindings
o RooAbsRealLValue
- Add new inRange() method with range name specifier to check against chosen
range instead of default range
o RooCmdConfig
- Fix dangling return pointer problem in decodeStringOnTheFly() method
o RooNameSet
- Fix bug in refoll()
o RooChi2Var, RooNLLVar
- Add processing of AddCoefRange() named argument
o RooConvCoefVar
- Hold p.d.f in proxy without value/shape state propagation to obtain
correct dependency of RooConvCoefVar through separate set proxy
with parameters that do have state propagation
- In getAnalyticalIntegral() ask for integration coefficient specific
to coefficient (following interface change in RooAbsAnaConv)
o RooEfficiency
- Follow interface change in RooCategoryProxy
o RooAbsAnaConvPdf
- Use new RooObjCacheManager to hold normalization and coefficient representations
- Extend getCoefAnalyticalIntegral() interface so that each coefficient
can have a separate integration configuration
- Modify makeCoefVars() such that it constructs the RooConvCoefVars with
actual dependents for each coefficients, rather than inserting dependencies
of any of the coefficients in each coefficient. This logic requires support
from the implementation class that is interface through a new member function
coefVars()
o RooAbsReal
- Add Boolean data member treeVar that indicates is value buffer is also
branch buffer of a tree. This information is already present in the RooAbsReal
but is relatively expensive to retrieve and is always needed in the inner
loop of data set operations. This extra member significantly speeds up operations
- Remove superfluous _norm[] token in name returned by integralNameSuffix() if
no normalization set is supplied.
- Add a fillDataHist() method that fills a given RooDataHist with a sampling
of the given function. Added for support of caching p.d.f.s
- Downgrading warning on non-dependent projection variables in plotOn() to
a debug level message
- Remove function optimizeDirty(),doConstOpt(),undoConstOpt(),findCacheableBranches()
findUnusedDatasetVariables() and findRedundantCacheServers() as part of reorganization
of optimization functionality.
o RooAbsCollection
- Use iterator semantics instead of vector semantics to process RooLinkedList
contents in assignment operator
- Add utility function contentsString() returning stl string with names
of contents
o RooAddPdf
- Rewrite cache management using new RooObjCacheManager that holds projection
integrals, range integrals and supplemental normalization lists
o RooAbsOptGoodnessOfFit
- Improve handling of normalization ranges and reference ranges for test statistics
containing RooAddPdfs. New named argument in fitTo() and RooNllVar::ctor() pass
reference range for fractions in RooAddPdf components that do not have an explicit
fixed definition already. Name all normalization ranges explicitly after the
subrange to which the're applied to avoid name clashes and conflicts if multiple
normalization ranges are involved.
- Rewrite informational messages through RooMsgService
- Implement new constOptimizeTestStatistic() function that signals all test statistic
components of a RooAbsArg expression tree to perform their constant term optimization
- Implement new optimizeCaching() driver function that changes default lazy-evaluation-with-caching
scheme to test statistic scheme where only parameters objects propagate state changes and
where all components that depend directly or indirectly on observables have lazy evaluation
disabled. Changes to p.d.f objects are delegated to RooAbsPdf::optimizeCacheMode(). Changes
to dataset are delegated to RooAbsData::optimizeReadingWithCaching()
- Implement new optimizeConstantTerms() function that is back end for constOptimizeTestStatistic
implementation.
o RooAICRegistry, RooNormSetCache
- Remove tracking of allocation cycles of RooArgSets as this scheme is superseded by
memory pool mechanism for RooArgSet allocation
o RooMappedCategory
- Follow interface change in RooCategoryProxy.
o RooRealMPFE
- Follow reorganization of optimization functionality: implement new constOptimizeTestStatistic
function for forwarding to slave processes.
o RooRealVar
- Add new setVal() function with range name to facilite setting of values that are outside
default range, but inside specified alternate range. Needed for numeric integration and
certain RooAddPdf coefficient projection.
o RooAbsArg
- Make state management functions public [is/set][Value/ShapeDirty](), setOperMode90
- Add static _flipAClean boolean to support setACleanAdirty() static method.
- Implement mechanism for registration of cache objects with base class RooAbsCache.
Forward all calls to operModeHook(), redirectServersHook(), optimizeCacheMode()
and printCompactTreeHook() to all caches for further processing
- Define constOptimize() function and provide default implementation that forwards
to all servers
- Implement optimizeCacheMode() function that puts expression tree in optimized
caching for test-statistics operations (only cache/lazy evaluate nodes that
do not (indirectly) depend on observables
- Implement findConstantNodes() function that identifies all nodes that depend
exclusively on constant observables and >0 observables that are eligible
for precalculation and caching in test statistics operations by
RooAbsOptTestStatistic::optimizeConstantTerms()
- Define constOptimizeTestStatistics that signal an expression tree that any
embedded test statistic objects should perform their constant term optimization.
Default implementation in RooAbsArg forwards call to all servers.
o RooAbsPdf
- Use new RooObjCacheManager to manage normalization integrals cache.
- Process new SumCoefRange() option in fitTo() that sets the coeffient
interpretation range for all embedded RooAddPdf objects of which
the interpretation range was not explicitly set
- Extend interface of fixAddCoefNormalizationSet(): add extra argument
that controls if AddCoef normalization set are forcibly overruled
for objects that already have an explicit range setting.
o RooRealIntegral
- Add some informational messaging through RooMsgService, rewrite existing ones
- Speed up numeric summations by precreating the involved RooSuperCategory
in the ctor rather than in evaluate().
- Fix bug in dependency insertion: explicitly require servers to be value
server to avoid pulling in fake dependents.
- Remove obsolete data members
- Implement new setACleanADirty() function that atomically flips state of
all AClean objects to ADirty for the duration of the integration step.
Replaces the much more expensive prepareACleanFunc() that did this
only for the objects involved.
- Process factorizing terms in integral only if the list is not empty
- Process Jacobian terms in integral only if the list is not empty
o RooAddGenContext
- Adapt to cache management chanches in RooAddPdf
o RooNumIntFactory
- Use STL classes for internal memory management
o RooSetProxyy
- Implement operator new() and operator() delete as required because
RooArgSet implements them
o RooAbsGoodnessOfFit
- Store and forward AddCoefRange information for embedded RooAddPdf objects
- Implement constOptimizeTestStatistic() and forward to components
o RooErrorVar
- Follow inRange() interface change in RooAbsRealLValue
o RooConvGenContext
- Adapt code to make it work with both RooAbsAnaConv objects and
the newly introduced RooFFTConvPdf
o RooMinuit
- Follow reorganization of optimization functionality
o RooProjectedPdf
- Store projection using new RooObjCacheManager
o RooGlobalFunc
- Add RooFit::SumCoefRange() named argument for RooAbsPdf::fitTo()
and RooNLLVar::ctor() and RooChi2Var::ctor()
o RooClassFactory
- Extend existing makePdf(),makeFunction and makeClass() functions
to also accept RooAbsCategory arguments, to accept an optional string
inserted as the return value expression inserted in the
evaluate() method of the class created, as well as as option string
specifying one or more analytical integrations of the given function
expression that will be advertised in the generated getAnalyticalIntegral()
code and implemented in the generated analyticalIntegral() code
- Add makeAndCompileFunction() and makeAndCompilePdf methods that
generate the code and immediate compile it through ROOTs ACliC interface.
These functions have a simpler interface because the list of arguments
of the function to be created can be specified as a const RooArgSet&
rather than a string with a list of names, thus making it easier
for on-the-fly definition of compiled objects.
- Add defineFunction() and definePdf() methods define and compile
a function/pdf using the above functions and immediately instantiate
an object of the given type passing the specified RooArgSet arguments
to the constructor of the object. These functions make a compiled
equivalent of RooFormulaVar based on the TFormula interpreter, i.e.
RooAbsReal* f = new RooFormulaVar("f","D(1-2w)",RooArgSet(D,w)) ;
becomes
RooAbsReal* f = RooClassFactory::defineFunction("f","D(1-2w)",RooArgSet(D,w)) ;
o RooAbsCategory
- Add Boolean data member treeVar that indicates is value buffer is also
branch buffer of a tree. This information is already present in the RooAbsReal
but is relatively expensive to retrieve and is always needed in the inner
loop of data set operations. This extra member significantly speeds up operations
- Construct explit clean name for TBranch name if node is cached, equivalent
to what is done in RooAbsReal. Needed because new constOptimizer can also
cache RooAbsCategory objects
o RooArgSet
- Implement operator new() and operator delete() to implement memory pool scheme
for RooArgSets. The goal of this implementation is to insure that two RooArgSet
pointers are _never_ the same. This allows to RooNormSet cache manager to safely
and quickly index integration and normalization configurations by evaluating
the contents of a RooArgSet only the first time it sees it.
o RooSimultaneous
- Implement caching of partial integrals using new RooObjCacheManager
- Following interface change in RooCategoryProxy ;
o RooAbsData
- Defined pure virtual methods optimizeReadingWithCache() and allClientsCached()
o RooTreeData
- Implement optimizeReadingWithCache() which determines given a p.d.f to be
evaluated and a list of the nodes that are cached for it, which observables
in the dataset are no longer required because they are either not an observable
of the p.d.f, or they exclusively feed nodes that are cached. Reading of these
observables is disabled through SetBranchStatus().
- Move allClientsCached() utility function here from RooAbsReal.
o RooCategoryProxy
- Remove const char*() conversion operator in favor of a const char* label() method
to remove possibly ambiguities in C++ math expressions involving category proxies.
o LinkDef3.h
- Add newly defined classes
Revision
13432 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Dec 1 16:10:20 2005 UTC (9 years, 1 month ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 10756 byte(s)
Diff to
previous 12298
o RooAbsAnaConvPdf
- Throw away cache of convCoef objects in serverRedirect (solves generator
problem reported by Gerhard)
- Follow interface change of getNormObj()
o RooAbsArg
- Add option pattern string argument to printCompactTree() that causes only
the components with names that match the pattern to be printed
- Add getCloningAncestors() utility function that returns list of pointers
to ancestors in the objects cloning history
o RooAbsGenContext
- Add auxiliary prototype variables to the _theEvent (solves generator problem
reported by Gerhard)
o RooAbsPdf
- Change getNormObj() to take both nset and iset argument so that it can
also cache fractional integrals. This is needed to support the use of
RooAddPdf objects in RooExtendPdf as fractional range intergrals of
RooAddPdfs cannot be represented as a ratio of two integrals in
a the restricted and full range divided by each other
o RooAbsReal
- Change const declaration in one of the createIntegral() declarations
o RooAddGenContext
- Follow interface change in RooAddPdf::updateCoefCache()
o RooAddPdf
- Pass both supplemental and regular normalization set to updateCoefCache() to
be able to deal with situations arising from using RooExtendPdf where the
former is a null pointer.
o RooConvGenContext
- Add auxiliary prototype variables in constructor to list of variables of model
and pdf.
- In initGenerator() resync observable lists _pdfVars and _modelVars to those
in the event that is passed to initGenerator(). Fixes generator problem reported
by Gerhard.
o RooExtendPdf
- Change way fractional integral factor is calculated in expectedEvents(): use
1-step createIntegral() procedure available through new getNormObj() interface.
This fixes a problem calculating the number of expected events in a range
of a RooAddPdf.
o RooGenContext
- Use createIntegral() interface to construct AcceptReject input function rather
than direct call of RooRealIntegral constructor.
o RooProdGenContext
- Small fix in handling of imported dependents in product parsing phase of generator context
o RooProdPdf
- Add forgotten handling of extended PDF term in selected constructors
o RooProduct
- Extend functionality so that product input terms can include RooAbsCategories as well
o RooRealVar
- Introduce concept of 'shared properties' among clones of RooRealVars. This simplifies
user handling of certain RooRealVar properties that are synchronous among all clones
of a RooRealVar. A simple demonstration:
RooRealVar x("x","x",-10,10) ;
RooRealVar* x2 = x->Clone() ;
x.setRange("signal",-1,1) ;
x2->getMin("signal") // returns -1 ;
x2->setMax("signal",5) ;
x.getmax("signal") // returns 5 ;
The sharing is explicitly through cloning and not by name, so two independently
created objects with identical names will not share properties. The sharing
of properties is retained throughout persistence and unpersistence of objects.
For now the definition of the named ranges has been moved into the
shared properties part of RooRealVar and simplifies certain common uses cases such as
RooRealVar x("x","x",-10,10) ;
RooRealVar y("y","y",-10,10) ;
// lots of code
RooAbsPdf* F ; // constructed somewhere
// more code
RooDataSet* D ; // constructed somewhere
y.setRange("signal",-1,1) ;
RooPlot* xframe = x.frame() ;
D->plotOn(xframe,CutRange("signal")) ; // RRV 'y' inside 'D' knows about "signal" through sharing
F->plotOn(xframe,ProjectionRange("signal")) ;
- Increment of RooRealVar schema version number from 2 to 4
- Explicit streamer of RooRealVar has been extended to be able to stream RooRealVar v3 objects
properly and automatically eliminate/reconnect multiple instances of identical shared property
objects that may have been created in ROOT persistence. The streamer is also capable of
reading in v1 and v2 RooRealVars for backward compatibility
o RooSimultaneous
- Modify behaviour of expectedEvents(): if index category is included in normalization set,
return sum of expectedEvents() of all components, otherwise return value of expectedEvents()
of currently selected p.d.f. (the 'old' behavior)
o RooSharedProperties
- Base class for implementation of shared property objects such as RooRealVarSharedProperty
used in RooRealVar. This class embeds a UUID that allows reconnection of multiple RooAbsArgs
to a single instance of a shared property in the unpersistance phase.
o RooSharedProperiesList
- Container class for RooSharedProperties objects that serves as repository for shared properties.
Concrete implementations of RooAbsArg that implement the shared properties concept, such as
RooRealVar, have a an instance of RooSharedPropertiesList as a static data member. This container
class owns all shared properties objects and performs their memory management through reference
counting and automatically eliminates duplicate copies of unique shared properties that many
occur on unpersisting objects
Revision
12298 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jul 12 15:43:07 2005 UTC (9 years, 6 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 10389 byte(s)
Diff to
previous 12082
o RooBanner
- Put version tag in separate string so that it can be easily
imported by make_roofit_installkit
o RooFormula
- Fix compiler error with ROOT3
o RooNumIntConfig
- Add non-const method getSection()
o make_roofit_installkit
- Add -bc flag to build installkit for ROOT3/ROOT4 by adding
appropriate MyConfig.mk and MyModules.mk make file fragments
- Import RooFit version tag from RooBanner
Revision
12082 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Jun 20 15:45:21 2005 UTC (9 years, 7 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 10336 byte(s)
Diff to
previous 12063
o RooBanner
- Update version number and copyright
o Many files
- Change <iostream> to "Riostream" to support compilation on platforms
that do not have iostream classes in namespace std
o RooAbsAnaConvPdf
- Fix bug in range integration in getAnalyticalIntegralWN()
- Change getCoefAnalyticalIntegral() signature to include rangeName in argument list
o RooAbsArg
- Add methods getObservables()/getParameters with const RooAbsData& argument
o RooAbsPdf
- Add support for Range(Double_t, Double_t) to specify fit range in fitTo()
- Migrate getMaxVal()/maxVal() to RooAbsReal [Gerhard]
- Fix bug in normalization of PDF projections over limited range: account for both
fraction of data in range and fraction of projection in range (calculation of latter
deferred to RooAbsReal::plotOn)
o RooAbsReal
- Migrate getMaxVal()/maxVal() from RooAbsReal [Gerhard]
- Add code in plotOn() to support normalization of PDF projections plotted in limited range
o RooAbsRealLValue, RooRealVar, RooErrorVar, RooLinearVar
- Change getBinning() so that it only creates a new binning on the fly if a newly added boolean argument
is true. Otherwise, return default binning
o RooAdaptiveGaussKronrodIntegrator1D, RooGaussKronrodIntegrator1D
- Declare prototypes for glue functions
o RooArgSet
- Fix readFromStream() and writeToStream() so that they are consistent with each other again for
both regular and scientific notation mode.
- Fix processing of include directives inside files in readFromFile()
- Suppress warning messages about ignored lines in files unless verbose flag is set. Add verbosity control
flag to readFromFile().
o RooCategory
- Support concept of ranges for categories as well through new member functions setRange(),addToRange(),
clearRange(),hasRange(),isInRange() and isStateInRange(). Ranges are named TLists containing a non-owned
subset of the possible RooCatTypes.
o RooCategoryProxy
- Make lvptr() const since it is.
o RooConvCoefVar
- Pass rangeName in getAnalyticalIntegral() to getCoefAnalyticalIntegral()
o RooPlotable, RooCurve, RooHist, RooEllipse
- Implement getFitRangeNEvt(Double_t, Double_t) that returns the number of events in the given sub-range.
o RooDataHist
- Fix bug using RooAbsData::plotOn --> using RooTreeData::plotOn
o RooGlobalFunc
- Add adjustNorm boolean argument to named argumentss Range()
o RooMultiCatIter
- Require that input is RooAbsCategoryLValue rather than RooAbsCategory.
o RooPlot
- Keep track of object that generated normalization event count in addition to event count itself.
This allows to later on calculate an event count in a limited range through getFitRangeNEvt(Double_t, Double_t)
o RooRealIntegral
- Support ranges in category summation in integration code.
o RooSimPdfBuilder
- Fix bug in unitarity constraint split of parameter in partial build: adjust formula for remainder fraction
so that it only uses the states that are actually built.
- Improve error handling
o RooSuperCategory
- Implement hasRange() and isInRange() functionality inherited from RooAbsRealLValue
o RooClassFactory
- New class that automatically generates code for PDFs and functions given a name and a list of argument names
o RooEffProd
- New class that implement product of PDF and efficiency function. Main feature is efficient implementation
of event generator in case input PDF has 'smart' event generator
o RooEffGenContext
- Generator context associated with RooEffProd
o Module.mk
- ROOT make file module needed to compile RooFit as part of ROOT
o make_roofit_installkit
- Script to package RooFit source as ROOT module for compilation with ROOT system
Revision
12063 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Jun 16 09:31:32 2005 UTC (9 years, 7 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 10384 byte(s)
Diff to
previous 11619
o RooFit.hh
- New global header file for compiler patches. Currently contains
single patch for SunOS imported from BaBar.hh
o All .cc files
- Include RooFit.hh as first header file
o RooAbsData
- Make all plotOn() methods public
o RooAbsProxy
- Include pragma to switch of VC++ warning C4355
"'this' : used in base member initializer list'"
which would otherwise be triggered on each proxy initialization.
(each proxy constructor _expects_ a base class ptr so the warning
is misleading)
o RooAdaptiveGaussKronrodIntegrator1D, RooDataHist, RooGaussKronrodIntegrator1D,
RooGraphSpring, RooMCIntegrator, RooPolyVar, RooTreeData
- Change pow --> TMath::power() to eliminate windows compiler warnings
o RooEllipse
- Change constant M_PI to TMath::Pi()
o RooGlobalFunc
- Change RooConst --> RooFit::RooConst as functions has been moved into namespace
o RooMath
- Add erf() and erfc() forwarder functions to TMath::Erf() and TMath::Erfc()
o RooRealConstant
- Move RooConst() function into namespace RooFit
o RooSimultaneous
- Remove one default parameter from implementation version of plotOn() to resolve
overloading ambiguity reported by AIX compiler
o RooTreeData
- Make nested struct PlotOpt public to avoid CINT access problems
o RooTruthModel
- Add explicit cast to fabs() of proxy as it gives warning in Windows C++
Revision
11172 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Feb 23 15:10:06 2005 UTC (9 years, 11 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 10304 byte(s)
Diff to
previous 11114
o All classes
- Migrate RooAbsArg::getDependents(),dependentOverlaps(),checkDependents(),recursiveCheckDependents() to
getObservables(),observableOverlaps(),checkObservables(),recursiveCheckObservables()
o RooAbsAnaConv
- Copy _convVar in copy ctor so that isDirectGenSafe() also works for copy constructed instances.
Use _isCopy instead of _convVar in declareBasis() to distinguish between original and copy constructed objects
o RooAbsArg
- Migrate RooAbsArg::getDependents(),dependentOverlaps(),checkDependents(),recursiveCheckDependents() to
getObservables(),observableOverlaps(),checkObservables(),recursiveCheckObservables(). Add old names
as forwarding functions to new names for backward compatibility
- Move cleanBranchName() and crc32() here from RooAbsReal
o RooAbsCollection
- Implement new InLine printing options as OneLine option without the newline at the end
- Upgrade printLatex() function to also take new Format() arguments with sub arguments
- Add Bool_t allInRange(const char* range) function that reports if all contained arguments
have values within the specified range
o RooAbsData
- Add plotOn() function that takes a RooLinkedList of RooCmdArgs
- Extend Double_t sumEntries() to take a cutSpec and a rangeSpec argument. If supplied
only the combined weight of entries meeting those criteria will be reported.
o RooAbsGoodnessOfFit
- Add verbose flag to constructor and make printing of informational messages conditional
to verbose flag being set
o RooAbsOptGoodnessOfFit
- Add verbose flag to constructor and make printing of informational messages conditional
to verbose flag being set
o RooAbsPdf
- Add fitTo() function that takes a RooLinkedList of RooCmdArgs
- Add support for Range(), PrintLevel() arguments in fitTo(). Support fitting composite
ranges by constructing composite NLLs using RooAddition.
- Implement named argument version of generate() supporting arguments ProtoData(), Extended(), Verbose() and NumEvents().
Copy support for protodata randomization for extended poisson over/under sampling from RooMCStudy
- Add named argument version of paramOn() supporting named arguments Label(),Layout(),ShowConstants(),Format(),Parameters().
This version also does not require an input data set to weed out observables: the normalization set from the frame is
used instead.
o RooAbsReal
- Add named argument version of createIntegral() function taking NumIntConfig(),NormSet() and Range() arguments.
Supports composite ranges through multiple Range() arguments
- Move algorithm to automatically generate name of integral in a given configuration to separate function integralNameSuffix()
- In plotOn() retire RangeWithVLine() named argument in favor of a separate VLines() argument.
- Move cleanBranchName(), crc32() functions to RooAbsArg
- Add verbose arguments to findCacheableBranches(),doConstOpt(),optimizeDirty(),findRedundantCacheServers() and findUnusedDataVariables()
and make printing of informational messages conditional on verbose flag being set.
o RooAbsRealLValue
- Add version of frame() accepting a RooLinkedList of RooCmdArgs. Add support for AutoRange(const RooAbsData&) and AutoSymRange(const RooAbsData&)
arguments that automatically calculate range that holds all points in given dataset with a specified margin. The latter function guarantees
a range symmetric around the mean of the distribution, unless domain limits of variable prohibit that.
- Add named argument version of createHistogram() taking Binning(), YVar() and ZVar() arguments where latter two arguments also take
optional Binning arguments
o RooChi2Var, RooNLLVar
- Add support for optional Verbose() argument in named argument constructor and pass flag to RooAbsOptGoodnessOfFit
o RooCmdArg
- Implement and interface linked list of sub-arguments. Add flag that controls if RooCmdConfig directly processes subarguments ot not.
- Implement assignment operator
o RooCmdConfig
- Add defineMutex() functions with 3, 4 arguments to facilitate definitions of many-way mutexes
- Add appendMode boolean to defineString(). If set, multiple instances of given string will be concatenated with
comma separattion, instead of multiple instances superceding each other.
- Add static function decodeStringOnTheFly()
o RooDataHist, RooDataSet
- Implement sumEntries() with cutSpec and rangeSpec arguments
o RooDataSet
- Add binnedClone() function
o RooFormula
- Add ifdef construction so that code compiles both with ROOT3 and with ROOT4
o RooGlobalFunc
- Move all global functions into namespace RooFit
o RooIntegrator1D
- Remove spurious debug print message
o RooMCStudy
- Add named argument constructor accepting arguments FitModel(),ConditionalObservables(),ProtoData(),Verbose(),Extended(),
FitOptions()
- Migrate function randomizeProtoOrder to RooAbsPdf
- Reimplement pull calculations using new class RooPullVar
- Add named argument function plotParamOn(). All named arguments are passed to RooAbsData::plotOn()
- Add named argument functions plotParam(),plotError(),plotPull(),plotNLL() taking arguments FrameRange(),
FrameBins(),Frame() and all arguments taken by RooAbsData::plotOn(). All sub arguments of Frame() are
passed to RooAbsRealLValue::frame(). Function plotNLL() takes additional argument FitGauss() that
adds Gaussian fit to plot. All methods default to AutoRange frames, except for plotPull() which
defaults to AutoSymRange()
o RooMinuit
- Suppress informational messages if printLevel is set to -1
o RooNumIntConfig
- Fix bug in printToStream() method
o RooPrintable
- Add InLine printing level. Implement default InLine method as OneLine method without the terminating newline character.
o RooProdPdf
- Reimplement makeRGGPName in terms of RooAbsReal::integralNameSuffix()
o RooRealIntegral
- Make RooAbsReal::getAnalyticalIntegral() return code supercede any information returned through anaSet to
avoid confusion.
o RooRealVar
- Add version of format() function that parses Format() named argument.
- Add setFitBins() function for backward compatibility.
o RooStreamParser
- Fix bug in putBackToken(): forgot to reinsert space to avoid collation with next token.
o RooTreeData
- Implement plotOn() function taking RooLinkedList of RooCmdArgs. Fix bug in determination
of default bin width if explicit binning is given. Add support for parsing of composite ranges.
- Add optional cutSpec and cutRange arguments to moment(),meanVar() and rmsVar() and rework
implementations to support this feature.
- Add named argument version of statOn() taking arguments Label(),Layout(),Format(),What(),Cut(),CutRange().
- Add getRange() function returning highest and lowest value of given variable in dataset.
o RooAddition
- New Utility class that inherits from RooAbsReal that represents a sum of RooAbsReal objects, or
a sum of products of RooAbsReal objects (when constructed with two RooArgLists). Can optionally
own components and is suitable for use with RooMinuit as it passes the errorLevel() definition
of its components
o RooPullVar
- New utility class that inherits fro RooAbsReal that calculates the pull of one RooRealVar
(with errors) w.r.t. another RooRealVar representing the truth value. If asymmetric errors
are defined in the former RRV those will be used for the pull calculation.
Revision
11114 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Feb 14 20:44:30 2005 UTC (9 years, 11 months ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 10250 byte(s)
Diff to
previous 10648
o RooNameReg
- Registry for unique string name IDs. Converts a 'const char*' string into
a unique 'const TNamed*' and back. General purpose utility to to map
string identifiers to unique 32-bit numbers
o RooAbsReal
- In getAnalyticalIntegral(WN) and analyticalIntegral(WN) add extra argument
const char* rangeName to identify range over which integration should
be performed
o All RooAbsReal derived classes
- Modify getAnalyticalIntegral(WN) and analyticalIntegral(WN) to follow
change in RooAbsReal. Pass rangeName argument to min() and max() functions
of RooRealProxy to retrieve requested range instead of default range
o RooAbsArg
- Add virtual inRange(const char* rangeName) member function.
o RooAbsCategoryLValue
- Name change get/setFitBin() --> get.setBin(), numFitBins() --> numBins()
getFitBinWidth --> getBinWidth
o RooAbsCollection
- Add printLatex() method for formatted LaTeX printing of lists.
Supports named arguments Columns() to change number of columns,
Format() to change printing format, OutputFile() for printing
directly to file and Sibling() to print along side on or more other lists.
o RooAbsData
- Sanitize plotOn() arrangement: just keep version with RooCmdArg arguments
- Add optional rangeName argument to fillHistogram
o RooAbsGenContext
- Pass normalization set to expectedEvents() to support calculation of
fractional intergrals in extended term (e.g. in RooExtendedPdf)
o RooAbsLValue
- Name change: setFitBin(),getFitBin(),numFitBins(),getFitBinWidth() -->
setBin(),getBin(),numBins(),getBinWidth()
o RooAbsOptGoodnessOfFit
- Follow name changes in RooAbs(Real)Lvalue
o RooAbsPdf
- Modernize syncNormalization by using createIntegral internally
- Add getNormObj() function that returns const RooRealIntegral*
pointer to specified normalization integral. Takes optional
rangeName argument for calculation of fractional integrals.
- Sanitize plotOn(). Only keep version with RooCmdArgs public.
Move implementation version in protected interface. Replace
way too long list of arguments with new internal
helper class RooAbsPdf::plotOpt, whose constructor sets all
the default options.
- Change expectedEvents() and extendedTerm() function signature to
take normalization set argument that can be used to calculated
normalization-dependent fractional integrals (e.g. in RooExtendedPdf)
- Migrate named argument global helper functions for plotOn() to RooGlobalFunc.cc
o RooAbsReal
- Modify createIntegral() method to take optional rangeName argument.
- Sanitize plotOn() and plotAsymOn(). Only keep version with RooCmdArgs public.
Move implementation version in protected interface. Replace
way too long list of arguments with new internal
helper class RooAbsPdf::plotOpt, whose constructor sets all
the default options.
- Migrate named argument global helper functions for plotOn() to RooGlobalFunc.cc
- Add Name() feature to plotOn() to give chosen name to resulting RooCurve
- Add ProjectionRange() feature to plotOn() -- Project PDF only over limited
range as specified by range name to show finite width slices
in projection dimensions
- Add Invisible() feature to plotOn() which stores curve invisibly in
RooPlot.
- Add AddTo() feature to plotOn() which adds curve to existing curve
in Rooplot.
o RooAbsRealValue
- Name change get/set/hasFitMin/Max() --> get/set/hasMin/Max() etc.
o RooAcceptReject
- Follow changes in RooAbsRealLValue
o All numeric integrator engines
- Add "#include RooArgSet.hh" to compensate for removal of stray include in RooCmdConfig.hh
o RooAddPdf
- Add feature to fix interpretation of fractional coefficients in particular reference range
that can be different from default range
o RooChi2Var
- Migrate named argument global helper functions for constructor to RooGlobalFunc.cc
o RooCmdConfig
- Modify defineObject() to also be able to process arrays of objects
- Add process() method with 8 RooCmdArg arguments
- Modify getString() so that it can optionally return an empty string as a null pointer
o RooConvGenContext,RooConvIntegrandBinding
- Follow name changes in RooAbsRealLValue
o RooCurve
- Add constructor that takes two existing curves and two weights. New curve is construction
for OR set of points that define both input curves. Points on one curve that do not exist
on the other are calculate using interpolation.
o RooDataHist, RooDataSet
- Sanitize plotOn() functions
- Follow name changes in RooAbsRealLValue
o RooErrorVar
- Follow name changes in RooAbsRealLValue
o RooExtendPdf
- Completely rewrite using newly introduced fractional integral technology. Change
constructor to take optional const char* rangeName argument to denote restricted
range for expectedEvents() interpretation.
o RooFitResult
- Follow name changes in RooAbsRealLValue
o RooFormula
- Add new interface to make it work with ROOT version 4 as well as ROOT version 3
o RooGenProdProj
- Make it work with optional restricted integration ranges as well
o RooHist
- Add constructor that constructs RooHist from two existing RooHists. Both input
RooHist must have identical structure. In Poisson mode error is recalculated for
total number of events in each bin. In SumW2 mode errors of input RooHists are
combined.
o RooMCStudy,RooMinuit,RooNLLVar
- Follow changes in RooAbsRealLValue and RooAbsPdf::expectedEvents().
o RooNormManager,RooNormListManager,RooNormSetCache
- Make managers aware of range names that are associated with integral definitions.
o RooPlot
- Add optional argument to addPlotable(),addObject(),addTH1() functions to add
given object invisibly.
- Modify updateFitRangeNorm() to optionally refresh the normalization event count
even if it has already been set
- Add getObject() method that identifies object by index rather than by name
- Add internal RooPlot::DrawOpt class that conversion ROOT draw options and
RooPlot options from and to a const char* string.
o RooProdPdf
- Make it work with integrals over restricted ranges
o RooRealAnalytic, RooRealBinding
- Take optional rangeName argument in constructor that modifies output
of getMin() and getMax() functions
o RooRealIntegral
- Take optional rangeName argument in constructor and pass it to analytical integrals
and numeric integrators.
o RooRealProxy
- Modify min() and max() functions to take optional rangeName argument
o RooRealVar
- Follow name changes in RooAbsRealLValue
- Implement getFit*() functions for backward compatibility.
- Augment format() with extra LaTeX formatting options used
in RooAbsCollection::printLatex()
o RooTObjWrap
- Modify so that it can also store lists of objects in addition to single objects
o RooTreeData
- Sanitize plotOn() and plotAsymOn(). Only keep version with RooCmdArgs public.
Move implementation version in protected interface. Replace
way too long list of arguments with new internal
helper class RooAbsPdf::plotOpt, whose constructor sets all
the default options.
- Add Name() feature to plotOn() to give resulting RooHist chosen name
- Add XErrorSize() feature to plotOn() to explicitly control size of X error bars
- Add Invisible() feature to plotOn() to be able to store RooHist invisible to RooPlot
- Add AddTo() feature to plotOn() to be able to add RooHist to an existing RooHist
in RooPlot
- Add RefreshNorm() feature to plotOn() which causes normalization event count in RooPlot
to be refreshed with event count from this plot operation
- Add optional rangeName argument to fillHistogram()
o RooGlobalFunc
- Move all global helper functions that create RooCmdArg named arguments here
- Additionally create short-hand helper functions C(), L() and S() respectively
that create a RooConst, a RooArgList and a RooArgSet. These shorthand functions
are stored in namespace RooFitShortHand and thus not by default available
in the global namespace
Revision
10648 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Nov 29 20:24:44 2004 UTC (10 years, 1 month ago) by
wverkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 10073 byte(s)
Diff to
previous 10638
o All Classs
- Remove '#include BaBar/BaBar.hh' that was erroneously
introduced by the BaBar IOstream migration utilities
o Several class
- Initializion order changes, removal of unused variables,
addition of missing return statements to make all code
compile cleanly with '-Wall -Wno-parentheses'
o RooAbsFunc
- Make resetNumCall() const
o RooAbsIntegrator
- Add calculate() method that wrape integral() between
profiling code the track the number of integrand
function calls
o RooIntegrator1D,RooImproperIntegrator1D,RooSegmentedIntegrator1D,
RooSegmentedIntegrator2D,RooMCIntegrator
- Change interface to take RooNumIntConfig class instead
of now deprecated RooIntegratorConfig class
- Add member function that advertise capability of the integrator:
canIntegrate1D,2D,ND,OpenEnded()
o RooAbsReal
- Change normalization integral management classes
(createIntegral(), (set)defaultIntegratorConfig(),
(set)specialIntegratorConfig()) to work with new
RooNumIntConfig class.
o RooArgSet
- Add new convenience functions get/setRealValue(),
get/setCatLabel/Index(), get/setStringValue() to
manage common content of RooArgSet.
o RooConvCoefVar, RooConvGenContext
- Support class name change RooConvolutedPdf -> RooAbsAnaConfPdf
o RooCustomizer
- Add function setCloneBrancSet() that allows to specify
an external set that takes ownership of the cloned branch
nodes so that customized objects can live beyond the lifetime
of the RooCustomizer instance
o RooImproperIntegrator1D
- Add code to handle limit scenario changes (closed to open ended
and vice versa) on the fly
o RooIntegrator1D
- Add fixSteps option to terminate integral calculation after
fixed number of steps w/o extrapolation. This is more robust
for certain types of integrals
o RooRealIntegral
- Change interface to take RooNumIntConfig class instead of
RooIntegratorConfig class
- Delegate instantiation of numeric integration engines to
new class RooNumIntFactory
o RooNumIntConfig
- New class to store configuration of numeric integator engines.
This class has a brief common section with common properties
like absolute and relative precision convergence criteria,
and a section with implementation specific details for each
engine in the form of a RooArgSet. The default settings for
each existing engine are automatically added to the defaultConfig()
instance during run-time initialization
o RooNumIntFactory
- Factory class for numeric integration engines. Each existing
integrator engine automatically registers with the factory
stating its capabilities (1D,2D,ND / Open-ended). The
createIntegrator() function instantiates an integrator
appropriate for a given problem. In case more than one
integration engine can solve the given problem the (user
changable) information in the RooNumIntConfig passed along
with the call is used.
o RooGaussKronrodIntegrator1D
- New integrator engine based on Gaussian quadrature techniques.
This implementation, taken from GSL 1.5 implements the Gauss-Kronrod
techniques where the error on the integral is take from the difference
between the Gauss and Kronrod techniques. These techniques share common
sampling points allowing to calculate the error without additional cost.
This integrator applies the 10,21,43, and 87 point rules in succession
until the desired accuracy is reached. Open-ended integrals are
automatically handled through a x -> 1/x coordinate transformation
o RooAdaptiveGaussKronrodIntegrator1D
- New integrator engine based on Gaussian quadrature techniques.
This implementation, taken from GSL 1.5 implements the Gauss-Kronrod
techniques where the error on the integral is take from the difference
between the Gauss and Kronrod techniques. These techniques share common
sampling points allowing to calculate the error without additional cost.
This integrator applies the 10,21,31,41,51 or 61 point rule and
recursively subdivides the integration domain until the desired accuracy
is reached. For integrands with integrable singulaties the Wynn epsilon
rule can be selected to speed up the converges of these integrals. Open
ended integrals are automatically handles through a x -> 1/x
coordinate transformation
o RooNumConvPdf
- New operator PDF class that implements numeric convolution of
any two PDFs. The calculation of the convolution integrand
is implemented in the auxiliary class RooConvIntegrandBinding,
which in turn can be integrated with any 1-D numeric integration
engine. The default integration method for convolution integrals
is the adaptive Gauss-Kronrod method, which appears to give the
most stable results. By default the integration is performed
from -inf to +inf, but can optionally be restricted to a sliding
window using the setConvolutionWindow class, useful for relatively
narrow resolution PDFs.
o RooAbsAnaConvPdf
- New name of RooConvolutedPdf to clearly distinguish its functionality
from RooNumConvPdf
Revision
5317 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Sep 17 06:39:35 2002 UTC (12 years, 4 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 10022 byte(s)
Diff to
previous 5212
o RooAbsPdf, RooAbsReal, RooDataHist, RooTreeData
- Changed protected plotOn() to accept RooLinkedList instead of TList
o RooCmdConfig
- Change process(),stripCmdList to use RooLinkedList instead of TList
o RooFormula
- Changes all internal lists to RooLinkedList (was TList, TObjArray)
o RooHashTable, RooLinkedList, RooLinkedListElem, RooLinkedListIter
- Change interface from RooAbsArg to TObject
o RooHtml
- Update copyright, web address etc
o RooRefCountList
- Inherit from RooLinkedList instead of THashList
o RooSimultaneous
- Fix handling of RooCmdArgLists & change protected plotOn() interface from
TList to RooLinkedList
o RooTrace
- Fix include files
o makedocs
- Set default to production color scheme
Revision
3150 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Nov 1 22:52:22 2001 UTC (13 years, 2 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 8598 byte(s)
Diff to
previous 3141
o RooAbsPdf
- In getVal() without normalization change to use
evalTracePdf instead of evalTrace (obsolete)
o RooAbsReal
- Change signature of static method createHistogram()
to take non-const RooArgList& as argument to avoid
overloading ambiguity with non-static createHistogram()
with RooAbsReal& in same slot.
- Fix asymmetry plotting. Relative normalization of positive
and negative component of functions asymmetry was not
properly accounted for
o RooAbsString
- Change internal storage mechanismg from char[1024]
to a heap based char array. Length can be specified in ctor
o RooArgSet
- Support input file sectioning in readFromFile()
o RooCustomizer
- Minor adjustment in verbose output
o RooDataSet
- In read(). wllow space in addition to ',' as separator between
file names
o RooFormula
- In DefinedVariable(), check that for objects of type 'cat::state'
the given state is actually defined in cat.
o RooSimPdfBuilder
- Use new custom string length of RooStringVar in various places
o RooStreamParser
- Change code to handle string tokens of more than 1024 chars
- Fixes in EOF detection logic
Revision
3141 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Oct 31 07:19:31 2001 UTC (13 years, 2 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 8029 byte(s)
Diff to
previous 3124
o RooAbsArg
- In redirectServers, propagate nameChange flag to redirectServersHook()
o RooArgList
- Suppress warning about extra EOL characters in readFromStream()
in non-verbose mode
o RooFormula
- Add nameChange flag to changeDependents() and process accordingly
o RooFormulaVar,RooGenericPdf,RooResolutionModel
- Change redirectServersHook() function to accept nameChange flag
and process accordingly
o RooPlot
- change findObject(),getAttLine(),getAttFill(),
getAttMarker(),getAttText() to accept null ptr as
object name string. In such case the object/attribute
of the last added object will be returned.
o RooRealIntegral
- Remove obsolete redirectServersHook() function
o RooResolutionModel
- Overload printToStream() to print out basis function details
in verbose mode
o RooTreeData
- In table() set name of table to '<dataset_name>(<cut_spec>)'
instead of "dataset"
o RooTruthModel
- Adapt to implement new set
of 9 (exp/sin/cos) X (plus/minus/sum) basis functions
Revision
3124 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Oct 27 22:28:23 2001 UTC (13 years, 2 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7975 byte(s)
Diff to
previous 3067
A large number of small fixes and improvements
o Roo1DTable
- Modify Print() behaviour. Standard print will
only show non-empty fields, verbose shows all fields
o RooAbsArg
- Change getParameters so that it can accept 0 as
dataset pointer (implies no dependents)
o RooAbsPdf
- Follow plotOn() changes in RooAbsReal
o RooAbsReal
- Add optional const RooArgSet* projData argument to
plotOn(). Projected dependents that appears in this
dataset, if specified, will be projection via summation
over data instead of integration.
- Add clipInvalid option to bindVars() and propagate to
RooRealBinding
- Modify cleanBranchName() to truncate 'clean names'
(which are used for the TTree branch) to 63 chars
as cannot handle such cases (SEGV). In case name
is longer than 63 chars, truncate name at 46 chars
and suffix with _crc followed by hex representation
of CRC32 checksum of the full name.
- Add crc32() method to calculate the checksum of a string
o RooAddModel,RooAddPdf
- Do not evaluate PDF components multiplied by a zero coefficient
o RooAddPdf
- Fix DIV0 in analyticalIntegral if number of expected events
for all PDFs combined totals zero
o RooArgSet
- Add ability to readFromStream and readFromFile to optionally
flag read arguments with a user specified attribute
(Mostly useful to determine which elements have _not_ been read)
o RooConvolutedPdf
- Change declareBasis() signature from a RooArgSet& to a RooArgList&
to correctly handle cases where the names of parameters are identical
(e.g. tau=zero and dm=zero for prompt background models)
- Expand logic in RooGenContext. Add additional requirement for
use of optimized generator context: both the physics pdf and
the resolution model must support direct generation of the
convolution variable.
(Still have to fix RooAddModel/Pdf for cases where all components
can do direct generation)
o RooCurve
- Deploy RooRealBinding::clipInvalid feature to zero plotted functions
outside the validity range of their dependents
- Add extra points at (xlo,0) and (xhi,0) to obtain correct filling
pattern when using the 'F' draw option.
o RooCustomizer
- Add warnings for multiple split or replace rules on the same leaf
o RooDataSet
- Make read() take a const RooArgList& instead of a RooArgList&
and immediately make temporary copy for internal use.
- All constructors with string based cut: add default empty cut.
o RooFitContext
- Ctor: Compare limits on dependents in PDF and dataset if limits
of PDF are smaller and fully contained in those of the dataset,
adjust the dataset ranges in the internal copy and reject events
outside the PDF limits. If PDF ranges are not identical or fully
contained in dataset limits, give error message and abort.
- In fit() fix handling of parameters handed to TMinuit: set pmin/pmax
to the parameter value for constant parameters. For floating parameters
with open limits and without error, use 1/10 of the plot range
instead of 1/10 of the fit range.
o RooFormula,RooFormulaVar
- Change RooArgSet to RooArgList to pass formula parameters.
This allows construction of formulas with ordinal references
for list of parameters with multiple occurrences of the same
variable.
o RooRealBinding
- Add clipInvalid option, specified in ctor. If set, loadValues()
will first check if the values to be loaded are in the limits
of the bound objects dependents. If not the values are not loaded
and an invalid flag is set. If the invalid flag is set operator()
will return 0.
o RooRealVar
- Add various 'named parameter' functions on a trial basis
o RooSimFitContext
- Gracefully handle RooSimultaneous PDFs with missing PDFs.
o RooSimGenContext
- Forgot to set index state in theEvent RooArgSet when generating
the index category
- Remove forced normalization of index state in evaluate()
- Remove dummy plotOn() method and specialized plotOn() with data
method as projection over the index state can now be handled
the regular plotOn method. Overload RooAbsPdf::plotOn to
force caller to specify projection dataset for the index category
if projection over the index category is requested
o RooTable
- Remove print(), add default Print(Option_t *), and reimplement
printing via inheritance from RooPrintable
o RooTreeData
- In loadValues(RooTreeData*) explicitly check isValid() of
each element of _vars after copying. If any is invalid,
reject the event.
- In table() change simple clone of tableVar to deep clone.
Implement use of optional cut string (accidentally omitted sofar)
o RooTruthModel
- Add highly trivial direct generator for the convolution variable
o RooDataProjBinding
- New lightweight binding between an RooAbsReal and a dataset
that returns the projection of the real over the dataset
via summation. If the dataset only contains category variables
an supercategory of all the datasets categories is created
and the data is summed (with appropriate weights) over the
supercategory states instead of over every event.
Revision
3067 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Oct 19 06:56:53 2001 UTC (13 years, 3 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7938 byte(s)
Diff to
previous 3048
o RooAbsArg
- Introduce static variable and function nameFieldLength()
that controls size of the name field when printing
in standard print mode. Default(0) makes field fit
name of object
- Introduce universal value assignment via virtual
operator=() to Double_t, Int_t, const char*.
Default implementation in RooAbsArg results in user
error message.
- Extend createFundamental() to optionally take a new name
as argument
- Add new pure virtual fillTreeBranch() method in which
subclasses must implement a method to fill their branches
in the given tree with their current value
o RooAbsCategory,RooAbsReal,RooAbsString
- Implement fillTreeBranch()
- Adjust createFundamental()
o RooAbsCollection
- Fix replace() to find correct replacement candidate if >1
object exists in list with name of variable to be replaced
- In printToStream() adjust RooAbsArg::nameFieldLength()
to size of longest argName contained in list
o RooAbsData
- Fix default ctor to instantiate unpersisted data members
o RooArgList
- Add operator[] taking index as argument, returning a
RooAbsArg&. If index is out of range, a softAbort() is
generated
o RooArgSet
- Add operator[] taking arg name as argument, returning a
RooAbsArg&. If index is out of range, a softAbort() is
generated
o RooErrorHandler
- New lightweight class implementing softAssert()
and softAbort() that will terminate processing
but not kill the root session.
o RooCustomizer
- Make inherit from RooPrintable and implement Print() method
o RooDataSet
- Add self to gDirectory() in every ctor to facilitate persistence.
Remove internal ttree from gDirectory to avoid unnecessary entries.
o RooFormula
- Disable conditional compilation pending investigation of some
obscure problems
o RooRealVar
- Add static functions printScientific() and printSigDigits()
that control formatting in print() and writeToStream().
- Augment format() to be able to print both value and error
with specified precision (instead of always using the precision
from the error when its printed)
o RooStreamParser
- Process continuation line sequences '\\' in readLine()
o RooStringVar
- Implement operator=(const char*)
o RooTreeData
- Change cacheArg() and cacheArgs() to use new column adding
technique implemented via fillTreeBranch()
- Change addColumn() and to use new column adding
technique implemented via fillTreeBranch().
Add new addColumns() member to do multiple columns at once.
Revision
3048 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Oct 17 05:04:00 2001 UTC (13 years, 3 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7912 byte(s)
Diff to
previous 3025
Efficient generation of convoluted variables
--------------------------------------------
o RooConvGenContext
- New generator context that generates physics
model and resolution model separately and returns
the smeared result
o RooConvolutedPdf
- Overload genContext() to use the new efficient
generator scheme if both resolution model and
and physics model support direct generation
of the convolution variable and the resolution
model has no other dependents
- Add protected changeModel() function to allow
RooConvGenContext to change present model on the
fly.
o RooGenContext
- Add option to force consideration for direct generation
of a given set of dependents. Used by RooConvGenContext
to force direct generation of convolution variable when
convoluted with the truth model
o RooTruthModel
- Hand code the 6 basis functions used for B mixing
and decay as special cases. (Significant speed gain)
o RooResolutionModel
- In convolution(), swicth from RooAbsArg::findServer(0) to
RooFormulaVar::getParameter(0)
Collection Storage / General stability improvement
--------------------------------------------------
o RooAbsCollection
- Switch to use RooLinkedList instead of THashList as
internal storage mechanism
o RooLinkedList,RooLinkedListElem,RooLinkedListIter
- New efficient implementation of a linked list
that doesn't try to access it's members when
removing them (nor does any other funny & illegal
things that all TList subclasses can't seem to stop doing)
Miscellaneous fixes
-------------------
o RooAICRegistry
- Fix copy ctor (clone owned RooArgSets)
o RooFormula
- Introduced delayed compilation of TFormula:
formula is compiled only when value is requested
for the first time. (Efficiency gain for RooFormulaVars
used as basis function, which are often not evaluated
at all)
o RooAbsReal
- Fix erroneous warning message in makeProjectionSet()
o RooAcceptReject
- Delete cache in ctor!
o RooListProxy
- Bug fix: overload addOwned()
Revision
3025 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Oct 13 21:53:22 2001 UTC (13 years, 3 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7687 byte(s)
Diff to
previous 3012
Fix coding errors and memory leaks found by
CodeWizard, Insure++ and Chaperon such as
- Omitted tests for self assignment in operator=
- Iterators and cloneSets not deleted
- delete[] instead of delete
- Classes with virtual member functions w/o virtual dtor
Revision
3012 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Oct 11 01:28:51 2001 UTC (13 years, 3 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7792 byte(s)
Diff to
previous 2995
o RooAbsArg
- Extend dependsOn() methods with optional ignoreVar
RooAbsArg argument, which will be ignored in the
dependency determination.
o RooAbsCollection
- Introduce safeDeleteList() method that attempts
to delete the contents of the list in a safer order:
Iteratively, objects without any client in the list are deleted.
This effectively deletes a tree structure contained in the
list top down.
- Use safeDelete() in dtor and removeAl() methods of owning
collections
- Fix remove() member that assumed that every object has
a unique name. If matchByName is set, all objects that
match the given name will be deleted
o RooDataSet
- Introduce write(const char* filename) method that writes
the dataset out as an ascii file.
o RooErrorVar
- New auxiliary class that represents the error of a RooRealVar
as separate variable. This class allows to recycle existing
technology for calculations involving a RRVs error, such
as calculating the pull
o RooFitContext
- Store MINUIT final status in RooFitResult
o RooFormula
- Elaborate 'Formula doesn't compile error with offending construction
o RooMath
- Export interpolate() function as public
o RooMCStudy
- Reimplementation of most of RFTs RooMCStudy class
o RooRealIntegral
- Minor modification is storage of function normalization argset
o RooRealVar
- add errorVar() method that instantiates a RooErrorVar representing
the error of this RooRealVar
- Overload RooAbsRealLValue::attachToTree() to also attach
the error as a TBranch, resulting in persistence of the error
- Overload copyCache() to copy the error from another RooRealVar
o RooTreeData
- Cleanup header
Revision
2995 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Oct 8 05:20:24 2001 UTC (13 years, 3 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7773 byte(s)
Diff to
previous 2811
Documentation update
--------------------
o Most classes
- Update inline documentation
o RooHtml
- Add MakeIndexNew() method that can create sub-index files
by topic. Similar to THtml::MakeIndex(), but topic is taken
from tag in file instead of subdirectory name
- Add MakeIndexOfTopics() method that creates master
index of index files by topic.
o All classes
- Provisionally assign one of the following topic tags to each class
PDF - Probability Density functions
REAL - Real valued functions
CAT - Discrete valued functions
PLOT - Plotting and tabulating
CONT - Container classes
MISC - Miscellaneous
USER - Other user classes
AUX - Auxiliary classes for internal use
o makedocs
- Modify to make new sub-index files and index of topics file.
(Description of topic tags is defined here)
Revision
2798 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon Sep 17 18:48:17 2001 UTC (13 years, 4 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7854 byte(s)
Diff to
previous 2788
Generalize RooArgSet to RooAbsCollection and introduce RooArgList
and corresponding proxy. Introduce RooArgList where appropriate
as replacement of a TList of proxies, eliminate all use of TList
inherited functions in RooArgSet/List.
Some optimizations implemented following profiling studies
Various fixes for compilation with Solaris CC 5.0
o RooAbsArg
- Change signature of server management function to use RooAbsCollection
instead of RooArgSet
- Add proxy management support for new RooListProxy class
o RooAbsPdf
- Disable use of RooNameSets as optimization attempt. It appears
to cost more time than it saves
o RooAbsProxy, RooArgProxy, RooAbsReal, RooAcceptReject,
RooDataHist, RooFormula, RooFormulaVar, RooGenCategory,
RooGenContext, RooGenericPdf, RooPlot, RooRealIntegral,
RooResolutionModel, RooSetProxy, RooSuperCategory, RooTreeData
- Follow RooAbsArg member function signature changes
o RooAddPdf, RooConvolutedPdf, RooFitContext, RooSimFitContext,
RooFitResult, RooPdfCustomizer, RooProdPdf,
- Change implementation from using TList to using RooArgList
o RooAbsCollection
- New abstract base class for collections of RooAbsArgs. This
class contains mostly code from the former RooArgSet implementation
o RooArgSet
- Re-implement as derived class of RooAbsCollection. A RooArgSet
cannot contain duplicates (as before), but also doesn't give
random access (by index) to its member elements
o RooArgList
- New implementation of RooAbsCollection that allows duplicates
in the list, allows sorting and lookup by index.
o RooListProxy
- Proxy version of RooArgList, similar to RooSetProxy. To be used
as data member of RooAbsArg implementation to hold external
RooAbsArg references.
Revision
2788 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Sep 11 00:30:33 2001 UTC (13 years, 4 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7844 byte(s)
Diff to
previous 2778
Reorganization of RooData* classes to introduce binned data sets
o RooAbsData
- Add new reduce() method to create subsets (either by cut
or listed columns) of abstract data sets.
o RooTreeData
- New abstract base class for data sets that implement their
data storage in a TTree (RooDataSet and RooDataHist currently)
Derives from RooAbsData.
o RooDataHist
- New binned data set class. Basic functionality is implemented,
but class is not fully functional yet.
o RooDataSet
- Make inherit from RooTreeData instead of directly RooAbsData.
Move many tree management function, including caching into
RooTreeData
o RooAbsArg,RooAbsPdf,RooFitContext,RooSimFitContext,RooSimultaneous
RooAcceptReject
- Change function prototypes to use RooAbsData(,*,&) instead
of RooDataSet
- Change use of some TTree inherited methods (GetEntries() etc)
to new RooAbsData abstract methods
o RooFormulaVar
- Suppress unnecessary error message
Revision
2778 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Sep 4 01:37:42 2001 UTC (13 years, 4 months ago) by
david
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7838 byte(s)
Diff to
previous 2735
RooRealIntegral:
- add logic to reuse an existing numerical integration engine when possible
RooArgSet:
- replace Delete() with _list.Delete()
- create addOwned() member fn that allows objects to be added to a list
with ownership transfered to the list (like addClone())
RooFitResult:
- change _globalCorr and the elements of _corrMatrix to use "copied"
ArgSet's and let the ArgSet dtor handle the cleanup (ie, remove Delete()'s
from RooFitResult)
RooFormula:
- replace RooArgSet::Clear() with removeAll() in actualDependents()
- replace InheritsFrom() with dynamic_cast in DefinedValue()
RooFormulaVar:
- implement getAnalyticalIntegral() and analyticalIntegral() as no-ops
to avoid problems with formulas that integrate to zero over their fit range.
*** does selfNormalized() actually work with RooRealIntegral ??
Revision
2735 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Aug 23 23:43:43 2001 UTC (13 years, 5 months ago) by
david
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7782 byte(s)
Diff to
previous 2655
The following changes enforce set semantics in the public use of
RooArgSet's by removing the public TList interface.
RooArgSet:
- change base class from TList to TObject
- add protected data member THashList _list
- add inline createIterator() to export _list.MakeIterator()
- add inline getSize() to export _list.GetSize()
RooAbsArg,RooAbsData,RooAbsPdf,RooAcceptReject,RooConvolutedPdf,
RooCurve,RooFitContext,RooFitResult,RooFormula,RooFormulaVar,
RooGenContext,RooGenericPdf,RooLinearVar,RooMultiCatIter,
RooNameSet,RooPdfCustomizer,RooRealBinding,RooRealIntegral,
RooSetProxy,RooSuperCategory,RooDataSet:
- replace RooArgSet::MakeIterator() with createIterator(), etc.
RooAbsArg,RooArgProxy,RooSetProxy:
- move a block of duplicated code in RooAbsArg::redirectServers()
RooSetProxy::changePointer() and RooArgProxy::changePointer() into
a new RooAbsArg::findNewServer() member fn.
*** Outstanding problems now resolved by temporary cheater member
*** functions added to RooArgSet:
- RooConvolutedPdf uses RooSetProxy::At() and ::IndexOf()
- RooFitContext uses RooArgSet::At() and ::Sort()
- RooFitResult uses RooArgSet::IndexOf() and ::At()
- RooMultiCatIter uses RooArgSet::getCollection()
- RooPdfCustomizer uses RooArgSet::Sort()
- RooRealBinding uses At()
- RooSimFitContext uses RooArgSet::At() and IndexOf()
Revision
2655 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Aug 9 01:02:15 2001 UTC (13 years, 5 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7780 byte(s)
Diff to
previous 2641
o Many classes
- Simplify use of TString as this is suspected to cause spurious
TString memory errors
o Many classes
- Fix about a dozen of memory leaks reported by GC (mostly iterators)
o RooArgProxy,RooSetProxy
- Change order of multiple inheritance to put TObject (or derived)
first. This fixes vtable/vptr mishap on Solaris
o RooAbsArg
- Introduce dynamic_cast<> in changeNormSet() to cast the TObject
from the proxy list into a RooAbsProxy (needed in conjuction
with above change)
o Several classes
- Make destructor virtual, fix Clone() function signature to match
that of TObject
Revision
2626 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Aug 2 21:39:13 2001 UTC (13 years, 5 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7681 byte(s)
Diff to
previous 2612
o RooTrace
- New memory tracing utility (singleton class)
o RooAbsArg,RooDataSet,RooArgSet
- Install hooks for RooTrace in ctors and dtors
o RooThreshEntry
- Fix bug in copy ctor
o RooAbsReal,RooAbsPdf
- Move analytical integration support
(getAnalyticalIntegral,analyticalIntegral,
forceAnalyticalInt,selfNormalized) from RooAbsPdf to RooAbsReal
so that every RooAbsReal can be integrated
o All RooAbsReal derived classes
- Change signature of evaluate(),getVal(),traceEval(),checkDependents()
from X(const RooDataSet* dset) X(const RooArgSet* nset)
o RooAbsPdf
- Manage normalization caching with a RooArgSet listing the dependents
instead of a RooDataSet containing this list
- Remove obsolete nLogLikelihood function (now in RooFitContext)
o RooAbsArg
- rename setProxyDataSet to setProxyNormSet
- add getParameters(),dependentOverlaps() that
take a 'const RooArgSet*'
o Roo*Proxy
- rename changeDataSet() to changeNormSet()
o RooConvolutedPdf
- Replace dummy data set for convolution normalization by an RooArgSet
o RooDataSet
- Remove inheritance from TTree, make it contain a TTree instead.
Forward all relevant TTree member functions. Add correct Clone()
function (now possible due to inheritance change)
o Various classes
- Fix const handling to eliminate Linux2 compiler warnings
Revision
2612 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jul 31 05:54:23 2001 UTC (13 years, 5 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7683 byte(s)
Diff to
previous 2405
o All RooAbsArg derived classes
- Change clone() to clone(const char* newname=0) to facilitate cloning with alternate names.
o RooAbsArg
- Add another layer to link management: operMode. If operMode=auto, all behaves
as before. If operMode=AClean, the arg assumes the cache is always clean and
getValueDirty() will always return false. If operMode=ADirty, the arg assumes
the cache is always dirty and isValueDirty will always return true.
The ADirty and AClean modes are used by the optimizer in the fit context
to shut down link management (and save time) for cases where the arg is
always dirty after a dirty state propagation from one of the dependents.
The AClean mode is used similarly for args that are cached in the dataset
The setOperMode() member is protected as care should be taken in switching modes.
It is the callers responsability to ensure that the claimed state (especially
in case of AClean) is indeed correct.
- Split setValueDirty(Bool_t flag) in setValueDirty() and clearValueDirty().
The latter is trivial and can be inlined to save time.
- redirectServers() now has an optional nameChange flag that allows to reconnect
to servers with different names. If the option is enabled, a link will be reconnected
to the server with a 'ORIGNAME:<servername>' attribute instead of a server with <servername>
This feature is used by RooPdfCustomizer.
- Added recursive printDirty() member that listed dirty state of arg and all its servers.
- Add sorting capability by implementing IsSortable() and CompareTo() members.
Sorting will result in alphabetical ordering by object name.
o RooAbsCategory
- Change tree attachement: store both label and index fields in tree instead of
just the index field. Looking up the corresponding label turns out to be rather
expensive, especially if many state are defined.
- The postTreeLoadHook() mechanism that formerly implemented the index lookup
has been abandoned completely (save 1 virtual function call per data set load).
o RooAbsPdf
- Change function call structure of eval tracing a bit to reduce the number
of calls per trace from virtual calls to 1 concrete call.
- In syncNormalization, if the data sets are different, first check if they
also have a different contents before processing the change. (Save multiple
identical normalization calculations for cases were a resolution model is
shared by >1 RooConvolutedPdf. (WVE Caveat: this has some problems: code will
die if cached data set is deleted before pdf. Will fix this soon)
Install pre- and postSyncNormalizationHook functions that can be used to customize
the call. Used by RooConvolutedPdf to create/update dummy data sets used to
push down partial integrations to the convolution integrals.
- Move nLogLikelihood to RooFitContext
o RooAbsReal
- in attachToTree(), mangle name of object in tree to exclude math symbols that
are interpreted by root in certain circumstances
o RooAddModel
- Store coef and proxy iterators in class instead of creating them on the fly each
time in evaluate()
- Release ownership of proxied resolution models in the copy constructor. If the
AddModel is copied, the proxied components will be owned by the list created
by RooArgSet::snapshot().
- Include name of AddModel owner in component resolution model to avoid multiple
identically named object in certain PDF configurations
- Export 'master list' of combined normalization leaf node servers of all components.
The convolutedPdf needs this for it's own dependency calculation
o RooArgSet
- Add silent option to remove()
o RooCatType
- Store name in char[] instead of in TNamed::fName (a TString) so that
the name can be attached to a Tree. (A TString is not a TObject)
o RooConvolutedPdf
- Push integration of all dependents that do not overlap with the coefficients
to the convolution integrals, instead of just the convolution variable
o RooDataSet
- Add new constructor that allows to specify the cut as a RooFormulaVar object
instead of a string. This allows to cut on function arguments that are not
part of the data set
- Allow to switch off dirty state propagation after a row-load operation
(can be used in certain optimization scenarios)
o RooFitContext
- Add option to not clone either dataset or pdf on construction
- Remove non-RooRealVar parameters from master parameter list to prevent that
MINUIT chokes on them
- Sort minuit parameter list alphabetically
- Add cache optimization option, which shuts down all link management for the
all pdf value components (not normalization). This can save a significant amount
of time, especially for very complex PDFs as the number dirty propagations scales
with the square of the number of nodes. Use newly introduces AClean and ADirty
modes to ensure proper evaluation of PDF nodes
- Add option to execute migrad with 'strategy 0', which skips the evaluation of
the error matrix. (Saves time if you do that later with HESSE anyway)
- Move nLoglikelihood() function from RooAbsPdf to here.
- Improve readability of messages in fitting in log-mode: print on screen only value
and name of parameters that change instead of dumping all their values all the time.
The old format has been retained in the log file, to allow automated processing of such files.
o RooFormulaVar
- Also update _origList on a serverRedirect
- Export ok() function of RooFormula (indicates if expression compiled ok)
o RooMath
- Add fast, interpolated, complex error function. Upon first use separate lookup tables
are filled for the im and re part of the complex error function. New functions will
do a 2nd or 3rd order 2D interpolation (depending on z) of the lookup table for either
the re part, the im part or both. Precision is better that 1e-6 in ~99% of covered
phase space. Imprecise regions are in problematic part of cErf where giant fluctuations
occur. Typical likelihood calculated with interpolated cErf agrees in the first 10
significant digits. Interpolation function is ~3.5 times faster than original CWERF
implementation, when only 1 component (im/re) of cErf is needed (most cases).
Interpolation function taken from Numerical Recipes and further optimized for
fixed grid assumption
o RooMappedCategory
- Clone also MapCatEntries in RooMappedCategory copy ctor
o RooProdPdf
- Store coef and proxy iterators in class, instead of instantiating them on the fly
in evaluate()
- Add optional cutoff parameter. If running PDF product goes below cutoff, product
calculation is terminated (default value=0, very small values like 1e-15 can be
benificial in case of wide window calculations a Gaussian + something flattish)
o RooRealIntegral
- Allow and perform integration over variables that input function doesn't depend
on (multiply integral by product of ranges of such variables)
o RooResolutionModel
- In convolution(): append name of owner to convolution, to avoid non-identical
convolutions with the same name in certain PDF configurations
- Forward redirectServers to basis function
o RooSimultaneous
- Overload fitTo() to create a RooSimFitContext instead of a RooFitContext
which allows certain additional optimizations specific to RooSimultaneous
- Normalize by the number of registered PDFs instead of the number of types
defined by the index category (allows to to partial fits)
o RooStreamParser
- Take '}' and ';' out of the default punctuation list so that RooSuperCategory
state names do not get broken up into multiple tokens
o RooThresholdCategory
- New category class that applies a series of thresholds on a RooRealVar to
define its state.
o RooThreshEntry
- Support class for RooThresholdCategory
o RooPdfCustomizer
- Utility class that serves a factory to build multiple PDFs from a single prototype
that have slightly different leaf nodes.
The class takes a proto type and a master index category in the constructor.
A series of splitting rules determines how given leaf nodes are to be 'split'
over the master index category or a subset of the master index (in case the master
index is a RooSuperCategory)
The instiated 'split' leaf nodes are put in an argset referenced in the constructor.
and the owner of the argset is responsible for deleting them (or passing them on
to another RooPdfCustomizer). The instantiated branch nodes are owned by the customizer.
o RooSimFitContext
- Specialized fit context, derived from RooFitContext, that optimizes the likelihood
calculation in case the top level pdf is a RooSimultaneous. The original data
set is broken into pieces, corresponding to a single state of the RooSimultaneous
index category and those data subsets are combined with the corresponding PDF branches
of the RooSimultaneous to form an array of regular RooFitContexts. The total likelihood
is calculated as the sum of the likelihoods from the array of fit contexts.
The NLL output from each subcontext is cached and only recalculated if a parameter
that the PDF of that subcontexts depends on, is changed.
This form of calculation is very efficient for fits where the correlation matrix has
a block diagonal form. The CPU time in RooSimFitContext scales (approximately) with
the number of elements in the block diagonal elements instead of with the total number
of elements.
o Nearly all classes
- A large number of minor bugs has been fixed and many functions
that are called very frequently have been inlined, made non-virtual or
have been eliminated, following the result of repeated profiler studies.
Revision
2405 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Tue Jun 12 19:06:27 2001 UTC (13 years, 7 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 7208 byte(s)
Diff to
previous 2222
o RooAbsArg
Make client list iterators used in setValueDirty()/ShapeDirty()
data members of RooAbsArg. (Fixes memory leak observed by John Back)
o RooAbsReal
Allow optional scale factor in plotOn()
o RooFormula
Pass dataset pointer in eval() and forward it to DefinedValue()
where real arguments are evaluated
o RooFormulaVar
- Forward data set argument in evaluate() to RooFormula
- evaluate() formula in ctor if RFV has no servers
(i.e. constant string expression), because for these
cases evaluate() gets never called as non-server
RooAbsArg are never dirty by construction.
- Add constructor that allows a title different from the formula expression
Revision
2191 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Mon May 14 05:22:55 2001 UTC (13 years, 8 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 6267 byte(s)
Diff to
previous 2182
Reorganize analytical/numerical integration structure
o RooAbsArg
- Back out 'integration dependents' option in getDependents()
(logic moved to RooRealIntegral)
- checkDependents is by default always OK
o RooAbsRealLValue
- Add isSafeForIntegation(const RooArgSet& depList) method
in which an LValue can indicate if it is OK to use the
object as LValue in integration fo the present
parameter/dependent configuration is
o RooRealIntegral
- Move all logic to decide what to integrate numerically/analytically
and where to use LValue and depth-expanded RValue into RRI ctor.
Summary of logic:
For every server of function that is to be integrated
if (RealLValue && isSafeForIntegration && noOverlapWithOtherServers)
Integrate of LValue
else if (CategoryLValue && noOverlapWithOtherServers)
Sum over LValue
else
Integrate/Sum over leafNode dependents of server
Now, all details of integration technique are completely contained
in RooRealIntegral, which can _always_ be performed (if N-dimensional
numerical integration is implemented)
Other changes
o RooFormulaVar
Allow new variable names in formula expression (@0, @1, ... @n)
that reference the nth object in the given RooArgSet.
(e.g. "@0 + @1 * @2")
Revision
2114 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu May 3 02:15:56 2001 UTC (13 years, 8 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 5467 byte(s)
Diff to
previous 2112
o (Most classes)
Merge X(const x&) and X(const char*, const X&) copy constructors
into a single X(const& X, const char*=0)
o RooAbsArg
- Add 'depth-aware' client-server management functions
recursiveRedirectServers(...)
treeNodeServerList(...)
leafNodeServerList(...)
branchNodeServerList(...)
overlaps(...)
dependsOn(...) (now recursive)
- Add/move parameter/dependent interpretation to RooAbsArg
getParameters(...)
getDependents(...)
dependentOverlaps(...)
checkDependents(...)
- Change Clone() to Clone(const char*) and make it call
a pure virtual clone().
o RooAbsPdf
- First implementation
- Actual fitting implemented in RooFitContext
- Incorporates normalization technology from
RooNormFunction (now retired)
- Separate getValNorm() dropped in favour of
getVal(const RooDataSet* =0)
- getVal(...) provides all owned proxies with
the correct data set (which they need for their
value cast operators that don't take an RDS)
o RooFitContext
- First implementation
- Owns a clone of a dataset and a PDF and ties them
together with a redirectServers
- Caches indexed parameter list for fast Minuit lookup
- global Optimizer function seeks out PDF components
that only have constant parameters and add these
as precalculated columns to the data set clone
(redirectServers edits PDF tree to point to cache)
o RooDataSet
- Implement addColumn(RooAbsReal) that adds a column
of precalculated values given function for each
row of the data set
o RooAbsReal
- Change getVal() to getVal(const RooDataSet* set=0)
to allow dynamic normalization for PDFs.
o RooArgProxy and dependents
- Cache last data set used, for use in getVal(...) call in
value cast operator.
o RooRealProxy
- add min()/max() functions that get out the integration limits
if the underlying real is a RooRealVar. (Needed by RooAbsPdf
analytical integration implementations)
o (Most classes)
- A large number of minor fixes have been applied to make
the Solaris 5.7 compiler happy
Revision
2112 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed May 2 18:09:00 2001 UTC (13 years, 8 months ago) by
david
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 5977 byte(s)
Diff to
previous 1985
RooHistError:
- new singleton utility class for calculating histogram error bars
RooPrintable:
- lessVerbose() maps Shape & Verbose to Standard
RooAbsArg:
- use writeToStream() for Standard printToStream()
- fix iterator memory leaks in dependsOn() and printToStream()
- copy ctor with name arg uses other object's name if strlen(name)==0
so that the Clone(const char *name= "") operator can use this copy ctor
(maybe we don't need copy ctors w/o name args any more?)
RooAbsArg,RooAbsReal,RooRealVar,RooAbsCategory:
- remove dedicated Standard printToStream()
RooAbsReal:
- implement plot() methods
- add binding method using f(x) syntax (see RooRealFunc1D)
RooRealVar:
- change default fit range in ctors to (-INF,+INF)
- change Clone() signature to match TObject::Clone()
RooFormula:
- multiply-inherit from RooPrintable & implement printToStream,Print
- make actualDependents() const
RooRealFormula:
- standardize printToStream()
- change Clone() signature to match TObject::Clone()
RooCurve:
- new class for smooth 1-dim curve (analog of RooHist)
RooPlotable:
- abstract interface for plotable objects (RooHist,RooCurve)
RooAbsFunc1D:
- abstract interface for evaluating real-valued func of one real var
and performing numerical algorithms on it (1D numerical integrator
should go in here...)
RooRealFunc1D:
- implementation of AbsFunc1D that binds an AbsReal with a RealVar
*** Things to discuss with Wouter:
- remove name from ArgSet ctors? (or make it optional?)
- add optional plot range & unit to some DerivedReal ctors, eg, RealFormula?
- RealFormula: arg is added to list of actual dependents each time it appears
(eg, "1+x*x" -> x is listed twice as a dependent)
- there an overloading ambiguity between:
TObject *Clone();
TObject *Clone(const char *name= "") const;
- do we need copy ctors that don't take a name arg?
- const cast errors in RooAbsIntegrator and RooRealIntegral
- should dependsOn() be recursive by default?
Revision
1985 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sat Apr 14 00:43:20 2001 UTC (13 years, 9 months ago) by
davidk
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 5305 byte(s)
Diff to
previous 1910
RooCatType:
- multiply-inherit from RooPrintable and standardize printToStream()
- remove Int_t() and Int_t&() cast operators
- operator==(const RooCatType&) requires index and label to match (was just index before)
RooAbsCategory:
- add lookupType(const RooCatType&) which was being faked using RooCatType::Int_t() before
- delegate equality tests in lookupType() methods to RooCatType::operator==() methods
- delegate printing of RooCatType's to RooCatType::printToStream()
RooMappedCategory:
- standardize printToStream()
- change a!=b into !(a==b) for RooCatType a,b (op!= was being faked by RooCatType::Int_t())
- add setShapeDirty() in addMap()
RooAbsArg:
- use AbsArg::printToStream(OneLine) to print client,server info in printToStream(Verbose)
RooPlot:
- add getPlotVar() member fn
RooDataSet:
- add const plot(RooAbsReal&) and plot(RooPlot*) methods to eventually replace Plot()
- make Plot() const and remove the unused options argument
- const_cast our ArgSet in Plot() so we can call redirectServers()
RooFormula:
- make ctor ArgSet argument const to allow DataSet::plot() to be const
Revision
1910 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Sun Apr 8 00:06:49 2001 UTC (13 years, 9 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 5302 byte(s)
Diff to
previous 1900
o Another major round of const-correctness improvements
o Add RooDerivedReal as an intermediates class between
RooAbsReal and RooRealFormula,RooRealIntegral,RooUnblind*
the getVal() -> cache check -> traceEval() -> evaluate()
chain has been moved into this class.
Derived Classes of RooDerivedReal only need to implement
evaluate() for contents definition. The getVal() of RooAbsReal
return the straight contents of _value.
o Added RooRealIntegral class, which represents the integal and/or sum
over various RooRealVar/RooCategory dependents of a generic RooDerivedReal
Integral value is cached and updated when the value of one of the
non-integrated dependents of the integrated functions changes
(detected via valueDirty bit propagation), or if the integration ranges
of one of the integrated dependents change (detected via shapeDirty
bit propagation).
If the RooDerivedReal supports analytical integration (implemented
via the getAnalyticalIntegral/analyticalIntegral functions) it's
analytical integrator is used. Otherwise a numerical integration algorithm
is used (currently limited to 1-dimensional integrations)
Summation of an arbitrary number of category dependents is supported
but not implemented yet, pending the port of RooSuperCategory, which
will support a trivial implementation.
Analytical integation interface: Each RooDerivedReal has 2 functions
implemented
- getAnalyticalIntegral(RooArgSet& integrandList),
which determines if analytical integration is supported
for the given list of integrands. If not, it returns
code 0. If yes, it returns a positive code, which RooRealIntegral
will pass to analyticalIntegral().
- analyticalIntegral(Int_t code) Performs or dispatches the
analytical integral represented by the code assigned by
getAnalyticalIntegral()
In theory, the above scheme could be implemented with just one
function, returning a pointer to a member function, but
pointer-to-members are not supported by ROOT due to portability
problems. The current scheme is inspired on the TFormula implementation
of referencing external parameters.
A default implementation in RooDerivedReal handles the default
(no analytical integration available) case.
Revision
1900 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Apr 5 01:49:11 2001 UTC (13 years, 9 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 5296 byte(s)
Diff to
previous 1874
o Implement custom Clone() for all RooAbsArg derivatives
which uses the copy constructor. The TObject Clone()
uses the Streamer() functions that have unintended side
effects on the bidirectional link lists in RooAbsArg
o Fix RooFormula/RooRealFormula so that it is properly
clonable / copyable
o Add options RooAbsArg::addServer(), that allow to mask
value or shape dirty state information from the server
(This will allow RooPDF classes to distinguish between
parameters, which require value state propagation, and
dependents, which require shape state propagation)
Revision
1874 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Mar 29 22:37:41 2001 UTC (13 years, 9 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 4463 byte(s)
Diff to
previous 1846
o Add Arg::Arg(const char* name, Arg& arg) type copy constructor
to all RooAbsArg derived types in addition to Arg::Arg(Arg& arg)
copy constructor.
(NB: We cannot omit or protect the latter form because CINT uses them)
o Some general constructor and operator=() cleanup
Revision
1846 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Thu Mar 22 15:31:25 2001 UTC (13 years, 10 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 4327 byte(s)
Diff to
previous 1839
o Extend RooFormula to understand RooCategory labels '<catName>:<catLabel>'
so you can e.g. do (tagCat==tagCat::Kaon)
o Transplant and rework most advanced reading options from RFT/RooVarList
to RFC/RooArgSet
- Nested if statements
if (conditional)
else if (conditional)
else
endif
Conditionals are evaluated by a RooFormula object that can use the
entire arglist as variables
- Recursive include statements
include <filepath>
- Some useful other commands for configuration file use
echo "message" -> Print message while processing
abort -> Force termination of read with error status
Handling of errors in the input file format is fairly exhaustive.
o Some reworking of the RooStreamParser in the way newlines are handled.
Some of the clients of RSP have been changed accordingly.
Main new feature is a RSP::atEOL() member that determines if there is
a newline between the last read token and the next token to be read.
o Temporarily made RooAbsArg::Print/printToStream non-const as the
implementation in some subclasses call a non-const getVal()
This problem must be fixed for good in all classes soon.
Revision
1839 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Wed Mar 21 15:14:21 2001 UTC (13 years, 10 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 3755 byte(s)
Diff to
previous 1834
o Finish RooMappedCategory::writeToStream()
o Check and fix validity checking in *::readFromStream()
o RooDataSet::read now uses RooArgSet::readFromStream
o Change event selection in RooDataSet::Plot,RooDataSet::RooDataSet(tree)
to use RooFormula instead of TTreeFormula
o Add interface to RooAbsCategory in RooFormula
Revision
1827 -
(
view)
(
download)
(
as text)
(
annotate)
-
[select for diffs]
Modified
Fri Mar 16 07:59:12 2001 UTC (13 years, 10 months ago) by
verkerke
Original Path:
trunk/roofitcore/src/RooFormula.cxx
File length: 2841 byte(s)
Diff to
previous 1826
o Make naming convention of member functions more uniform
o RooAbsArg: Add 'Shape' dirty state management
o Roo*Value: Distinguish between integration and plotting limits
o Roo*Value: Disentangle meaning of limits and constant-ness
o Add tracing to RooAbs{Value,Index} evaluation
o redirectServers & traceEval have global trace function and
hooks for additional subclass tracing
This form allows you to request diffs between any two revisions of this file.
For each of the two "sides" of the diff,
enter a numeric revision.
