[root] Log of /trunk/roofit/roofitcore/src/RooObjCacheManager.cxx

Revision 39817 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Jun 18 12:49:41 2011 UTC (3 years, 7 months ago) by wouter
File length: 7778 byte(s)
Diff to previous 25184

  
  o  RooDataSet

     - Introduce pool-based memory allocation scheme

     - In ctor for composite datasets with Link() ensure that 
       order of observables is preserved to allow use of assignFast()
       

  o  RooRealSumPdf

     - Use getNorm() in expectedEvents() rather than createIntegral()


  o  RooAbsCollection

     - Do no allocate hash tables by default

     - Introduce contents claim counter to counter 'foreign' ownership
       claims of contents (needed for RooAbsOptTestStatistic::setData()
       support)

     - If collection is owning, only delete contents if claim count is also zero

     - In snapshot() raise hash table threshold from 100 to 1000


  o RooRefCountedList

     - Disable hash tables by default


  o RooStudyPackage

     - Make study package own clone of incoming workspace

     - Implement copy ctor


  o RooAbsTestStatistic

     - Implement 'master' setData() method. Forward to setDataSlave()
       of self for monolithic likelihoods or forward data components
       to likelihood components in case node is SimMaster. If data
       is not fast-splittable, execute slow split.


  o RooAbsData

     - Implement 'live check' to be able to conclude if a given dataset
       pointer points to a live or dead object

     - Claim contents of _vars through new claim mechanism. Release
       in dtor, allow _vars to delete contents if claim count is zero

     - Add concept of owned component datasets to support fast-splitting
       of dataset

     - Add method canSplitFast() that indicate if fast split is available
       (only possible if dataset was created as composite)

     - Add method getSimData() that retrieves pointer to component
       RooDataSet representation for a given index state


   o RooObjCacheManager

     - Add static mechanism that allows to deleted cached observables lists used for
       cache optimization triggers to be deleted on a sterilize() action. This
       is useful on toy studies with setData() operation, that would otherwise
       collect very large lists of observable clones during the toy cycle.


   o RooAbsPdf

     - Set contraint term to ADirty to avoid synchronization problems when using
       setData() in the likelihood


   o RooAbsArg

     - In clone operations set hash table threshold at 1000 nodes

     - In getObservables() use pass-by-value iterators rather than heap iterators
       to making this faster. Also make getObservables() non-virtual, as it is in
       fact not overloaded in any subclass (anymore). Also remove looping over
       branch nodes to call getObservablesHook() as no class implements method
       anymore.

   
   o RooAddition

     - Implement a setData() method that forwards to its components. Allows transparent
       operation of setData() on likelihood objects with constraint terms


   o RooLinkedList

     - Add method that returns iterator by value (simply forwards to similar implementation
       in RooLinkedList)


   o RooSimGenContext   

     - Move calculation of fraction table from ctor to dedicated updateFraction() method

     - Before each generation sequence call updateFractions() so that multi-generation
       sequence are robust against parameter changes between calls

     - In createDataSet() always make a composite dataset if the index is present, as this
       allows faster use in toymc operations


   o RooAbsOptTestStatistic

     - Initialize all variables in default ctor

     - In dtor and ctor handle ownership of dataset observables, on which we put a claim
       (i.e. we need to delete contents if the test statistics survives the dataset)

     - Reimplement existing setData() as setDataSlave(), and add claim management on
       dataset observables. When attached new data to function, request that object caches
       clear full content in sterilize() operation to avoid buildup of cache objects in
       long toy runs.

     - In setData() adjust event count of test statistics, for correct functioning of extended
       terms after update


   o RooArgSet

      - In ctor for list and a single object, only add object if not already in list
        (is already checked, but new procedure preserves order of list elements in case
         object was already present)

   o LinkDef

      - Add list<RooAbsData*> and map<string,RooAbsData*> to support streaming of composite datasets


   o RooAbsStudy

      - Implement clone method to support polymorphic array cloning

 
   o RooAbsReal

      - Add interface method setData() 


   o RooProfileLL

      - When storing coordinates of absolute minimum, store only those that are non-constant.
        Otherwise option to restart each minimization from known absmin may alter constant
        parameters

Revision 25184 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Aug 20 13:59:55 2008 UTC (6 years, 5 months ago) by wouter
File length: 6881 byte(s)
Diff to previous 24285


   o RooAbsSelfCachedPdf

     - Declare embedded RooHistPdf as self-normalized to prevent
       superfluous calculation of unit normalization


   o RooDataHist

     - Add new named argument ctor that can collate multiple
       TH[123] into a N+1 dimensional RooDataHist which has
       an extra RooCategory to distinguish the source, as
       well as import single a TH[123] objects

     - Add ctor that can do the same, but specified from
       a map<string,TH1> specification.

     - Add new importTH1Set(),importTH1() utility methods to implement
       common functionaly of both new ctors

     - Add adjustBinning() method that encapsulates the functionality
       to adjust the RooDataHist observable binning to match that
       of a given (imported) TH1, which was formerly contained in the ctor

     - Speed up code in interpolateDim() by reducing number of required
       lookups of the observable binning definition.


  o RooParamBinning

    - Add tree printout of boundary functions, if defined in verbose
      printing mode


  o RooMsgService

    - Add special handling of PROGRESS message level: automatically 
      insert newline when switching from a PROGESS to another message level.


  o RooPlot

    - In verbose printing, add index number to printout of each contained 
      plotable object


  o RooGenContext

    - Fix for handling of observables with parameterized ranges

    - Eliminate forgotted debug print statement


  o RooAbsRealLValue

    - Implement new binning interface methods that take binning reference
      rather than binning name, for faster use in internal operations

    - Implement new RooAbsLValue methods with RooAbsBinning pointers


  o RooDataSet

    - Add new named argument constructor that can generically handle imports
      of TTrees, RooDataSet and can collate multiple RooDataSets into
      a N+1 dimensional RooDataSet with an extra RooCategory that labels
      the source dataset


  o RooDLLSignificanceModule

    - Tune some of the names of the produced output observables


  o RooChi2Var

    - Set the default error type to RooAbsData::SumW2


  o RooCustomizer

    - Modify the sterile build() routine to make the returned
      head node own all the created components rather than
      the customizer itself.


  o RooAbsCategoryLValue

    - In copyCache(), check that the value copied is in fact
      valid for the destination.


  o RooFitResult

    - Tune the line widths of the objects created in plotOn()
      when creating the error ellipse.

    - Add a method correlationHist() that returns a 2D histogram
      with the correlation matrix element values, which is labeled
      with the parameter names.


  o RooCurve

    - Add explicit handling for evaluation errors that can occur
      when sampling the function being represented. New constructor
      arguments control how evaluation errors are logged to
      RooMsgService, in similar style to RooMinuit, and control
      how the drawn output value is affected (as calculated, or
      substituted with a user controlled value).


  o RooFFTConvPdf

    - Add automated handling of FFT sampling windows of the 'physics'
      pdf and the 'resolution' pdf. In the new setup the second pdf
      is always assumed to be a 'resolution' pdf and its sampling window
      is chosen symmetrically around zero, regardless of the definition
      of the range of the convolution observable. The width of the sampling
      window, and the number of sampling bins is still tied to the "cache"
      binning defined in the convolution observable. Added setShift()
      modifiers allow the user to manually control the sampling window
      shifts on both pdf. The shift introduced by sampling a shifted 
      window of the resolution effect is correct a posteriori by
      performing a compensating rotation of the final FFT buffer.

    - Modify FFTCacheElem to cache a functional clone of both pdf
      with optional shift transformations applied through a RooLinearVar
      substitution of the original convolution observable. Instruct
      caching RooDataHist not to forward dirty state propagation calls
      and set sampling pdf clones to AlwaysDirty to increased operational
      efficiency.


 o RooChangeTracker

   - Add parameters() method returning the tracked parameters


 o RooRealSumPdf

   - Implement component selection functionality in plotting as
     is available for RooAddPdf


 o RooEfficiency

   - Implement analytical integral over acceptance category
     (it is always 1.0)


 o RooHist

   - Implement ability to handle RooAbsData::None error bars
     (i.e no errors)

   - Expand functionality of constructor taking two TH1s
     to also represent the efficiency binomial in addition
     to the assymmetry binomial

   - Add addEfficiencyBin() method to handle calculation
     of efficiency bins.


 o RooAbsReal

   - Make named argument version of fitTo() default method
     when invoked with no arguments

   - In fitTo(), if pdf is extendable and no explicit Extended() argument
     is given, automatically included extended likelihood term

   - In fitTo(), disable default running of MINOS when invoked without
     arguments

   - Move component selection functionality from RooAbsPdf
     to here so that it also works for RooRealSumPdf, which
     takes RooAbsReals as components rather than RooAbsPdf

   - Add simplified createHistogram() method that takes
     string with comma separated observable names and
     three optional bin numbers. 

   - Add createHistogram() method that takes a list of
     RooCmdArgs that can serve as backend for all user
     interface methods.

   - In plotOn() support the new Slice() argument for categories
     that allow inline specification of of the slice position.

   - Also add support for the PrintEvalErrors(Int_t numErr) and
     EvalErrorValue(Double_t value) arguments to allow better control
     of evaluation error handlign during plotting.

   - Also add support for the MoveToBack() argument that immediately
     inserts the curve at the bottom of a RooPlot stack.


 o RooProduct 
   
   - Remove erroneous assert()


 o RooAbsCollection

   - In snapshot(), only add "Snaphot of" to name if original
     has a non-null name.

   - In verbose printing mode, remove printing of 'extras' and
     only print '(owning contents)' of collection has a non-null name


 o RooAddPdf

   - Fix logic of recursive fractions constructor. Recursive additions
     happen start on the rightmost pair of pdfs, recursively adding
     one more pdf to the left at each iteration. Coefficients describe
     the fractions of the leftmost pdf in each recursive addition,
     starting with the outermost addition of the 1st pdf to the
     som of all other pdfs, continuing with the fraction of the
     2nd pdf being added to the sum of pdf 3-n etc...
   

 o RooAbsCachedPdf

   - Degrade 'parameters have changed' message from INFO to DEBUG

   - Interface cache histogram objects to RooExpensiveObjectCache
     with associated parameters given by RooChangeTracker

   - Fix bug in printing: only print normalization object of
     cache if it actually exists


 o RooAbsTestStatistic

   - Reimplement copy constructor to initialize from scratch from
     original contents, to support sane implemlementation of
     copying of optimized test statistics with multi-process
     calculations.
      
   - Fix redirectServers method for objects implementing multi-process
     test statistics
   
 
 o RooRecursiveFraction

   - Invert incoming list of plain fractions when filling internal
     list in ctor so that last fraction is 'special' instead of first
     to support improved handling of recursive fractions in RooAddPdf


 o RooAbsData

   - Fix client-server reconnect handling for dataset observables
     with parameterized ranges in terms of other dataset observables

   - Add simplified createHistogram() method that takes
     string with comma separated observable names and
     three optional bin numbers. If bin counts are negative,
     the ranges of output histogram are automatically calculated.
     If the bin counts are positive, the ranges of the observables
     are used for the histogram, unless the observable has an
     open-ended ranges, in which case the automatic calculation
     is used.

   - Add createHistogram() method that takes a list of
     RooCmdArgs that can serve as backend for all user
     interface methods.

   - Extend createHistogram() method with named arguments
     to take AutoBinning and AutoSymBinning arguments to
     automatically calculate the ranges of the output histogram
     with the specified number of bins.


   - Add a table() method that takes a set of RooCategories
     and returns a table of the output states of a RooSuperCategory
     of the given input categories.


 o RooProfileLL

   - Add option to start minimization always from parameters
     of global minimum.
   

 o RooRealMPFE

   - Remove some forgotted debug printouts

   - Pass IsConstant() state of RooRealVars being transferred in
     addition to their value and error.

   - Fix copy constructor
 

 o RooRealVar

   - In printing interface, maker error part of 'value' rather
     than of 'extras'

   - Fix bug in format() concerning constant parameters with
     errors.


 o RooAbsPdf

   - Move component selection support for RooAddPdf to RooAbsReal
     so that it also works with RooRealSumPdf.

   - Remove some superfluous DEBUG level print messages

   - Add support for EvalErrorWall() named argument in fitTo
     to give user control of the 'NLL wall' feature used to
     force MINUIT to retreat from regions with evaluation errors

   - Enlarge default size of box created by paramOn()

 
 o RooAbsArg

   - Add pointer to expensive object cache to use for any expensive
     objects to be cached in association with this object

   - Add recurseNonDerived option to branchNodeServerList

   - Overload printAddress() to so that RooAbsArg base address
     is printed rather than RooPrintable base address, which
     can be different due to multiple inheritance

   - In constant term optimization, prevent addition of 
     observables with parameterized ranges to cache.

   - Add interface methods to get and set the associated
     expensive object cache

   - Add flipAClean() accessor method for corresponding
     static data member to solve windows linkage problems.


 o RooRealIntegral

   - Add support for cache values of >1D integrals in 
     expensive object cache


 o RooExpensiveObjectCache

   - New repository class that holds expensive components of RooAbsArg
     function objects along with the parameters value for which the
     stored expensive object is valid. All newly created objects
     are associated with a default singleton instance in memory,
     but objects in RooWorkspaces are associated with a cache in the
     workspace.
    

 o RooMCStudy

   - Add Silence() named argument to ctor that will silence all
     RooFit messages during running below the PROGRESS level

   - Store generated number of events in fitParDataSet()

   - Only store generated parameter values in fitParDataSet()
     if constraints were used

   - Give fitParDataSet() a unique named, named after the
     fit and/or generator model used.


 o RooNumRunningInt

   - Fix bug in calculation of cdfs.
    

 o RooMinuit

   - Deprecate support for error handling mechanisms that are now
     phase out.

   - Implement option to ignore evaluation errors   

   - Improve the contour() method to return a RooPlot containing
     contour TGraphs, rather than drawing them directory on a canvas


 o RooDouble

   - Set name to string representation of value


 o RooGlobalFunc

   - Add various named argument constructors needed by other code


 o RooCintUtils

   - New name space with CINT interaction utilities

   - Add function to match a given functin pointer to a string with
     a function argument list specification to facilitate manual overloading
     of method on function pointer declarations, which is not supported
     directly by CINT


 o RooPrintable

   - Introduce printAddress() method to print address


 o RooRandomizeParamMCSModule

   - Fix bug in init()


 o RooAcceptReject

   - Adjust code to make it work with observables with parameterized ranges


 o RooWorkspace

   - Add an embedded expensive object cache to each workspace. Connect each
     inserted object to the internal expensive object cache and transfer
     any cache contents upon insertion as necessary.


 o RooNumIntConfig

   - Tune non-verbose printing output


 o RooAbsOptTestStatistic

   - Implement correct handling of test statistics with observables
     that have parameterized ranges in terms of other observables

   - Implement sane copy constructor.


 o RooHistError

   - Add method to calculate confidence intervals for efficiency binomials.


 o RooSentinel

   - Add cleanup handler for expensive object cache global instance


 o RooBinningCategory

   - New real->cat function that represents binning associated with
     any given RooAbsRealLValue as category functions. Category states
     mapping to observable bins are automatically created and named


 o RooSimultaneous

   - Add support for new Slice() arguments that allow to specify the
     slice position for category observables.


 o RooTreeData

   - More fixes for infernal warning messages from TTree concerning
     improperly constructed memory resident trees

   - Forward TTree::Draw() method with cut expression.

   - Add Efficiency() named argument to plotOn() method to support
     plotting of efficiencies represent by a category observable
     that indicates which event do (not) pass a given cut

   - Support FillColor() and FillStyle() named arguments in plotOn()
     for the benefit of bar chart representations of histograms

   - Add plotEffOn() method to implement internal handling specific
     to efficiency plotting

   - Extend functionality of getRange() method to automatically
     include margins and optional interval symmetrization around
     the mean if requested.

   - Adjust observable pruning algorithm in data reading optimization
     mode to take observables with parameterized ranges into account


 o RooDirItem

  - When creating a memory resident object, do not change directory if
    already in memory directory.

Revision 20988 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Nov 22 14:54:13 2007 UTC (7 years, 2 months ago) by wouter
Original Path: trunk/roofitcore/src/RooObjCacheManager.cxx
File length: 5147 byte(s)
Diff to previous 20879

 
  ** Bringing trunk up-to-date w.r.t recent changes in branches/dev/roofit branch **

  Aggregated messages from branch commits follow

  --- Date: Fri Oct 19 20:35:30 2007 New Revision: 20422 ---

  o RooAbsArg

    - Add debug level print statement in findConstantNodes()

  o RooAbsAnaConvPdf

    - Do not expose cached RooCoefVars to constant term finding process.



  --- Date: Fri Oct 19 21:03:40 2007 New Revision: 20423 ---

  o RooPlot

    - Add forwarding function for all revent Set*() methods of TH1



  --- Date: Fri Oct 19 21:48:40 2007 New Revision: 20424 ---

  o RooAbsAnaConvPdf

    - Back out special handling of exposure of cached RooCoefVars 
      to constant term finding process.


  o RooObjCacheManager

    - Do not perform constant term finding on cache contents
      if cache manager is configured to perform clearOnRedirect
      for server redirects.



  --- Date: Wed Oct 31 23:36:10 2007 New Revision: 20587 ---

   o RooAbsRealLValue

      - Remove stray debug print statements


   o RooAddPdf

      - Add new default ctor to fix persistence introduced by
        new cache management scheme

      - Add forgotten initializer to regular ctor


   o RooAbsCachedPdf

      - Add formal server-link dependency on cache parameters to 
        RooHistPdf cache representation so that the constant term
        optimizer can make the correct decision

      - Make RooObjCacheManager a persistent data member


   o RooObjCacheManager

     - Add debug message level information

     - Make _optCacheObservables a transient data member and initialize
       it in the default ctor.


   o RooAbsPdf, RooProjectedPdf

      - Add new default ctor to fix persistence introduced by
        new cache management scheme

      - Make RooObjCacheManager a persistent data member


   o RooAbsArg

      - Add methods graphVizTree() that produce input files
        for AT&Ts graphViz to make graphical representation
        of object tree. (To make actual graphics run 'dot -Tps -o graph.ps %s'
        where %s is argument passed to graphVizTree().

   o RooSetProxy

      - Remove stray debug print statements


   o RooSimultaneous

      - Initialize forgotten data member in all ctors


   o RooProdPdf, RooAbsAnaConvPdf

      - Make RooObjCacheManager a persistent data member
        

   o RooSuperCategory

      - Make contained iterator a transient data member
        and initialize it in the default ctor.

   
   o RooCacheManager

      - Add explicit separate default ctor.


   o RooAddModel

      - Completely new implementation, based on existing RooAddPdf.
        RooResolutionModel functionality (convolution(),basisCode())
        taken from original RooAddModel. Reimplement integration strategy
        with caching of integral objects, rather than implementing
        only common analytical component

   o RooAbsAnaConvPdf,RooResolutionModel,RooAbsPdf

      - Remove special hook function that were required for functioning
        of original RooAddModel

   o RooObjCacheManager

      - Keep all _optCacheObservables versions created alive in separate owned list
        and only delete at end in dtor to avoid dangling pointer in complex
        optimizations

   o RooAbsArg

      - In optimizeCacheMode() ignore nodes that already have been const optimized.
        Although const optimization normally happens first, late cache optimization
        that happen upon late creation of objects can take place after const optimization.



  --- Date: Tue Nov 13 12:04:55 2007 New Revision: 20774 ---

   o RooAddModel

      - Completely new implementation, based on existing RooAddPdf.
        RooResolutionModel functionality (convolution(),basisCode())
        taken from original RooAddModel. Reimplement integration strategy
        with caching of integral objects, rather than implementing
        only common analytical component

   o RooAbsAnaConvPdf,RooResolutionModel,RooAbsPdf

      - Remove special hook function that were required for functioning
        of original RooAddModel

   o RooObjCacheManager

      - Keep all _optCacheObservables versions created alive in separate owned list
        and only delete at end in dtor to avoid dangling pointer in complex
        optimizations

   o RooAbsArg

      - In optimizeCacheMode() ignore nodes that already have been const optimized.
        Although const optimization normally happens first, late cache optimization
        that happen upon late creation of objects can take place after const optimization.

   o RooMsgService

      - Some restructuring to speed up code. 

      - Change topic naming from string to enum. 

      - Change debug-level print macros to take inline pre-decision
        based on static RooMsgService boolean that indicates if any debug
        stream is active. Also extend this speedup to doLogD() macro.

      - Allow multiple Topic specifications in a single stream using bit-wise
        or to reduce default number of streams from 6 to 2.

      - Terminate matching logic to streams early for 'universal' streams
        for which the logic does not depend on object properties.


   o RooGlobalFunc

      - Change Topic() argument from RooMsgService::MsgTopic to Int_t to allow specification
        of multiple topics


   o RooDataHist, RooMsgService, RooGenContext, RooAddModel, RooFFTConvPdf
     RooAbsAnaConvPdf, RooAbsReal, RooAddPdf, RooAbsOptGoodnessOfFit, RooAbsCachedPdf
     RooProfileLL, RooObjCacheManager, RooAbsArg, RooAbsPdf, RooRealIntegral
     RooAddGenContext, RooProdGenContext, RooConvGenContext, RooProjectedPdf, RooClassFactory
     RooWorkspace, RooTreeData
 
      - Follow change in RooMsgService interface



 --- Date: Tue Nov 13 13:13:05 2007 New Revision: 20776 ---


   o RooMCStudy

     - Initialize _genParams in 2nd ctor (fixes savannah #31139)



 --- Date: Fri Nov 16 21:24:52 2007 New Revision: 20853 ---


   o RooProdPdf, RooAddition

     - Fix memory leaks found with valgrind


   o RooMsgService, RooRealConstant, RooNumIntFactory, RooMinuit, RooNameReg, RooNumIntConfig, RooArgSet

     - Add cleanup() function to delete singleton at exit


   o RooMinuit

     - Initialize _warnLevel data member (valgrind)


   o RooAddModel

     - Disable coefficient projections in convolution mode
       (savannah #31302)


   o RooTrace

     - Remove messages about objects already deleted when not in verbose mode


   o RooSentinel

     - New class handling cleanup at exit


 --- Date: Mon Nov 19 16:41:52 2007 New Revision: 20901 ---


   o Makefile

     - Makefile to build stressRooFit


   o Makefile.arch

     - Stolen from $ROOTSYS/test


   o stressRooFit

     - Driver framework, base class of unit tests and
       automatic plot, curve, fit result comparison tools
       that unit tests can request


   o TestBasic1

     - Basic test running fitting, generation and plotting on Gaussian p.d.f



 --- Date: Wed Nov 21 17:58:28 2007 New Revision: 20965 ---

  o stressRooFit

    - Add regression test support for Double_t values
      and RooTables

    - In post-test analysis mode, analyze count of
      (silent) ERROR messages and fail test if they
      occcur

    - Eliminate memory leaks in testing framework

    - Add arguments '-n <N>' to run single test and
      argument '-mc' to run suite in memory checking 
      mode in which case no references files are opened
      to avoid ROOT I/O related noise in valgrind leak reports.

    - Link in 21 new tests


  o TestBasic2 ... TestBasic22

    - New stress testing modules. Modules 4,6,7,11,21 and 22
      are empty for now. All others are fully functional.



 --- Date: Thu Nov 22 14:32:14 2007 New Revision: 20980 ---


   o test/TestBasic15, test/TestBasic16, test/TestBasic20

     - Fix memory leak in test code itself


   o test/stressRooFit

     - Activate RooFit internal memory tracing when run in memory check mode


   o RooDataHist

     - Fix memory leak


   o RooMsgService

     - Add Tracing subject

     - Fix bug in printing of multi-subject streams 

     - Keep track of total number of (silent) ERROR messages

     - Add method to access contents of stream configurations


   o RooIntegrator1D, RooIntegrator2D, RooSegmentedIntegrator1D, RooSegmentedIntegrator2D, 
     RooGaussKronrodIntegrator1D, RooAdaptiveGaussKronronIntegrator1D, RooMCIntegrator, RooGrid

     - Fix default ctor to initialize all values used in dtor


   o RooAddModel

     - Add optional boolean to ctor to take ownership of components. Used
       in RooAddModel::convolution()

     - Fix memory leak in convolution()


   o RooFitResult

     - Migrations to RooMsgService

     - Add isIdentical() method for use in regression testing


   o RooCurve, RooHist

     - Add isIdentical() method for use in regression testing


   o Roo1DTable

     - Make persistable

     - Add isIdentical() method for use in regression testing


   o RooMath

     - Migrations to RooMsgService

     - Register static memory allocation of CERF lookup table in RooSentinel
       for cleanup in atexit().


   o RooAbsReal

     - Migrations to RooMsgService

     - Fix invalid read access due to wrong destructor order in plotAsymOn()

     - Fix memory leak in plotOn()


   o RooAbsCollection

     - Restrict creation of hash tables to deep-copy operations
       or shallow copy operations of lists with >30 elements


   o RooAddPdf, RooRealVar, RooDataProjBinding, RooFormulaVar, RooTreeData

     - Migrations to RooMsgService


   o RooAbsOptGoodnessOfFit

     - Fix memory leak


   o RooAbsPdf

     - Migrations to RooMsgService

     - Fix memory leak in fitTo()


   o RooNumIntFactory
            
     - Delete all owned prototype integrators in dtor


   o RooBinning

     - Fix ctors to always initialize _xlo and _xhi


   o RooResolutioModel

     - Register static identity RooFormulaVar with RooSentinel
       for cleanup in atexit()


   o RooSimPdfBuilder

     - Migrations to RooMsgService

     - Delete all fitCats and RooSimultaneous instances created 
       by builder in dtor

     - Return non-const top-level p.d.f. from buildPdf()


   o RooLinkedList

     - First delete hash tables, then clear list instead of
       reverse order to avoid invalid read problems with TList


   o RooMinuit

     - Migrations to RooMsgService

     - Initialize MINUIT print levels to -1 if RooMsgService
       is operating in silent mode

     - Trim initial error on parameters if param +/- 2*errors
       is out of param range


   o RooSentinel

     - Add cleanup hooks from RooMath and RooResolutionModel


   o RooSimultaneous

     - Fix memory leak

     - Migrations to RooMsgService


   o  RooProjectedPdf

     - Implement RooProjectedPdf::CacheElem dtor


   o  RooTable

     - Add pure virtual isIdentical() interface

Revision 20161 - (view) (download) (as text) (annotate) - [select for diffs]
Added Mon Oct 1 16:28:25 2007 UTC (7 years, 3 months ago) by wouter
Original Path: trunk/roofitcore/src/RooObjCacheManager.cxx
File length: 4644 byte(s)

   o RooAbsCache

    - New abstract base class for cache objects associated with RooAbsArgs.
      Caches register themselves with the owning RooAbsArg and propagate
      all necessary state changes and meta information to objects in the cache


   o RooCacheManager

    - Concrete template implementation of RooAbsCache with an interface
      and functionality styled after RooNormListManager. The template class
      provide no special handling for cache contents that includes RooAbsArg
      objects and does not forward hook calls. It is thus mostly intended
      to cache basic types indexed on a normalization/integration configuration


   o RooObjCacheManager

    - Class derived from RooCacheManager<RooAbsCacheElement> that implements
      all proper call forwarding and handling of state and other meta information
      to RooAbsArg objects embedded in the cache elements. To facilitate this
      functionality the RooAbsCacheElement defines a pure virtual method
      containedArgs() that must be implemented to expose its contents to
      the cache manager. The default behavior on a serverRedirect hook is
      to sterilize the cache. OperMode changes are not forwarded by default
      to the cache contents as cached objects do not necessarily have the
      same operation mode (e.g. if the cache contains an integral of its owner).
      Any calls to optimizeCacheMode(), printCompactTreeHook(), and findConstantNodes()
      are forwarded. Moreover, optimizeCacheMode() calls are remembered and
      any objects inserted in the cache after such a call was received will be
      optimized upon insertion in the cache

   o RooAbsCacheElement

    - Abstract base class for objects to be managed by RooObjCacheManager. Each
      object must in addition to its payload implement the containedArgs()
      member function that exposes the RooAbsArg object content to the manager
      for processing. The argument passed to containedArgs() indicates the use
      case for the returned list of objects, allowing the cache payload to
      return different lists depending upon use. This is for most applications
      not required.


   o RooAbsCachedPdf

    - Abstract base class derived from RooAbsPdf for p.d.f.s that implement 
      value caching in a grid over the entire domain of the observables. 
      The base class implements the overall caching logistics and manages
      the RooDataHists and RooHistPdfs that respresent the cached contents.
      Derived classes must inputBaseName() defined a unique name prefix for
      all cache objects, actualObservales() and actualParameters() to
      determined the actual observables and parameters given a set of 
      available observables and fillCacheObject() which should fill the
      RooDataHist cache for a given obs/params configuration with the
      p.d.fs values.


   o RooAbsSelfCachedPdf

    - Abstract base class derived from RooAbsCachedPdf that implements
      all of the required logistics in RooCachedPdf and only require
      derived classes from RooAbsSelfCachedPdf to implement evaluate().
      Any class derived from RooAbsPdf can thus be trivially switched
      to derived from RooAbsSelfCachedPdf and gain the caching functionality.
      

   o RooCachedPdf

    - Concrete class derived from RooAbsCachedPdf that implements
      the caching of an externally provided p.d.f in the constructor.


   o RooFFTConvPdf

    - Concrete class derived from RooAbsCachedPdf that implement generic
      numeric convolution of two input p.d.f.s using FFT technique
      and convolution theorem. Actual FFTs are calculated by FFTW
      through TVirtualFFT interface in ROOT. Present implementation only supports 
      convolution in one dimension, but this will be extended later
      as there are no fundamental limitations in RooAbsCachedPdf nor FFTW.
 

   o RooHistPdf

    - Moved from RooFit to RooFitCore because it is used by caching classes


   o RooProdPdf

     - Use new RooObjCacheManager to store partial objects

     - Fix memory leak (already patched in 15.0.14h)


   o RooDataHist

     - Use new RooCacheManager template to cache partial bin volumes

     - Add new set(),setAllWeights() method to update current weight and all weights
       respectively, for use in cached p.d.f.s

     - Add sliceIterator() that iterates over all bins in a lower dimensional 
       slice of the dataset


   o RooDataHistSliceIter

    - Class derived from TIterator that implements the iteration
      over a slice in a reduced number of dimensions in a RooDataHist


   o RooMsgService

     - Speed up processing of debug streams in cases where no debug streams are active

     - add macros series oocoutX and oocxcoutX that allow to associate message with
       a different object than *this

   o RooRealBinding

     - Interface new setValue method that allows value to be set outside default
       domain, but inside given alternate named range. For use in numeric integrator
       bindings


   o RooAbsRealLValue

     - Add new inRange() method with range name specifier to check against chosen
       range instead of default range


   o RooCmdConfig

     - Fix dangling return pointer problem in decodeStringOnTheFly() method


   o RooNameSet

     - Fix bug in refoll()


   o RooChi2Var, RooNLLVar

     - Add processing of AddCoefRange() named argument


   o RooConvCoefVar

     - Hold p.d.f in proxy without value/shape state propagation to obtain
       correct dependency of RooConvCoefVar through separate set proxy
       with parameters that do have state propagation

     - In getAnalyticalIntegral() ask for integration coefficient specific
       to coefficient (following interface change in RooAbsAnaConv)


   o RooEfficiency

     - Follow interface change in RooCategoryProxy


   o RooAbsAnaConvPdf

    - Use new RooObjCacheManager to hold normalization and coefficient representations

    - Extend getCoefAnalyticalIntegral() interface so that each coefficient
      can have a separate integration configuration

    - Modify makeCoefVars() such that it constructs the RooConvCoefVars with
      actual dependents for each coefficients, rather than inserting dependencies
      of any of the coefficients in each coefficient. This logic requires support
      from the implementation class that is interface through a new member function
      coefVars()


   o RooAbsReal 

    - Add Boolean data member treeVar that indicates is value buffer is also
      branch buffer of a tree. This information is already present in the RooAbsReal
      but is relatively expensive to retrieve and is always needed in the inner
      loop of data set operations. This extra member significantly speeds up operations

    - Remove superfluous _norm[] token in name returned by integralNameSuffix() if 
      no normalization set is supplied.

    - Add a fillDataHist() method that fills a given RooDataHist with a sampling
      of the given function. Added for support of caching p.d.f.s


    - Downgrading warning on non-dependent projection variables in plotOn() to
      a debug level message

    - Remove function optimizeDirty(),doConstOpt(),undoConstOpt(),findCacheableBranches()
      findUnusedDatasetVariables() and findRedundantCacheServers() as part of reorganization
      of optimization functionality.


   o RooAbsCollection

    - Use iterator semantics instead of vector semantics to process RooLinkedList
      contents in assignment operator

    - Add utility function contentsString() returning stl string with names
      of contents


   o RooAddPdf

    - Rewrite cache management using new RooObjCacheManager that holds projection
      integrals, range integrals and supplemental normalization lists


   o RooAbsOptGoodnessOfFit

    - Improve handling of normalization ranges and reference ranges for test statistics
      containing RooAddPdfs. New named argument in fitTo() and RooNllVar::ctor() pass
      reference range for fractions in RooAddPdf components that do not have an explicit
      fixed definition already. Name all normalization ranges explicitly after the
      subrange to which the're applied to avoid name clashes and conflicts if multiple
      normalization ranges are involved.

    - Rewrite informational messages through RooMsgService

    - Implement new constOptimizeTestStatistic() function that signals all test statistic
      components of a RooAbsArg expression tree to perform their constant term optimization

    - Implement new optimizeCaching() driver function that changes default lazy-evaluation-with-caching
      scheme to test statistic scheme where only parameters objects propagate state changes and
      where all components that depend directly or indirectly on observables have lazy evaluation
      disabled. Changes to p.d.f objects are delegated to RooAbsPdf::optimizeCacheMode(). Changes
      to dataset are delegated to RooAbsData::optimizeReadingWithCaching()

    - Implement new optimizeConstantTerms() function that is back end for constOptimizeTestStatistic
      implementation. 


  o RooAICRegistry, RooNormSetCache

    - Remove tracking of allocation cycles of RooArgSets as this scheme is superseded by
      memory pool mechanism for RooArgSet allocation


  o RooMappedCategory

    - Follow interface change in RooCategoryProxy.


  o RooRealMPFE

    - Follow reorganization of optimization functionality: implement new constOptimizeTestStatistic
      function for forwarding to slave processes.


  o RooRealVar

    - Add new setVal() function with range name to facilite setting of values that are outside
      default range, but inside specified alternate range. Needed for numeric integration and
      certain RooAddPdf coefficient projection.


  o RooAbsArg

    - Make state management functions public [is/set][Value/ShapeDirty](), setOperMode90
  
    - Add static _flipAClean boolean to support setACleanAdirty() static method.

    - Implement mechanism for registration of cache objects with base class RooAbsCache.
      Forward all calls to operModeHook(), redirectServersHook(), optimizeCacheMode()
      and printCompactTreeHook() to all caches for further processing
   
    - Define constOptimize() function and provide default implementation that forwards
      to all servers 

    - Implement optimizeCacheMode() function that puts expression tree in optimized
      caching for test-statistics operations (only cache/lazy evaluate nodes that
      do not (indirectly) depend on observables

    - Implement findConstantNodes() function that identifies all nodes that depend
      exclusively on constant observables and >0 observables that are eligible
      for precalculation and caching in test statistics operations by 
      RooAbsOptTestStatistic::optimizeConstantTerms()

    - Define constOptimizeTestStatistics that signal an expression tree that any
      embedded test statistic objects should perform their constant term optimization.
      Default implementation in RooAbsArg forwards call to all servers.


  o RooAbsPdf

    - Use new RooObjCacheManager to manage normalization integrals cache.

    - Process new SumCoefRange() option in fitTo() that sets the coeffient
      interpretation range for all embedded RooAddPdf objects of which
      the interpretation range was not explicitly set

    - Extend interface of fixAddCoefNormalizationSet(): add extra argument
      that controls if AddCoef normalization set are forcibly overruled
      for objects that already have an explicit range setting.

  
   o RooRealIntegral 

    - Add some informational messaging through RooMsgService, rewrite existing ones

    - Speed up numeric summations by precreating the involved RooSuperCategory
      in the ctor rather than in evaluate().

    - Fix bug in dependency insertion: explicitly require servers to be value
      server to avoid pulling in fake dependents.
    
    - Remove obsolete data members

    - Implement new setACleanADirty() function that atomically flips state of
      all AClean objects to ADirty for the duration of the integration step.
      Replaces the much more expensive prepareACleanFunc() that did this
      only for the objects involved.

    - Process factorizing terms in integral only if the list is not empty

    - Process Jacobian terms in integral only if the list is not empty


  o RooAddGenContext

   - Adapt to cache management chanches in RooAddPdf


  o RooNumIntFactory

   - Use STL classes for internal memory management


  o RooSetProxyy

   - Implement operator new() and operator() delete as required because
     RooArgSet implements them 


  o RooAbsGoodnessOfFit

   - Store and forward AddCoefRange information for embedded RooAddPdf objects

   - Implement constOptimizeTestStatistic() and forward to components


  o RooErrorVar

   - Follow inRange() interface change in RooAbsRealLValue


  o RooConvGenContext

    - Adapt code to make it work with both RooAbsAnaConv objects and
      the newly introduced RooFFTConvPdf


  o RooMinuit

    - Follow reorganization of optimization functionality


  o RooProjectedPdf

    - Store projection using new RooObjCacheManager


  o RooGlobalFunc

    - Add RooFit::SumCoefRange() named argument for RooAbsPdf::fitTo() 
      and RooNLLVar::ctor() and RooChi2Var::ctor()


  o RooClassFactory

    - Extend existing makePdf(),makeFunction and makeClass() functions
      to also accept RooAbsCategory arguments, to accept an optional string
      inserted as the return value expression inserted in the 
      evaluate() method of the class created, as well as as option string
      specifying one or more analytical integrations of the given function
      expression that will be advertised in the generated getAnalyticalIntegral()
      code and implemented in the generated analyticalIntegral() code

    - Add makeAndCompileFunction() and makeAndCompilePdf methods that
      generate the code and immediate compile it through ROOTs ACliC interface.
      These functions have a simpler interface because the list of arguments
      of the function to be created can be specified as a const RooArgSet&
      rather than a string with a list of names, thus making it easier
      for on-the-fly definition of compiled objects.

    - Add defineFunction() and definePdf() methods define and compile
      a function/pdf using the above functions and immediately instantiate
      an object of the given type passing the specified RooArgSet arguments
      to the constructor of the object. These functions make a compiled
      equivalent of RooFormulaVar based on the TFormula interpreter, i.e.

           RooAbsReal* f = new RooFormulaVar("f","D(1-2w)",RooArgSet(D,w)) ;

      becomes
       
           RooAbsReal* f = RooClassFactory::defineFunction("f","D(1-2w)",RooArgSet(D,w)) ;

   
  o RooAbsCategory

   - Add Boolean data member treeVar that indicates is value buffer is also
     branch buffer of a tree. This information is already present in the RooAbsReal
     but is relatively expensive to retrieve and is always needed in the inner
     loop of data set operations. This extra member significantly speeds up operations

   - Construct explit clean name for TBranch name if node is cached, equivalent
     to what is done in RooAbsReal. Needed because new constOptimizer can also
     cache RooAbsCategory objects


  o RooArgSet

   - Implement operator new() and operator delete() to implement memory pool scheme
     for RooArgSets. The goal of this implementation is to insure that two RooArgSet
     pointers are _never_ the same. This allows to RooNormSet cache manager to safely
     and quickly index integration and normalization configurations by evaluating
     the contents of a RooArgSet only the first time it sees it.


  o RooSimultaneous

   - Implement caching of partial integrals using new RooObjCacheManager

   - Following interface change in RooCategoryProxy ;


  o RooAbsData

   - Defined pure virtual methods optimizeReadingWithCache() and allClientsCached()


  o RooTreeData

   - Implement optimizeReadingWithCache() which determines given a p.d.f to be
     evaluated and a list of the nodes that are cached for it, which observables
     in the dataset are no longer required because they are either not an observable
     of the p.d.f, or they exclusively feed nodes that are cached. Reading of these
     observables is disabled through SetBranchStatus().
  
   - Move allClientsCached() utility function here from RooAbsReal.


  o RooCategoryProxy

   - Remove const char*() conversion operator in favor of a const char* label() method
     to remove possibly ambiguities in C++ math expressions involving category proxies.


  o LinkDef3.h

   - Add newly defined classes

This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.

Links to HEAD:	(view) (download) (as text) (annotate)
Sticky Revision: