[root] / trunk / roofit / roostats / src / AsymptoticCalculator.cxx Repository:
ViewVC logotype

Log of /trunk/roofit/roostats/src/AsymptoticCalculator.cxx

Parent Directory Parent Directory


Links to HEAD: (view) (download) (as text) (annotate)
Sticky Revision:

Revision 47326 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Nov 15 17:25:55 2012 UTC (2 years, 2 months ago) by moneta
File length: 57859 byte(s)
Diff to previous 47005
Fix in Asymptoticcalculator the case when the number of bins in the observables are not enough. 
Add a parameter in the constructor to pass a new value of bins for making the Asimov data set

Revision 47005 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Nov 2 14:56:00 2012 UTC (2 years, 2 months ago) by moneta
File length: 57063 byte(s)
Diff to previous 46094
Fix AsymptoticCalculator to change in RooStats utils to not return always a product in case of one single nuisance pdf. 
Try to use in AsymptoticCalculator the same binning for Asimov data set as for observed data sets. This fixes a problem reported by a user
with a binned model.

Revision 46094 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Sep 20 20:26:05 2012 UTC (2 years, 4 months ago) by moneta
File length: 55527 byte(s)
Diff to previous 46081
fix generation of Asimov data sets for counting model made by a single pdf with many observables

Revision 46081 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Sep 20 13:34:46 2012 UTC (2 years, 4 months ago) by moneta
File length: 54942 byte(s)
Diff to previous 45684
implement the possibility to pass the ConditionalObservables when creating the NLL or doing a fit
In this case the NLL will be computed by normalizing only on the observables and excluding the fglobal observables. 
See http://root.cern.ch/phpBB3/viewtopic.php?f=15&t=15312

Revision 45684 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Aug 22 10:03:46 2012 UTC (2 years, 5 months ago) by moneta
File length: 54329 byte(s)
Diff to previous 45143
fix a bug in the AsymptoticCalculator in setting qmu-tilde for computing limit (thanks to M. Baak who reported this).  The bug  affects only the first scanned point

Revision 45143 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Jul 19 23:16:50 2012 UTC (2 years, 6 months ago) by moneta
File length: 54344 byte(s)
Diff to previous 44768
apply patch from Gabriel: 

 fixes the SimpleLikelihoodRatio by removing constraints terms from pdf. Add in RooStatsUtils funciton to factorize pdf and remove constraint (MakeUNconstrainedPdf)
 Remove also some reduntant code in AsymptoticCalculator and use RooStats utils

add in stressRooStats new tests of SimpleLikelihoodRatio and update reference file

Revision 44768 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Jun 27 14:26:15 2012 UTC (2 years, 6 months ago) by moneta
File length: 54981 byte(s)
Diff to previous 44366
do not call in AsymptoticCalculator SetBackgroundAsAlt(true) since it does not applies in case of hypothesis test 
(for limits  it is called inside the inverter)
add a tolerance for checking qhen qmu is less than zero for numerical errors in computation of qmu

Revision 44366 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed May 30 15:32:27 2012 UTC (2 years, 7 months ago) by axel
File length: 54854 byte(s)
Diff to previous 44339
Remove #include "Riostream.h" from roofitcore/inc/RooCacheManager.h, which pulls in using namespace std.
Deal with the consequences.

Revision 44339 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue May 29 13:05:03 2012 UTC (2 years, 7 months ago) by moneta
File length: 54833 byte(s)
Diff to previous 44268
use correctly RooAbsReal instead of a wrong cast to RooNLLVar for the returned object of RooAbsPdf::createNLL

Revision 44268 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed May 16 12:49:25 2012 UTC (2 years, 8 months ago) by moneta
File length: 54846 byte(s)
Diff to previous 44266
fix a compilation warning

Revision 44266 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed May 16 12:32:18 2012 UTC (2 years, 8 months ago) by moneta
File length: 54836 byte(s)
Diff to previous 44156
apply some Coverity fixes
improve some error messaging in AsymptoticCalculator and automatically set onesideddiscovery if null snapshot is equal to minimum of parameter at construction time

Revision 44156 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon May 7 16:37:38 2012 UTC (2 years, 8 months ago) by moneta
File length: 53515 byte(s)
Diff to previous 44152
- AsymptoticCalculator:: do a fix for bins where pdf is zero when generating Asimov data sets
- HypoTestInverterResult: another fix for lower/upper limit search

Revision 44152 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon May 7 10:30:54 2012 UTC (2 years, 8 months ago) by moneta
File length: 53337 byte(s)
Diff to previous 44130
fix a printing message and add default to teh GetExpectedPValue function to make it backward compatible

Revision 44130 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat May 5 10:08:31 2012 UTC (2 years, 8 months ago) by moneta
File length: 53297 byte(s)
Diff to previous 44126
fixes for Coverity and improve upper/lowerlimit search in InverterResult

Revision 44126 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri May 4 16:55:47 2012 UTC (2 years, 8 months ago) by moneta
File length: 53270 byte(s)
Diff to previous 44101
- fix in AsymptoticCalculator the formulae for the two-sided test statistics for both observed and expected p values
- improve search for upper/lower limit in InverterResult
  add also a flag to indicate in the InverterResult if it comes from using a two sided test statistic.  
 This is needed to use the right formula for the asymptotic case. 

- Add also possibility to skip and to not draw the points where there is a failing fit or any other error

- Add in Profile likelihood possibility to query if the test statistic is one or two sided

Revision 44101 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu May 3 16:38:46 2012 UTC (2 years, 8 months ago) by moneta
File length: 51498 byte(s)
Diff to previous 44059
fix asymptotic calculator for 2-sided test statistic
and for one sided discovery
- add also method to retrieve the global best fit parameters

Revision 44059 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed May 2 07:38:48 2012 UTC (2 years, 8 months ago) by moneta
File length: 48208 byte(s)
Diff to previous 44034
- BayesianCalculator: do not require anymore to have a prior pdf when using an uniform prior
  Make it default case as in case of MCMCCalculator

- AsymptoticC. : fix a comment

Revision 44034 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Apr 30 14:54:15 2012 UTC (2 years, 8 months ago) by moneta
File length: 48208 byte(s)
Diff to previous 43228
Verious fixes for outstanding Coverity issues (mainly add check of returned pointers to avoid  to dereference them)

Revision 43228 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Mar 2 16:27:43 2012 UTC (2 years, 10 months ago) by moneta
File length: 48332 byte(s)
Diff to previous 43189
- fix a memory leak by deleting the RoOFitResult created from RooMinimizer
 - some fixes for printout and tolerance

Revision 43189 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Mar 1 11:16:40 2012 UTC (2 years, 10 months ago) by moneta
File length: 48326 byte(s)
Diff to previous 43118
- fix the restoring of log messages in case the NLL was not fitted
- fix generation of Asimov data for simple (not-extended) Gaussian models

Revision 43118 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Feb 24 15:35:25 2012 UTC (2 years, 10 months ago) by moneta
File length: 46749 byte(s)
Diff to previous 43091
do some cleanup of log messages

Revision 43091 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Feb 22 13:56:28 2012 UTC (2 years, 11 months ago) by moneta
File length: 45443 byte(s)
Diff to previous 42833
merge from 5.32 patches fix http://root.cern.ch/viewvc?view=rev&revision=43090
in the AsymptoticCalculator.

Revision 42833 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Jan 31 16:07:14 2012 UTC (2 years, 11 months ago) by moneta
File length: 45309 byte(s)
Diff to previous 42829
add option in the constructor to use the nominal Asimov data set (i.e. the one where nuisance have nominal values when generating the data set)

Revision 42829 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Jan 31 07:48:33 2012 UTC (2 years, 11 months ago) by moneta
File length: 44344 byte(s)
Diff to previous 42828
fix for  coverity (41625)

Revision 42828 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Jan 30 16:55:11 2012 UTC (2 years, 11 months ago) by moneta
File length: 44273 byte(s)
Diff to previous 42730
implement a new version of MakeAsimovData where one passes just model and parameter values. 
In this case the nuisance parameters are not set to the fitted value from the observed data but they are kept
at their nominal values
Implement the old method using the new one

Revision 42730 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Jan 19 14:40:31 2012 UTC (3 years ago) by moneta
File length: 42521 byte(s)
Diff to previous 42603
fix checking of status code in case one is running Improve. 
 Fix also loops on trying the fit when evaluating the PL test statistics to avoid 
re-fitting with the same conditions

Revision 42603 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Jan 13 08:31:20 2012 UTC (3 years ago) by moneta
File length: 42070 byte(s)
Diff to previous 42482
fix a bug in making the Asimov data set (in setting t he global observables to the right value) with the workspace generated with the new version of the Histfactory
In this case the constraint terms are of like Gaussian( glob_obs, func( nuis_param) ), and therefore the global observable must be set to 
glob_obs_ASIMOV = func(nuis_param_MLE )  and not glob_ASIMOV = nuis_param_MLE as it was done before

Revision 42482 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Dec 13 17:35:39 2011 UTC (3 years, 1 month ago) by moneta
File length: 38761 byte(s)
Diff to previous 42324
fix to set back the  of poi to non-const after having create the Asimov data set. 
 The initial Asimov data fit is still done with a fixed poi value (e.g. mu=0) 

- when fitfing for finding the best conditional nuisance parameters for the Asimov data set,  use the user default minimizer

Revision 42324 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Nov 30 16:31:03 2011 UTC (3 years, 1 month ago) by moneta
File length: 38428 byte(s)
Diff to previous 42274
fix the possibility to pass a different tolerance when using the profile likelihood

Revision 42274 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Nov 28 14:35:42 2011 UTC (3 years, 1 month ago) by moneta
File length: 38237 byte(s)
Diff to previous 42259
use optimizeCOnst(2)

Revision 42259 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Nov 25 21:29:16 2011 UTC (3 years, 1 month ago) by moneta
File length: 38240 byte(s)
Diff to previous 42258
fix evaluating NLL on asimov data set in case of no nuisance parameters

Revision 42258 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Nov 25 20:57:12 2011 UTC (3 years, 1 month ago) by moneta
File length: 38266 byte(s)
Diff to previous 41995
- change  MakeAsimovData to be a static function which can be used outside the class
- fix a bug  when models do not have nuisance parameters

Revision 41995 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Nov 15 10:05:31 2011 UTC (3 years, 2 months ago) by moneta
File length: 37419 byte(s)
Diff to previous 41799
use qtilde automatically when poi is limited and minimum = B=0 value

Revision 41799 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Nov 7 17:39:20 2011 UTC (3 years, 2 months ago) by moneta
File length: 36557 byte(s)
Diff to previous 41754
- fix a problem in computing minimum of NLL 
 - fix printout in profileLL test statistics according to a print level

Revision 41754 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Nov 3 16:21:13 2011 UTC (3 years, 2 months ago) by rdm
File length: 36338 byte(s)
Diff to previous 41748
fix issues causing compilation failures on Solaris with CC5.

Revision 41748 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Nov 3 12:54:23 2011 UTC (3 years, 2 months ago) by moneta
File length: 36318 byte(s)
Diff to previous 41455
use optimize const when minimizing the likelihood

Revision 41455 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Oct 18 13:23:21 2011 UTC (3 years, 3 months ago) by moneta
File length: 36321 byte(s)
Copied from: branches/dev/roostats/roofit/roostats/src/AsymptoticCalculator.cxx revision 41454
Diff to previous 41409
merge from development branch r41278 through r41454 
 - add new AsymptoticCalculator and its support in HypoTestInverter
 - add utility function to make the nuisance pdf
   + various small improvements

Revision 41409 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Oct 17 07:23:10 2011 UTC (3 years, 3 months ago) by moneta
Original Path: branches/dev/roostats/roofit/roostats/src/AsymptoticCalculator.cxx
File length: 36321 byte(s)
Diff to previous 41390
- add some comments and improve debugging. Load also null snapshot before doing global fit instead of alt one
- Cleanup of SimpleLikelihoodRatioTestStat.h. Remove usage of workspace which duplicated all the model and waste memory

Revision 41390 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Oct 14 08:11:17 2011 UTC (3 years, 3 months ago) by moneta
Original Path: branches/dev/roostats/roofit/roostats/src/AsymptoticCalculator.cxx
File length: 33357 byte(s)
Diff to previous 41382
fix compution of CLb for the case of qtilde 
+ some debugging improvements

Revision 41382 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Oct 13 13:49:11 2011 UTC (3 years, 3 months ago) by moneta
Original Path: branches/dev/roostats/roofit/roostats/src/AsymptoticCalculator.cxx
File length: 32831 byte(s)
Diff to previous 41344
do some cleanup of error and debug messages

Revision 41344 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Oct 11 20:01:00 2011 UTC (3 years, 3 months ago) by moneta
Original Path: branches/dev/roostats/roofit/roostats/src/AsymptoticCalculator.cxx
File length: 28873 byte(s)
Diff to previous 41303
fix resetting of global observables to their previous value after using Asimov data set

Revision 41303 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Oct 10 13:56:00 2011 UTC (3 years, 3 months ago) by moneta
Original Path: branches/dev/roostats/roofit/roostats/src/AsymptoticCalculator.cxx
File length: 27716 byte(s)
Diff to previous 41286
add expected limits ofr asymptotic calculator

Revision 41286 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Oct 7 16:10:43 2011 UTC (3 years, 3 months ago) by moneta
Original Path: branches/dev/roostats/roofit/roostats/src/AsymptoticCalculator.cxx
File length: 27016 byte(s)
Diff to previous 41278
add new code (from Giovanni) for setting global observables values when making  Asimov data sets

Revision 41278 - (view) (download) (as text) (annotate) - [select for diffs]
Added Fri Oct 7 12:48:28 2011 UTC (3 years, 3 months ago) by moneta
Original Path: branches/dev/roostats/roofit/roostats/src/AsymptoticCalculator.cxx
File length: 27785 byte(s)
first version of Asymptotic calculator + add utility (from Giovanni Petrucciani) for make constraint pdf

This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.

  Diffs between and
  Type of Diff should be a

Sort log by:

Subversion Admin
ViewVC Help
Powered by ViewVC 1.0.9