[root] / trunk / tree / tree / src / TFriendElement.cxx Repository:
ViewVC logotype

Log of /trunk/tree/tree/src/TFriendElement.cxx

Parent Directory Parent Directory


Links to HEAD: (view) (download) (as text) (annotate)
Sticky Revision:

Revision 43993 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Apr 27 16:23:16 2012 UTC (2 years, 8 months ago) by pcanal
File length: 7962 byte(s)
Diff to previous 35378
Fix coverity issues
Dereference null return:
32943,32945,36325,36329: TFormLeafInfo::GetLocalValuePointer
33253: TTreeFormula::EvalObject
33763: CloneTree
33258: GetBasket
34034: In DropBuffers (in addition avoid reading the basket when the intend is to drop the content from memory!)
36307: TTree::BuildIndex
36328: DrawCopy
36332: GetStreamerInfoCache
33025: BuildStreamerInfo
42469: Clone
33436: MakeIterator
Dereference after null check.
42470: in ImportStreamerInfo
33138: in TEntryListArray::Enter
Unchecked return value:
32049, 32050: TBranchProxy::Read and Setup
Mixed enums:
32705,32706: TClass::fStreamerType (and also name the enum type).

Revision 35378 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Sep 17 13:55:42 2010 UTC (4 years, 4 months ago) by brun
File length: 7938 byte(s)
Diff to previous 35376
Fix another null_return. coverity

Revision 35376 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Sep 17 13:43:00 2010 UTC (4 years, 4 months ago) by brun
File length: 7911 byte(s)
Diff to previous 25057
Fix null_return. coverity CID 11090

Revision 25057 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Aug 5 18:34:34 2008 UTC (6 years, 5 months ago) by pcanal
File length: 7884 byte(s)
Diff to previous 25054
fix typo in rev 25054

Revision 25054 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Aug 5 14:39:21 2008 UTC (6 years, 5 months ago) by pcanal
File length: 7872 byte(s)
Diff to previous 22902
If the TreeFriend is entered via a TTree*, properly detect that it is in the same file and do _not_ record the filename (since we will alway know where to find it\!)

Revision 22902 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Mar 31 09:48:42 2008 UTC (6 years, 9 months ago) by rdm
File length: 7400 byte(s)
Diff to previous 22805
move tree, treeplayer and treeviewer under tree meta directory.

Revision 22805 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Mar 20 22:04:03 2008 UTC (6 years, 10 months ago) by pcanal
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 7400 byte(s)
Diff to previous 20882
Remove unnecessary change of the current ROOT directory
and reduce the span of those that are still compulsory
(hence aiding threadsafety)

Revision 20882 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Nov 19 11:31:26 2007 UTC (7 years, 2 months ago) by rdm
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 7397 byte(s)
Diff to previous 19826
Set property svn:eol-style LF on all source and Makefiles. This should avoid
problems with Win32 line endings ending up in the repository. All MS tools
support LF eols fine.

Revision 19826 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Sep 19 19:56:11 2007 UTC (7 years, 4 months ago) by rdm
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 7397 byte(s)
Diff to previous 19825
imported svn:keywords Id property

Revision 19825 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Sep 19 19:49:10 2007 UTC (7 years, 4 months ago) by rdm
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 7456 byte(s)
Diff to previous 17173
remove :$ from tag line

Revision 17173 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Dec 12 10:35:20 2006 UTC (8 years, 1 month ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 7466 byte(s)
Diff to previous 17121
In TFriendElement::GetFile replace "new TFile" by "Tfile::Open" such that
a friend file can be accessed via rootd, xrootd, etc.

Revision 17121 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Dec 8 17:29:26 2006 UTC (8 years, 1 month ago) by pcanal
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 7464 byte(s)
Diff to previous 15810
From Stefan Otto:
If a TChain that has friend TChains is cloned via TTree::CloneTree(), the TFriendElements of the cloned TTrees create unowned files that are not closed by deleting the cloned TChain. Please see attached macro and proposed fix for details.

Revision 15810 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Jul 14 19:52:44 2006 UTC (8 years, 6 months ago) by pcanal
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 7438 byte(s)
Diff to previous 15260
Prevent TFriendElement::GetFile from changin gDirectory/gFile
Properly lookup a chain name in gROOT (instead of the current
directory).  This repairs the case ch->AddFriend(chainname)
when ch is not stored in gROOT.

Revision 15260 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed May 31 10:05:49 2006 UTC (8 years, 7 months ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 7577 byte(s)
Diff to previous 13207
From Federico:
More cleanup for gcc effc++

Revision 13207 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Nov 11 22:16:04 2005 UTC (9 years, 2 months ago) by pcanal
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 6871 byte(s)
Diff to previous 10167
Update the spacing and documentation to match the coding rule

Revision 10167 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Sep 24 18:22:46 2004 UTC (10 years, 4 months ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 6880 byte(s)
Diff to previous 7149
From Philippe:
TFriendElement is never really the owner of the
TTree is points (in the common case, the TFile objects owns it).

In case where the TTree and its friend are in the same file, this
leads to a double deletion of the friend tree.

The solution is to just remove the deletion of the TTree from
the TFriendElement destructor.

The only downside is that in the case (should be rare!) where
the TFriendElement does not own the TFile and the TFriendElement
is deleted then the TTree will be kept in memory until the file
is deleted.

Revision 7149 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Aug 23 14:53:41 2003 UTC (11 years, 5 months ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 7152 byte(s)
Diff to previous 5717
From Philippe

There is a bug in the Friend implementation.  If the tree (to which you add friend to) is memory resident it's
directory has to be zero.

Revision 5717 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Dec 2 18:50:12 2002 UTC (12 years, 1 month ago) by rdm
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 6987 byte(s)
Diff to previous 5107
mega patch to remove almost all compiler warnings on MacOS X where the
compiler is by default in pedantic mode (LHCb also like to use this option).
The following issues have been fixed:
- removal of unused arguments
- comparison between signed and unsigned integers
- not calling of base class copy ctor in copy ctor's
To be done, the TGeo classes where we get still many hundred warnings of
the above nature. List forwarded to Andrei.

Revision 5107 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Aug 9 22:35:03 2002 UTC (12 years, 5 months ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 6995 byte(s)
Diff to previous 4827
This patch prevents core dumps if the file of a tree friend is missing.  This can easily happen if a friend is
attached to a tree before it is saved and then in a new session (several days later :)) the tree is reloaded
and analyzed when the original friend is missing.

Philippe.

Revision 4827 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Jul 6 06:54:35 2002 UTC (12 years, 6 months ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 6907 byte(s)
Diff to previous 4773
From Philippe
This patch solves an ownership problem (friend chains on the stack were
delete), it also fix a problem with refreshing the pointer to the leaf
when the leaf was accessed using a tree-alias name.  It also enables the
befriending of chains contains series of trees of unequal size (in
parallel).

It also re-enable using string (char*) store into a TClonesArray using a
TTree::Draw command (in the current version it was reading repetitively
the string of the 1st element).

Revision 4773 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Jun 25 05:47:51 2002 UTC (12 years, 7 months ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 6776 byte(s)
Diff to previous 2832
Fixes by Philippe to support Tree friends with TChains.
Still some limitations.The chains have to have a list of file
which have (in parallel) the same number of event.  (This is because
(for now) the length of each tree is compared with the other trees).
Also I did not test saving and reloading chains with friend.

Revision 2832 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Sep 22 10:06:56 2001 UTC (13 years, 4 months ago) by rdm
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 5601 byte(s)
Diff to previous 2390
Support also friends in already open TFile's, i.e. new method AddFriend()
taking a TFile* instead of a "filename".

Revision 2390 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Jun 7 08:40:13 2001 UTC (13 years, 7 months ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 4676 byte(s)
Diff to previous 2085
Fix a typo in comments

Revision 2085 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Apr 27 08:03:06 2001 UTC (13 years, 9 months ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 4677 byte(s)
Diff to previous 1949
Initialize fParentTree to the current Tree in the default constructor.
This is necessary when reading a Tree with a list of friends.

Revision 1949 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Apr 10 16:34:51 2001 UTC (13 years, 9 months ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 4647 byte(s)
Diff to previous 1912
Add support for Tree aliases. This is useful when two files contain the same Tree
structure (Trees with same names) and one wants to correlate variables from
the two trees.

Revision 1912 - (view) (download) (as text) (annotate) - [select for diffs]
Added Mon Apr 9 07:52:33 2001 UTC (13 years, 9 months ago) by brun
Original Path: trunk/tree/src/TFriendElement.cxx
File length: 4270 byte(s)
New class TFriendElement:
//                                                                      //
// A TFriendElement TF describes a TTree object TF in a file.           //
// When a TFriendElement TF is added to the the list of friends of an   //
// existing TTree T, any variable from TF can be referenced in a query  //
// to T.                                                                //
//                                                                      //
// To add a TFriendElement to an existing TTree T, do:                  //
//       T.AddFriend("friendTreename","friendTreeFilke");               //
//                                                                      //
//  see TTree::AddFriend for more information                           //

This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.

  Diffs between and
  Type of Diff should be a

Sort log by:

Subversion Admin
ViewVC Help
Powered by ViewVC 1.0.9