[root] / trunk / tree / treeplayer / src / TChainIndex.cxx Repository:
ViewVC logotype

Log of /trunk/tree/treeplayer/src/TChainIndex.cxx

Parent Directory Parent Directory


Links to HEAD: (view) (download) (as text) (annotate)
Sticky Revision:

Revision 44719 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Jun 25 17:22:37 2012 UTC (2 years, 6 months ago) by pcanal
File length: 14411 byte(s)
Diff to previous 43397
Fix off by one error introduced in revision 43390 ; this fixes <http://savannah.cern.ch/bugs/?94910> (TChained Tree index returns wrong entry on GetEntryNumberWithIndex)

Revision 43397 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Mar 19 22:22:43 2012 UTC (2 years, 10 months ago) by pcanal
File length: 14410 byte(s)
Diff to previous 43390
GetEntryNumberWith[Best]Index is not suppose to complain on stderr/stdout when the index is out of range, just return -1. (also remove debug '0' in if statement)

Revision 43390 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Mar 19 18:45:12 2012 UTC (2 years, 10 months ago) by pcanal
File length: 14409 byte(s)
Diff to previous 38501
Properly handle the case where the requested index is too high. (See http://root.cern.ch/phpBB3/viewtopic.php?p=61833

Revision 38501 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Mar 18 11:44:33 2011 UTC (3 years, 10 months ago) by pcanal
File length: 14174 byte(s)
Diff to previous 38496
Prevent T[Chain|Tree]Index from finding the branches from the friend tree when looking up the value in the master/parent TTree.  This fixes <https://savannah.cern.ch/bugs/?79166>.

Revision 38496 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Mar 18 10:04:01 2011 UTC (3 years, 10 months ago) by pcanal
File length: 13553 byte(s)
Diff to previous 38495
Update GetEntryNumberFriend to retun a Long64_t as needed (and as the other methods)

Revision 38495 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Mar 18 09:56:36 2011 UTC (3 years, 10 months ago) by pcanal
File length: 13554 byte(s)
Diff to previous 35344
Minor clarification in documentation

Revision 35344 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Sep 16 21:34:21 2010 UTC (4 years, 4 months ago) by pcanal
File length: 13441 byte(s)
Diff to previous 26795
Fix Coverity reports

G__ci.h: #11161 missing initialization
common.h: #11161 missing initialization
error.cxx: #20793 Array compared against 0
init.cxx: #11712 explicit null derefence
macro.cxx: #10192 missing initialization
shl.cxx: #10626,10627 constant expression result

TBranchProxy.h: #10047 unchecked return value
TTreeProxyGenerator.cxx: #10059,#10060 enum as boolean
TClassEdit.cxx: #11546,#11734 forward null pointer
TStreamerInfoWriteBuffer.cxx: #11572, #11573 forward null pointer
TTreeFormula.cxx: #11587,#11588,#11592 forward null pointer
   #11618,#11619 unckecked dynamic cast
TTreePlayer.cxx:  #11984,#11985,#11986 dereference after null check
TTreeIndex.cxx: #11596  unckecked dynamic cast
TChainIndex.cxx: #11597,#11988 unckecked dynamic cast
TOracleServer.cxx: #11898 dereference after null check
TH1.cxx: #11983 dereference after null check
TFileDrawMap.cxx: $10896 copy into fixed size buffer

Revision 26795 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Dec 10 15:03:14 2008 UTC (6 years, 1 month ago) by pcanal
File length: 13161 byte(s)
Diff to previous 26785
extent assert as needed

Revision 26785 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Dec 9 23:10:09 2008 UTC (6 years, 1 month ago) by pcanal
File length: 13137 byte(s)
Diff to previous 26765
When detaching an index from a TTree, also detach the TTree from the index.  Now we can properly delete 'detached' TTreeIndices in TChainIndex

Revision 26765 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Dec 9 16:26:33 2008 UTC (6 years, 1 month ago) by pcanal
File length: 13323 byte(s)
Diff to previous 24160
Better solution for revision 17257 (fixing http://savannah.cern.ch/bugs/?22722).
Avoid double delete without introducing a memory leak.

Revision 24160 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Fri Jun 6 04:35:15 2008 UTC (6 years, 7 months ago) by pcanal
File length: 13189 byte(s)
Diff to previous 22902
Fix TChainIndex when the lookuped value does not exist

Revision 22902 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Mar 31 09:48:42 2008 UTC (6 years, 9 months ago) by rdm
File length: 13193 byte(s)
Diff to previous 22243
move tree, treeplayer and treeviewer under tree meta directory.

Revision 22243 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Feb 20 11:21:30 2008 UTC (6 years, 11 months ago) by brun
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 13193 byte(s)
Diff to previous 20882
In the TChainIndex constructor, add a protection:
if an index already exists, we must check if major/minorname correspond
to the major/minor names in this function call.

Revision 20882 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Mon Nov 19 11:31:26 2007 UTC (7 years, 2 months ago) by rdm
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 12660 byte(s)
Diff to previous 19826
Set property svn:eol-style LF on all source and Makefiles. This should avoid
problems with Win32 line endings ending up in the repository. All MS tools
support LF eols fine.

Revision 19826 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Sep 19 19:56:11 2007 UTC (7 years, 4 months ago) by rdm
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 12660 byte(s)
Diff to previous 19825
imported svn:keywords Id property

Revision 19825 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Sep 19 19:49:10 2007 UTC (7 years, 4 months ago) by rdm
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 12713 byte(s)
Diff to previous 19666
remove :$ from tag line

Revision 19666 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Aug 22 17:36:46 2007 UTC (7 years, 5 months ago) by pcanal
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 12723 byte(s)
Diff to previous 19574
If two chains are made friends and the files they contain do not have
the same number of entries, we need to informed the TTreeIndex of
the friend chain's tree when the main chain's tree is changed.
This correct the problem seen at http://root.cern.ch/phpBB2/viewtopic.php?p=21435

Revision 19574 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Aug 9 06:42:41 2007 UTC (7 years, 5 months ago) by brun
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 12556 byte(s)
Diff to previous 19116
Fix coding conventions

Revision 19116 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Thu Jun 21 19:14:21 2007 UTC (7 years, 7 months ago) by pcanal
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 12429 byte(s)
Diff to previous 17657
Add new method TVirtualIndex::Append
Use it to insurge that the existing indexes are properly concatenated
when doing a TTree or TChain Merge.

Revision 17657 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Feb 3 17:28:54 2007 UTC (7 years, 11 months ago) by brun
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 11479 byte(s)
Diff to previous 17257
Use forward declarations of TTreeIndex and TTreeFormula.

Revision 17257 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Jan 6 09:24:09 2007 UTC (8 years ago) by brun
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 11428 byte(s)
Diff to previous 14745
In TChainIndex::DeleteIndices prevent a double delete
This fix the bug report http://savannah.cern.ch/bugs/?22722

Revision 14745 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Wed Apr 19 08:22:26 2006 UTC (8 years, 9 months ago) by rdm
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 11359 byte(s)
Diff to previous 12602
Change the TError.h macros:
Assert   ->  R__ASSERT
Check    ->  R__CHECK
Change the TCollection.h macro:
ForEach  ->  R__FOR_EACH
This to avoid potential problems due too trivial macro names.
The old macros will be removed in the next release. Currently
they will print out warning messages with the advice to move
to the new macro names.

Revision 12602 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Sat Sep 3 02:26:31 2005 UTC (9 years, 4 months ago) by pcanal
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 11343 byte(s)
Diff to previous 12221
Fix to follow coding conventions

Revision 12221 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Jun 28 16:49:45 2005 UTC (9 years, 6 months ago) by brun
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 11344 byte(s)
Diff to previous 12220
Fix a warning due to previous correction

Revision 12220 - (view) (download) (as text) (annotate) - [select for diffs]
Modified Tue Jun 28 16:46:07 2005 UTC (9 years, 6 months ago) by brun
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 11340 byte(s)
Diff to previous 12187
From Valeriy Onuchin:
Fix a compilation error with VC++6

Revision 12187 - (view) (download) (as text) (annotate) - [select for diffs]
Added Fri Jun 24 20:25:11 2005 UTC (9 years, 7 months ago) by pcanal
Original Path: trunk/treeplayer/src/TChainIndex.cxx
File length: 11343 byte(s)
From Marek:
hen a user creates a TChainIndex (by invoking e.g. TChain::BuildIndex())

1. The TChainIndex constructor reads all the trees one by one
and for each:

  a. checks if there is an index if not or if that one is built on
     different formaulae it builds an index and keeps it (can't leave an
     index in a tree because when the next tree is loaded the index
     will be deleted).
  b. takes the min and max values of the index (perhaps only min is
     needed - I'll see later on).

2. checks if the min and max values of all the tree indices are sorted.
   If not it turns itself into z Zombie.

When the index is accessed:
1. using the min and max values finds a tree which should be accessed
2. loads the tree using Load(the first entry number in that tree)
3. If there is no index in that tree (it means it was created inside
   TChainIndex constructor) the index is set to that tree.
4. the entry is loaded using the tree index.
5. if the tree didn't have an index before its index is set back to 0
   (needed because otherwise the index would have been deleted in the
   tree  destructor called when loading another tree in the chain).

This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.

  Diffs between and
  Type of Diff should be a

Sort log by:

Subversion Admin
ViewVC Help
Powered by ViewVC 1.0.9